Re: Second Listview status update
On Fri, 18 Oct 2002 09:33:14 -0400, you wrote: On October 18, 2002 03:35 am, Rein Klazes wrote: It does. Finally! I had nightmares about it... :) Now it crashes again like it did after the change in rev. 210 You mean that 209 worked fine, and 210 crashes?!? That was supposed to be a noop change... I looked at it again, and there's not much to it. Listen, I need your help to fix it, as I'm running out of time. Can you take 209, and then apply bits of the changes until you find which one does it? If you don't know how to do that, let me know, and I'll try to come up with some patches. This makes r210 work again: | --- listview.210.c2002-10-19 09:59:20.0 +0200 | +++ listview.c2002-10-21 19:54:28.0 +0200 | @@ -3102,7 +3102,7 @@ | TRACE((hdc=%x, nItem=%d)\n, hdc, nItem); | | /* get information needed for drawing the item */ | -lvItem.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE | LVIF_INDENT; | +lvItem.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE | LVIF_INDENT | LVIF_PARAM; | lvItem.stateMask = LVIS_SELECTED | LVIS_FOCUSED | LVIS_STATEIMAGEMASK; | lvItem.iItem = nItem; | lvItem.iSubItem = 0; Which must be done on one or two places more I think. Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Second Listview status update
Rizsanyi Zsolt [EMAIL PROTECTED] wrote: I dont really know where Alexandre has reached with applying your pathes. Maybe he should add the codename of the patch to the cvs commits. Alexandre saves the order of sent patches when he commits them. Isn't the Changelog provided in each patch and CVS commit message enough? -- Dmitry.
Re: Second Listview status update
On Thu, 17 Oct 2002 23:55:59 -0400, you wrote: On October 17, 2002 01:49 am, Rein Klazes wrote: Uploaded to www.xs4all.nl/~rklazes/temp/nb3.log.bz2 Fine. That didn't work... :/ But I think I fixed now: please try T0, and T1. If that doesn't work... It does. Now it crashes again like it did after the change in rev. 1.210: | Unhandled exception: page fault on read access to 0x4e8880d8 in 32-bit code |(0x004092ed). | In 32-bit mode. | 0x004092ed (nbpro.exe..text+0x82ed in H:\binw\nbpro\nbpro.exe): call *0x20(%eax) | Backtrace: | =0 0x004092ed (nbpro.exe..text+0x82ed in H:\binw\nbpro\nbpro.exe) (ebp=004c7470) | 1 0x2bdce900 (LIBFILTER.DLL..reloc+0x1bd8b900) (ebp=4e8880b8) | *** Invalid address 0x4e8880b8 (_end+0xc2c0718) | A fresh message log uploaded as www.xs4all.nl/~rklazes/temp/nb4.log.bz2 Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Second Listview status update
On October 18, 2002 03:35 am, Rein Klazes wrote: It does. Finally! I had nightmares about it... :) Now it crashes again like it did after the change in rev. 210 You mean that 209 worked fine, and 210 crashes?!? That was supposed to be a noop change... I looked at it again, and there's not much to it. Listen, I need your help to fix it, as I'm running out of time. Can you take 209, and then apply bits of the changes until you find which one does it? If you don't know how to do that, let me know, and I'll try to come up with some patches. -- Dimi.
Re: Second Listview status update
On Fri, 18 Oct 2002 09:33:14 -0400, you wrote: On October 18, 2002 03:35 am, Rein Klazes wrote: It does. Finally! I had nightmares about it... :) Now it crashes again like it did after the change in rev. 210 You mean that 209 worked fine, and 210 crashes?!? 209 does not crash and 210 crashes. I checked again to be sure. That was supposed to be a noop change... I looked at it again, and there's not much to it. Listen, I need your help to fix it, as I'm running out of time. Can you take 209, and then apply bits of the changes until you find which one does it? If you don't know how to do that, let me know, and I'll try to come up with some patches. No problem. Hopefully I can do that later today. Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Second Listview status update
On October 18, 2002 03:35 am, Rein Klazes wrote: It does. Now it crashes again like it did after the change in rev. BTW, how did you get it to crash? It starts up, and load newsgroups just fine here... -- Dimi.
Re: Second Listview status update
On October 18, 2002 08:22 am, Rizsanyi Zsolt wrote: Ok. I have updated cvs, and the double click problem went away :) At least there is _some_ good news :) But I have tested more toroughly the open dialog of Word97 and found out that it has some update problems when changing beetwen different view modes. Duh! Like when you change from Details view to Properties view, then the header of the Details view (where the Name, Size, Type, ... is written) stays there. If you change back to List view and then directly to Properties, then the Properties view is ok. WTH is Properties? I don't have Office97, so can you please send me a sceenshot with it OK, and with the problem? -- Dimi.
Re: Second Listview status update
On Fri, 18 Oct 2002 09:46:18 -0400, you wrote: On October 18, 2002 03:35 am, Rein Klazes wrote: It does. Now it crashes again like it did after the change in rev. BTW, how did you get it to crash? It starts up, and load newsgroups just fine here... Select a newsgroup, right click and choose download latest headers The newsgroup listview then clears and the program crashes. Aparently when it is rebuilding the display again. Using newsbin 4.05. Wine with no native system dll's. Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Second Listview status update
On Friday 18 October 2002 22:29, you wrote: On October 18, 2002 11:53 am, Rizsanyi Zsolt wrote: 'Properties' is a simple listview which is tied to a 'preview' window, which does not show preview, but some properties of the document. Though its a simple listview as the 'List', but it has this bug, while 'List' does not have... Thanks for the explanation. Try T0-4, they should solve it. If not, please let me know. And what have to be applied to the current cvs? Its enough if I only apply the T0-4 patches? I dont really know where Alexandre has reached with applying your pathes. Maybe he should add the codename of the patch to the cvs commits. Regards Zsolt
Re: Second Listview status update
On October 17, 2002 01:49 am, Rein Klazes wrote: Uploaded to www.xs4all.nl/~rklazes/temp/nb3.log.bz2 Fine. That didn't work... :/ But I think I fixed now: please try T0, and T1. If that doesn't work... -- Dimi.
Re: Second Listview status update
On Tue, 15 Oct 2002 00:39:43 -0400, you wrote: So once again, I am interested to hear about regressions. I think the code reached a state where we can concentrate on cleaning up our act, before adding new features. OK, here is the status for newsbin. All relative to the status that I reported before. For the sake of this report there are two listviews: one filled with newsgroups the other with messages. The actions that I like to do is 1) select a newsgroup with left button click on de group listview 2) call up a context menu and choose retrieve messages 3) see the message listview getting populated. As an alternative to 2) I can double click or use the main menu. Here are the changes observed with the different revisions of listview.c: rev 1.199 Right click to get context menu doesn't work anymore; rev 1.200 The message listview doesn't get populated anymore. From the flickers it looks like message are added and almost immedeately removed again. rev 1.205 Right click works again (see r 1.199) rev 1.206 Left clicks now bring up the context menu. More over instead of selecting one, two groups get selected (the other one is 14 lines below the pointer psoition) rev 1.207 Selection isn't hightlighted anymore rev 1.208 Selection highlighting works again. rev 1.210 After step 2) the group listview clears and the program crashes, details below. Upto 1.230 (== current cvs) I haven't seen any changes yet. The R patches appear to solve the selection issues, but not the crash is still there and the latest (R3) introduces a new crash long before any window is drawn. No details of this yet. Details of the crash in current cvs: | Unhandled exception: page fault on read access to 0x245c8b73 in 32-bit code |(0x004092ed). | In 32-bit mode. | 0x004092ed (nbpro.exe..text+0x82ed in H:\binw\nbpro\nbpro.exe): call *0x20(%eax) | Backtrace: | =0 0x004092ed (nbpro.exe..text+0x82ed in H:\binw\nbpro\nbpro.exe) (ebp=00409180) | 1 0x0c43f608 (_end+0x43e3e8c) (ebp=245c8b53) | *** Invalid address 0x245c8b53 (LIBFILTER.DLL..reloc+0x14585b53) | Message log +relay,+listview (950 KB) is on www.xs4all.nl/~rklazes/temp/nb.log.bz2 Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Second Listview status update
On October 16, 2002 06:23 am, Rein Klazes wrote:
Upto 1.230 (== current cvs) I haven't seen any changes yet. The R
patches appear to solve the selection issues, but not the crash is
still there and the latest (R3) introduces a new crash long before any
window is drawn. No details of this yet.
OK. Newsbin seems to be using custom draw, and for some reason it
crashes. So let's disable it, and see what else is wrong. As you
say, R-series fixes the selection issues, and a buch of other stuff,
so please test with them. I am interested in a trace like the one
you posted for R3, to see why, and where it crashes.
After you get the trace, add the line:
return 0;
before the line 703:
return notify_hdr(infoPtr, NM_CUSTOMDRAW, lpnmlvcd-nmcd.hdr);
Like so:
static inline DWORD notify_customdraw (LISTVIEW_INFO *infoPtr, DWORD dwDrawStage,
NMLVCUSTOMDRAW *lpnmlvcd)
{
lpnmlvcd-nmcd.dwDrawStage = dwDrawStage;
return 0;
return notify_hdr(infoPtr, NM_CUSTOMDRAW, lpnmlvcd-nmcd.hdr);
}
Hopefully this will eliminate the crash.
--
Dimi.
Re: Second Listview status update
On Tuesday 15 October 2002 06:39, Dimitrie O. Paun wrote: So once again, I am interested to hear about regressions. I think the code reached a state where we can concentrate on cleaning up our act, before adding new features. Most of the regressions are fixed now. Thanks But the double click selection do not work eg in the MSOffice file open dialogs. Regards Zsolt
Re: Second Listview status update
On October 16, 2002 06:16 am, Rizsanyi Zsolt wrote: But the double click selection do not work eg in the MSOffice file open dialogs. Did you apply the R-series? -- Dimi.
Re: Second Listview status update
On Wed, 16 Oct 2002 17:19:59 -0400, you wrote: On October 16, 2002 09:21 am, Rein Klazes wrote: It still crashes at the same point. OK, let's try this: -- apply all my R-series patches -- apply the Listview struct defs v6.0 -- make sure you back out the return 0 hack we just tried And see if it still crashes. If it does, please send me a trace just like you did before. Uploaded to www.xs4all.nl/~rklazes/temp/nb3.log.bz2 Rein. -- Rein Klazes [EMAIL PROTECTED]
