Re: Third listview status update
On Thu, 24 Oct 2002 02:32:51 -0400, you wrote: > On October 22, 2002 06:16 am, Rein Klazes wrote: > > - only first column displays text; this problem existed from the > > beginning; > > OK, X5 + X6 should fix this. Newsbin Pro is just perfect now :) Yes, I'm impressed ;-) Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Third listview status update
On October 22, 2002 06:16 am, Rein Klazes wrote: > - only first column displays text; this problem existed from the > beginning; OK, X5 + X6 should fix this. Newsbin Pro is just perfect now :) -- Dimi.
Re: Third listview status update
On October 22, 2002 06:16 am, Rein Klazes wrote: > - the green background extends as far as the text; with native > comctl32 is extends the whole column; > - A line that has both a green background and is marked slected will > display as white text on green backgound; With native comctl32 is > shows as white text on dark blue background (same as selected); X4 should solve these. Please let me know if it doesn't. -- Dimi.
Re: Third listview status update
On October 23, 2002 02:50 am, Rein Klazes wrote: > That seems to solve it, no crashes for a while. Needs a lot longer > testing to 100% sure though. True. Let me know if you get any more crashes. > Here is a patch that solves the r1.200 regression: Thanks! Looks good, please submit it, or if you don't feel like, let me know, and I'll include it in my next patchset. -- Dimi.
Re: Third listview status update
On Tue, 22 Oct 2002 23:59:28 -0400, you wrote:
> On October 22, 2002 11:45 pm, Rein Klazes wrote:
> > On Tue, 22 Oct 2002 19:38:41 -0400, you wrote:
> > > The line numbers look strage. What version of
> > > dlls/comctl32/comctl32undoc.c did you run it with?
> >
> > rev 1.71, latest cvs.
>
> Interesting. Listen, can you please retry with _all_ my
> latest patches, there were 2 very serious bugs that
> might have caused those problems, in some strange ways.
That seems to solve it, no crashes for a while. Needs a lot longer
testing to 100% sure though.
Here is a patch that solves the r1.200 regression:
===
--- listview.w6.c 2002-10-23 08:38:12.0 +0200
+++ listview.c 2002-10-23 08:40:53.0 +0200
@@ -4453,8 +4453,13 @@
lvItem.iSubItem = 0;
if (!LISTVIEW_GetItemW(infoPtr, &lvItem)) continue;
- if (lvItem.mask & LVIF_PARAM && lpFindInfo->lParam ==
lvItem.lParam)
- return nItem;
+ if (lvItem.mask & LVIF_PARAM)
+{
+if (lpFindInfo->lParam == lvItem.lParam)
+return nItem;
+else
+continue;
+}
if (lvItem.mask & LVIF_TEXT)
{
Rein.
--
Rein Klazes
[EMAIL PROTECTED]
Re: Third listview status update
On October 22, 2002 06:16 am, Rein Klazes wrote: > - the green background extends as far as the text; with native > comctl32 is extends the whole column; > - A line that has both a green background and is marked slected will > display as white text on green backgound; With native comctl32 is > shows as white text on dark blue background (same as selected); I need good & bad screenshots of these things to understand what is wrong, and what needs to get done. -- Dimi.
Re: Third listview status update
On October 22, 2002 11:45 pm, Rein Klazes wrote: > On Tue, 22 Oct 2002 19:38:41 -0400, you wrote: > > The line numbers look strage. What version of > > dlls/comctl32/comctl32undoc.c did you run it with? > > rev 1.71, latest cvs. Interesting. Listen, can you please retry with _all_ my latest patches, there were 2 very serious bugs that might have caused those problems, in some strange ways. Thanks. -- Dimi.
Re: Third listview status update
On Tue, 22 Oct 2002 19:38:41 -0400, you wrote: > > The line numbers look strage. What version of dlls/comctl32/comctl32undoc.c > did you run it with? rev 1.71, latest cvs. Rein. -- Rein Klazes [EMAIL PROTECTED]
Re: Third listview status update
On October 22, 2002 06:16 am, Rein Klazes wrote: > On the positive side background colouring for new messages works now. ;) [snip] > - updates are from bottom to top; this gets some getting used to; Fixed in one of the W-patches. > Crash 2: > | err:ntdll:RtlpWaitForCriticalSection section 0x4fcf28 "?" wait timed out, > | retrying (60 sec) tid=087eedb8 Unhandled exception: page fault on write > | access to 0x1784562e in 32-bit code (0x4272392f). In 32-bit mode. > | 0x4272392f (_end+0xdbf6f): addb %bh,0x957c4272(%ebx,%edi,1) > | Register dump: > | CS:0023 SS:002b DS:002b ES:002b FS:008f GS:1587 > | EIP:4272392f ESP:40741c5c EBP:40741cb4 EFLAGS:00210a86( R- 00O I S - > | -P1 ) EAX:427d1354 EBX:40be1094 ECX:41a7ff3c EDX:0002 > | ESI:41a7ff3c EDI:414a0328 > | Backtrace: > | =>0 0x4272392f (_end+0xdbf6f) (ebp=40741cb4) > | 1 0x40b7db77 (DPA_QuickSort+0xf3(lpPtrs=0x414bd320, l=0xd1, r=0xd2, > | pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2077] in > | comctl32.dll.so) (ebp=40741ce0) 2 0x40b7db1c > | (DPA_QuickSort+0x98(lpPtrs=0x414bd320, l=0xd1, r=0xd4, > | pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2072] in > | comctl32.dll.so) (ebp=40741d14) 3 0x40b7db35 > | (DPA_QuickSort+0xb1(lpPtrs=0x414bd320, l=0xcc, r=0xd4, > | pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2075] in > | comctl32.dll.so) (ebp=40741d5c) 4 0x40b7db1c The line numbers look strage. What version of dlls/comctl32/comctl32undoc.c did you run it with? -- Dimi.
Re: Third listview status update
On Mon, 21 Oct 2002 23:57:52 -0400, you wrote: > I would like to thank everybody that helped me with testing, > patches, or reporting bugs. I couldn't have done the half of > it without that support. > > This sounds like this is a done deal. It's not. There's a lot > of stuff that remains to be done, but I needed some closure. :) Yes that seems the right way to proceed. Here is an update of newsbin status (current cvs == V18 ). On the positive side background colouring for new messages works now. Current show-stoppers: - only first column displays text; this problem existed from the beginning; - when downloading headers, the messages listview doesn't get filled; this problem was introduced in rev. 1.200; I can get the list to display after the download is finished by toggling the "show only new headers" option; I have uploaded a cut of a +listview trace on www.xs4all.nl/~rklazes/nb.log.bz2 ; - crashes :(( see below. Nit-picking: - the green background extends as far as the text; with native comctl32 is extends the whole column; - A line that has both a green background and is marked slected will display as white text on green backgound; With native comctl32 is shows as white text on dark blue background (same as selected); - updates are from bottom to top; this gets some getting used to; Till sofar I had two different (looking at the backtrace) crashes. I did not found a way to reproduce easily, just that it happens always shorly after a second download is requested. I will try to create debug logs when I find a way to reproduce. Crash 1: | err:ntdll:RtlpWaitForCriticalSection section 0x4fcf28 "?" wait timed out, retrying |(60 sec) tid=087ee0b8 | Unhandled exception: page fault on write access to 0x00418082 in 32-bit code |(0x400a3e2d). | In 32-bit mode. | 0x400a3e2d (INSTR_EmulateInstruction+0xaf9 [instr.c:615] in libntdll.dll.so): movl | %eax,0x0(%esi) | Warning: L"/usr/home/projects/wine/mywine/dlls/ntdll/../../memory/instr.c" not |accessible from a configured DOS drive | Unable to open file /usr/home/projects/wine/mywine/dlls/ntdll/../../memory/instr.c | Backtrace: | =>0 0x400a3e2d (INSTR_EmulateInstruction+0xaf9(context=0x40630a50, |context=0x40630a50, context=0x40630a50, context=0x40630a50, context=0x40630a50, |context=0x40630a50, context=0x40630a50, context=0x40630a50, context=0x40630a50, |context=0x40630a50, context=0x40630a50, context=0x40630a50, context=0x40630a50, |context=0x40630a50, context=0x40630a50, context=0x40630a50, context=0x40630a50, |context=0x40630a50, context=0x40630a50, context=0x40630a50) [instr.c:615] in |libntdll.dll.so) (ebp=406309c4) | 1 0x400dd289 (do_segv+0x109(context=0x40630a50, trap_code=0xd, cr2=0x0, |err_code=0x0) [signal_i386.c:761] in libntdll.dll.so) (ebp=40630a2c) | 2 0x400dd762 (segv_handler+0x3a(__signal=0xb, __context=0x1587) |[signal_i386.c:986] in libntdll.dll.so) (ebp=40630d1c) | 3 0x4025fb88 (NTDLL.DLL.toupper+0x59ae in libc.so.6) (ebp=414a0328) | 4 0x0cd6 (ebp=00010023) | 5 0x18171615 (LIBFILTER.DLL..reloc+0x812e615) (ebp=14131211) | *** Invalid address 0x14131211 (LIBFILTER.DLL..reloc+0x40ee211) | Crash 2: | err:ntdll:RtlpWaitForCriticalSection section 0x4fcf28 "?" wait timed out, retrying |(60 sec) tid=087eedb8 | Unhandled exception: page fault on write access to 0x1784562e in 32-bit code |(0x4272392f). | In 32-bit mode. | 0x4272392f (_end+0xdbf6f): addb %bh,0x957c4272(%ebx,%edi,1) | Register dump: | CS:0023 SS:002b DS:002b ES:002b FS:008f GS:1587 | EIP:4272392f ESP:40741c5c EBP:40741cb4 EFLAGS:00210a86( R- 00O I S - -P1 ) | EAX:427d1354 EBX:40be1094 ECX:41a7ff3c EDX:0002 | ESI:41a7ff3c EDI:414a0328 | Backtrace: | =>0 0x4272392f (_end+0xdbf6f) (ebp=40741cb4) | 1 0x40b7db77 (DPA_QuickSort+0xf3(lpPtrs=0x414bd320, l=0xd1, r=0xd2, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2077] in comctl32.dll.so) |(ebp=40741ce0) | 2 0x40b7db1c (DPA_QuickSort+0x98(lpPtrs=0x414bd320, l=0xd1, r=0xd4, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2072] in comctl32.dll.so) |(ebp=40741d14) | 3 0x40b7db35 (DPA_QuickSort+0xb1(lpPtrs=0x414bd320, l=0xcc, r=0xd4, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2075] in comctl32.dll.so) |(ebp=40741d5c) | 4 0x40b7db1c (DPA_QuickSort+0x98(lpPtrs=0x414bd320, l=0xcc, r=0xdd, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2072] in comctl32.dll.so) |(ebp=40741d90) | 5 0x40b7db35 (DPA_QuickSort+0xb1(lpPtrs=0x414bd320, l=0xb9, r=0xdd, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2075] in comctl32.dll.so) |(ebp=40741dd8) | 6 0x40b7db35 (DPA_QuickSort+0xb1(lpPtrs=0x414bd320, l=0x94, r=0xdd, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2075] in comctl32.dll.so) |(ebp=40741e20) | 7 0x40b7db1c (DPA_QuickSort+0x98(lpPtrs=0x414bd320, l=0x94, r=0x126, |pfnCompare=0x40b9728c, lParam=0x10023) [comctl32undoc.c:2072] in comctl32.dll.so) |(ebp=40741e54) | 8 0x40b7db35 (DPA_QuickSort+0xb1(lpPtrs=0x
