Re: dlls/advapi32/tests/security.c - Bugfix in test!
Jakob Eriksson wrote: Alexandre Julliard wrote: Jakob Eriksson [EMAIL PROTECTED] writes: --- dlls/advapi32/tests/security.c14 Mar 2005 17:20:58 - 1.12 +++ dlls/advapi32/tests/security.c16 Mar 2005 09:32:28 - @@ -289,8 +289,8 @@ luid.LowPart = i; cchName = sizeof(buf); ret = pLookupPrivilegeNameA(NULL, luid, buf, cchName); -ok( ret GetLastError() != ERROR_NO_SUCH_PRIVILEGE, - LookupPrivilegeNameA(0.%ld) failed: %ld\n, i, GetLastError()); +if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) +ok( ret, LookupPrivilegeNameA(0.%ld) failed: %ld\n, i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. True. Don't know what I was thinking. Now I know. If the error was ERROR_NO_SUCH_PRIVILEGE, it's ok, we don't care. Move on. NT4 has this behaviour. If it isn't, but ret is 0, AKA LookupPrivilegeName() failed, I wan't to know exactly what the error was. It's a trace. So I think the patch is valid, there is method to the madness. regards, Jakob
Re: dlls/advapi32/tests/security.c - Bugfix in test!
Jakob Eriksson wrote: Jakob Eriksson wrote: Alexandre Julliard wrote: Jakob Eriksson [EMAIL PROTECTED] writes: --- dlls/advapi32/tests/security.c14 Mar 2005 17:20:58 - 1.12 +++ dlls/advapi32/tests/security.c16 Mar 2005 09:32:28 - @@ -289,8 +289,8 @@ luid.LowPart = i; cchName = sizeof(buf); ret = pLookupPrivilegeNameA(NULL, luid, buf, cchName); -ok( ret GetLastError() != ERROR_NO_SUCH_PRIVILEGE, - LookupPrivilegeNameA(0.%ld) failed: %ld\n, i, GetLastError()); +if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) +ok( ret, LookupPrivilegeNameA(0.%ld) failed: %ld\n, i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. True. Don't know what I was thinking. Now I know. If the error was ERROR_NO_SUCH_PRIVILEGE, it's ok, we don't care. Move on. NT4 has this behaviour. What about: ok( ret || GetLastError() == ERROR_NO_SUCH_PRIVILEGE,? - Filip
Re: RICHED20: remove casts and unused code
+static inline char *RTFStrSave(char *s) Not a big deal, but the name is a bit uncommon. Wouldn't RTFStrDup() be a better/more recognizable name? -- Dimi.
Re: Wine FAQ removed from the doc tarballs
I always find it annoying when I cannot go to /usr/share/doc/package I suppose the other option is to provide all docs as a seperate package on a release basis (like any other package.) I could be wrong on this, but I don't think the docs are updated on a monthly basis. :) For example, a user could see that the newest Wine package released thus far is from March and the newest Wine docs package could be November of last year (arbitrary date). And if its only 23kb, it shouldn't be much of a problem for modem users; escpecially since it saves them from having to download an extra 23kb with every Wine release when they don't really need it. :) Hiji P.S. Looking at http://www.gimp.org/downloads/ , it looks like they are already doing something similar with their help files. They offer them as a seperate download. __ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/
Re: dlls/advapi32/tests/security.c - Bugfix in test!
On Sat, 19 Mar 2005, Jakob Eriksson wrote: Now I know. If the error was ERROR_NO_SUCH_PRIVILEGE, it's ok, we don't care. Move on. NT4 has this behaviour. If it isn't, but ret is 0, AKA LookupPrivilegeName() failed, I wan't to know exactly what the error was. It's a trace. So I think the patch is valid, there is method to the madness. I don't quite follow this, but I'd suggest that, even if the patch is valid, a comment at this location explaining the logic is definitely called for. --scott D5 SLBM Ft. Meade arrangements Leitrim munitions SDI SSBN 731 struggle KUGOWN NORAD Washington SMOTH supercomputer quiche Khaddafi LPMEDLEY ( http://cscott.net/ )
Re: [WINEALSA] multiple sound card support patch review needed
On Thu, 17 Mar 2005 16:06:52 -0500, Robert Reif [EMAIL PROTECTED] wrote: This patch adds multiple sound card support to the ALSA driver. My system shows 3 sound devices: a builtin sound card, a builtin modem and a usb sound card. The wave regression tests have problems with the modem. I'm not sure it is an ALSA problem or a problem with this patch. Could someone familiar with ALSA look this patch over. I would also like feedback from any brave testers that have multiple sound cards. I have an ALSA system with 3 soundcards and 4 devices. So, a good testcase for this patch. I tried the CVS of today (that includes this patch now) with ASRC (http://www.asrc.info). But it seems to have a winealsa regression that wasn't there a week ago and not directly related to this patch. To try to find the problem I have minimized my setup. Back to the common emu10k1 driver with a SBLive! 5.1 and no ~/.asoundrc with things like dmix and asym. I have attached a log of a +wave run of the application with this setup. Paul wave.log.bz2 Description: application/bzip
Re: [WINEALSA] multiple sound card support patch review needed
Paul van Schayck wrote: I have an ALSA system with 3 soundcards and 4 devices. So, a good testcase for this patch. I tried the CVS of today (that includes this patch now) with ASRC (http://www.asrc.info). But it seems to have a winealsa regression that wasn't there a week ago and not directly related to this patch. To try to find the problem I have minimized my setup. Back to the common emu10k1 driver with a SBLive! 5.1 and no ~/.asoundrc with things like dmix and asym. I have attached a log of a +wave run of the application with this setup. Paul I downloaded the program and ran it and don't even get as far as you got. Try different devices and combinations of devices: hw, plug:hw plughw and see if that helps. I'll look into it when I get some more time.
kde plugin
Hi, I've got a plugin for KDE that displays icons and thumbnails for windows applications and dlls in Konqueror. I was intending to extend it to meta info and maybe a full kioslave for browsing windows PE files, but never got that far. At the moment it's a bit of a licensing nightmare, but I can package it up in a format that's ok for QT and Wine if anyone's interested. Oliver. Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: kde plugin
On Sat, 2005-03-19 at 22:05 +, Oliver Stieber wrote: Hi, I've got a plugin for KDE that displays icons and thumbnails for windows applications and dlls in Konqueror. I was intending to extend it to meta info and maybe a full kioslave for browsing windows PE files, but never got that far. At the moment it's a bit of a licensing nightmare, but I can package it up in a format that's ok for QT and Wine if anyone's interested. Oliver. Send instant messages to your online friends http://uk.messenger.yahoo.com Well, there's nothing to stop you from releasing it as public domain or a BSD-type license that should be compatible with anything. I'm sure people would appreciate your code. Thanks, Scott Ritchie
Re: Theming for Wine via the registry
On Sat, 2005-03-12 at 22:36 +, Mike Hearn wrote: On Sat, 2005-03-12 at 22:15 +, Oliver Stieber wrote: The only problem I can see would be drawing the widgets, I haven't looked deeply enough into QT or GTK to know if it's more on the 'impossible' side of difficult or not. Wrapping the event loop and passing events should be relatively easy. You have feature mismatches, eg GtkTextBuffer cannot do some things the richedit control can, Win32 menus can't do some things that GTK can etc etc. Also getting the message/paint sync especially for subclassed windows would be impossible. Basically we have to do our own widgets, we can't actually map win32 widgets to some other toolkit. I've actually tried getting Wine to use GTK widgets. I made some progress but hit some issues that I wasn't sure I had a solution to. It is true that the controls in Wine and GTK have different semantics, however matching semantics probably shouldn't be the first goal you try to achieve. To begin with, you just want to get GTK to draw the widgets and let Wine feed GTK's rendering engine with enough information to do what it needs to. That is, Wine would still intercept all the mouse clicks, keypress events etc and use that to update the state of the GTK analogue of each of your widgets. If it turns out you can get that going, then it's probably worth thinking about other modifications to Wine's behaviour, probably based on some configuration file. Reversing the order of buttons for example. It's also worth remembering that there are a bunch of controls that will work just the same. Checkboxes for example. Now, when I did this, I asked the gtk widgets to draw themselves directly onto the X windows that Wine used. That won't work. There was something going on in the way GTK handled X events that left my widgets half rendered. What would probably work is to use the windows port of GDK to do the actual drawing. That way, X messages would still be dealt with by wine and this drawing code would just be another thread managed by wine like any other. There are some other hurdles to overcome in doing this, but I think that approach would get you somewhere. I started prototyping what I'm suggesting to you and found that there was a missing wine feature that stopped glib from working. I'll try to have a look some time this week and see if that's still the case. On the question of mapping colours though (which is where this thread started): I had some code in my local tree which would query GTK for the colours it was using for various widgets and set the equivalent registry entry for Wine. It was relatively straightforward and I can probably dig it up if anyone's interested. It really did look quite weird for some themes though. GTK gives you a lot of control over the colours used on widgets. The basic colour mechanism in Windows doesn't give you the same level of control. To get it to look right, you'd really need to use GTK widgets. Keep us informed on this. I'll offer any feedback I can from my experience in doing this. If there's anyone here really familiar with the windows GTK port, maybe we could combine resources to get this working. James. -- James Gregory [EMAIL PROTECTED]
Re: kde plugin
--- Scott Ritchie [EMAIL PROTECTED] wrote: On Sat, 2005-03-19 at 22:05 +, Oliver Stieber wrote: Hi, I've got a plugin for KDE that displays icons and thumbnails for windows applications and dlls in Konqueror. I was intending to extend it to meta info and maybe a full kioslave for browsing windows PE files, but never got that far. At the moment it's a bit of a licensing nightmare, but I can package it up in a format that's ok for QT and Wine if anyone's interested. Oliver. Send instant messages to your online friends http://uk.messenger.yahoo.com Well, there's nothing to stop you from releasing it as public domain or a BSD-type license that should be compatible with anything. I'm sure people would appreciate your code. I'm using a wine header that's lgpl but QT is GPL only, I'd just re-write the parts of the header I'm using. Thanks, Scott Ritchie Send instant messages to your online friends http://uk.messenger.yahoo.com
