Re: EnumMedia patch
Maarten Lankhorst wrote: This patch fixes AM_MEDIA_TYPE-pbFormat not being handled correctly, unfortunately, this also means some stuff has to be rewritten to avoid memleaks, instead of CoTaskMemFree(AM_MEDIA_TYPE), DeleteMediaType has to be used.. This also fixes the errors i had with msn webcam, i feel like i stumbled over every bug in quartz now.. @@ -45,6 +46,7 @@ void DeleteMediaType(AM_MEDIA_TYPE * pMe IUnknown_Release(pMediaType-pUnk); pMediaType-pUnk = NULL; } +CoTaskMemFree(pMediaType); } BOOL CompareMediaTypes(const AM_MEDIA_TYPE * pmt1, const AM_MEDIA_TYPE * pmt2, BOOL bWildcards) This change is wrong. DeleteMediaType is not supposed to free the memory used for the AM_MEDIA_TYPE structure itself as the function is also used in places where the AM_MEDIA_TYPE was not allocated using CoTaskMemAlloc. Rob
Re: Make test status - latest CVS
The thing to understand is that any failure of make test due to either default configuration or a bug in anything other than wine is a failure of the test system. If make test passed, and Alexandre committed a patch, then this patch MUST pass on all machines. If that's not the case, then people will (and do) not use the test infrastructure, and more tests fail. That's not good! As such, I think you should fix your test to not fail (or mark it as a test wine does not pass). If you have different behaviors whether the driver bug exists or not on my system, split the test into two parts. This way, you can have one test that passes on wine whether or not the driver is broken (i.e. - if the bug in wine comes up, ignore it). The second test is one that fails if the bug in the driver doesn't come up, and if the bug in the driver does come up, fails if wine handles it differently from Windows. Mark this test as fails on wine until you fix it. This way, the tests won't fail on my machine, regardless of how it is set up. Like I said, getting the tests to pass on all wine hackers machines is crucial to build confidence with the tests, thus allowing people to run the tests prior to sending patches. If you are in Stuttgart, feel free to grab me and talk about it. Shachar Robert Reif wrote: Shachar Shemesh wrote: The problem is that I'm not interested in this test. I just think that, off the shelf, tests should not fail. My opinion is that if this is not a problem with Wine, it shouldn't fail the test. The issue from a test perspective is that wine fails differently than windows under this situation. Wine really does initialization at CoCreateInstance and our Initialize really does nothing. Wine should fail at Initialize, not CoCreateInstance. Moving initialization to Initialize will require some restructuring of the code in dsound.dll. I'll look into it but won't promis any fixes real soon. -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/
Re: dlls/dinput/mouse.c - GetDeviceState
On Wed, Jun 16, 2004 at 08:50:50PM +0200, James Dean Anderson wrote:
this patch adds a missing errorcode in GetDeviceState in
dlls/dinput/mouse.c which prevented the mouse to work in some game.
Well, I finally found the time to clean my wine-devel mailing list and do
the DInput test program and now I can confirm that this patch is right and
should go in CVS (really sorry for the ... errm ... 10 month delay).
The only problem is that it does not apply anymore (as the name of the file
changed) and that I am a bit away on my Linux box (live from WineConf :-) )
to rework it. So either one can resubmit synced to current CVS or I will do
it on Wednesday when I come back home.
Lionel
Index: dlls/dinput/mouse.c
===
RCS file: /home/wine/wine/dlls/dinput/mouse.c,v
retrieving revision 1.3
diff -u -d -r1.3 mouse.c
--- dlls/dinput/mouse.c 4 Jun 2004 18:06:37 - 1.3
+++ dlls/dinput/mouse.c 16 Jun 2004 18:17:16 -
@@ -677,6 +677,8 @@
LPDIRECTINPUTDEVICE8A iface,DWORD len,LPVOID ptr
) {
ICOM_THIS(SysMouseImpl,iface);
+
+if(This-acquired == 0) return DIERR_NOTACQUIRED;
EnterCriticalSection((This-crit));
TRACE((this=%p,0x%08lx,%p): \n,This,len,ptr);
--
Lionel Ulmer - http://www.bbrox.org/
Re: dlls/dinput/mouse.c - GetDeviceState
On Sun, May 01, 2005 at 10:32:24AM +0200, Lionel Ulmer wrote:
On Wed, Jun 16, 2004 at 08:50:50PM +0200, James Dean Anderson wrote:
this patch adds a missing errorcode in GetDeviceState in
dlls/dinput/mouse.c which prevented the mouse to work in some game.
Well, I finally found the time to clean my wine-devel mailing list and do
the DInput test program and now I can confirm that this patch is right and
should go in CVS (really sorry for the ... errm ... 10 month delay).
The only problem is that it does not apply anymore (as the name of the file
changed) and that I am a bit away on my Linux box (live from WineConf :-) )
to rework it. So either one can resubmit synced to current CVS or I will do
it on Wednesday when I come back home.
Lionel
Try this :-)
Huw.
Index: dlls/dinput/mouse.c
===
RCS file: /home/wine/wine/dlls/dinput/mouse.c,v
retrieving revision 1.21
diff -u -p -r1.21 mouse.c
--- dlls/dinput/mouse.c 24 Mar 2005 21:01:39 - 1.21
+++ dlls/dinput/mouse.c 1 May 2005 09:05:11 -
@@ -685,7 +685,9 @@ static HRESULT WINAPI SysMouseAImpl_GetD
LPDIRECTINPUTDEVICE8A iface,DWORD len,LPVOID ptr
) {
SysMouseImpl *This = (SysMouseImpl *)iface;
-
+
+if(This-acquired == 0) return DIERR_NOTACQUIRED;
+
EnterCriticalSection((This-crit));
TRACE((this=%p,0x%08lx,%p): \n,This,len,ptr);
Put all Wineconf slides on Winehq
For the sake of all the mis fortunate who could not attend Wineconf this year. Could someone, Please, collect all presentations and put them on Winehq. I thought that it could be nice if Wineconf page's Agenda could be updated to what it actually was, with links from each session to it's slides, and if possible some commentary on important QA that arose. Please ... Free Life Boaz
wine-20050419 crashes warcraft 3
Hi all, I recently compiled wine-20050419, and decided to give Warcraft 3 a try. The game installed nicely but crashed at runtime, freezing my computer. I had to hard-reboot the box to recover. Unfortunately, i am unable to give any trace or log, because each time i launch Warcraft it hangs, leaving me with no alternative but rebooting the system. On the other hand, the world editor works more or less : i can't see the menu bar above the map entry, but i can play with the landscape elements and build a map. I also managed to play Starcraft and Atomic Bomberman, which don't make use of opengl, so it sounds like my installation is correct. Running Warcraft with or without -opengl, in managed or desktop mode, as root or normal user, with any windows version (from win98 up to winxp) amounts to the same crash. My config is: - kernel 2.4.26 running on a k6-2 500MHz. - xorg server 6.8.1 - GeForce 4 MX440 with latest NVidia drivers (1.7174) Everything compiled locally with gcc 3.3.4. Any (little) help is more than welcomed! regards, Seb.
Re2: EnumMedia patch
Robert Shearman wrote:
Maarten Lankhorst wrote:
This patch fixes AM_MEDIA_TYPE-pbFormat not being handled correctly,
unfortunately, this also means some stuff has to be rewritten to
avoid memleaks, instead of CoTaskMemFree(AM_MEDIA_TYPE),
DeleteMediaType has to be used.. This also fixes the errors i had
with msn webcam, i feel like i stumbled over every bug in quartz
now..
@@ -45,6 +46,7 @@ void DeleteMediaType(AM_MEDIA_TYPE * pMe
IUnknown_Release(pMediaType-pUnk);
pMediaType-pUnk = NULL;
}
+CoTaskMemFree(pMediaType);
}
BOOL CompareMediaTypes(const AM_MEDIA_TYPE * pmt1, const
AM_MEDIA_TYPE * pmt2, BOOL bWildcards)
This change is wrong. DeleteMediaType is not supposed to free the
memory used for the AM_MEDIA_TYPE structure itself as the function is
also used in places where the AM_MEDIA_TYPE was not allocated using
CoTaskMemAlloc.
Rob
This change is right, if you don't want to release the format block you
need to use freemediatype... quoting msdn...
*DeleteMediaType*
The **DeleteMediaType* *function deletes an allocated *AM_MEDIA_TYPE*
http://msdn.microsoft.com/library/en-us/directshow/htm/am_media_typestructure.asp
structure, including the format block.
*Syntax*
|*void WINAPI *DeleteMediaType*(
**AM_MEDIA_TYPE* /*pmt/
*);*
|
*Parameters*
/pmt /
Pointer to an *AM_MEDIA_TYPE* structure.
*Return Value*
No return value.
*Remarks*
Use this function to release any media type structure that was allocated
using either *CoTaskMemAlloc* or *CreateMediaType*
http://msdn.microsoft.com/library/en-us/directshow/htm/createmediatype.asp.
If you prefer not to link to the base class library, you can use the
following code directly:
|void MyDeleteMediaType(AM_MEDIA_TYPE *pmt)
{
if (pmt != NULL)
{
MyFreeMediaType(*pmt); // See FreeMediaType for the implementation.
CoTaskMemFree(pmt);
}
}
|
*Requirements*
* Header:* Declared in Mtype.h; include Streams.h.
* Library:* Use Strmbase.lib (retail builds) or Strmbasd.lib (debug
builds).
Re: Re2: EnumMedia patch
Maarten Lankhorst wrote: Robert Shearman wrote: Maarten Lankhorst wrote: This patch fixes AM_MEDIA_TYPE-pbFormat not being handled correctly, unfortunately, this also means some stuff has to be rewritten to avoid memleaks, instead of CoTaskMemFree(AM_MEDIA_TYPE), DeleteMediaType has to be used.. This also fixes the errors i had with msn webcam, i feel like i stumbled over every bug in quartz now.. @@ -45,6 +46,7 @@ void DeleteMediaType(AM_MEDIA_TYPE * pMe IUnknown_Release(pMediaType-pUnk); pMediaType-pUnk = NULL; } +CoTaskMemFree(pMediaType); } BOOL CompareMediaTypes(const AM_MEDIA_TYPE * pmt1, const AM_MEDIA_TYPE * pmt2, BOOL bWildcards) This change is wrong. DeleteMediaType is not supposed to free the memory used for the AM_MEDIA_TYPE structure itself as the function is also used in places where the AM_MEDIA_TYPE was not allocated using CoTaskMemAlloc. Rob This change is right, if you don't want to release the format block you need to use freemediatype... quoting msdn... Ok, the way it was designed in Wine didn't match the DShow SDK way. You still need to fix up the callers before making this change then. Rob
Re: Mouse warp questions
On Sat, Apr 16, 2005 at 10:52:10PM +, Stefan Dösinger wrote: Yes, it fixes the problem. The mouse wasn't moved once during my 2 minute test, but it looks like this is because the mouse warp is broken with MOUSE_HACK undefined. No, I think it's due to a bug in Wine: trace:dinput:SysMouseAImpl_GetDeviceData (0x77c60a80)-(dods=16,entries=-1,fl=0x0001) trace:dinput:SysMouseAImpl_GetDeviceData Application discarding 2 event(s). trace:dinput:SysMouseAImpl_GetDeviceData Warping mouse to 400 - 300 So basically the application is trying to get the number of events in the queue and we just discard all of them. As before, a patch will be done when I come back home (I really should have taken the time to install Linux on this laptopt :-) ) but I think it's pretty easy to fix (i.e. just handle the 'PEEK' attribute in the 'dod == NULL' case). A real proper fix would need to handle the 'INFINITE' value for 'entries' and stuff like this, but well, I doubt it's really necessary. Anyway, the bug is that we tell the application that there are two events in the queue (but erase them in the process of querying) and when the application actually asks for these two events, we do not return any as we flushed them. So the game cursor will not move at all :-) I digged a little bit into the mouse warp thing. It looks like that the mouse warp is used for applications which read the mouse moves. But the cursor still exists and if it reaches the boarder of the screen X wouldn't report any changes in the mouse position, so wine constantly warps the mouse back to the middle of the screen. Basically yeah. It comes mostly from the fact that DInput requires relative mouse movements (a mouse does not report any absolute axis in Windows and if you request absolute mode, it's completely broken, even on Windows). The problem is how to handle a case when the user continuously moves his mouse to - let's say - the right and that your mouse cursor reaches the edge of your screen ? X11 will always report the same X coordinate and thus even if the user moves his mouse, Wine will report to the game that the mouse did not move in the horizontal direction. So a part from an X11 extension (which I plan to work on again one of these days with the X.org guys), the only way to support this is via mouse warping (note that DGA mouse exists, but well, it's a bit ugly and is a bit frowned upon by the X people now). Lionel -- Lionel Ulmer - http://www.bbrox.org/
Re: Benchmarking Wine againt XP Part 2
On Fri, Apr 29, 2005 at 02:13:57PM -0400, Tom Wickline wrote: This is part two of the results. These things should be nicely formatted and posted on the Wiki: wiki.winehq.org This way we can keep track of such results, see how we (hopefully) improve in time. -- Dimi.
Adobe Photoshop
When I´ve installed Abobe Photoshop CS2 it was closed without any error
Logs:
fixme:msi:MsiGetProductInfoA {236BB7C4-4419-42FD-0409-1E257A25E34D}
PackageCode 0x406fdbc8 0x406fdc38
fixme:msi:MsiGetProductInfoW L{236BB7C4-4419-42FD-0409-1E257A25E34D}
LPackageCode 0x403e3f38 0x406fdc38
err:dc:DCE_FreeWindowDCE [0x10026] GetDC() without ReleaseDC()!
fixme:msi:MsiInstallProductW LZ:\\soft\\win\\Photoshop CS2\\Photoshop
CS2\\Adobe(R) Photoshop(R) CS2\\Adobe Photoshop CS2.msi L SETUPEXEDIR=\Z:
\\soft\\win\\Photoshop CS2\\Photoshop CS2\\Adobe(R) Photoshop(R) CS2\
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{786C5747-1033--B58E-0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{B74D4E10-1033---0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{ECA57BE9-1E11-4F5F-807D-950BD40DA776})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{E9787678-1033--8E67-0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\[ProductCode])
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LFindRelatedProducts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LValidateProductID
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LIsolateComponents
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LMigrateFeatureStates
fixme:msi:ACTION_PerformUIAction UNHANDLED MSI ACTION LInstallWelcome
fixme:msi:ACTION_PerformUIAction UNHANDLED MSI ACTION LSetupProgress
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LExecuteAction
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveExistingProducts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LAllocateRegistrySpace
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnpublishComponents
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LMsiUnpublishAssemblies
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnpublishFeatures
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LStopServices
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LDeleteServices
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterComPlus
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LSelfUnregModules
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterTypeLibraries
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action LRemoveODBC
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterFonts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveRegistryValues
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterClassInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterExtensionInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterProgIdInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterMIMEInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveIniValues
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveShortcuts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveEnvironmentStrings
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveDuplicateFiles
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action LRemoveFiles
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveFolders
fixme:msi:ACTION_CustomAction Rollback only action... rollbacks not supported
yet
--
Linux forever
pgp1SLuU4PLmj.pgp
Description: PGP signature
Adobe Photoshop
When I´ve installed Abobe Photoshop CS2 it was closed without any error
Logs:
fixme:msi:MsiGetProductInfoA {236BB7C4-4419-42FD-0409-1E257A25E34D}
PackageCode 0x406fdbc8 0x406fdc38
fixme:msi:MsiGetProductInfoW L{236BB7C4-4419-42FD-0409-1E257A25E34D}
LPackageCode 0x403e3f38 0x406fdc38
err:dc:DCE_FreeWindowDCE [0x10026] GetDC() without ReleaseDC()!
fixme:msi:MsiInstallProductW LZ:\\soft\\win\\Photoshop CS2\\Photoshop
CS2\\Adobe(R) Photoshop(R) CS2\\Adobe Photoshop CS2.msi L SETUPEXEDIR=\Z:
\\soft\\win\\Photoshop CS2\\Photoshop CS2\\Adobe(R) Photoshop(R) CS2\
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{786C5747-1033--B58E-0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{B74D4E10-1033---0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{ECA57BE9-1E11-4F5F-807D-950BD40DA776})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{E9787678-1033--8E67-0001})
fixme:msi:ACTION_AppSearchReg AppSearch unimplemented for RegLocator (key path
LSOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\[ProductCode])
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LFindRelatedProducts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LValidateProductID
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LIsolateComponents
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LMigrateFeatureStates
fixme:msi:ACTION_PerformUIAction UNHANDLED MSI ACTION LInstallWelcome
fixme:msi:ACTION_PerformUIAction UNHANDLED MSI ACTION LSetupProgress
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LExecuteAction
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveExistingProducts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LAllocateRegistrySpace
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnpublishComponents
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LMsiUnpublishAssemblies
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnpublishFeatures
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LStopServices
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LDeleteServices
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterComPlus
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LSelfUnregModules
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterTypeLibraries
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action LRemoveODBC
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterFonts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveRegistryValues
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterClassInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterExtensionInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterProgIdInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LUnregisterMIMEInfo
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveIniValues
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveShortcuts
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveEnvironmentStrings
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveDuplicateFiles
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action LRemoveFiles
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
LRemoveFolders
fixme:msi:ACTION_CustomAction Rollback only action... rollbacks not supported
yet
err:msi:ACTION_ProcessExecSequence Execution halted due to error (1603)
--
Linux forever
pgplRLg5mYWhH.pgp
Description: PGP signature
Re: Bugzilla voting
I don't see a way to disallow voting by reporter with out changing the bugzilla code. Someone can correct me here. I'll change the votes to confirm setting to 1 if there is enough people who want it. On Thu, 2005-04-28 at 20:59 -0500, Dustin Navea wrote: Just had a quick question about the voting process on Bugzilla, hope Jeremy sees this and can answer it. It seems that when a bug is voted for by 1 person, it does not become confirmed like it used to, it now takes 2 votes. This seems a little unnecessary, as 1 vote would mean that 2 people are experiencing the same problem (the reporter and the person casting the vote), in which case it is most likely a bug, and not some mis-configuration. If we are worried that a bug reporter might exploit this and confirm his own bugs by using the voting system, we could always set it up to disallow votes from the reporter, couldn't we? Just my thoughts. Hoping you will see my point and lower the number of votes to confirm value by 1.. Dustin
regression due to patch 16515 2005-03-09
The application of this patch causes a menu item to not be displayed. In appplication TablEdit Demo available at http://www.tabledit.com/download/tabled32.exe there is under the File entry of the menubar a submenu entry for both Import and Export which are both present when run under WINE before this patch is applied. After application the Import submenu is no longer present. The loss of this submenu persists into the current 20050405 release. I am running Slackware 10.0 on a AMD K6 500Mhz with self-compiled binaries from CVS as per regression testing procedure on winehq.com. -- Timm Reasbeck
Re: wine-20050419 crashes warcraft 3
Hi, You should probably edit your wine config file in .wine/config (if you have one) to run war3.exe in a window. This will possibly allow you to view any traceback information. The other thing is that you should make sure that you are running Warcraft 3 in OpenGL. The command is: wine war3.exe -opengl I hope that this helps. --Tim Hi all, I recently compiled wine-20050419, and decided to give Warcraft 3 a try. The game installed nicely but crashed at runtime, freezing my computer. I had to hard-reboot the box to recover. Unfortunately, i am unable to give any trace or log, because each time i launch Warcraft it hangs, leaving me with no alternative but rebooting the system. On the other hand, the world editor works more or less : i can't see the menu bar above the map entry, but i can play with the landscape elements and build a map. I also managed to play Starcraft and Atomic Bomberman, which don't make use of opengl, so it sounds like my installation is correct. Running Warcraft with or without -opengl, in managed or desktop mode, as root or normal user, with any windows version (from win98 up to winxp) amounts to the same crash. My config is: - kernel 2.4.26 running on a k6-2 500MHz. - xorg server 6.8.1 - GeForce 4 MX440 with latest NVidia drivers (1.7174) Everything compiled locally with gcc 3.3.4. Any (little) help is more than welcomed! regards, Seb.
Re: Benchmarking Wine againt XP Part 1
On 4/30/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: On Fri, 29 Apr 2005 20:13:51 +0200, Tom Wickline [EMAIL PROTECTED] wrote: This is part one of the results.. Tom And that's all I got. The msg shows as 15k but those two lines are all I see. dont know if it got filtered by the mailing list or my email client (opera) did not like it. What format/tool did you use? Hello, Part 1 is just 4 text files, I have no idea why Opera would dislike text file attachments. You can download the text files from : http://www.winehq.org/hypermail/wine-devel/2005/04/0645.html Tom I'd be very interested to see you results anyway. Thx.
Re: Benchmarking Wine againt XP Part 2
On 5/1/05, Dimitrie O. Paun [EMAIL PROTECTED] wrote: On Fri, Apr 29, 2005 at 02:13:57PM -0400, Tom Wickline wrote: This is part two of the results. These things should be nicely formatted and posted on the Wiki: wiki.winehq.org This way we can keep track of such results, see how we (hopefully) improve in time. Thanks Dimi, this sounds like a wonderful idea. If other people have run different benchmarks and have results on the same hardware/setup we could add there results as well. If anyone wants me to run a certain benchmark just let me know and ill be more than glad to do it. I have run Pov-Ray in the past if anyone is interested in this bench ill re-install it and run it again. http://www.povray.org/ Cheers, Tom -- Dimi.
Re: Put all Wineconf slides on Winehq
On 5/1/05, Boaz Harrosh [EMAIL PROTECTED] wrote: For the sake of all the mis fortunate who could not attend Wineconf this year. Could someone, Please, collect all presentations and put them on Winehq. I thought that it could be nice if Wineconf page's Agenda could be updated to what it actually was, with links from each session to it's slides, and if possible some commentary on important QA that arose. We (Ivan, me and Lionel) also have recorded both sound and video of most presentations. We are not really sure about the quality (webcam and a line-in signal connected to a microphone input) yet. And the size might be still to big. Some are 500MB (xvid + mp3 compression). We'll see what we can do with it. Right now Lionel has all recordings on his laptop. Paul
Re: Make test status - latest CVS
Shachar Shemesh wrote:
The problem is that I'm not interested in this test. I just think
that, off the shelf, tests should not fail. My opinion is that if this
is not a problem with Wine, it shouldn't fail the test.
Does this patch help? It should fail the same way windows does now.
Index: dlls/dsound/dsound.c
===
RCS file: /home/wine/wine/dlls/dsound/dsound.c,v
retrieving revision 1.31
diff -u -p -r1.31 dsound.c
--- dlls/dsound/dsound.c15 Mar 2005 15:40:36 - 1.31
+++ dlls/dsound/dsound.c1 May 2005 21:40:14 -
@@ -684,11 +684,107 @@ static HRESULT WINAPI IDirectSoundImpl_I
LPCGUID lpcGuid)
{
IDirectSoundImpl *This = (IDirectSoundImpl *)iface;
+HRESULT hr = DS_OK;
TRACE((%p,%s)\n,This,debugstr_guid(lpcGuid));
-This-initialized = TRUE;
+if (This-initialized == TRUE) {
+WARN(already initialized\n);
+return DSERR_ALREADYINITIALIZED;
+}
-return DS_OK;
+/* If the driver requests being opened through MMSYSTEM
+ * (which is recommended by the DDK), it is supposed to happen
+ * before the DirectSound interface is opened */
+if (This-drvdesc.dwFlags DSDDESC_DOMMSYSTEMOPEN)
+{
+DWORD flags = CALLBACK_FUNCTION;
+
+/* disable direct sound if requested */
+if (ds_hw_accel != DS_HW_ACCEL_EMULATION)
+flags |= WAVE_DIRECTSOUND;
+
+hr = mmErr(waveOutOpen((This-hwo),
+This-drvdesc.dnDevNode, This-pwfx,
+(DWORD)DSOUND_callback, (DWORD)This,
+flags));
+if (hr != DS_OK) {
+WARN(waveOutOpen failed\n);
+return hr;
+}
+}
+
+if (This-driver) {
+hr = IDsDriver_Open(This-driver);
+if (hr != DS_OK) {
+WARN(IDsDriver_Open failed\n);
+return hr;
+}
+
+/* the driver is now open, so it's now allowed to call GetCaps */
+hr = IDsDriver_GetCaps(This-driver,(This-drvcaps));
+if (hr != DS_OK) {
+WARN(IDsDriver_GetCaps failed\n);
+return hr;
+}
+} else {
+WAVEOUTCAPSA woc;
+hr = mmErr(waveOutGetDevCapsA(This-drvdesc.dnDevNode, woc,
sizeof(woc)));
+if (hr != DS_OK) {
+WARN(waveOutGetDevCaps failed\n);
+return hr;
+}
+ZeroMemory(This-drvcaps, sizeof(This-drvcaps));
+if ((woc.dwFormats WAVE_FORMAT_1M08) ||
+(woc.dwFormats WAVE_FORMAT_2M08) ||
+(woc.dwFormats WAVE_FORMAT_4M08) ||
+(woc.dwFormats WAVE_FORMAT_48M08) ||
+(woc.dwFormats WAVE_FORMAT_96M08)) {
+This-drvcaps.dwFlags |= DSCAPS_PRIMARY8BIT;
+This-drvcaps.dwFlags |= DSCAPS_PRIMARYMONO;
+}
+if ((woc.dwFormats WAVE_FORMAT_1M16) ||
+(woc.dwFormats WAVE_FORMAT_2M16) ||
+(woc.dwFormats WAVE_FORMAT_4M16) ||
+(woc.dwFormats WAVE_FORMAT_48M16) ||
+(woc.dwFormats WAVE_FORMAT_96M16)) {
+This-drvcaps.dwFlags |= DSCAPS_PRIMARY16BIT;
+This-drvcaps.dwFlags |= DSCAPS_PRIMARYMONO;
+}
+if ((woc.dwFormats WAVE_FORMAT_1S08) ||
+(woc.dwFormats WAVE_FORMAT_2S08) ||
+(woc.dwFormats WAVE_FORMAT_4S08) ||
+(woc.dwFormats WAVE_FORMAT_48S08) ||
+(woc.dwFormats WAVE_FORMAT_96S08)) {
+This-drvcaps.dwFlags |= DSCAPS_PRIMARY8BIT;
+This-drvcaps.dwFlags |= DSCAPS_PRIMARYSTEREO;
+}
+if ((woc.dwFormats WAVE_FORMAT_1S16) ||
+(woc.dwFormats WAVE_FORMAT_2S16) ||
+(woc.dwFormats WAVE_FORMAT_4S16) ||
+(woc.dwFormats WAVE_FORMAT_48S16) ||
+(woc.dwFormats WAVE_FORMAT_96S16)) {
+This-drvcaps.dwFlags |= DSCAPS_PRIMARY16BIT;
+This-drvcaps.dwFlags |= DSCAPS_PRIMARYSTEREO;
+}
+if (ds_emuldriver)
+This-drvcaps.dwFlags |= DSCAPS_EMULDRIVER;
+This-drvcaps.dwMinSecondarySampleRate = DSBFREQUENCY_MIN;
+This-drvcaps.dwMaxSecondarySampleRate = DSBFREQUENCY_MAX;
+This-drvcaps.dwPrimaryBuffers = 1;
+}
+
+hr = DSOUND_PrimaryCreate((IDirectSoundImpl*)This);
+if (hr == DS_OK) {
+This-initialized = TRUE;
+DSOUND_renderer = (IDirectSoundImpl*)This;
+timeBeginPeriod(DS_TIME_RES);
+DSOUND_renderer-timerID = timeSetEvent(DS_TIME_DEL, DS_TIME_RES,
DSOUND_timer,
+(DWORD)DSOUND_renderer, TIME_PERIODIC | TIME_CALLBACK_FUNCTION);
+} else {
+WARN(DSOUND_PrimaryCreate failed\n);
+}
+
+return hr;
}
static HRESULT WINAPI IDirectSoundImpl_VerifyCertification(
@@ -841,11 +937,11 @@ HRESULT WINAPI IDirectSoundImpl_Create(
return DSERR_OUTOFMEMORY;
}
-pDS-pwfx-wFormatTag = WAVE_FORMAT_PCM;
/* We rely on the sound driver to return
Steam Problems
I am experiencing two problems w/ Steam:
1) It's always on top of all other windows,on all
workspaces of GNOME, which is very annoying, and makes
it impossible to try HL2. If clicked while HL2 is on startup
screen it will crash the game.
2) If you click on any game, go to Update News, it will crash
every time. If there are Update News when Steam is started, it
will crash (but it will work after that). Here's the output, although it
doesn't look very helpful to me:
ALSA lib control.c:739:(snd_ctl_open_noupdate) Invalid CTL plug:hw:0
err:mmio:MMIO_ParseExtA No . in szFileName:
err:mmio:MMIO_ParseExtA No . in szFileName: C:\\Program Files\\Valve\
\Steam\\
fixme:sync:CreateIoCompletionPort (0x, (nil), ,
): stub.
fixme:ole:CoCreateInstance no classfactory created for CLSID
{4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154
Win32 MiniDump Helper version 1.0.0.0 (c) Copyright 2000-2003 Valve
Corporation All rights reserved.
Expected argument 'ProcessId'.
Usage: WriteMiniDump [EMAIL PROTECTED] [/?|h|help] [/v|version] [/Type value]
ProcessId DumpFile
@argfileRead arguments from a file.
/? Show usage.
/v Show version.
/Type value Select dump type values are:
normal
full
ProcessId Select process id for which to generate a dump
DumpFileSelect path of output dump file
Shutting down. . .
1
--
Ivan Gyurdiev [EMAIL PROTECTED]
Cornell University
Re: wine-20050419 crashes warcraft 3
--- Sebastien Fievet [EMAIL PROTECTED] wrote: I had to hard-reboot the box to recover. Unfortunately, i am unable to give any trace or log, because each time i launch Warcraft it hangs, leaving me with no alternative but rebooting the system. Maybe you can do: wine wc3.exe 21 | tee ~/log Then when you reboot, the errors should go to ~/log. I've tried this with xkill'ing the terminal I run it in, and I'm not sure if this works for a crash, but it's worth a try ;) William Poetra Yoga Hadisoeseno __ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/
Re: DirectX 9 patches
Okay, more info and screenshots over here: http://ivan.ivg2.net/hl2/ It's not playable, but it's exciting that it gets this far in the first place! ...it has to be installed through Steam (since msi won't work). -- Ivan Gyurdiev [EMAIL PROTECTED] Cornell University
Anyone remember winemine?
Hi, anyone here remember winemine? The whole window just shifts down by one pixel whenever we click the smiley in the middle. This patch fixes it. P.S: Sorry about my last patch, I didn't check that nonclient.c has moved from windows/ to dlls/user/ :P William Poetra Yoga Hadisoeseno __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com Index: dlls/user/nonclient.c === RCS file: /home/wine/wine/dlls/user/nonclient.c,v retrieving revision 1.1 diff -p -u -r1.1 nonclient.c --- dlls/user/nonclient.c 25 Apr 2005 11:33:36 - 1.1 +++ dlls/user/nonclient.c 2 May 2005 03:38:54 - @@ -398,7 +398,7 @@ LONG NC_HandleNCCalcSize( HWND hwnd, REC winRect-top += MENU_GetMenuBarHeight( hwnd, winRect-right - winRect-left, - -tmpRect.left, -tmpRect.top ) + 1; + -tmpRect.left, -tmpRect.top ); } if( exStyle WS_EX_CLIENTEDGE) @@ -1025,7 +1025,7 @@ static void NC_DoNCPaint( HWND hwnd, H TRACE(Calling DrawMenuBar with rect (%ld, %ld)-(%ld, %ld)\n, r.left, r.top, r.right, r.bottom); - rect.top += MENU_DrawMenuBar( hdc, r, hwnd, suppress_menupaint ) + 1; + rect.top += MENU_DrawMenuBar( hdc, r, hwnd, suppress_menupaint ); } TRACE(After MenuBar, rect is (%ld, %ld)-(%ld, %ld).\n,
