Re: wine on FreeBSD
On Saturday 30 July 2005 04:18, jean-marc DETREZ wrote: > Hi, > > > > With the differents mails i receive from users or wine's developers, i > think that: > > > > - Dislike OpenBSD or SRV4, mincore did'nt fail if the page is > not mapped no [ENOMEM] error condition. > > > > - the FreeBSD man pages say that mmap would fail with [ENOMEM] > error condition if address is in use but in the reality it seems always > return the start address. > > > > So for to use wine on FreeBSD before doing a more clean patch i propose to > add this to mmap . I know that it would map memory pages without verify > before that the pages is'nt already map but the man pages say it must > failed so I'm just verify that the result is equal to start address the > mmap call asking for. > > > > > > I do that only when creating System heap because requesting > mmap for 0x80 start address (without MAP_FIXED) always fail and prevent > wine running on FreeBSD. > > > > I'll do more test to implement a try_mmap_fixed function > working on FreeBSD like this done for SRV4,NetBSD and DARWIN. > > > > Jean-marc Actually the fix for SVR4 (Solaris) does work BUT, the numerous vforks cause resource problems under Solaris. I already have a patch which does a single reserve of 64 MB for the system heap and leaves the rest alone. Other memory gets mapped out on the first memory allocate autmagically by the wine allocator. This approach seems to work well under Solaris.. From what I know is is unlikely (read very improbable) that 64K from 0x8000 would be in use so early in the wine process so a fixed mmap is unlikely to actually unmap anything. Still it would be polite to check if possible. (Yo ucan do this by reading the processes address space (as) file in /proc on SVR4 systems as will as mincore Bob
Re: Add KERNEL32.SetThreadUILanguage() stub
"Andreas Mohr" <[EMAIL PROTECTED]> wrote:
+LANGID WINAPI SetThreadUILanguage(WORD wReserved)
+{
+ FIXME("SetThreadUILanguage(0x%04x), semi-stub! (defaulting to english)\n",
wReserved);
+ return MAKELANGID(LANG_ENGLISH, SUBLANG_DEFAULT);
+}
Why are you returning english here? Wine should display UI according
to current user locale, so GetUserDefaultUILanguage() would be more
appropriate here.
--
Dmitry.
[AppDB] Regression: Editing notes doesn't work anymore
Didn't had time to investigate yet. -- Jonathan Ernst <[EMAIL PROTECTED]> signature.asc Description: This is a digitally signed message part
TR: wine on FreeBSD with patch
De : jean-marc DETREZ [mailto:[EMAIL PROTECTED] Envoyé : vendredi 29 juillet 2005 20:28 À : 'Alexandre Julliard' Cc : '[EMAIL PROTECTED]'; 'wine-devel@winehq.com'; '[EMAIL PROTECTED]'; 'Dmitry Timoshkov'; 'Gerald Pfeifer' Objet : TR: wine on FreeBSD with patch De : jean-marc DETREZ [mailto:[EMAIL PROTECTED] Envoyé : vendredi 29 juillet 2005 20:18 À : 'Alexandre Julliard' Cc : '[EMAIL PROTECTED]'; 'Gerald Pfeifer'; 'wine-devel@winehq.com'; '[EMAIL PROTECTED]'; 'Dmitry Timoshkov' Objet : wine on FreeBSD Hi, With the differents mails i receive from users or wine’s developers, i think that: - Dislike OpenBSD or SRV4, mincore did’nt fail if the page is not mapped no [ENOMEM] error condition. - the FreeBSD man pages say that mmap would fail with [ENOMEM] error condition if address is in use but in the reality it seems always return the start address. So for to use wine on FreeBSD before doing a more clean patch i propose to add this to mmap . I know that it would map memory pages without verify before that the pages is’nt already map but the man pages say it must failed so I’m just verify that the result is equal to start address the mmap call asking for. I do that only when creating System heap because requesting mmap for 0x80 start address (without MAP_FIXED) always fail and prevent wine running on FreeBSD. I’ll do more test to implement a try_mmap_fixed function working on FreeBSD like this done for SRV4,NetBSD and DARWIN. Jean-marc mmap.patch Description: Binary data
wine on FreeBSD
Hi, With the differents mails i receive from users or wine’s developers, i think that: - Dislike OpenBSD or SRV4, mincore did’nt fail if the page is not mapped no [ENOMEM] error condition. - the FreeBSD man pages say that mmap would fail with [ENOMEM] error condition if address is in use but in the reality it seems always return the start address. So for to use wine on FreeBSD before doing a more clean patch i propose to add this to mmap . I know that it would map memory pages without verify before that the pages is’nt already map but the man pages say it must failed so I’m just verify that the result is equal to start address the mmap call asking for. I do that only when creating System heap because requesting mmap for 0x80 start address (without MAP_FIXED) always fail and prevent wine running on FreeBSD. I’ll do more test to implement a try_mmap_fixed function working on FreeBSD like this done for SRV4,NetBSD and DARWIN. Jean-marc
Re: Add KERNEL32.SetThreadUILanguage() stub
Hi,
On Fri, Jul 29, 2005 at 07:14:22PM +0200, Thomas Weidenmueller wrote:
> Andreas Mohr wrote:
> > Hello all,
> >
> > this one is needed by XP's ping.exe and a reworked ReactOS version.
> >
> > Andreas Mohr
>
> This prototype is outdated. MS has documented this function in the
> meanwhile:
Thanks, very fast reaction!
This is now a semi-stub which should be able to satisfy requirements
much more than before.
Andreas Mohr
Index: dlls/kernel/kernel32.spec
===
RCS file: /home/wine/wine/dlls/kernel/kernel32.spec,v
retrieving revision 1.158
diff -u -r1.158 kernel32.spec
--- dlls/kernel/kernel32.spec 25 Jul 2005 11:08:31 - 1.158
+++ dlls/kernel/kernel32.spec 29 Jul 2005 18:18:33 -
@@ -959,6 +959,7 @@
@ stdcall SetThreadLocale(long)
@ stdcall SetThreadPriority(long long)
@ stdcall SetThreadPriorityBoost(long long)
+@ stdcall SetThreadUILanguage(long)
@ stdcall SetTimeZoneInformation(ptr)
@ stub SetTimerQueueTimer
@ stdcall SetUnhandledExceptionFilter(ptr)
Index: dlls/kernel/thread.c
===
RCS file: /home/wine/wine/dlls/kernel/thread.c,v
retrieving revision 1.27
diff -u -r1.27 thread.c
--- dlls/kernel/thread.c27 Jun 2005 12:03:56 - 1.27
+++ dlls/kernel/thread.c29 Jul 2005 18:18:33 -
@@ -514,6 +514,15 @@
}
/***
+ * SetThreadUILanguage (KERNEL32.@)
+ */
+LANGID WINAPI SetThreadUILanguage(WORD wReserved)
+{
+ FIXME("SetThreadUILanguage(0x%04x), semi-stub! (defaulting to english)\n",
wReserved);
+ return MAKELANGID(LANG_ENGLISH, SUBLANG_DEFAULT);
+}
+
+/***
* QueueUserAPC (KERNEL32.@)
*/
DWORD WINAPI QueueUserAPC( PAPCFUNC func, HANDLE hthread, ULONG_PTR data )
[Fwd: Re: [Fwd: Re: [Wine]wine-20050725 feedback : lots of graphical glitches]]
Sending to the devel-list as suggested by people on wine-users. Just
wasn't sure whther those kind of reports would be welcome on the devel ML.
The issues mentioned below seem to be regressions.
Thanks for your attention, I am willing to help but am just beginning to
grasp everything wine-related.
Vincent
Original Message
Subject: Re: [Fwd: Re: [Wine]wine-20050725 feedback : lots of graphical
glitches]
Date: Fri, 29 Jul 2005 14:03:50 +0200
From: Vincent Rubiolo <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
References: <[EMAIL PROTECTED]>
Hello,
I have submitted three bugs relative to these problems :
+ http://bugs.winehq.org/show_bug.cgi?id=3169
+ http://bugs.winehq.org/show_bug.cgi?id=3170
+ http://bugs.winehq.org/show_bug.cgi?id=3171
Vincent
Vincent Rubiolo wrote:
Ths list was forgotten. Forwarding.
Vincent
Original Message
Subject: Re: [Wine]wine-20050725 feedback : lots of graphical glitches
Date: Thu, 28 Jul 2005 17:45:44 -0700
From: George Lober <[EMAIL PROTECTED]>
To: Vincent Rubiolo <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Vincent Rubiolo wrote:
Hello wine-users,
I built and installed (with wineinstall) wine-20050725 [see system
info at end of mail].
While it works OK for most of the applications that I use (I still
have some crashes, I will investigate them), I have lots of graphical
glitches, some of which greatly reduce the usability of the
applications :
Firefox :
--
+ Installation problems, esp. with respect to icons and text. I am
attaching small screenshots for you to see the problems. During the
installation, the console returns :
fixme:win:SetWindowTextW setting text L"Extracting" of other process
window 0x10022 should not use SendMessage
err:static:STATIC_SetIcon huh? hicon!=0, but info=0???
+ Main page display problem. Black boxes in rendered page (which is
perfect on native Linux FF). Menubar scrambled. It clears up a little
(not perfect though) when my mouse passes over it. Console says :
err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59}
not registered
fixme:ole:CoCreateInstance no classfactory created for CLSID
{4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154
err:clipboard:CLIPBOARD_CloseClipboard Failed to set clipboard.
7-Zip:
--
The combo box under the icons is almost not appearing at all, making
it impossible to navigate in directories (see small screenshot).
This is just to show the problems I am encountering. I tried searching
in the Bugzilla but the search (keyword firefox) returned no replies.
I have to say that the search is quite cumbersome. I use Bugzilla
almost daily (Mozilla project for instance), and searches are a lot
easier because there is a simple search box, instead of having
everyone to use the advanced search function.
I also have opened an account on the AppDB. Should I report these
problems to the apps maintainers instead (it seems so)?
There is so much documentation that I don't know what to do : you seem
to welcome bug reports but I am not sure whether apps bugs are helpful
to you. Are they?
Could you give me some pointers please?
Thank you. I am willing to participate and help but don't know what to
report exactly as I am not familiar with Wine internals.
Vincent
System information as requested on
http://www.winehq.com/site/docs/wine-user/bug-reporting :
-
+ Wine 20050725 (note that wine -v does not work anymore, contrary to
what the page says)
+ kernel : i686 GNU/Linux 2.4.21-27.0.1.EL (this is Redhat Entreprise
WS3)
+ compiler : gcc (GCC) 3.4.3
+ windows : no windows installed or used
+ program : firefox 1.0.5, available at www.mozilla.org
+ cmdline : wine firefox.exe (in fake_c\Program Files\Mozilla Firefox)
+ X server : 4.3.0 shipped by Redhat
+ steps to reproduce : simply start firefox after installing. Same for
7zip.
Hello,
I would also like to add that I am having similar problem with my
install of wine-20050725, where the Toolbar buttons of an application
called DietPower are incorrectly sized smaller (about 26pix compared to
normal size of about 37pix). The Toolbutton Images are sized correctly
resulting in a mess. Version 20050628 and previous versions don't have
this problem. Would it help to post this on the bug-tracker ?
Regards, George
--
Reclaim Your Inbox!
http://www.mozilla.org/products/thunderbird
--
Reclaim Your Inbox!
http://www.mozilla.org/products/thunderbird
Re: [wined3d] tidy up draw prim and add strided data new to d3d9
Oliver Stieber wrote: use ++x instead of x++ since x++ potentially requires a temporary variable. I seriously doubt this will actually have an effect on the resulting assembly code generated by any semi-serious compiler (regardless of the -O level) as for(i = 0; i < x; i++) is a quite common idiom... Felix
Re: Add KERNEL32.SetThreadUILanguage() stub
Andreas Mohr wrote: > Hello all, > > this one is needed by XP's ping.exe and a reworked ReactOS version. > > Andreas Mohr This prototype is outdated. MS has documented this function in the meanwhile: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/intl/mui_set_thread_ui_lang.asp Best Regards, Thomas Weidenmueller
How to turn off Anti-aliasing
I have just updated my install of Wine and I notice that the config file is now deprecated, it doesn't get used. I want to turn off Wine Anti-aliasing. I was able to do it in the config file, but now I don't know. 'winecfg' doesn't have any such setting. Can it be turned off in the registry ? If so what is the setting ? Thankyou, George
Re: Impressive! Installshield actually almost worked!
Hans Kristian Rosbach wrote: Unhandled exception: page fault on read access to 0x in 32-bit code (0x). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:11ff GS:0033 EIP: ESP:5a9ec654 EBP:5a9edb24 EFLAGS:00210202( - 00 - -RI1) EAX:7c47a010 EBX: ECX:00010020 EDX:006486ee ESI:10014d10 EDI:7cfb0fe0 Stack dump: 0x5a9ec654: 10005639 7c47a010 10017b48 10003baf 0x5a9ec664: 10014d10 5a9edb18 5a9edb24 10011a00 0x5a9ec674: 5a9edb18 10003a03 10017b48 7be3e1a0 0x5a9ec684: 0017b1d8 00175720 0x5a9ec694: 0x5a9ec6a4: 023f: sel=11ff base=7d50e000 limit=1fff 32-bit rw- Backtrace: =>1 0x (0x5a9edb24) 2 0x0013fc44 DllThread+0x280(info=0x7be52270) [/usr/src/wine-cvs/wine/dlls/msi/custom.c:442] in msi (0x5a9edb48) 3 0x00b7ce85 THREAD_Start+0xd1(ptr=0x7be52c80) [/usr/src/wine-cvs/wine/dlls/kernel/thread.c:108] in kernel32 (0x5a9edc14) 4 0x006287ee start_thread+0x12e(info=0x7be53028) [/usr/src/wine-cvs/wine/dlls/ntdll/thread.c:235] in ntdll (0x5a9ee458) 5 0x00440b80 start_thread+0x80 in libpthread.so.0 (0x5a9ee4c8) 6 0x00398dee __clone+0x5e in libc.so.6 (0x) This looks like an MSI issue. The stack trace looks bogus because the code checks for a NULL function before calling it. Enable the +msi channel for more information. If you don't want to debug the installer yourself, you might want to check out this: http://www.codeweavers.com/compatibility/challenge/ -- Rob Shearman
Re: WLDAP32: implement ldap_err2string
On Friday 29 July 2005 15:55, Dmitry Timoshkov wrote:
> > How would you handle this using LoadString?
>
> Something like this:
>
> PCHAR ldap_err2stringA( ULONG err )
> {
> static char buf[256];
>
> if (!LoadStringA(wldap_hinst, err, buf, 256))
> LoadStringA(wldap_hinst, IDS_DEFAULT_ERROR, buf, 256);
>
> return buf;
> }
Thanks, that looks reasonable. Now let's see if I can learn how to
do resource files...
-Hans
Impressive! Installshield actually almost worked!
For the very first time I the AltiAgent 5.0 installer actually
managed to show a spash screen and even a progress bar that shows
the loading of Installshield. I think the progressbar got to 100%,
but then wine crashed.
Good work, I'm seriously impressed and will be testing a few other
installers too now. Btw, anyone know a good IE5/5.5/6 installer?
One of my other programs depends on it beeing installed.
I'm running a cvs checkout of about an hour old.
This is the complete unedited output (ignore the libGL warnings):
[EMAIL PROTECTED] AltiAgent 5.0]# wine setup.exe
libGL warning: 3D driver claims to not support visual 0x23
libGL warning: 3D driver claims to not support visual 0x24
libGL warning: 3D driver claims to not support visual 0x27
libGL warning: 3D driver claims to not support visual 0x28
libGL warning: 3D driver claims to not support visual 0x2b
libGL warning: 3D driver claims to not support visual 0x2c
libGL warning: 3D driver claims to not support visual 0x2f
libGL warning: 3D driver claims to not support visual 0x30
fixme:msi:MsiGetProductInfoW L"{87E06BA6-48C0-4793-9382-6945EF684D96}"
L"PackageCode" 0x6e4ac070 0x7fddd884
fixme:msi:MsiInstallProductW L"Z:\\home\\hk\\.wine\\drive_c\\AltiAgent
5.0\\ISScript9.Msi" L"REBOOT=ReallySuppress ADDLOCAL=All"
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
L"SelfUnregModules"
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
L"RemoveFiles"
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
L"MoveFiles"
fixme:msi:ACTION_InstallFiles Write DiskPrompt
fixme:msi:ITERATE_DuplicateFiles We should track these duplicate files
as well
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
L"RemoveRegistryValues"
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action
L"RemoveFolders"
libGL warning: 3D driver claims to not support visual 0x23
libGL warning: 3D driver claims to not support visual 0x24
libGL warning: 3D driver claims to not support visual 0x27
libGL warning: 3D driver claims to not support visual 0x28
libGL warning: 3D driver claims to not support visual 0x2b
libGL warning: 3D driver claims to not support visual 0x2c
libGL warning: 3D driver claims to not support visual 0x2f
libGL warning: 3D driver claims to not support visual 0x30
fixme:msi:MsiInstallProductW L"Z:\\home\\hk\\.wine\\drive_c\\AltiAgent
5.0\\AltiAgent 5.0.msi" L" REINSTALLMODE=vemus REINSTALL=ALL
SETUPEXEDIR=\"Z:\\home\\hk\\.wine\\drive_c\\AltiAgent 5.0\""
libGL warning: 3D driver claims to not support visual 0x23
libGL warning: 3D driver claims to not support visual 0x24
libGL warning: 3D driver claims to not support visual 0x27
libGL warning: 3D driver claims to not support visual 0x28
libGL warning: 3D driver claims to not support visual 0x2b
libGL warning: 3D driver claims to not support visual 0x2c
libGL warning: 3D driver claims to not support visual 0x2f
libGL warning: 3D driver claims to not support visual 0x30
fixme:ole:RpcChannelBuffer_GetDestCtx (0x19445734,0x19445738), stub!
fixme:ole:RpcChannelBuffer_GetDestCtx (0x19445730,0x19445734), stub!
fixme:win:SetWindowTextA setting text "TITLE_CAPTIONBAR" of other
process window (nil) should not use SendMessage
fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fdcef00,0x7fdcef04), stub!
fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fdcee04,0x7fdcee08), stub!
fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fdcee88,0x7fdcee8c), stub!
[EMAIL PROTECTED] AltiAgent 5.0]# wine: Unhandled exception (thread 000c),
starting debugger...
WineDbg starting on pid 0xa
Unhandled exception: page fault on read access to 0x in 32-bit
code (0x).
In 32 bit mode.
Register dump:
CS:0073 SS:007b DS:007b ES:007b FS:11ff GS:0033
EIP: ESP:5a9ec654 EBP:5a9edb24 EFLAGS:00210202( - 00 -
-RI1)
EAX:7c47a010 EBX: ECX:00010020 EDX:006486ee
ESI:10014d10 EDI:7cfb0fe0
Stack dump:
0x5a9ec654: 10005639 7c47a010 10017b48 10003baf
0x5a9ec664: 10014d10 5a9edb18 5a9edb24 10011a00
0x5a9ec674: 5a9edb18 10003a03 10017b48 7be3e1a0
0x5a9ec684: 0017b1d8 00175720
0x5a9ec694:
0x5a9ec6a4:
023f: sel=11ff base=7d50e000 limit=1fff 32-bit rw-
Backtrace:
=>1 0x (0x5a9edb24)
2 0x0013fc44 DllThread+0x280(info=0x7be52270)
[/usr/src/wine-cvs/wine/dlls/msi/custom.c:442] in msi (0x5a9edb48)
3 0x00b7ce85 THREAD_Start+0xd1(ptr=0x7be52c80)
[/usr/src/wine-cvs/wine/dlls/kernel/thread.c:108] in kernel32
(0x5a9edc14)
4 0x006287ee start_thread+0x12e(info=0x7be53028)
[/usr/src/wine-cvs/wine/dlls/ntdll/thread.c:235] in ntdll (0x5a9ee458)
5 0x00440b80 start_thread+0x80 in libpthread.so.0 (0x5a9ee4c8)
6 0x00398dee __clone+0x5e in libc.so.6 (0x)
0x: addb%al,0x0(%eax)
Modules:
Module Address Debug info Name (71 modules)
ELF 0x00111000-0017c000 Stabs msi
\-PE 0x0013-0017c000 \ msi
ELF 0x0017c000-00233000 Def
Re: WLDAP32: implement ldap_err2string
"Hans Leidekker" <[EMAIL PROTECTED]> wrote:
But according MSDN:
The return value is a static pointer to the character string.
Do not free this string.
How would you handle this using LoadString?
Something like this:
PCHAR ldap_err2stringA( ULONG err )
{
static char buf[256];
if (!LoadStringA(wldap_hinst, err, buf, 256))
LoadStringA(wldap_hinst, IDS_DEFAULT_ERROR, buf, 256);
return buf;
}
PWCHAR ldap_err2stringW( ULONG err )
{
static WCHAR buf[256];
if (!LoadStringW(wldap_hinst, err, buf, 256))
LoadStringW(wldap_hinst, IDS_DEFAULT_ERROR, buf, 256);
return buf;
}
--
Dmitry.
Re: WLDAP32: implement ldap_err2string
On 29.07.2005 15:23, Hans Leidekker wrote: > On Friday 29 July 2005 14:45, Dmitry Timoshkov wrote: > >> I'd suggest to move all strings into a stringtable and load them >> by LoadStringA/W. That way you get internationalization for free. > > But according MSDN: > >> The return value is a static pointer to the character string. >> Do not free this string. > > How would you handle this using LoadString? Hm, perhaps load all strings at DLL init time and free them when the DLL gets unloaded again? -f.r.
Re: Theming & code duplication
On 28.07.2005 15:54, Robert Shearman wrote: > In that case, you will have to retrieve the rectangle of the changed > area and pass that rectangle to RedrawWindow. Though, that would mean that paint messages are emitted to the window? IIRC last time I checked (with Spy++), there were no paint messages when e.g. the state of a checkbox changed. So using RedrawWindow() may mean a different behaviour than on native. -f.r. signature.asc Description: OpenPGP digital signature
Re: WLDAP32: implement ldap_err2string
On Friday 29 July 2005 14:45, Dmitry Timoshkov wrote: > I'd suggest to move all strings into a stringtable and load them > by LoadStringA/W. That way you get internationalization for free. But according MSDN: > The return value is a static pointer to the character string. > Do not free this string. How would you handle this using LoadString? -Hans
Re: WLDAP32: implement ldap_err2string
"Hans Leidekker" <[EMAIL PROTECTED]> wrote:
+static const char *errorstring[] = {
+"Success",
...
+static const WCHAR error00[] = { 'S','u','c','c','e','s','s',0 };
I'd suggest to move all strings into a stringtable and load them
by LoadStringA/W. That way you get internationalization for free.
--
Dmitry.
Re: Benchmark's on the Wiki
On Thu, Jul 28, 2005 at 05:34:08PM +0200, Holger Dell wrote: > >or is there a way to not only test "functionality" with tests but > >also "speed"? i guess this would be nice to find bottlenecks. > has anyone ever tried to use grpof or any other profiling tool to > analyze, which code eats most cpu time (=bottlenecks). i would consider gprof a tool to optimize an application - but its a little hard to profile an API with it. different apps will produces different results and so using gprof with certain apps (mainstream) results in _exaclty_ what you dont want (what transgaming does?). thinking about it - also using the benchmarks as a mark is the same (isnt that what all the driver developers do?). but having winetests, that also do certain things (lets say application "patterns") and then time them is IMHO a Good Thing - it can be coded into the winetest framework, which already runs the tests on real windows and on wine - then also time it and compare it. especially in the directx area this would be good to compare to windows (even if its sometimes simply not fair - if e.g. sound mixing is done in hardware under windows and in the cpu on wine). -- cu pgpX7HR1JAXbb.pgp Description: PGP signature
