Re: Add Tests for InternetQueryOption - try 2

[Dmitry Timoshkov]

On Sat, 2006-02-04 at 09:58 +0530, Vijay Kiran Kamuju wrote:

> I did initialize at the start when we use it first time i dont have problems.

But people like me who review and will later add/fix your code
may be confused by it.

> And later where ever i am using that i have initialized it.

Please, do not do it later, do it at the appropriate time and place
of the code.

> oops regarding the newlen check i will change that.
> If dont use the newlen variable, on windows the test will definitely crash.

As I said, get rid of newlen altogether, it's confusing.

-- 
Dmitry.

Re: Add Tests for InternetQueryOption - try 2

[Vijay Kiran Kamuju]

Hi,

I did initialize at the start when we use it first time i dont have problems.
And later where ever i am using that i have initialized it.
oops regarding the newlen check i will change that.
If dont use the newlen variable, on windows the test will definitely crash.

Thanks,
VJ

On 2/4/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> On Sat, 2006-02-04 at 09:16 +0530, Vijay Kiran Kamuju wrote:
>
> > I have initialized it the starting of the code.
> > see newlen=len=strlen(useragent)+1;
> > Are you talking about the first one, (i could see only one near the 
> > begining).
>
> Yes, apparently I overlooked that one, sorry. I'd suggest to initialize
> len variable before each call where it's actually used and get rid of
> newlen variable, it's actually not used and in one place it's checked
> instead of the len.
>
> --
> Dmitry.
>
>

Re: Add Tests for InternetQueryOption - try 2

[Dmitry Timoshkov]

On Sat, 2006-02-04 at 09:16 +0530, Vijay Kiran Kamuju wrote:

> I have initialized it the starting of the code.
> see newlen=len=strlen(useragent)+1;
> Are you talking about the first one, (i could see only one near the begining).

Yes, apparently I overlooked that one, sorry. I'd suggest to initialize
len variable before each call where it's actually used and get rid of
newlen variable, it's actually not used and in one place it's checked
instead of the len.

-- 
Dmitry.

Re: Add Tests for InternetQueryOption - try 2

[Vijay Kiran Kamuju]

Hi.

I have initialized it the starting of the code.
see newlen=len=strlen(useragent)+1;
Are you talking about the first one, (i could see only one near the begining).

Thanks,
Vijay

On 2/3/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> On Fri, 2006-02-03 at 15:36 +0530, Vijay Kiran Kamuju wrote:
>
> > +SetLastError(0xdeadbeef);
> > +
> retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,&len);
> > +err=GetLastError();
>
> You need to initialize length parameter before InternetQueryOption call.
>
> --
> Dmitry.
>
>

Re: msftedit.dll

[Dmitry Timoshkov]

On Sat, 2006-02-04 at 02:26 +0300, Phil Krylov wrote:

> Could this be done another way? E.g., symlink msftedit.dll.so to
> riched20.dll.so? Or copy riched20.dll.so as msftedit.dll.so, which would
> resemble MS approach more.

I'd suggest #3: forward msftedit entry points to the riched20 ones.

-- 
Dmitry.

Re: gethostbyname call with 0 length arg

[Phil Goss]

Thanks,

So basically, this check is now taken care of in the latest patches,  
correct?


Good ... Ill take a look at the guide as James suggested.

Cheers,
Phil

On Wed, 01 Feb 2006 23:27:53 +0100, Detlef Riekenberg <[EMAIL PROTECTED]>  
wrote:



Am Sonntag, den 29.01.2006, 14:46 +0100 schrieb Phil Goss:


There seems to be a check in the gethostbyname for a NULL arg name  ...
if(!name) ... But no check for  ... if(!strlen(name)) 


Alexandre changed "strlen(xxx) > 0" in my first Patch to xxx[0]
So for your code above, simple change:

if(!name) {

to

if((!name) && (name[0])) {

The logic is the same: use the code-path, if name is NULL and use it
also, when the string is empty.

I send this type of patch yesterday and it's already in the tree.

The Commit-Message is here:
http://www.winehq.org/pipermail/wine-cvs/2006-February/020657.html

(i used (pName != NULL) to have a common style in this function)



Does the above make sense, as I am not a programmer?

Yes, it does, and it's important when we have a Program that depend on
this behaviour.


Not sure if this s bug in wine even though it implementation should be
matching Windows native.


That's also a reason, why we have the Testsuite.
A specific Test changes "should match" to
"does not match (yet)" or "matches all the cases we tested".

The winedev-guide is nice to read. (see msg from James)






--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

Re: gethostbyname call with 0 length arg

[Phil Goss]

This is what seems to have worked for me

if(!name || !strlen(name)) {


On Fri, 03 Feb 2006 19:23:22 +0100, Christer Palm <[EMAIL PROTECTED]> wrote:


Detlef Riekenberg wrote:

 if((!name) && (name[0])) {



Do you really mean that?
"if name is 0, then dereference name"?

--
Christer Palm







--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

pr 3277 redux (err:opengl:X11DRV_ChoosePixelFormat glXChooseFBConfig returns NULL)

[Dan Kegel]

Hi Fenix!
What's the status of the glXChooseFBConfig problem you had
a test fix for in
http://www.winehq.com/hypermail/wine-devel/2005/05/0369.html
?
I think this is http://bugs.winehq.org/show_bug.cgi?id=3277
can you chime in there if appropriate?

People keep running into something similar, most recently
http://www.winehq.org/pipermail/wine-users/2006-February/020389.html

Thanks,
Dan

--
Wine for Windows ISVs: http://kegel.com/wine/isv

Re: msftedit.dll

[Phil Krylov]

On Sat, 4 Feb 2006 00:07:24 +0100
Stefan Leichter <[EMAIL PROTECTED]> wrote:

> +2 stub IID_IRichEditOle
> +3 stub IID_IRichEditOleCallback
> +4 stub CreateTextServices
> +5 stub IID_ITextServices
> +6 stub IID_ITextHost
> +7 stub IID_ITextHost2
> +8 stub REExtendedRegisterClass
> +9 stub RichEditANSIWndProc
> +10 stub RichEdit10ANSIWndProc
> +11 stub SetCustomTextOutHandlerEx
> +12 stub DllGetVersion
> +13 stub RichEditWndProc
> +14 stub RichListBoxWndProc
> +15 stub RichComboBoxWndProc

Could this be done another way? E.g., symlink msftedit.dll.so to
riched20.dll.so? Or copy riched20.dll.so as msftedit.dll.so, which would
resemble MS approach more.

-- Ph.

Re: New wined3d configuration window

[Brian Hill]

Ok, after working on the winecfg program for a bit, this is what I have :

http://img434.imageshack.us/my.php?image=winecfg17nf.png

I removed the paragraphs from the window as they took up a considerable 
amount of space.  Perhaps it would be best to document the functions as 
stated earlier through either the users guide or some kind of built-in 
help mechanism. 

The pixel shader option has been changed from a check box to a 
drop-down.  This allows selecting a version of pixel shaders to use.  
This is helpful if there is a bug in say a function that's only in PS 
1.3 so the game in question does not try to use it.


Graphics card memory allows the user to specify how much graphics card 
memory the wined3d module should report to programs.  Right now, as of 
the latest cvs version of Wine, it's hardcoded to 64 megabytes plus your 
available AGP memory.  This is a fairly good default as most vid cards 
today have at least that much but a slight theoretical performance boost 
can be gained on texture memory intensive games by allowing full use of 
a graphics cards memory.  Ideally, Wine should auto-detect this but the 
implementation varies by GPU maker.  Also, in the case of cards that 
share graphics card memory with system ram, you may not want a game to 
use all available texture memory. 

I've given the options a default setting as well.  Right now, the 
default settings are hard-linked to specific settings however in the 
future, it would be nice to have default try to automagically detect 
what settings are best. 

Re: dx9 and shaders

[Stefan Dösinger]

> Have you got a diff against a current tree anywhere? I can't promise
> I'll be of any help, but I wouldn't mind taking a look sometime when I
> can find the time. A small test program might be usefull as well.

I have attached a diff with my getDC implementation against the current tree, 
and a test application. The GetDC is taken from ddraw, and it's explained in 
http://article.gmane.org/gmane.comp.emulators.wine.devel/38533/ The problem 
of this code is that it crashes with a heap corruption sooner or later :(

The test program can be compiled with winelib, you only have to place a 
image.bmp file into it's folder with the size 640x480 and 24 bit color depth. 
It should show the image after loading. I wasn't able to run this program on 
a windows machine, because I didn't have access to one, but I think it should 
work.

If you have any ideas why GetDC fails, please tell me

Stefan
Index: dlls/wined3d/wined3d_private.h
===
RCS file: /home/wine/wine/dlls/wined3d/wined3d_private.h,v
retrieving revision 1.72
diff -u -r1.72 wined3d_private.h
--- dlls/wined3d/wined3d_private.h	9 Dec 2005 12:18:30 -	1.72
+++ dlls/wined3d/wined3d_private.h	3 Feb 2006 21:02:08 -
@@ -790,6 +790,17 @@
 } WINED3DSURFACET_DESC;
 
 /*
+ * Structure for DIB management
+ */
+typedef struct wineD3DSurface_DIB {
+HBITMAP DIBsection;
+void* bitmap_data;
+HGDIOBJ holdbitmap;
+BOOL client_memory;
+DWORD d3d_data[4]; /* room for Direct3D driver data */
+} wineD3DSurface_DIB;
+
+/*
  * IWineD3DSurface implementation structure
  */
 struct IWineD3DSurfaceImpl
@@ -831,10 +842,16 @@
 BOOL  inPBuffer;
 
 glDescriptor  glDescription;
+wineD3DSurface_DIBdib;
+BOOL  DC_in_use;
 };
 
 extern const IWineD3DSurfaceVtbl IWineD3DSurface_Vtbl;
 
+const LONG get_bitmask_red(WINED3DFORMAT fmt);
+const LONG get_bitmask_green(WINED3DFORMAT fmt);
+const LONG get_bitmask_blue(WINED3DFORMAT fmt);
+
 /*
  * IWineD3DVertexDeclaration implementation structure
  */
Index: dlls/wined3d/surface.c
===
RCS file: /home/wine/wine/dlls/wined3d/surface.c,v
retrieving revision 1.33
diff -u -r1.33 surface.c
--- dlls/wined3d/surface.c	31 Dec 2005 14:22:18 -	1.33
+++ dlls/wined3d/surface.c	3 Feb 2006 21:02:13 -
@@ -28,6 +28,9 @@
 WINE_DEFAULT_DEBUG_CHANNEL(d3d_surface);
 #define GLINFO_LOCATION ((IWineD3DImpl *)(((IWineD3DDeviceImpl *)This->resource.wineD3DDevice)->wineD3D))->gl_info
 
+extern HBITMAP DIB_CreateDIBSection( HDC hdc, const BITMAPINFO *bmi, UINT usage, VOID **bits,
+ HANDLE section, DWORD offset, DWORD ovr_pitch );
+
 /* ***
IWineD3DSurface IUnknown parts follow
*** */
@@ -884,14 +887,178 @@
 
 HRESULT WINAPI IWineD3DSurfaceImpl_GetDC(IWineD3DSurface *iface, HDC *pHDC) {
 IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface;
-FIXME("No support for GetDC yet for surface %p\n", This);
-return D3DERR_INVALIDCALL;
+HRESULT hr;
+D3DLOCKED_RECT lock;
+UINT usage;
+BITMAPINFO* b_info;
+HDC ddc;
+
+ERR("(%p)->(%p): This does not work yet\n",This,pHDC);
+
+if (This->DC_in_use)
+return /*DDERR_DCALREADYCREATED*/ D3DERR_INVALIDCALL /*for now*/;
+
+/* lock the surface, Create a DIB section and create a DC
+ * One problem: Pow2 size vs real size
+ * Texture repacking
+ * Propably others too. It doesn't work yet
+ */
+
+memset(&lock, 0, sizeof(lock)); /* To be sure */
+hr = IWineD3DSurface_LockRect(iface, &lock, NULL, 0);
+if (FAILED(hr))
+{
+return hr;
+}
+
+/* Create a DIB section */
+switch (This->bytesPerPixel)
+{
+case 2:
+case 4:
+/* Allocate extra space to store the RGB bit masks. */
+b_info = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(BITMAPINFOHEADER) + 3 * sizeof(DWORD));
+break;
+
+case 3:
+b_info = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(BITMAPINFOHEADER));
+break;
+
+default:
+/* Allocate extra space for a palette. */
+b_info = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
+   sizeof(BITMAPINFOHEADER)
+   + sizeof(RGBQUAD)
+   * (1 << (This->bytesPerPixel * 8)));
+break;
+}
+
+b_info->bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
+b_info->bmiHeader.biWidth = This->currentDesc.Width;
+b_info->bmiHeader.biHeight = -This->currentDesc.Height;
+b_info->bmiHeader.biPlanes = 1;
+b_inf

Re: WINE 0.9.3-0.9.6 and Photoshop 7 & CS

[Aleksey]

0.9.7 also breaks PS.
Oops, sent to the wrong email at first.

On 1/20/06, Hiji <[EMAIL PROTECTED]> wrote:
> --- Aleksey <[EMAIL PROTECTED]> wrote:
> > The patch has been found that breaks Photoshop, but
> > 0.9.6 still brakes PS.
>
> Yes, if the submitter of the patch that broke
> Photoshop could take a look and fix this, that would
> be great!  (This has been broken since 0.9.3)
>
> It's this patch:
> http://source.winehq.org/git/?p=wine.git;a=commit;h=0b17529332b0ef5ee57873afd4ded6f359e76781
>
> H.
>
>
> __
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
>
>

Re: gethostbyname call with 0 length arg

[Christer Palm]

Detlef Riekenberg wrote:


if((!name) && (name[0])) {



Do you really mean that?
"if name is 0, then dereference name"?

--
Christer Palm

Re: Wine release 0.9.7

[Michael Stefaniuc]

Duane Clark wrote:

Xtramind Autoresponder wrote:


Sehr geehrte Damen und Herren,

Herr Holger Stenzhorn ist nicht mehr im operativen Geschaeft der 
Xtramind Technologies GmbH taetig. 



Could someone tell me if that means he no longer works there? If so, 
Yes, that seems to be the case though they used a marketing formulation 
i didn't hear befor.



I'll remove this email from the list.

Yes.

bye 
michael
--
Michael Stefaniuc   Tel.: +49-711-96437-199
Sr. Network EngineerFax.: +49-711-96437-111
Red Hat GmbHEmail: [EMAIL PROTECTED]
Hauptstaetterstr. 58http://www.redhat.de/
D-70178 Stuttgart

Re: crypt32: implement W versions of string routines

[Stefan Leichter]

Am Donnerstag, 2. Februar 2006 23:47 schrieb Juan Lang:
> Stefan Leichter wrote:
> >This patch breaks compilation of the tests with mingw.
>
> (snip)
>
> >str.cross.o: In function `test_NameToStrConversionW':
> >/usr/src/wine/wine-mingw/dlls/crypt32/tests/../../../../wine/include/wine/
> >debug.h:179: undefined reference to `_wine_dbgstr_wn'
>
> This isn't the only test suite to use wine_dbg_str, mlang's does as
> well.  How do you deal with it for mlang?
> --Juan

in mlang there is always a #ifdef in front of wine_dbgstr_w. So it is exclude 
from compile.

Stefan

Re: Wine release 0.9.7

[Duane Clark]

Xtramind Autoresponder wrote:

Sehr geehrte Damen und Herren,

Herr Holger Stenzhorn ist nicht mehr im operativen Geschaeft der 
Xtramind Technologies GmbH taetig. 


Could someone tell me if that means he no longer works there? If so, 
I'll remove this email from the list.

RE: Wine release 0.9.7

[Xtramind Autoresponder]

Sehr geehrte Damen und Herren,

Herr Holger Stenzhorn ist nicht mehr im operativen Geschaeft der 
Xtramind Technologies GmbH taetig. 

Ihre E-Mail wurde nicht an Herrn Stenzhorn ausgeliefert.

Sollte der Inhalt Ihrer E-Mail geschaeftliche Belange der Xtramind 
Technologies GmbH betreffen, so senden Sie diese bitte erneut an
Frau Daniela Kurz:

[EMAIL PROTECTED]

Vielen Dank!



== Original Message Headers Follow == 

>From [EMAIL PROTECTED]  Thu Feb  2 17:44:37 2006
Return-Path: <[EMAIL PROTECTED]>
X-Original-To: [EMAIL PROTECTED]
Delivered-To: [EMAIL PROTECTED]
Received: from localhost (localhost.xtramind.dfki.de [127.0.0.1])
by mousepad.xtramind.dfki.de (Postfix) with ESMTP id 6D9361C356C
for <[EMAIL PROTECTED]>; Thu,  2 Feb 2006 17:44:37 +0100 (CET)
Received: from mousepad.xtramind.dfki.de ([127.0.0.1])
 by localhost (izac.xtramind.dfki.de [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 83893-06 for <[EMAIL PROTECTED]>;
 Thu,  2 Feb 2006 17:44:30 +0100 (CET)
Received: from wine.codeweavers.com (wine.codeweavers.com [209.32.141.3])
by mousepad.xtramind.dfki.de (Postfix) with ESMTP id 80F6F1C353A
for <[EMAIL PROTECTED]>; Thu,  2 Feb 2006 17:44:30 +0100 (CET)
Received: from localhost ([127.0.0.1] helo=localhost.localdomain)
by wine.codeweavers.com with esmtp (Exim 4.50)
id 1F4gyn-00065O-GE; Thu, 02 Feb 2006 10:06:41 -0600
Received: from localhost ([127.0.0.1])
by wine.codeweavers.com with esmtp (Exim 4.50) id 1F4gyl-00065D-Ar
for [EMAIL PROTECTED]; Thu, 02 Feb 2006 10:06:39 -0600
Received: from wine.codeweavers.com ([127.0.0.1])
by localhost (wine [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
id 18821-04 for <[EMAIL PROTECTED]>;
Thu, 2 Feb 2006 10:06:39 -0600 (CST)
Received: from mail.codeweavers.com ([216.251.189.131] ident=Debian-exim)
by wine.codeweavers.com with esmtp (Exim 4.50) id 1F4gyc-00064j-Qs
for [EMAIL PROTECTED]; Thu, 02 Feb 2006 10:06:39 -0600
Received: from adsl-84-227-124-103.adslplus.ch ([84.227.124.103]
helo=wine.dyndns.org) by mail.codeweavers.com with esmtpsa
(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1F4gyl-0003QK-42
for [EMAIL PROTECTED]; Thu, 02 Feb 2006 10:06:48 -0600
Received: by wine.dyndns.org (Postfix, from userid 1000)
id 1B2104F654; Thu,  2 Feb 2006 17:06:36 +0100 (CET)
To: [EMAIL PROTECTED]
From: Alexandre Julliard <[EMAIL PROTECTED]>
MIME-Version: 1.0 (mime-construct 1.9)
Message-Id: <[EMAIL PROTECTED]>
Date: Thu,  2 Feb 2006 17:06:36 +0100 (CET)
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at codeweavers.com
Subject: Wine release 0.9.7
X-BeenThere: [EMAIL PROTECTED]
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: wine-devel@winehq.org
List-Id: Wine Announcements 
List-Unsubscribe: ,

List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,

Sender: [EMAIL PROTECTED]
Errors-To: [EMAIL PROTECTED]
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: [EMAIL PROTECTED]
X-SA-Exim-Scanned: No (on wine.codeweavers.com); SAEximRunCond expanded to false
X-DSPAM-Result: Innocent
X-DSPAM-Processed: Thu Feb  2 17:44:34 2006
X-DSPAM-Confidence: 0.9997
X-DSPAM-Probability: 0.
X-DSPAM-Signature: 43e236f2844651657811814
X-DSPAM-Factors: 27,
X-Virus-Scanned: amavisd-new at xtramind.com

Re: crypt32: implement W versions of string routines

[Juan Lang]

Stefan Leichter wrote:


This patch breaks compilation of the tests with mingw.
 


(snip)


str.cross.o: In function `test_NameToStrConversionW':
/usr/src/wine/wine-mingw/dlls/crypt32/tests/../../../../wine/include/wine/debug.h:179:
 undefined reference to `_wine_dbgstr_wn'
 

This isn't the only test suite to use wine_dbg_str, mlang's does as 
well.  How do you deal with it for mlang?

--Juan

Re: linux/capi.h: present but cannot be compiled

[Joshua Crawford]

* Marcus Meissner <[EMAIL PROTECTED]> [2006-01-31 17:25 +0100]:
> On Tue, Jan 31, 2006 at 10:57:52PM +1100, Joshua Crawford wrote:
>> (I'm not on the devel list, so please Cc: replies either to me or the users
>> list.)
>> 
>> After recently upgrading my distro (from Slackware 10.1 to Slackware 10.2
>> with Freerock GNOME), configure (current CVS) now reports
> 
> It will likely work nethertheless, see here:

Of course. Sorry, I should have mentioned it was building as I wrote that
email. A line you snipped said to report it to wine-devel, so I did.
-- 
Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn

 Join the Wine users [EMAIL PROTECTED] team.
http://setiathome.berkeley.edu/team_display.php?teamid=38091


pgpSPW9aN9quO.pgp
Description: PGP signature

Re: Add Tests for InternetQueryOption - try 2

[Dmitry Timoshkov]

On Fri, 2006-02-03 at 15:36 +0530, Vijay Kiran Kamuju wrote:

> +SetLastError(0xdeadbeef);
> +
retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,&len);
> +err=GetLastError();

You need to initialize length parameter before InternetQueryOption call.

-- 
Dmitry.

Most Wanted Windows Apps on Linux

[Vijay Kiran Kamuju]

Hi All,

Check this link
http://www.desktoplinux.com/news/NS2756049592.html

And how many of the top windows programs that are wanted on linux fare
with WINE.

Thanks and Regards,
VJ