Re: ws2_32: Rewrite getsockopt to make it more readable.
On Sunday 03 December 2006 16:46, Kai Blin wrote: --- dlls/ws2_32/socket.c | 409 ++ dlls/ws2_32/tests/sock.c | 35 2 files changed, 332 insertions(+), 112 deletions(-) Sorry, misplaced a closing bracked somehow. I'll send a fixed version in a minute. Kai -- Kai Blin, kai Dot blin At gmail Dot com WorldForge developerhttp://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton. pgpdC8ComvlpK.pgp Description: PGP signature
Re: [ws2_32] make closesocket cancel pending I/O operations
On Monday 04 December 2006 07:01, Damjan Jovanovic wrote: On Windows, calling closesocket in one thread causes blocking I/O operations on that socket (select, accept) running in other threads to return immediately. On Linux, the I/O will block forever. Calling shutdown as part of closesocket reproduces the same behaviour under Linux. Closes #4619 and #3777. Sweet, this seems to solve part of the problems in bug #5534, too. Thanks, Kai -- Kai Blin, kai Dot blin At gmail Dot com WorldForge developerhttp://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton. pgpx0FhPFGKhb.pgp Description: PGP signature
Re: tools/. mono.php
Le vendredi 01 décembre 2006 à 10:35 -0600, Jeremy Newman a écrit : ChangeSet ID: 30235 CVSROOT: /opt/cvs-commit Module name: tools Changes by: [EMAIL PROTECTED] 2006/12/01 10:35:01 Added files: . : mono.php Log message: Jonathan Ernst [EMAIL PROTECTED] - mono downloader script Please don't forget to upload the files to sourceforge as requested with the patches, because it is breaking those Wine downloads... See: http://source.winehq.org/mono.php?action=showlist http://source.winehq.org/mozactivex?action=showlist Thanks
Re: tools/. mono.php
I don't maintain the Wine SF.net uploads section. I can't remember if I even have privileges to upload anymore. Who is in charge of that these days? On Mon, 2006-12-04 at 14:28 +0100, Jonathan Ernst wrote: Please don't forget to upload the files to sourceforge as requested with the patches, because it is breaking those Wine downloads... See: http://source.winehq.org/mono.php?action=showlist http://source.winehq.org/mozactivex?action=showlist
Re: Call for DirectPlay captures
On Sunday 26 November 2006 22:39, Kai Blin wrote: Here's what I would like you to do (if you want to help out): Fire up a network sniffer that dumps to libpcap format. Grab TCP and UDP packets. Start a game that uses DirectPlay for networking and start a network game. Start the game on another box and connect to the game. Now, in the game lobby, use the chat to say something from both games. Then, change a setting or two and start the game. After a few moments of playing (or more, your pick), leave the game. After both games are closed, you can stop the capture, zip it up and send it to me. I'll pay the person who gets me a complete Settlers3 trace a beer at the next Wineconf. I didn't manage to join a game there, but even when just trying to join, I found a packet type my dissector didn't have. Should be interesting. :) Cheers, Kai -- Kai Blin, kai Dot blin At gmail Dot com WorldForge developerhttp://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton. pgp8yheT6qavT.pgp Description: PGP signature
Re: Call for DirectPlay captures
Am Montag 04 Dezember 2006 18:12 schrieb Kai Blin: On Sunday 26 November 2006 22:39, Kai Blin wrote: Here's what I would like you to do (if you want to help out): Fire up a network sniffer that dumps to libpcap format. Grab TCP and UDP packets. Start a game that uses DirectPlay for networking and start a network game. Start the game on another box and connect to the game. Now, in the game lobby, use the chat to say something from both games. Then, change a setting or two and start the game. After a few moments of playing (or more, your pick), leave the game. After both games are closed, you can stop the capture, zip it up and send it to me. I'll pay the person who gets me a complete Settlers3 trace a beer at the next Wineconf. I didn't manage to join a game there, but even when just trying to join, I found a packet type my dissector didn't have. Should be interesting. :) I've got that game, will try to grab a trace. Entering a game doesn't work in wine though, so I'll have to use windows. It used to work a long time ago. pgpx1pI2NlYBJ.pgp Description: PGP signature
Help needed on an SHGetFileInfoW() crash
A friend pointed me to a railway signalling simulation game: http://www.simsig.co.uk/html/downloads.html However, the installer crashes in SHGetFileInfoW(): 000d:Call shell32.SHGetFileInfoA(0045eae8,0010,0034fcec,0160,1010) ret=0045e9f6 000d:trace:seh:raise_exception code=c005 flags=0 addr=0x7e8871b2 000d:trace:seh:raise_exception info[0]= 000d:trace:seh:raise_exception info[1]= More precisely the crash happens on this line: hr = IShellFolder_GetUIObjectOf(psfParent, 0, 1, (LPCITEMIDLIST*)pidlLast, IID_IExtractIconW, uDummy, (LPVOID*)pei); And the reason is that psfParent is NULL. psfParent is initialized a bit above, but only if SHGetFileInfoW() was given a PIDL and SHGFI_USEFILEATTRIBUTES was not used. This means that whenever a 'real path' or SHGFI_USEFILEATTRIBUTES is used in combination with SHGFI_DISPLAYNAME, SHGFI_ICONLOCATION, SHGFI_ICON or SHGFI_SYSICONINDEX, then SHGetFileInfoW() will crash. However we cannot just create a pidl since the 'real path' will usually refer to a nonexistent file or directory (in our case it is 'c:\directory' so it's clear the installer just wants to know what's the icon for a standard directory). Any idea? -- Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/ Lotto: A tax on people who are bad at math. -- unknown Windows: Microsoft's tax on computer illiterates. -- WE7U
Re: [5/6] wined3d: Make CreateFakeGLContext thread safe.
Jan Zerebecki [EMAIL PROTECTED] writes: This adds thread safety to CreateFakeGLContext and it's corresponding Release function only. This addresses no thread safety in the rest of wined3d, which AFAIk as a whole is still not thread safe. When addressing thread safety in wined3d it must also be taken care that a GL context is not deleted away by a different thread when execution is between these two functions. You are calling ENTER_GL while holding your crit section, this will deadlock. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Help needed on an SHGetFileInfoW() crash
On 04.12.2006 19:20, Francois Gouget wrote: Any idea? FWIW, maybe you need an IExtractIcon that does not work on a pidl but only on a filename and file attributes. So if the attribute is a folder, return the folder icon. Else get the default icon for that particular file type. Maybe the existing IExtractIcon could even be extended for that. -f.r.
Re: [winetest] Make sure we can send larger files
On Thu, 2006-11-30 at 13:11 -0500, Dimi Paun wrote: On Thu, November 30, 2006 1:01 pm, Paul Vriens wrote: I'm hitting the 1MB limit already with my win98 tests. Most other tests are about to reach that threshold as well. I'd make it 2MB, what's 1MB these days... :) Hi, the sending side is OK now. The receiving side has to be changed as well I think. I get an error on my Win98 box. Any ideas? Cheers, Paul.
Re: make check_no_exec() work reliable
Peter Beutner [EMAIL PROTECTED] writes: I'm not so sure about this, I think I read somewhere that each loaded DLL is checked for this not just the main exe and the protection is disabled if at least on module is not nx compatible. But as no wine dll is marked as NX_COMPAT(i assume) this would basically mean to always disable the protection. It probably doesn't hurt to leave it like this for now. Yes, the next step is to implement a smarter strategy for turning protection on or off. I don't know about checking the flag for all dlls or only the main exe, I guess I'll have to ask you to try this on Windows too... -- Alexandre Julliard [EMAIL PROTECTED]
Re: [PATCH 4/4] ole32: Support reading and writing custom clipformats in the data cache.
Robert Shearman wrote:
+{
+char *format_name = HeapAlloc(GetProcessHeap(), 0, length);
+if (!format_name)
+return E_OUTOFMEMORY;
+GetClipboardFormatNameA(clipformat, format_name, length);
+hr = IStream_Write(stream, format_name, length, NULL);
+}
You might want to free format_name at the end of that block.
Mike
Re: James Hawkins : msi: Add tests for installing from continuouscabinets.
Alexandre Julliard [EMAIL PROTECTED] wrote: Module: wine Branch: master Commit: 1f3f88bf67d32983ff00d96bf58bf91c6e72ae02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f3f88bf67d32983ff00d96bf58bf91c6e72ae02 Author: James Hawkins [EMAIL PROTECTED] Date: Mon Oct 23 18:15:28 2006 -0700 msi: Add tests for installing from continuous cabinets. According to http://test.winehq.org/data/200612021000/ this test fails under all NT based platforms. I've ran it under XP SP2 and got the following error messages: install.c:864: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:869: Test failed: File not installed install.c:870: Test failed: File not installed install.c:871: Test failed: File not installed install.c:873: Test failed: File not installed install: 1147 tests executed, 0 marked as todo, 5 failures. and a bunch of .log files in the TEMP directory with the following contents: Error 1334. The file 'maximus' cannot be installed because the file cannot be found in cabinet file 'test1.cab'. This could indicate a network error, an error reading from the CD-ROM, or a problem with this package. Error 1334. The file 'augustus' cannot be installed because the file cannot be found in cabinet file 'test1.cab'. This could indicate a network error, an error reading from the CD-ROM, or a problem with this package. So, either the test is not entirely correct, or just the .cab files it creates are corrupted. -- Dmitry.
Re: James Hawkins : msi: Add tests for installing from continuouscabinets.
On 12/4/06, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Alexandre Julliard [EMAIL PROTECTED] wrote: Module: wine Branch: master Commit: 1f3f88bf67d32983ff00d96bf58bf91c6e72ae02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f3f88bf67d32983ff00d96bf58bf91c6e72ae02 Author: James Hawkins [EMAIL PROTECTED] Date: Mon Oct 23 18:15:28 2006 -0700 msi: Add tests for installing from continuous cabinets. According to http://test.winehq.org/data/200612021000/ this test fails under all NT based platforms. I've ran it under XP SP2 and got the following error messages: install.c:864: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:869: Test failed: File not installed install.c:870: Test failed: File not installed install.c:871: Test failed: File not installed install.c:873: Test failed: File not installed install: 1147 tests executed, 0 marked as todo, 5 failures. and a bunch of .log files in the TEMP directory with the following contents: Error 1334. The file 'maximus' cannot be installed because the file cannot be found in cabinet file 'test1.cab'. This could indicate a network error, an error reading from the CD-ROM, or a problem with this package. Error 1334. The file 'augustus' cannot be installed because the file cannot be found in cabinet file 'test1.cab'. This could indicate a network error, an error reading from the CD-ROM, or a problem with this package. So, either the test is not entirely correct, or just the .cab files it creates are corrupted. The tests fail in Windows because part of the cab creation function is #if defined out. Cabinet compression is not implemented in Wine's cabinet.dll, so when the function is not #if defined out, hundreds of cab files are created (which isn't correct) instead of the correct number of cab files with the correct files in each cab. -- James Hawkins
Re: James Hawkins : msi: Add tests for installing from continuouscabinets.
James Hawkins [EMAIL PROTECTED] wrote: The tests fail in Windows because part of the cab creation function is #if defined out. Cabinet compression is not implemented in Wine's cabinet.dll, so when the function is not #if defined out, hundreds of cab files are created (which isn't correct) instead of the correct number of cab files with the correct files in each cab. Thanks for the explanation. Once I change #if 0 to #if 1 under /* spews out hundreds of cab files. re-enable when cabinet.dll is fixed */ the tests pass cleanly here. But that's not good to have broken tests, the test should be either disabled completely, or made it run only if cabinet.dll is detected. -- Dmitry.
Re: James Hawkins : msi: Add tests for installing from continuouscabinets.
Dmitry Timoshkov [EMAIL PROTECTED] wrote: the test should be either disabled completely, or made it run only if cabinet.dll is detected. Last line should read as: if good/not broken cabinet.dll is detected. -- Dmitry.
Putting my hand up for WWN
I'm prepared to write the WWN releases in Brian Vincent seeming absence if it pleases the powers that be. If this is alright I'd like some one to give an overview of what topics should be covered and then for some one to review the first one or two created. I've read the last hundred or so WWN issues over the years so I have a good idea of whats required though clarification would be nice. I already got wine-devel/wine-users - are there any more that need to be monitored. Finally I would need to know how to submit the newsletter and the proper syntax. Edward
