Re: (Cross)Compile failure for dsound/tests and shlwapi/tests
On Friday 12 January 2007 12:54, Paul Vriens wrote: glad to hear the problems are fixed. I don't need the patches as I will wait for the RPM's that Hans provides. Find them here: http://mirzam.it.vu.nl/mingw/ -Hans
Re: Getting GTK/W32 applications to run
On Sunday 14 January 2007 22:30, Peter Gerwinski wrote: Since both WINE and pango/GTK are free software, I am confident that these problems will be solved in the long run. I hope that you can use my observations. Thank you for your elaborate diagnosis. This is probably related to the problem Mono has on Wine because it also uses Pango/GTK. Does it help if you install MS core fonts? http://sourceforge.net/project/showfiles.php?group_id=34153package_id=56408 It would be good if you could put your findings in a bug in Bugzilla (there may already exist a bug for this, otherwise you can open a new one). -Hans
Re: dsound: fix tests for old versions of windows
On Fri, 12 Jan 2007, Robert Reif wrote:
This patch fixes the tests to they can run without crashing on old versions of
windows that doesn't have dsound.dll.
+hDsound = LoadLibrary(dsound.dll);
+if (hDsound)
{
[...]
+pDirectSoundCaptureEnumerateA=(void*)GetProcAddress(hDsound,
+DirectSoundCaptureEnumerateA);
+if (pDirectSoundCaptureCreate pDirectSoundCaptureEnumerateA)
+{
[...]
If all dsound.dll implementations are supposed to have these functions
(which I believe is the case), then I would test that we found them with
an ok() call.
Also, if we fail to load dsound.dll, then we should indicate that we are
skipping the tests with the new skip() function. This will make it
clearer when analysing the logs that a big chunk of functionality was
not tested (see the d3d8 tests for instance).
--
Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/
Computers are like airconditioners
They stop working properly if you open WINDOWS
Re: [5] snmpapi: Implement SnmpUtilVarBindListCpy and SnmpUtilVarBindListFree.
Hans Leidekker wrote:
+
+/***
+ * SnmpUtilVarBindListCpy (SNMPAPI.@)
+ */
+INT WINAPI SnmpUtilVarBindListCpy(SnmpVarBindList *dst, SnmpVarBindList *src)
+{
+unsigned int i, size;
+SnmpVarBind *src_entry, *dst_entry;
+
+TRACE((%p, %p)\n, dst, src);
+
+size = sizeof(SnmpVarBindList);
+if (!(dst = HeapAlloc(GetProcessHeap(), 0, size))) return SNMPAPI_ERROR;
Where do you return this memory to the caller?
+
+size = src-len * sizeof(SnmpVarBind *);
+if (!(dst-list = HeapAlloc(GetProcessHeap(), 0, size)))
+{
+HeapFree(GetProcessHeap(), 0, dst);
+return SNMPAPI_ERROR;
+}
+src_entry = src-list;
+dst_entry = dst-list;
+for (i = 0; i src-len; i++)
+{
+if (SnmpUtilVarBindCpy(dst_entry, src_entry))
+{
+src_entry++;
+dst_entry++;
+}
+else
+{
+for (--i; i 0; i--) SnmpUtilVarBindFree(--dst_entry);
+HeapFree(GetProcessHeap(), 0, dst-list);
+HeapFree(GetProcessHeap(), 0, dst);
+return SNMPAPI_ERROR;
+}
+}
+dst-len = src-len;
+return SNMPAPI_NOERROR;
+}
--
Rob Shearman
user32: the patches - what's wrong?
Hi, Traditional questions from rejected patch-sender: 1) What's wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html 2) What can be done to improve them? Those patches let the window proc repaint NC area instead of calling NCPaint directly. And changes processing of WM_SETICON to be similar with WM_SETTEXT. -- Kirill
Re: user32: the patches - what's wrong?
Kirill K. Smirnov [EMAIL PROTECTED] writes: Traditional questions from rejected patch-sender: 1) What's wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html 2) What can be done to improve them? You should add tests in tests/msg.c to show that your changes yield the same message sequence as on Windows. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Getting GTK/W32 applications to run
Hallo, Hans! You wrote: Thank you for your elaborate diagnosis. This is probably related to the problem Mono has on Wine because it also uses Pango/GTK. Does it help if you install MS core fonts? I tried, but it did not help. Cheers, Peter -- Dr. rer. nat. Peter Gerwinski - http://www.peter.gerwinski.de German pages for GNU free software - http://www.gnu.de G-N-U GmbH - EDV-Dienstleistungen - http://www.g-n-u.de Essener Linux User Group - http://www.elug.de
Re: [dinput 4/5] Add a config for the axes
Christoph Frick wrote: Add a config for the axes like we do for the buttons This adds a mapping from the linux input id of the axis to the instance id we assigned the axis. --- df-rgodf[idx++].dwType = DIDFT_MAKEINSTANCE(axis++) | DIDFT_ABSAXIS; } -for (i = 0; i 4; i++) + +idx = WINE_JOYSTICK_MAX_AXES; Why are you creating a gap? This is exactly the point here to skip all the objects that we do not have. And they all need to be sequential in godf - no gaps. Otherwise you braking EnumObjects. Vitaliy.
Re: [dinput 4/5] Add a config for the axes
On Mon, Jan 15, 2007 at 10:42:10AM -0700, Vitaliy Margolen wrote: df-rgodf[idx++].dwType = DIDFT_MAKEINSTANCE(axis++) | DIDFT_ABSAXIS; } -for (i = 0; i 4; i++) + +idx = WINE_JOYSTICK_MAX_AXES; Why are you creating a gap? This is exactly the point here to skip all the objects that we do not have. And they all need to be sequential in godf - no gaps. Otherwise you braking EnumObjects. you are right. funny thing is - everything works with this patches :/ i will drop the two idx assigns and resubmit the patch. -- cu pgpaoMUOrdkfV.pgp Description: PGP signature
Some stats (Was: Re: Alexandre Julliard : oleaut32/tests: Replace some macros by functions to reduce code size and compile time.)
Alexandre Julliard wrote: Module: wine Branch: master Commit: 25571d878960cd802aa31f291d473888dc01e035 URL: http://source.winehq.org/git/wine.git/?a=commit;h=25571d878960cd802aa31f291d473888dc01e035 Author: Alexandre Julliard [EMAIL PROTECTED] Date: Mon Jan 15 13:01:42 2007 +0100 oleaut32/tests: Replace some macros by functions to reduce code size and compile time. Some compile stats for vartest.c on my P4 3GHz HT, 2 GB RAM, FC6, gcc version 4.1.1 20070105 (Red Hat 4.1.1-51) -O0 -O1 -O2 -O3 -Os size vartest.o with -O2 before 9s 38s 60s 870s750s1352256 after 3s 23s 35s 41s 42s 474300 I would say impressive, especially the -O3 and -Os changes. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network EngineerFax.: +49-711-96437-111 Red Hat GmbHEmail: [EMAIL PROTECTED] Hauptstaetterstr. 58http://www.redhat.de/ D-70178 Stuttgart
Re: oleaut32: Remove unused items
Michael Stefaniuc wrote:
-SIMPLE(LONG64, LONG, VarI8FromI4);
Are you removing a test here?
Hi Michael,
I'm not sure what you mean. All I know is that the SIMPLE() macro - also
in oleaut32/vartype.c - is defined as follows.
/* Inline return type */
#define RETTYP inline static HRESULT
/* Simple compiler cast from one type to another */
#define SIMPLE(dest, src, func) RETTYP _##func(src in, dest* out) { \
*out = in; return S_OK; }
So
SIMPLE(LONG64, LONG, VarI8FromI4);
generates a function definition similar to
inline static HRESULT _VarI8FromI4(LONG64 in, LONG* out)
{
*out = in;
return S_OK;
}
and _VarI8FromI4() is not called from anywhere within the codebase. In
particular, there is not a dll function similarly named but without the
leading underscore to call it. (Compare with VarI8FromI2(), which calls
_VarI8FromI2(), for example.)
VarI8FromI4() seems to be undocumented and unimplemented.
To complete the job - if my patch is otherwise correct - I should also
remove its declaration from include/oleaut.h.
Of course, it may be that this macro should be left in, perhaps marked
as TODO. I welcome advice.
Thanks,
-- Andy.
Re: appdb rating inflation
Whoever it is that is wanting to update the HOWTO for the Diablo 2 appdb please email me. I don't have my email address on there for nothing. For whatever reason, I can't see who changes things nor does the appdb email me on changes anymore. Quote from new HOWTO note. THIS IS A DUPLICATE ENTRY. I am making this simply because lots of the information in the original howto is either wrong, invalid or unnecessary. This is the new HOWTO. I'm leaving the old one in place so that the ones that wrote it can see the changes and voice anything before I remove the old one entirely. I read it and you really did not change anything. But I will say that that YES the HOWTO is mostly unnessecary. However, when I tried going to a skeletal HOWTO, I got a bunch of odd complaints (especially on the CD-ROM info you removed). Also note, that the HOWTO duplicates the War3 one just because it's the same in almost every way. Jesse
re: iphlpapi - MacOS / BSD support
Hi Gav! You wrote: Author: Mark Adams mark at transgaming.com ... Cool... nice to see you on wine-patches again! For completeness, can you specify the license your patches are under? I assume MIT/X11...? - Dan
Re: user32/tests: add tests for WM_SETICON
Kirill K. Smirnov [EMAIL PROTECTED] wrote: +/* Message sequences for WM_SETICON */ +hwnd = CreateWindowExA(0, TestWindowClass, NULL, + WS_OVERLAPPEDWINDOW, + CW_USEDEFAULT, CW_USEDEFAULT, 300, 300, 0, + NULL, NULL, 0); +flush_sequence(); +SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)LoadIcon(0, IDI_APPLICATION)); +ok_sequence(WmSetIcon, WM_SETICON for window with caption, FALSE); This code doesn't show behaviour of a more interesting case - a visible window. -- Dmitry.
Re: iphlpapi - MacOS / BSD support
Dan Kegel wrote: Cool... nice to see you on wine-patches again! For completeness, can you specify the license your patches are under? I assume MIT/X11...? Thanks! 8-) As the iphlpapi DLL is LGPLed, our patches to it are necessarily under the LGPL as well. Take care, -Gav -- Gavriel State Founder CTO TransGaming Technologies Inc. [EMAIL PROTECTED] http://www.transgaming.com Broadening The Playing Field
