appdb hosed
The left nav bars are broken, can't approve any new test data.
Re: appdb hosed
On Friday 18 January 2008 09:08:19 Dan Kegel wrote: The left nav bars are broken, can't approve any new test data. Does it work if you press 'refresh' a couple of times? Alexander N. Sørnes
Re: appdb hosed
On Friday 18 January 2008 10:04:00 you wrote: Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: The left nav bars are broken, can't approve any new test data. Does it work if you press 'refresh' a couple of times? Yes, thanks. Hopefully not everybody has to do that...? Unfortunately. We changed the menus so that doing things like Ctrl + click for opening new tabs should work properly. Alexander
Re: appdb hosed
Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: The left nav bars are broken, can't approve any new test data. Does it work if you press 'refresh' a couple of times? Yes, thanks. Hopefully not everybody has to do that...?
problem with widl.
I have a question about widl.
tools\widl\header.cfunction write_method_macro
fprintf(header, #define %s_, name);
write_name(header,def);
fprintf(header, (p);
for (c=0; cargc; c++)
fprintf(header, ,%c, c+'a');
fprintf(header, ) );
fprintf(header, (p)-lpVtbl-);
write_name(header, def);
fprintf(header, (p);
for (c=0; cargc; c++)
fprintf(header, ,%c, c+'a');
fprintf(header, )\n);
This code wrong, because if my function have more then 16 parameters I receive
something like this:
#define Imyinterface_Open(p,a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q
(p)-lpVtbl-Open(p,a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q)
and the compiler gives out a mistake
library.h:1296:63: duplicate macro parameter p
I think that this code should be like this:
Variant 1.
int p=0;
for (c=0; cargc; c++) {
if (p==15) p++;
fprintf(header, ,%c, p+'a');
p++;
}
fprintf(header, ) );
fprintf(header, (p)-lpVtbl-);
write_name(header, def);
fprintf(header, (p);
p=0;
for (c=0; cargc; c++) {
if (p==15) p++;
fprintf(header, ,%c, p+'a');
p++;
}
fprintf(header, )\n);
or
Variant 2. (Without cycles)
char str[] =
{'p',',','a',',','b',',','c',',','d',',','e',',','f',',','g',',','h',',','i',',','j',',','k',',','l',',','m',',','o',',','q',',','r',',','s',',','t',',','u',',','v',',','w',',','x',',','y',',','z',',',0};
str[2*argc+1] = 0;
fprintf(header, #define %s_, name);
write_name(header,def);
fprintf(header,();
fprintf(header,%s,str);
fprintf(header, ) );
fprintf(header, (p)-lpVtbl-);
write_name(header, def);
fprintf(header,();
fprintf(header,%s,str);
fprintf(header, )\n);
What do you think about that?
Sinitsin Ivan
Re: Debugger unhappiness blocking valgrind runs
Dan Kegel schreef: On Jan 17, 2008 12:08 PM, Eric Pouech [EMAIL PROTECTED] wrote: http://bugs.winehq.org/show_bug.cgi?id=11211 you're likely running out of memory (just to be sure, if the test segfaults, but winedbg correctly starts, it's likely the cause) It doesn't seem like I'm running out of memory. winedbg does not correctly start. free shows lots of free swap space. Amusingly, this shows up now on one of my machines when I run Photoshop CS2 tryout. File / Browse crashes, which will bring up winedbg, which crashes, which brings up winedbg, which crashes,... you have to do wineserver -k quick or you'll have zillions of winedbg's all waiting to be debugged. A single application can only use 3 gb of memory, it doesn't have to be actual memory, it can be 'virtual' as well. This means it's reserved, but it doesn't necessarily have to be used. You can see this in top under the virt column.
Re: qmgr [1/3]: Implement IClassFactory methods.
Dan Hipschman [EMAIL PROTECTED] writes: I split the last patch into three. This is essentially the same as the last one Roy sent, but cleaned up a bit. This adds the IClassFactory methods for BITS. When sending a patch written by someone else, please include a From: line with the proper attribution in your message. -- Alexandre Julliard [EMAIL PROTECTED]
Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
Jason Green [EMAIL PROTECTED] writes:
+
+#ifdef TRACE_SYMBOL_LIST
+TRACE(\n\n* sorting the table {count = %d}\n\n,
module-num_sorttab);
+#endif
+
+qsort(module-addr_sorttab, module-num_sorttab, sizeof(struct
symbol_entry), symt_cmp_addr_and_size);
+
+generateSymbolChains(module);
+
+
+#ifdef TRACE_SYMBOL_LIST
+if (0){
+ULONG64 prevAddr = 0;
Please don't add ifdef'ed out code, it should either be compiled always,
or removed completely.
+ sizeof(SYMBOL_INFO), Symbol-SizeOfStruct,
+ (intptr_t)Symbol-SizeOfStruct - (intptr_t)Symbol,
+ (intptr_t)Symbol-TypeIndex - (intptr_t)Symbol,
+ (intptr_t)Symbol-Reserved[0] - (intptr_t)Symbol,
Don't use stdint.h types, there are Win32 types for that.
--
Alexandre Julliard
[EMAIL PROTECTED]
Wine font license
Right now on our fonts we say they're LGPL. (Look for the LangName attribute in the .sfd file.) We might want to make a modification to that. Here's what the FSF has to say about it: http://www.fsf.org/licensing/licenses/gpl-faq.html#FontException Or, to just copy and paste that info: ---8- How does the GPL apply to fonts? Font licensing is a complex issue which needs serious consideration. The following license exception is experimental but approved for general use. We welcome suggestions on this subject—please see this this explanatory essay and write to [EMAIL PROTECTED] To use this exception, add this text to the license notice of each file in the package (to the extent possible), at the end of the text that says the file is distributed under the GNU GPL: As a special exception, if you create a document which uses this font, and embed this font or unaltered portions of this font into the document, this font does not by itself cause the resulting document to be covered by the GNU General Public License. This exception does not however invalidate any other reasons why the document might be covered by the GNU General Public License. If you modify this font, you may extend this exception to your version of the font, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. -Brian
Re: GOM player
On 1/17/08, Dan Kegel dank at kegel.com wrote: http://www.guardian.co.uk/technology/2008/jan/17/linux.korea says everyone in Korea uses the GOM player... It installs ok, but blew up when I tried to load the Sony music stream from its playlist. ... http://www.gomplayer.com/ supposedly comes with lots of codecs. Rolf Kalbermatter r.kalbermatter at hccnet.nl writes: I tested it in wine, doesn't play anything in plain wine. With native quartz (and installing some codecs with winetricks) it works , but there is still some issues: window can't be moved, and it displays the movies just too bright. Unfortunately I haven't seen any work on quartz latest months/years. For now i'd give it a bronze rating.
Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
Jason Green a écrit : From 14d91ebd5974c8fc02f8b83d53e8eff0df7ad76d Mon Sep 17 00:00:00 2001 From: Jason Green [EMAIL PROTECTED](none) Date: Thu, 17 Jan 2008 16:41:11 -0500 Subject: [PATCH] Rewrite much of the symbol lookup method to work with Optimized PDB files as well. Also, improves a number of TRACEs, and wraps strings in the debugstr() functions. what's the rationale of optimized pdb ? the patch is already big enough not to mix code evolution with stuffing new trace:s all over the place A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)
RE: GOM player
On 1/17/08, Dan Kegel [EMAIL PROTECTED] wrote: http://www.guardian.co.uk/technology/2008/jan/17/linux.korea says everyone in Korea uses the GOM player... It installs ok, but blew up when I tried to load the Sony music stream from its playlist. ... http://www.gomplayer.com/ supposedly comes with lots of codecs. I tried it some time ago. On the pro side it supports just about any media stream out of the box, well ok quite a lot. It's a one time stop for RM, WMF and QT media. On the con side I didn't like it's perseverance in trying to install all kinds of additional gadgets that I wouldn't care of or wouldn't fully trust with. As nice as it seemed to be able to watch just about every common media format out there, I deinstalled it after a short trial. Didn't test it in Wine though as watching media in Linux itself although not as painless isn't that difficult either. For my Windows box I use Media Player Classic with QT and RM codec support now and that works almost flawlessly. Rolf Kalbermatter
Re: problem with widl.
Ivan Sinitsin [EMAIL PROTECTED] writes: What do you think about that? I put in a fix to use the real parameter names instead. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Suggestion to the list maintainer
PS : I do find Subject prefixes ugly too... Bu I hadn't found a more handy solution. Don't use squirrelmail, or better yet - fix it. I suggest you replace squirrel with Zimbra, it's much better. I'm just a happy user. Cheers, Kuba
Re: Suggestion to the list maintainer
On Wednesday 16 January 2008, [EMAIL PROTECTED] wrote: Hello. I have many subscriptions to different mailing list with my email-address and I'd appreciate a lot to be able to identify a message from this mailing list quickly by reading it's subject. Could you please add a subject prefix like [WINE-DEVEL] in the mailman preferences ? It's very easy to do, so maybe there is a good reason why you haven't done it yet... Thanks. François. !DSPAM:478e0614252561039011321!
Re: WWN license issue
On Jan 18, 2008 9:26 AM, Alexander Nicolaysen Sørnes [EMAIL PROTECTED] wrote: Now that you mention it, since we are trying to move the AppDB to the Affero GPL v3, it would be nice to have the WWN covered by the similar GLP v3 :) Everything I wrote was GPL v2 and I'm quite happy with that. -Brian
Re: [dbghelp 7/10] Fix file searching to search only listed directories instead of the whole HD
Jason Green a écrit :
From ad95ee9cad0df8b4e8ca35d2d5a280d755c7bf7f Mon Sep 17 00:00:00 2001
From: Jason Green [EMAIL PROTECTED](none)
Date: Thu, 17 Jan 2008 17:21:00 -0500
Subject: [PATCH] Fix file searching to search only listed directories instead
of the whole HD.
And, wrap some TRACE parameters in debugstr.
From: Eric van Beurden ([EMAIL PROTECTED])
---
dlls/dbghelp/path.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/dlls/dbghelp/path.c b/dlls/dbghelp/path.c
index 2e191af..fac9dc0 100644
--- a/dlls/dbghelp/path.c
+++ b/dlls/dbghelp/path.c
@@ -57,7 +57,7 @@ HANDLE WINAPI FindDebugInfoFile(PCSTR FileName, PCSTR
SymbolPath, PSTR DebugFile
{
HANDLE h;
-h = CreateFileA(DebugFilePath, GENERIC_READ, FILE_SHARE_READ, NULL,
+h = CreateFileA(FileName, GENERIC_READ, FILE_SHARE_READ, NULL,
OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
you failed to set DebugFilePath to the desired value
again the rest of the patch has nothing to do with the first part of the
patch
A+
--
Eric Pouech
The problem with designing something completely foolproof is to underestimate
the ingenuity of a complete idiot. (Douglas Adams)
Re: Suggestion to the list maintainer
PS : I do find Subject prefixes ugly too... Bu I hadn't found a more handy solution. Don't use squirrelmail, or better yet - fix it. I suggest you replace squirrel with Zimbra, it's much better. I'm just a happy user. Zimbra is commercial groupware suite. SquirrelMail is free webmail application. You are suggesting to replace whole user's email system with some proprietary locked product. -- Tomas
Re: Suggestion to the list maintainer
On Wednesday 16 January 2008, [EMAIL PROTECTED] wrote: Hello. I have many subscriptions to different mailing list with my email-address and I'd appreciate a lot to be able to identify a message from this mailing list quickly by reading it's subject. Could you please add a subject prefix like [WINE-DEVEL] in the mailman preferences ? It's very easy to do, so maybe there is a good reason why you haven't done it yet... Just filter on List-Id: Wine Developer's List wine-devel.winehq.org Cheers, Kuba
Re: Suggestion to the list maintainer
On Jan 18, 2008 1:06 PM, Tomas Kuliavas [EMAIL PROTECTED] wrote: Zimbra is commercial groupware suite. SquirrelMail is free webmail application. You are suggesting to replace whole user's email system with some proprietary locked product. There's an (at least in name) FOSS version of Zimbra... but eeew. I am tasked with the unfortunate duty of admining a machine running Zimbra and I can say it's not worth the trouble. Unless you like Java processes that gobble 2Gb of ram like cookies, that is. --tim
Re: [dbghelp 10/10] Clamp minidump memory blocks to 928KB
Jason Green a écrit :
From 1127317807ec264541e2e03e6a633cefee8f697b Mon Sep 17 00:00:00 2001
From: Jason Green [EMAIL PROTECTED](none)
Date: Thu, 17 Jan 2008 17:43:41 -0500
Subject: [PATCH] Clamp minidump memory blocks to 928KB and improve TRACEs
WinDbg can't read minidumps with memory blocks larger than this.
From: Eric van Beurden ([EMAIL PROTECTED])
---
dlls/dbghelp/minidump.c | 35 +--
1 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/dlls/dbghelp/minidump.c b/dlls/dbghelp/minidump.c
index 564d824..f113728 100644
--- a/dlls/dbghelp/minidump.c
+++ b/dlls/dbghelp/minidump.c
@@ -32,6 +32,13 @@
WINE_DEFAULT_DEBUG_CHANNEL(dbghelp);
+
+/* windbg isn't able to open minidump files if they contain a single memory
block larger
+ than 928KB. If a larger block is found, it simply reports that all
following streams
+ could not be loaded. This is as of WinDbg version 6.7.0005.1. */
+#define MINIDUMP_MEMORY_BLOCK_MAX (928 * 1024)
+
+
struct dump_memory
{
ULONG base;
@@ -640,8 +647,32 @@ static voiddump_threads(struct dump_context* dc,
}
if (mdThd.Stack.Memory.DataSize (flags_out
ThreadWriteStack))
{
-add_memory_block(dc, mdThd.Stack.StartOfMemoryRange,
- mdThd.Stack.Memory.DataSize,
+ULONG size;
+ULONG64 base;
+
+
+/* windbg only supports memory blocks up to 928KB in size.
Not sure where that
+ specific amount comes from, but in testing it will
completely fail to load
+ all minidump streams that follow a memory block that is
larger than 928KB.
+ Because of this, we'll clamp all of the memory blocks
that we add to the
+ file. */
+if (mdThd.Stack.Memory.DataSize MINIDUMP_MEMORY_BLOCK_MAX){
+size = MINIDUMP_MEMORY_BLOCK_MAX;
+
+/* since this is the thread stack we'll want to save
this block top-down
+ instead of just clamping the buffer size */
+base = mdThd.Stack.StartOfMemoryRange +
(mdThd.Stack.Memory.DataSize - MINIDUMP_MEMORY_BLOCK_MAX);
+
+TRACE(clamping the stack block starting at 0x%08llx
{oldSize = %u bytes, newSize = %u bytes, newBase = 0x%08llx}\n,
+mdThd.Stack.StartOfMemoryRange,
mdThd.Stack.Memory.DataSize, size, base);
+}
+
+else{
+size = mdThd.Stack.Memory.DataSize;
+base = mdThd.Stack.StartOfMemoryRange;
+}
+
+add_memory_block(dc, base, size,
rva_base +
sizeof(mdThdList.NumberOfThreads) +
mdThdList.NumberOfThreads *
sizeof(mdThd) +
FIELD_OFFSET(MINIDUMP_THREAD,
Stack.Memory.Rva));
if that's really the case (and I'm even not sure we want to support this
backward compatibility), a good fix would be to add several streams each
up to 928k instead of clamping
A+
--
Eric Pouech
The problem with designing something completely foolproof is to underestimate
the ingenuity of a complete idiot. (Douglas Adams)
Re: Fix for LoadStringW
Ferenc Wagner wrote: Dmitry Timoshkov [EMAIL PROTECTED] writes: Christopher [EMAIL PROTECTED] wrote: Thanks for pointing that out! Am I suppose to attach a test case for all my patches to wine-patches? I had submitted a testcase under the bug report I filed, so I didn't attach it to the email. You have to add the test to the exiting tests in dlls/kernel32/tests Actually, there are LoadStringA tests in dlls/user32/tests/resource.c, maybe it's best to team up with those (and possibly extend for the same set of tests). I read the documentation on writing conformance tests. But is there a way for me to compile the tests under Linux to run on Windows? Having never written a conformance test before I would like to test it out on my own before I submit it. Also, once I write the test do I submit it at the same time as my patch, or do I need to submit the test first and wait for it to be accepted before sending in my patch? Christopher
