Re: Serial port support in wine-1.0: What to do to make it working ?
Hi Uwe, > Pavel, > > perhaps compile wine yourself and instrument the serial code with debugging > output. Try to see what's going wrong. Look at the codes where this happens > and read the old changelogs, where somebody fiddled witrh the code. Ask > about what people thought (or smoked) when implementing or offer a better > implementation. OK, will do. I'm always compiling wine from source, so I will try to dig into the driver and search for the bugs there. One of the cases is I think simple, the device uses normal ASCII protocol and I can talk to it using kermit or minicom, but the windows program intended to control it simply stucks on the first command and never gets a reply. I think there is a good place to start. > > There is a big problem with those special devices, as only few if any wine > developpers have it... Yes, I know. I hope that there is just a limited number of bugs, but they affect many such devices, so it looks that the driver is totally broken. With regards, Pavel Troller
Re: winetest problems
On Fr, 2008-05-02 at 18:38 -0500, James Hawkins wrote: > i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o > testlist.cross.o -o advpack_crosstest.exe -lcabinet -ladvapi32 > -lkernel32 > /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: > cannot find -lcabinet > collect2: ld returned 1 exit status > make[2]: *** [advpack_crosstest.exe] Error 1 mingw from mingw.org is to old for Wine. > Which (I assume) is usually fixed by Paul Millar's win32api custom > patches. Any thoughts or ideas? Hans Leidekker maintains patched mingw packages: http://mirzam.it.vu.nl/mingw/ -- By by ... Detlef
What happened to the ntdll rtlstr tests?
Hello Alexandre, Why were the fixes for the ntdll rtlstr test failures on windows not accepted? Cheers, Maarten.
Re: [PATCH] fixed if check before strchr
On Tue, May 06, 2008 at 10:00:38PM +0200, Eric Pouech wrote: > > spath = strchr(spath, '\\'); > > -if (!spath) spath = strchr(spath, '/'); > > +if (spath) spath = strchr(spath, '/'); So the correct solution would be something like bpath=strchr(spath, '\\'); spath=strchr(spath, '/'); if (bpath && spath) spath=MIN(bpath, spath); else spath=MAX(bpath,spath); ? Btw, are Unix filenames that contain a '\' a problem? Ciao Joerg -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
Re: winetest problems
On Tue, May 6, 2008 at 4:20 PM, Paul Millar <[EMAIL PROTECTED]> wrote: > Hi, > > > On Saturday 03 May 2008 01:38:07 James Hawkins wrote: > > I'm trying to fix the failing cross tests, but we haven't had a > > winetest build on Paul Millar's server in a few days. > > Just to mention that gaps will appear if the winetest.exe builds but hasn't > changed. As Paul (Vriens) says, the log files should indicate if there's a > problem: > > http://quisquiliae.physics.gla.ac.uk/cross/logs/ > > > [...] a recent commit has broken the build. > > Yes. It's the usual story: some new tests were added that test some > functions > that MinGW w32api doesn't support. As it happens, the breakage coincided > with my spending a long weekend without Internet access. > > The problem appears to be fixed now and a new winetest.exe should be > available. > > [...] > > > Which (I assume) is usually fixed by Paul Millar's win32api custom > > patches. > > Yup. I try to provide a tar-ball of these patches "every so often", see: > http://www.astro.gla.ac.uk/users/paulm/Cross/ > > I must point out that there is a group of us who do this share the patches > and > the vast, vast majority of the patches are not by me. > Thanks a lot Paul and everyone else who contributes to this! -- James Hawkins
Re: winetest problems
Hi, On Saturday 03 May 2008 01:38:07 James Hawkins wrote: > I'm trying to fix the failing cross tests, but we haven't had a > winetest build on Paul Millar's server in a few days. Just to mention that gaps will appear if the winetest.exe builds but hasn't changed. As Paul (Vriens) says, the log files should indicate if there's a problem: http://quisquiliae.physics.gla.ac.uk/cross/logs/ > [...] a recent commit has broken the build. Yes. It's the usual story: some new tests were added that test some functions that MinGW w32api doesn't support. As it happens, the breakage coincided with my spending a long weekend without Internet access. The problem appears to be fixed now and a new winetest.exe should be available. [...] > Which (I assume) is usually fixed by Paul Millar's win32api custom > patches. Yup. I try to provide a tar-ball of these patches "every so often", see: http://www.astro.gla.ac.uk/users/paulm/Cross/ I must point out that there is a group of us who do this share the patches and the vast, vast majority of the patches are not by me. Cheers, Paul.
Re: Bison 2.1 / Solaris
On Mo, 2008-05-05 at 23:55 -0500, Austin English wrote: > [EMAIL PROTECTED]:~/wine$ bison --version > bison (GNU Bison) 2.1 I used Wine ~2 Years on on Ubuntu Dapper without Problems. Bison in Dapper was 2.1: http://packages.ubuntu.com/dapper/devel/bison (I'm unable to verify the latest used bison-version: I switched 2 Weeks ago) -- By by ... Detlef
Re: [PATCH] fixed if check before strchr
On Tue, May 6, 2008 at 1:00 PM, Eric Pouech <[EMAIL PROTECTED]> wrote:
> Marcus Meissner a écrit :
>> Hi,
>>
>> spotted by Coverity (CID 701), a if (!spath) should be if (spath).
>>
>> Ciao, Marcus
>> ---
>> programs/winedbg/source.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c
>> index 5519c57..1db7092 100644
>> --- a/programs/winedbg/source.c
>> +++ b/programs/winedbg/source.c
>> @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char* srcfile,
>> char* path)
>> while (!found)
>> {
>> spath = strchr(spath, '\\');
>> -if (!spath) spath = strchr(spath, '/');
>> +if (spath) spath = strchr(spath, '/');
>> if (!spath) break;
>> spath++;
>> found = SearchPathA(dbg_curr_process->search_path, spath, NULL,
>> MAX_PATH, path, NULL);
>>
> actually no
> the code intends to find the first occurence of / or \
In that case, the code is still incorrect. Perhaps it should be:
-if (!spath) spath = strchr(spath, '/');
+if (!spath) spath = strchr(srcfile, '/');
instead?
--Juan
Re: [PATCH] fixed if check before strchr
On Tue, May 6, 2008 at 3:00 PM, Eric Pouech <[EMAIL PROTECTED]> wrote:
> Marcus Meissner a écrit :
>
>
> > Hi,
> >
> > spotted by Coverity (CID 701), a if (!spath) should be if (spath).
> >
> > Ciao, Marcus
> > ---
> > programs/winedbg/source.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c
> > index 5519c57..1db7092 100644
> > --- a/programs/winedbg/source.c
> > +++ b/programs/winedbg/source.c
> > @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char*
> srcfile, char* path)
> > while (!found)
> > {
> > spath = strchr(spath, '\\');
> > -if (!spath) spath = strchr(spath, '/');
> > +if (spath) spath = strchr(spath, '/');
> > if (!spath) break;
> > spath++;
> > found = SearchPathA(dbg_curr_process->search_path, spath,
> NULL, MAX_PATH, path, NULL);
> >
> actually no
> the code intends to find the first occurence of / or \
> A+
>
Then you have to use a different variable than spath. If you don't
find '\\', then you'll pass NULL into the second strchr.
--
James Hawkins
Re: [PATCH] fixed if check before strchr
Marcus Meissner a écrit :
> Hi,
>
> spotted by Coverity (CID 701), a if (!spath) should be if (spath).
>
> Ciao, Marcus
> ---
> programs/winedbg/source.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c
> index 5519c57..1db7092 100644
> --- a/programs/winedbg/source.c
> +++ b/programs/winedbg/source.c
> @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char* srcfile,
> char* path)
> while (!found)
> {
> spath = strchr(spath, '\\');
> -if (!spath) spath = strchr(spath, '/');
> +if (spath) spath = strchr(spath, '/');
> if (!spath) break;
> spath++;
> found = SearchPathA(dbg_curr_process->search_path, spath, NULL,
> MAX_PATH, path, NULL);
>
actually no
the code intends to find the first occurence of / or \
A+
--
Eric Pouech
"The problem with designing something completely foolproof is to underestimate
the ingenuity of a complete idiot." (Douglas Adams)
Re: [PATCH] cmd.exe: MSI packages execution implemented
Vitaly Perov wrote: > Changelog: cmd.exe: MSI packages execution implemented > > > That doesn't look right. You sure this information is hard-coded into cmd.exe and it's not coming from the registry CLASSES hive? Vitaliy
Re: [PATCH 1/3] dinput: Remove redundant variable.
Vitaliy Margolen wrote: > Vitaliy Margolen wrote: >> --- >> dlls/dinput/joystick_linux.c | 16 +++- >> 1 files changed, 7 insertions(+), 9 deletions(-) >> > > Forgot to add that this series of patches should finally address bugs 12052 > and 11644. Was there anything wrong with these patches? > > Vitaliy. > > Uh sorry I guess I know the [PATCH 3/3] does not compiles. Sorry about it. I'm almost positive I've tested that patch. New replacement on the way. Vitaliy.
Re: Serial port support in wine-1.0: What to do to make it working ?
> "Pavel" == Pavel Troller <[EMAIL PROTECTED]> writes: Pavel> Hi! I have really BIG problems running any application, which Pavel> needs to comm over a serial port: - My ham TCVR - My GPS - My Pavel> multimeter - A lot of my mobiles - A lot of devices used in my Pavel> work (special telco equipment, comms varying from simple AT-style Pavel> commands up to complex proprietary binary protocols). In all the Pavel> cases there are very similar problems - either the program Pavel> doesn't detect the device properly, or the device doesn't Pavel> respond, or in some cases the device does, what the program Pavel> wants, but it then can't read it back. It looks that some Pavel> archaic wine versions are better, for example I have to use Pavel> wine-0.9.40 to communicate with a device in my work (simple Pavel> text-based command-reply communication), any wine newer than say Pavel> 0.9.50 doesn't work, the communication times out. Because I'm a Pavel> telco engineer and serial comm is my daily work, and there are Pavel> only windows versions of many tools I have to use, proper and Pavel> mature serial port support is essential for me. So, what can I Pavel> do to help fixing these problems ? Should I open a bug for every Pavel> such a program ? Or just open one bug and state all the programs Pavel> there ? I think that bugzilla contains a lot of bugs related to Pavel> serial port; is it good to add a new ones ? I'm afraid I can't Pavel> bisect a problem between 0.9.40 and current wine, but I can make Pavel> a serial trace for both of them and look at the difference. Would Pavel> it help to find at least this one particular problem ? Or what Pavel> more can I do to make the serial port working ? I can code in C Pavel> in the Linux environment, but I know NOTHING about windows... Pavel> With regards, Pavel Troller Pavel, perhaps compile wine yourself and instrument the serial code with debugging output. Try to see what's going wrong. Look at the codes where this happens and read the old changelogs, where somebody fiddled witrh the code. Ask about what people thought (or smoked) when implementing or offer a better implementation. There is a big problem with those special devices, as only few if any wine developpers have it... Bye -- Uwe Bonnes[EMAIL PROTECTED] Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 Fax. 06151 164321 --
Re: draft Call for Testing
On Tue, May 6, 2008 at 8:19 AM, Adam Petaccia <[EMAIL PROTECTED]> wrote: > > 4. For each app you test, add a test report into Wine's AppDB. > > I'd explicitly state something about reporting bugs for things that > don't work. It should be obvious, but being explicit rarely hurts. As I > tell my friends who refuse to file bugs: "They can't fix it if they > don't know its broke". Yeah. But I'd rather not scare them with bugzilla, so how about this: 4. For each app you test, add a test report into Wine's AppDB. Since you're only testing apps that were rated as platinum, it should work perfectly, even for people who don't know a commandline from a kumquat. If it doesn't work perfectly from start to finish, rate it no higher than gold. Now, if this was just a misrated application, you're done. But if you can verify that it actually worked great in an earlier version of wine, you've found a regression! In that case, please post a message whose subject starts with 'regression:' in the wine forum (or the wine-users mailing list), or file a bug at bugs.winehq.org. Now, that text is too long, but you get the idea. How's it sound now?
Re: draft Call for Testing
> 4. For each app you test, add a test report into Wine's AppDB. > > As a token of our thanks, we will pick one of the users who submits > a healthy set of useful test results and send him or her a tasteful > Wine-themed goodie of some sort. > > So fire up your keyboards and start testing! > Thanks, and good hunting! I'd explicitly state something about reporting bugs for things that don't work. It should be obvious, but being explicit rarely hurts. As I tell my friends who refuse to file bugs: "They can't fix it if they don't know its broke". signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/3] dinput: Remove redundant variable.
Vitaliy Margolen wrote: > --- > dlls/dinput/joystick_linux.c | 16 +++- > 1 files changed, 7 insertions(+), 9 deletions(-) > Forgot to add that this series of patches should finally address bugs 12052 and 11644. Was there anything wrong with these patches? Vitaliy.
Re: draft Call for Testing
Dan Kegel wrote: > So, what should we be asking wine users to be > doing once rc1 is out? How about this: This has as subject "Call for Testing" but we could also need help with the translations http://wiki.winehq.org/Translating and http://pf128.krakow.sdi.tpnet.pl/wine-transl/ bye michael > --- snip --- > Calling all wine users! > Today, after 15 years of development, the first release > candidate for wine-1.0.0 was released. > Wine has been under heavy development in recent > months, and some applications that used to work well > no longer do. But we don't know which ones! Please > help us find them, so we can fix them. Here's how: > > 0. Make sure your machine runs glxgears properly > (if it crashes, you may need to update your graphics drivers) > > 1. Install wine-1.0.0-rc1 (you can download it from > http://www.winehq.org/site/download ). > Make sure wine's notepad starts up ok and says > "wine 1.0.0 rc1" when you do Help / About Wine. > > 2. Visit the Wine application database at > http://appdb.winehq.org/browse_by_rating.php?sRating=Platinum > and pick out a few applications that supposedly work perfectly under Wine > but do not yet have any test reports with wine-1.0.0-rc1 or later. > > 3. Try installing and running those apps, one at a time. > Before installing each app, delete your .wine directory; that way > you get a clean run, uncontaminated by the previous app's settings. > > 4. For each app you test, add a test report into Wine's AppDB. > > As a token of our thanks, we will pick one of the users who submits > a healthy set of useful test results and send him or her a tasteful > Wine-themed goodie of some sort. > > So fire up your keyboards and start testing! > Thanks, and good hunting! > --- snip --- > > (Not sure how the goodie would be handled, but I'm willing to cover the > expenses myself, especially if I get to pick the winner :-) > > How's that sound? > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 Reg. Adresse: Red Hat GmbH, Otto-Hahn-Strasse 20, 85609 Dornach bei Muenchen Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich
Re: [PATCH 3/3] ddraw/tests: Add tests for IDirect3DDevice7_Load.
Am Montag, 5. Mai 2008 23:49:34 schrieb Alexander Dorofeyev: > + /* Freed in reverse order as native seems to dislike and crash on > freeing top level surface first. */ just fyi, native ignores refcounts on sublevels(if they are created as complex surface, not attached). As long as the top level exists, you can release the sublevels into oblivion if you want to, they'll stay around. If the top level is destroyed, the sublevels are destroyed regardless of their refcounts. There are some tests for this behavior in dsurface.c, and Wine does the same essentially. A very extensive test, wow!
Re: AppDB: update the general help page and also make it valid html
> I've updated the general help page with links to git instead of cvs, > updated building instructions and also changed the html a little so it > validates, I've also removed a link to a cracks website and replaced > it with a statement about third party software. > > before and after: http://img222.imageshack.us/img222/8647/baiz4.png It's great that you're fixing up the help pages. But i don't see why you are removing the link to MegaGames; I added it to make it easier for users to test games without a how-to; removing it would appear to do the opposite. Alexander N. Sørnes
