Re: CrossCallsWtoA - updated
On Monday 20 October 2008 06:39:10 Austin English wrote: Howdy, I ran the winapi_check tool today, seems the wiki hadn't been updated in a while 2 years. For those curious, here are the results (I removed the nonbugs as mentioned on the wiki). dlls/ws2_32/socket.c: ws2_32: WSAStringToAddressW: illegal call to WSAStringToAddressA (Unicode - ASCII) Looking at this one. dlls/rsaenh/implglue.c:41: : VOID WINAPI MD5Init(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2919) dlls/rsaenh/implglue.c:42: : VOID WINAPI MD5Update(MD5_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/msi/msi.c:2920) dlls/rsaenh/implglue.c:43: : VOID WINAPI MD5Final(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2921) dlls/secur32/util.c:104: : VOID WINAPI MD4Init(MD4_CTX *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:37) dlls/secur32/util.c:105: : VOID WINAPI MD4Update(MD4_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:38) dlls/secur32/util.c:106: : VOID WINAPI MD4Final(MD4_CTX *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:39) dlls/secur32/util.c:107: : VOID WINAPI MD5Init(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2919) dlls/secur32/util.c:108: : VOID WINAPI MD5Update(MD5_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/msi/msi.c:2920) dlls/secur32/util.c:109: : VOID WINAPI MD5Final(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2921) dlls/winex11.drv/graphics.c:1512: : void WINAPI A_SHAInit(sha_ctx *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:45) dlls/winex11.drv/graphics.c:1513: : void WINAPI A_SHAUpdate(sha_ctx *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:46) dlls/winex11.drv/graphics.c:1514: : void WINAPI A_SHAFinal(sha_ctx *,unsigned char *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:47) There's no header file for this, so all the code that uses these functions has to declare this. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. signature.asc Description: This is a digitally signed message part.
Re: winedos interrupts getting lost.
Peter Dons Tychsen wrote: Hello. It starting with me trying to figure out why i was loosing keyboard events in winedos. 1) I then traced the keyboard events to a call to signal(SIGUSR2) in function DOSVM_QueueEvent(). 2) The signal() triggers code in ntdll, which generates an exception EXCEPTION_VM86_STI for the current vm86 context. 3) The exception is supposed to trigger exception_handler(), which will then handle the keyboard event, by kicking the event queue. This never happens however, as the mechanism stops working very quickly. I found out the code gets to raise_vm86_sti_exception in ntdll, and then stops. ntdll_get_thread_data()-vm86_ptr is NULL, so the STI exception is never signaled. Does anyone know more about the exception subsystem, and what could be causing this kind of strange behavior? I can mention that the system can generate EXCEPTION_VM86_INTx exceptions successfully, but fails to execute the EXCEPTION_VM86_STI. Thanks, /pedro One issue with dos input is (was?), that since 2.6 linux kernel we should signal the thread not the process. Have a look at [1]. That patch once fixed all my dos input issues, although I haven't looked at this stuff for quite some time. I'm not sure you have the same problem, just a possible hint. Markus [1] http://www.winehq.org/pipermail/wine-patches/2004-November/013645.html
Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]
Yes, the mail is at http://kegel.com/wine/patchwatcher/results/3193.txt and log is at http://kegel.com/wine/patchwatcher/results/3193.log . Why, was there any problems with this patch? Regards, Andrey 2008/10/20 James McKenzie [EMAIL PROTECTED] Was this ever processed through Patchwatcher? James McKenzie Original Message Subject:mpr: fix NULL pointer dereference in WNetGetResourceInformationW Date: Tue, 07 Oct 2008 20:18:00 +0400 From: Andrey Turkin [EMAIL PROTECTED] Reply-To: wine-devel@winehq.org To: wine-patches [EMAIL PROTECTED] The dereference was spotted by Anastasius Focht in bug 13737; this patch fixes this bug. --- dlls/mpr/wnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Re: DOS game support - just needs a little VGA love?
Hi, Perhaps support for more VGA features can increase compatibility of DOS software on 32-bit hardware. 64-bit users won't be able to run most dos programs as there is no vm86 support when using a 64-bit kernel. In the end we need x86 emulation.. Roderick Hey, that CGA video support patch today from Peter Dons Tychsen, http://winehq.org/pipermail/wine-patches/2008-October/063417.html reminded me there's an old downloadable DOS game my wife likes to dig out every now and then. I tried it today and discovered that what's stopping it is support for a VGA feature, so I filed a bug: http://bugs.winehq.org/show_bug.cgi?id=15688 There are three other similar bugs, some with patches: http://bugs.winehq.org/buglist.cgi?product=Winecomponent=doslong_desc_type=substringlong_desc=vga Getting old DOS games working might be pretty easy at this point if, like this game, they just need a little VGA love. Let's encourage newcomers to contribute in this area... it'd be fun to see those classic games running in wine. I added an entry to http://wiki.winehq.org/SummerOfCode for this, in case nobody does it before summer. - Dan -- GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/[EMAIL PROTECTED]
Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid
Sorry for the truncated object, certainly a copy/paste error. It should be: Make the shlwapi tests load on systems Vista by providing a private implementation of RegDeleteTreeW. Regards, Nicolas Le Cam
Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid
Hi Paul, I've just seen that. Please ignore my patch. I've followed the same 'trick' that has been used in other tests but I also think Detlef's approach is better. Thanks for your feedback, Nicolas Le Cam 2008/10/20 Paul Vriens [EMAIL PROTECTED]: Nicolas Le Cam wrote: Regards, Nicolas Le Cam Hi Nicolas, Detlef already sent a patch for this: http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html I think his approach is better as W-calls are not implemented on win9x and we can get away with 2 normal key deletes. -- Cheers, Paul.
RE: DOS game support - just needs a little VGA love?
Perhaps support for more VGA features can increase compatibility of DOS software on 32-bit hardware. 64-bit users won't be able to run most dos programs as there is no vm86 support when using a 64-bit kernel. In the end we need x86 emulation.. Dosemu (not dosbox) works nice here on my 64 bit linux distro. How are they doing that? Afaics dosemu uses vm86 instead of a full-blown CPU emulation.
Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
James Hawkins [EMAIL PROTECTED] writes: diff --git a/tools/wine.inf.in b/tools/wine.inf.in index 4756d7d..bc1b1d6 100644 --- a/tools/wine.inf.in +++ b/tools/wine.inf.in @@ -128,7 +128,7 @@ HKCR,folder\shell\open\ddeexec,,2,[ViewFolder(%l, %I, %S)] HKCR,folder\shell\open\ddeexec,NoActivateHandler,2, HKCR,folder\shell\open\ddeexec\application,,2,Folders HKCR,hlpfile\shell\open\command,,2,%11%\winhlp32.exe %1 -HKCR,htmlfile\shell\open\command,,2,%11%\winebrowser.exe -nohome +HKCR,htmlfile\shell\open\command,,2,%11%\winebrowser.exe -nohome HKCR,htmlfile\shell\open\ddeexec,,2,%1,,-1,0 HKCR,htmlfile\shell\open\ddeexec,NoActivateHandler,2, HKCR,htmlfile\shell\open\ddeexec\Application,,2,IExplore This isn't look right, the entry works just fine without quotes, we shouldn't have to add them just to satisfy a test. -- Alexandre Julliard [EMAIL PROTECTED]
Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable
--- On Sun, 10/19/08, Rob Shearman [EMAIL PROTECTED] wrote: The information is added at commit time so it won't make any difference if you just run git format-patch after configuring the above settings, it matters what the settings were when you committed. If you haven't committed anything since you can do: git reset HEAD^ git commit And then enter your commit message again and this will create a new commit with the correct author information. Thanks, it worked indeed, so next time the patch will have correct contact information Joris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: DOS game support - just needs a little VGA love?
On Sun, 2008-10-19 at 20:56 -0700, Dan Kegel wrote: Hey, that CGA video support patch today from Peter Dons Tychsen, http://winehq.org/pipermail/wine-patches/2008-October/063417.html reminded me there's an old downloadable DOS game my wife likes to dig out every now and then. I tried it today and discovered that what's stopping it is support for a VGA feature, so I filed a bug: http://bugs.winehq.org/show_bug.cgi?id=15688 There are three other similar bugs, some with patches: http://bugs.winehq.org/buglist.cgi?product=Winecomponent=doslong_desc_type=substringlong_desc=vga Getting old DOS games working might be pretty easy at this point if, like this game, they just need a little VGA love. Let's encourage newcomers to contribute in this area... it'd be fun to see those classic games running in wine. I added an entry to http://wiki.winehq.org/SummerOfCode for this, in case nobody does it before summer. - Dan Hey D. Yes. This is exactly what i was thinking. And there is lots of material to start on, and the old DOS environment is quite well documented via various projects and documents scattered over the net. My biggest problem right now is to get keyboard input working, as there is an annoying bug (or something) in the exception system (see my mail called winedos interrupts getting lost). That needs to get fixed for any games to work. I think its some kind of problem with ntdll. I would love to see support for games like paratrooper and police quest. Thanks, /pedro
today build's broken for me
make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: error: ‘gnutls_transport_set_errno’ undeclared here (not in a function) schannel.c:61: warning: type defaults to ‘int’ in declaration of ‘pgnutls_transport_set_errno’ schannel.c: In function ‘schan_pull’: schannel.c:571: error: called object ‘pgnutls_transport_set_errno’ is not a function schannel.c: In function ‘schan_push’: schannel.c:593: error: called object ‘pgnutls_transport_set_errno’ is not a function make[2]: *** [schannel.o] Error 1 make[2]: Leaving directory `/home/mrlarch/wine/dlls/secur32' make[1]: *** [secur32] Error 2 make[1]: Leaving directory `/home/mrlarch/wine/dlls' make: *** [dlls] Error 2 I'm using libgnutls-dev 1.4.4-3 from etch.
Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid
Nicolas Le Cam wrote: Regards, Nicolas Le Cam Hi Nicolas, Detlef already sent a patch for this: http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html I think his approach is better as W-calls are not implemented on win9x and we can get away with 2 normal key deletes. -- Cheers, Paul.
RE: DOS game support - just needs a little VGA love?
Am Montag, den 20.10.2008, 12:36 +0200 schrieb Stefan Dösinger: Dosemu (not dosbox) works nice here on my 64 bit linux distro. How are they doing that? Afaics dosemu uses vm86 instead of a full-blown CPU emulation. Dosemu has a hybrid approach. On x86, vm86 is used. On systems lacking vm86 (that is most notably x64), full-blown CPU emulation (either interpreting or a JIT compiler) is used instead. 32 bit protected mode programs can run natively on x86 and x64, but emulation is also available as an option in protected mode. Regards, Michael Karcher (who already fixed some bugs in dosemu's cpu emulatiopn code) signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid
Sorry again, didn't see Detlef has already sent a fix to this one [1]. Please ignore. Regards, Nicolas Le Cam [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html 2008/10/20 Nicolas Le Cam [EMAIL PROTECTED]: Sorry for the truncated object, certainly a copy/paste error. It should be: Make the shlwapi tests load on systems Vista by providing a private implementation of RegDeleteTreeW. Regards, Nicolas Le Cam
Re: wintrust: Implement CryptCATAdminCalcHashFromFileHandle
Hi Maarten,
+if (pbHash *pcbHash 20)
+{
+SetLastError(ERROR_INSUFFICIENT_BUFFER);
+return FALSE;
+}
That's not correct, *pcbHash must be set to 20 if it's too small.
+while (ReadFile(hFile, tempbuffer, TEMP_BLOCK_SIZE,
readbytes, NULL) readbytes)
+CryptHashData(hash, tempbuffer, readbytes, 0);
You return TRUE if ReadFile fails, which is unlikely to be correct.
Thanks,
--Juan
Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
Vitaly claims he gets no feedback for his patches. He knows full well
that I give him plenty of feedback. I explained to him what was wrong
with his test SHFileOperation patches, yet he repeatedly sent the same
patch to the list. I'm not going to repeat the same comment over and
over again.
Yes, it was plenty of feedback from James. I was rewriting my test, James
showed my errors, and send the test agan. But when I send the last version of
my test (I thought it was good enough), I have received no reply. I resent it
2 or 3 times but no reply again.
In this sentence rather than is the same as instead of. So
FOF_MULTIDESTFILES indicates that the pTo member does *not* specify one
destination directory, but a list of destination files instead
Yes, now I see my fault. Sometimes it's very difficult to translate such kind
of expressions. I've translated this as or
I suspect (but I am definitely not an expert in this area), that the
patch Vitaly Perov sent:
| + /* move many files into directory with FOF_MULTIDESTFILES */
| + set_curr_dir_path(from, test?.txt\0);
| + set_curr_dir_path(to, testdir2\0);
| + retval = SHFileOperationA(shfo2);
| + todo_wine
| + {
| + ok(retval == ERROR_SUCCESS, Expected ERROR_SUCCESS, got %d\n,
retval);
| + ok(file_exists(testdir2\\test2.txt), Expected the
file 'test2.txt' to exist\n);
| + ok(file_exists(testdir2\\test4.txt), Expected the
directory 'test4.txt' to exist\n);
| + }
This test is not related to patch shell32: FOF_MULTIDESTFILES must be set
when copying files into directory
If the translation of rather than is instead of, now I see my fault.
But this test is passed in windows (win2k3). It doesn't pass in wine.
So, it show difference between windows and wine behaviour.
So, what's wrong in this test?
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
Re: latest GIT
Austin English wrote: On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt [EMAIL PROTECTED] wrote: Anyone else having a problem compiling the latest git? mine has failed 2 times when I compile... one with a clean tree and one with an older tree.. chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com What error are you getting? What gcc version? make[2]: Entering directory `/home/cahrendt/wine-git/tools/widl' gcc -c -I. -I. -I../../include -I../../include-Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o parser.yy.o parser.yy.c parser.l: In function ‘xstrtoul’: parser.l:92: error: ‘errno’ undeclared (first use in this function) parser.l:92: error: (Each undeclared identifier is reported only once parser.l:92: error: for each function it appears in.) parser.l:94: error: ‘ERANGE’ undeclared (first use in this function) make[2]: *** [parser.yy.o] Error 1 make[2]: Leaving directory `/home/cahrendt/wine-git/tools/widl' make[1]: *** [widl] Error 2 make[1]: Leaving directory `/home/cahrendt/wine-git/tools' make: *** [tools] Error 2 GCC version 4.1.2-45.el5 chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Today's git won't install DNS10 - IE not found
I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. The popup messages says that IE 5 or greater is needed. wine-1.1.6-379-g07badc7 Susan fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies - 6 ignored LMsiAssembly table values fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly LMicrosoft.VC80.MFCLOC err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth = 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action LLaunchConditions returned 1603 [EMAIL PROTECTED]:~/DNS10$ [EMAIL PROTECTED]:~/DNS10$ [EMAIL PROTECTED]:~/DNS10$ cd [EMAIL PROTECTED]:~$ sudo rm -rf .wine [EMAIL PROTECTED]:~$ sh winetricks fakeie6 Could not load Mozilla. HTML rendering will be disabled. err:wgl:opengl_error No OpenGL support compiled in. wine: configuration in '/home/susan/.wine' has been updated. Executing wine regedit /home/susan/.wine/drive_c/winetrickstmp/fakeie6.reg Install of fakeie6 done winetricks done. [EMAIL PROTECTED]:~$ winecfg [EMAIL PROTECTED]:~$ cd DNS10 [EMAIL PROTECTED]:~/DNS10$ wine setup fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies - 6 ignored LMsiAssembly table values fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly LMicrosoft.VC80.MFCLOC err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth = 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action LLaunchConditions returned 1603 [EMAIL PROTECTED]:~/DNS10$ cd [EMAIL PROTECTED]:~$ sudo rm -rf .wine [EMAIL PROTECTED]:~$ sh winetricks fakeie6 Could not load Mozilla. HTML rendering will be disabled. err:wgl:opengl_error No OpenGL support compiled in. wine: configuration in '/home/susan/.wine' has been updated. Executing wine regedit /home/susan/.wine/drive_c/winetrickstmp/fakeie6.reg Install of fakeie6 done winetricks done. [EMAIL PROTECTED]:~$ winecfg [EMAIL PROTECTED]:~$ cd DNS10 [EMAIL PROTECTED]:~/DNS10$ wine setup fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies - 6 ignored LMsiAssembly table values fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly LMicrosoft.VC80.MFCLOC err:ntlm:SECUR32_initNTLMSP
Today's git won't install DNS10 - IE not found
I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. wine-1.1.6-379-g07badc7 fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies - 6 ignored LMsiAssembly table values fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly LMicrosoft.VC80.MFCLOC err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth = 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action LLaunchConditions returned 1603 [EMAIL PROTECTED]:~/DNS10$
Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
On Mon, Oct 20, 2008 at 6:25 AM, Alexandre Julliard [EMAIL PROTECTED] wrote: James Hawkins [EMAIL PROTECTED] writes: diff --git a/tools/wine.inf.in b/tools/wine.inf.in index 4756d7d..bc1b1d6 100644 --- a/tools/wine.inf.in +++ b/tools/wine.inf.in @@ -128,7 +128,7 @@ HKCR,folder\shell\open\ddeexec,,2,[ViewFolder(%l, %I, %S)] HKCR,folder\shell\open\ddeexec,NoActivateHandler,2, HKCR,folder\shell\open\ddeexec\application,,2,Folders HKCR,hlpfile\shell\open\command,,2,%11%\winhlp32.exe %1 -HKCR,htmlfile\shell\open\command,,2,%11%\winebrowser.exe -nohome +HKCR,htmlfile\shell\open\command,,2,%11%\winebrowser.exe -nohome HKCR,htmlfile\shell\open\ddeexec,,2,%1,,-1,0 HKCR,htmlfile\shell\open\ddeexec,NoActivateHandler,2, HKCR,htmlfile\shell\open\ddeexec\Application,,2,IExplore This isn't look right, the entry works just fine without quotes, we shouldn't have to add them just to satisfy a test. The value is quoted in Windows; what's the harm in matching that? The test in question was added to fix an installer (can't remember which one now), and the recently added tests now show that msi is correct, while the current value of the command is incorrect. -- James Hawkins
Re: Today's git won't install DNS10 - IE not found
On Mon, Oct 20, 2008 at 10:17 AM, Susan Cragin [EMAIL PROTECTED] wrote: I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. The popup messages says that IE 5 or greater is needed. wine-1.1.6-379-g07badc7 Susan fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - 1 ignored LUpgrade table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies - 6 ignored LMsiAssembly table values fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) Lsusan 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly LMicrosoft.VC80.MFCLOC err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth = 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action LLaunchConditions returned 1603 [EMAIL PROTECTED]:~/DNS10$ Please apply this patch and see if it works for you: http://winehq.org/pipermail/wine-patches/2008-October/063450.html -- James Hawkins
Re: today build's broken for me
On Mon, Oct 20, 2008 at 6:44 AM, Nikolay Sivov [EMAIL PROTECTED] wrote: make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: error: 'gnutls_transport_set_errno' undeclared here (not in a function) schannel.c:61: warning: type defaults to 'int' in declaration of 'pgnutls_transport_set_errno' schannel.c: In function 'schan_pull': schannel.c:571: error: called object 'pgnutls_transport_set_errno' is not a function schannel.c: In function 'schan_push': schannel.c:593: error: called object 'pgnutls_transport_set_errno' is not a function make[2]: *** [schannel.o] Error 1 make[2]: Leaving directory `/home/mrlarch/wine/dlls/secur32' make[1]: *** [secur32] Error 2 make[1]: Leaving directory `/home/mrlarch/wine/dlls' make: *** [dlls] Error 2 I'm using libgnutls-dev 1.4.4-3 from etch. It looks like you need libgnutls-dev 2.x to compile schannel.c as is.
Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
James Hawkins [EMAIL PROTECTED] writes: The value is quoted in Windows; what's the harm in matching that? The test in question was added to fix an installer (can't remember which one now), and the recently added tests now show that msi is correct, while the current value of the command is incorrect. The command is supposed to be editable by the user, so we can't depend on a specific format. Also since it's editable it won't be automatically upgraded, so for backwards compatibility we have to handle the current format anyway. -- Alexandre Julliard [EMAIL PROTECTED]
Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
On Mon, Oct 20, 2008 at 12:19 PM, Alexandre Julliard [EMAIL PROTECTED] wrote: James Hawkins [EMAIL PROTECTED] writes: The value is quoted in Windows; what's the harm in matching that? The test in question was added to fix an installer (can't remember which one now), and the recently added tests now show that msi is correct, while the current value of the command is incorrect. The command is supposed to be editable by the user, so we can't depend on a specific format. Also since it's editable it won't be automatically upgraded, so for backwards compatibility we have to handle the current format anyway. Even if it is editable, I don't see what the problem is with making this the default value. Susan Craig has already run into this problem with the DNS 10 installer, which uses the AppSearch action to search for IE using this value. I don't know the policy of the shell command values, but maybe the executable has to be quoted if options are given. -- James Hawkins
Re: [RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.
Rob Shearman wrote:
I've looked at the spec and I see that it has a nice lookahead not a
member of '{, function' in the rule for ExpressionStatement, meaning
that the grammar cannot be implemented unambiguously by a LALR(1)
parser-generator like bison. :-(
I've found on MS blog that my guess that JScript treads function
expressions with identifier as function declaration was right. I can't
find the link now, it was somewhere on
http://blogs.msdn.com/jscript/
I've sent a patch that implements this behavior.
Thanks,
Jacek
Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]
Andrey Turkin [EMAIL PROTECTED] on Oct 20, 2008 1:02 AM wrote about Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW] 2008/10/20 James McKenzie [EMAIL PROTECTED] Was this ever processed through Patchwatcher? James McKenzie Original Message Subject:mpr: fix NULL pointer dereference in WNetGetResourceInformationW Date: Tue, 07 Oct 2008 20:18:00 +0400 From: Andrey Turkin [EMAIL PROTECTED] Reply-To: wine-devel@winehq.org To: wine-patches [EMAIL PROTECTED] The dereference was spotted by Anastasius Focht in bug 13737; this patch fixes this bug. --- dlls/mpr/wnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Yes, the mail is at http://kegel.com/wine/patchwatcher/results/3193.txt and log is at http://kegel.com/wine/patchwatcher/results/3193.log . Why, was there any problems with this patch? Regards, Andrey Thank you. I could not find it last night when I was reviewing PatchWater entries. James McKenize
Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
James Hawkins [EMAIL PROTECTED] writes: Even if it is editable, I don't see what the problem is with making this the default value. Susan Craig has already run into this problem with the DNS 10 installer, which uses the AppSearch action to search for IE using this value. I don't know the policy of the shell command values, but maybe the executable has to be quoted if options are given. Making it the default value can be done, but that doesn't solve the problem. You can't require that people blow away their ~/.wine for the installers to work again, we are supposed to be backwards compatible with the Wine 1.0 registry. -- Alexandre Julliard [EMAIL PROTECTED]
Re: cryptui: Add a partial implementation of CryptUIWizImport.
Hi Hans,
I know this patch already got committed.
+BOOL WINAPI CryptUIWizImport(DWORD dwFlags, HWND hwndParent, LPCWSTR
pwszWizardTitle,
+ PCCRYPTUI_WIZ_IMPORT_SRC_INFO
pImportSrc, HCERTSTORE hDestCertStore)
+{
+static const WCHAR Root[] = {'R','o','o','t',0};
(snip)
+if (!(cert = CertCreateCertificateContext(encoding, buffer, size)))
+{
+WARN(unable to create certificate context\n);
+HeapFree(GetProcessHeap(), 0, buffer);
+return FALSE;
+}
+/* FIXME: verify certificate and determine store name dynamically */
+if (!(store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0,
CERT_SYSTEM_STORE_CURRENT_USER, Root)))
+{
+WARN(unable to open certificate store\n);
+CertFreeCertificateContext(cert);
+HeapFree(GetProcessHeap(), 0, buffer);
+return FALSE;
+}
+ret = CertAddCertificateContextToStore(store, cert,
CERT_STORE_ADD_REPLACE_EXISTING, NULL);
This doesn't look correct. Why are you always using the root store,
and ignoring hDestCertStore? Even if you expect hDestCertStore to be
NULL (in which case a default store may make sense), using the Root
store seems like it won't do what the user wants. The certificate
won't be persisted if it's added to the Root store, because the Root
store is only read from the local system. When the process (Outlook)
exits, the certificate will no longer exist.
It should be possible to add a test that shows which store the
certificate should be added to, if nothing else to satisfy my doubt.
--Juan
Re: cryptui: Add a partial implementation of CryptUIWizImport.
On Monday 20 October 2008 21:48:37 Juan Lang wrote:
+/* FIXME: verify certificate and determine store name dynamically */
+if (!(store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0,
CERT_SYSTEM_STORE_CURRENT_USER, Root)))
+{
+WARN(unable to open certificate store\n);
+CertFreeCertificateContext(cert);
+HeapFree(GetProcessHeap(), 0, buffer);
+return FALSE;
+}
+ret = CertAddCertificateContextToStore(store, cert,
CERT_STORE_ADD_REPLACE_EXISTING, NULL);
This doesn't look correct. Why are you always using the root store,
and ignoring hDestCertStore? Even if you expect hDestCertStore to be
NULL (in which case a default store may make sense), using the Root
store seems like it won't do what the user wants. The certificate
won't be persisted if it's added to the Root store, because the Root
store is only read from the local system. When the process (Outlook)
exits, the certificate will no longer exist.
It's my limited manual testing with a self-signed root CA certificate
that turned this up on Windows. The certificate is still there after
Outook is closed.
It's an absolute minimal implementation and you are right that we need
to find out what determines the store for the whole range of certificate
types. The FIXME comment I put in should really have been a FIXME().
-Hans
Re: cryptui: Add a partial implementation of CryptUIWizImport.
It's my limited manual testing with a self-signed root CA certificate that turned this up on Windows. The certificate is still there after Outook is closed. In Windows? Sure. In Wine? I can't see how that would be the case. (In fact it turns up a crash here for me.) --Juan
Re: cryptui: Add a partial implementation of CryptUIWizImport.
On Monday 20 October 2008 22:51:15 Juan Lang wrote: It's my limited manual testing with a self-signed root CA certificate that turned this up on Windows. The certificate is still there after Outook is closed. In Windows? Sure. In Wine? I can't see how that would be the case. (In fact it turns up a crash here for me.) It persists in Windows, yes. Haven't tested Wine, where do you see a crash? -Hans
Re: cryptui: Add a partial implementation of CryptUIWizImport.
It persists in Windows, yes. Haven't tested Wine, where do you see a crash? In crypt32. I wrote a quick test program that does what your patch does, and it crashes adding the certificate to the root store. I'll send a patch shortly that'll avoid the crash. Nevertheless, this won't do what you want in Wine: the root store is read-only in Wine. --Juan
Re: cryptui: Add a partial implementation of CryptUIWizImport.
On Monday 20 October 2008 23:06:35 Juan Lang wrote: It persists in Windows, yes. Haven't tested Wine, where do you see a crash? In crypt32. I wrote a quick test program that does what your patch does, and it crashes adding the certificate to the root store. I'll send a patch shortly that'll avoid the crash. Nevertheless, this won't do what you want in Wine: the root store is read-only in Wine. It may not persist but I could import the certificate fine on Wine. Is there an alternative for the root store? What's involved in making the root store read-write? -Hans
Re: DOS game support - just needs a little VGA love?
Peter Dons Tychsen schrieb: [...] I would love to see support for games like paratrooper and police quest. don't they work in DOS-Box? bye Jochen
Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
Am Montag, den 20.10.2008, 19:04 +0400 schrieb Vitaly Perov:
I suspect (but I am definitely not an expert in this area), that the
patch Vitaly Perov sent:
| +/* move many files into directory with FOF_MULTIDESTFILES */
| +set_curr_dir_path(from, test?.txt\0);
| +set_curr_dir_path(to, testdir2\0);
| +retval = SHFileOperationA(shfo2);
| +todo_wine
| +{
| +ok(retval == ERROR_SUCCESS, Expected ERROR_SUCCESS, got %d\n,
retval);
| +ok(file_exists(testdir2\\test2.txt), Expected the file
'test2.txt' to exist\n);
| +ok(file_exists(testdir2\\test4.txt), Expected the directory
'test4.txt' to exist\n);
| +}
This test is not related to patch shell32: FOF_MULTIDESTFILES must be set
when copying files into directory
If the translation of rather than is instead of, now I see my fault.
But this test is passed in windows (win2k3). It doesn't pass in wine.
So, it show difference between windows and wine behaviour.
So, what's wrong in this test?
I honestly don't know. I can add that this test passes on XP SP3 too. It
can be helpfull to include a history into the patch (saying: third
resend: Changed this and that). One really has to ask Alexandre, or
ask on wine-devel for feedback. Something like Obviously, patch http
link here did not get applied even after resending. Does anybody see
anything obviously wrong with it?. As a guide to non-native speakers on
#winehackers: Just ask (when julliard is online and not marked as ways)
julliard: What is wrong with http link here. Copy'n'paste all
responses (recognizable by being from Alexandre or starting with your
nickname) and try to make sense of them later.
Regards,
Michael Karcher
Re: cryptui: Add a partial implementation of CryptUIWizImport.
It may not persist but I could import the certificate fine on Wine. Is there an alternative for the root store? What's involved in making the root store read-write? You haven't convinced me that Windows does indeed import the certificate to the root store in all cases. Making the root store read-write isn't the right answer. Please write more tests first. --Juan
Re: winedos interrupts getting lost.
Hello Markus. I think this is exactly what is going wrong. It fits the description of what i am seeing. The kernel man-pages even go so far as to state: The effects of this call in a multi-threaded process are unspecified. http://linux.die.net/man/2/signal So i guess using signal() inside wine is a no-go. I think this patch needs to be applied. I will try out the patch, and re-sync it if it has come out-of-date. Thanks, /pedro On Mon, 2008-10-20 at 09:44 +0200, Markus Amsler wrote: Peter Dons Tychsen wrote: Hello. It starting with me trying to figure out why i was loosing keyboard events in winedos. 1) I then traced the keyboard events to a call to signal(SIGUSR2) in function DOSVM_QueueEvent(). 2) The signal() triggers code in ntdll, which generates an exception EXCEPTION_VM86_STI for the current vm86 context. 3) The exception is supposed to trigger exception_handler(), which will then handle the keyboard event, by kicking the event queue. This never happens however, as the mechanism stops working very quickly. I found out the code gets to raise_vm86_sti_exception in ntdll, and then stops. ntdll_get_thread_data()-vm86_ptr is NULL, so the STI exception is never signaled. Does anyone know more about the exception subsystem, and what could be causing this kind of strange behavior? I can mention that the system can generate EXCEPTION_VM86_INTx exceptions successfully, but fails to execute the EXCEPTION_VM86_STI. Thanks, /pedro One issue with dos input is (was?), that since 2.6 linux kernel we should signal the thread not the process. Have a look at [1]. That patch once fixed all my dos input issues, although I haven't looked at this stuff for quite some time. I'm not sure you have the same problem, just a possible hint. Markus [1] http://www.winehq.org/pipermail/wine-patches/2004-November/013645.html
Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)
Alistair Leslie-Hughes wrote:
Hi,
Clean up the get function.
Make sure we round down the value passed in.
Corrected test to prove above.
Changelog:
mshtml: Implement IHTMLStyle get/put posLeft
+
+V_VT(v) = VT_I4;
+V_I4(v) = floor(f);
+
+if(VariantChangeType(v, v, 0, VT_BSTR) == S_OK)
- It won't work for some locales
- It's probably better to use sprintfW for this and set units to px for free
+hres = get_style_attr(This, STYLEID_LEFT, ret);
+if(SUCCEEDED(hres))
+{
+if(ret)
+*p = atoiW(ret);
+}
- Your patch adds support only for px values, so you should check if we
really return px value. Something like
for(ptr=ret; isdigitW(*ptr); ptr++);
if(*ptr || strcmp(ptr, pxW)) {
FIXME(...);
return E_NOTIMPL;
}
should be fine.
- You leak ret
- It's better to use get_nsstyle_attr_nsval to avoid one useless memory
allocation.
And you really want to move these function to separated functions like
[get|set]_style_pos that would take styleid_t as an argument to avoid
code duplication.
Jacek
Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)
Jacek Caban wrote:
for(ptr=ret; isdigitW(*ptr); ptr++);
if(*ptr || strcmp(ptr, pxW)) {
.. .. of course...
Jacek
Re: DOS game support - just needs a little VGA love?
Jochen wrote: I would love to see support for games like paratrooper and police quest. don't they work in DOS-Box? We would like to get to the point where users don't have to wonder which tool to use to run .exe's with. i.e. it would be nice if we could just map .exe's to Wine in the desktop. Anything that gets us closer to that, especially if it's easy, is a good thing.
Re: DOS game support - just needs a little VGA love?
On Monday 20 October 2008 02:14:41 pm Jochen Theodorou wrote: don't they work in DOS-Box? I know Daggerfall doesn't work all that great in DOSBox (it's a heavy effort in tweaking to get the videos to play at the right speed, and that usually causes the game to play like crap, and vice-versa..). Getting it, and the needed tools (vdmsound(?) and speedset and such) working in Wine would be great.
Re: DOS game support - just needs a little VGA love?
Don't forget the .com files those wonderful real-mode 64K wonders... I noticed that the distros do not map .com files to wine. They probably should. /p On Mon, 2008-10-20 at 16:18 -0700, Dan Kegel wrote: Jochen wrote: I would love to see support for games like paratrooper and police quest. don't they work in DOS-Box? We would like to get to the point where users don't have to wonder which tool to use to run .exe's with. i.e. it would be nice if we could just map .exe's to Wine in the desktop. Anything that gets us closer to that, especially if it's easy, is a good thing.
Re: latest GIT
Austin English wrote: On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt [EMAIL PROTECTED] wrote: Anyone else having a problem compiling the latest git? mine has failed 2 times when I compile... one with a clean tree and one with an older tree.. chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com What error are you getting? What gcc version? so has anyone figured out why its broken yet? chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: Wine PulseAudio Driver
Hello. I have updated the testing pulseaudio waveout patch for http://bugs.winehq.org/show_bug.cgi?id=10495 The patch has been split in two. The first adds a stub driver that just creates waveout devices based upon pulseaudio sinks and adds checks for pulseaudio to configure.ac. The second patch adds the actual waveout functionality. The patch now detects pulseaudio version prior to 0.9.11 (aka most ubuntu versions) and can build against them. I hope to receive your feedback on this. Thanks - Art
Re: latest GIT
On Mon, Oct 20, 2008 at 10:37 PM, chris ahrendt [EMAIL PROTECTED] wrote: Austin English wrote: On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt [EMAIL PROTECTED] wrote: Anyone else having a problem compiling the latest git? mine has failed 2 times when I compile... one with a clean tree and one with an older tree.. chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com What error are you getting? What gcc version? so has anyone figured out why its broken yet? chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com On Mon, Oct 20, 2008 at 10:37 PM, chris ahrendt [EMAIL PROTECTED] wrote: Austin English wrote: On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt [EMAIL PROTECTED] wrote: Anyone else having a problem compiling the latest git? mine has failed 2 times when I compile... one with a clean tree and one with an older tree.. chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com What error are you getting? What gcc version? so has anyone figured out why its broken yet? chris __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com A regression test would help. -- -Austin
Re: [PATCH 07/12] LookupAccountNameW() - NULL account name handled
On Tuesday 21 October 2008 01:05:34 Paul Bryan Roberts wrote: Hi Paul, I'm glad to see someone tackle this. One minor thing I have with this patch.. +ok(sid_use == SidTypeDomain, Expected SidTypeDomain, got %d\n, SidTypeDomain); seems like this should be ok(sid_use == SidTypeDomain, Expected SidTypeDomain(%d), got %d\n, SidTypeDomain, sid_use); This was wrong before already, but perhaps you could fix that while touching that code anyway. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. signature.asc Description: This is a digitally signed message part.
Re: [PATCH 11/12] LookupAccountNameW() - refactor to eliminate code duplication
On Tuesday 21 October 2008 01:06:45 Paul Bryan Roberts wrote: -FIXME(%s %s %p %p %p %p %p - stub\n, debugstr_w(lpSystemName), debugstr_w(lpAccountName), +TRACE(%s %s %p %p %p %p %p - stub\n, debugstr_w(lpSystemName), debugstr_w(lpAccountName), Sid, cbSid, ReferencedDomainName, cchReferencedDomainName, peUse); If you still consider this function a stub, please keep the FIXME, otherwise, please remove the - stub from the TRACE. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. signature.asc Description: This is a digitally signed message part.
