Re: [PATCH] cryptui: check NULL ptr differently (Coverity)
Marcus Meissner wrote:
> Hi,
>
> CID 829, cryptui fails to handle data being NULL
> correctly after the if (data) branch.
>
> Since it is a allocation error, just return on failure.
>
> Ciao, Marcus
> ---
> dlls/cryptui/main.c | 35 +--
> 1 files changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c
> index 498c158..1fe2ed0 100644
> --- a/dlls/cryptui/main.c
> +++ b/dlls/cryptui/main.c
> @@ -1076,25 +1076,24 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd,
> UINT msg, WPARAM wp,
> HWND tab = GetDlgItem(hwnd, IDC_MGR_STORES);
>
> data = HeapAlloc(GetProcessHeap(), 0, sizeof(struct CertMgrData));
> -if (data)
> +if (!data)
> +return 0;
> +data->imageList = ImageList_Create(16, 16, ILC_COLOR4 | ILC_MASK, 2,
> 0);
> +if (data->imageList)
> {
> -data->imageList = ImageList_Create(16, 16, ILC_COLOR4 | ILC_MASK,
> - 2, 0);
> -if (data->imageList)
> -{
> -HBITMAP bmp;
> -COLORREF backColor = RGB(255, 0, 255);
> + HBITMAP bmp;
> + COLORREF backColor = RGB(255, 0, 255);
> +
> + bmp = LoadBitmapW(hInstance, MAKEINTRESOURCEW(IDB_SMALL_ICONS));
> + ImageList_AddMasked(data->imageList, bmp, backColor);
> + DeleteObject(bmp);
> + ImageList_SetBkColor(data->imageList, CLR_NONE);
> + SendMessageW(GetDlgItem(hwnd, IDC_MGR_CERTS), LVM_SETIMAGELIST,
> + LVSIL_SMALL, (LPARAM)data->imageList);
> + }
> + SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data);
> + data->title = pCryptUICertMgr->pwszTitle;
>
> -bmp = LoadBitmapW(hInstance,
> MAKEINTRESOURCEW(IDB_SMALL_ICONS));
> -ImageList_AddMasked(data->imageList, bmp, backColor);
> -DeleteObject(bmp);
> -ImageList_SetBkColor(data->imageList, CLR_NONE);
> -SendMessageW(GetDlgItem(hwnd, IDC_MGR_CERTS),
> LVM_SETIMAGELIST,
> - LVSIL_SMALL, (LPARAM)data->imageList);
> -}
> -SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data);
> -data->title = pCryptUICertMgr->pwszTitle;
> -}
> initialize_purpose_selection(hwnd);
> add_cert_columns(hwnd);
> if (pCryptUICertMgr->pwszTitle)
You are mixing tabs and spaces in this one.
--
Cheers,
Paul.
Re: Stub DDE interface for Progman.exe
"Jeremiah Flerchinger" wrote: >> > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in >> > shell32.dll. Both will need to be extended and a 3rd progman interface >> > will need to be added in user32. >> >> Progman DDE interface should be implemented by shell32.dll, nowhere else. >> > The shell32.dll DDE callback isn't always initialized & handling Progman > calls for all apps. I've seen Progman calls pass through the DDE_client > and DDE_server of user32.dll instead and never go through shell32.dll. progman.exe in Windows is an empty stub. > We can have the actual Progman functions in shell32.dll, but at least > user32.dll will have to be able to call & be called by these. I think a > separate progman.c/progman.h in /dlls/user32 to handle calls from all > locations may be preferred. Probably you need to write some tests first which actually use the progman DDE interface. -- Dmitry.
Re: New Wine Gecko package
Jacek Caban wrote: > Hi all, > > The last release of Wine Gecko caused a few regressions. Thanks to > Alexandre, we've found the reason. The bad news is that the fix requires > a new package. I've uploaded RC build to: > > http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab > > I'd appreciate if people that observe the regression (mostly strange > crashed) could retest bugs with this build. To do so, you will need the > new package and the attached patch. Also quick tests with random apps > would be nice. This is a bugfix release based on the same codebase as > 0.9.0 version so I don't expect any new regressions with it. > Is this version compatible with Wine 1.0.1 by chance? Thanks, Scott Ritchie
Re: ideas and questions for implementation of MessageMode in Named Pipes
Hi Luke, > how about: ripping out the use of unix-pipes altogether, and replacing > them with tdb (trivial database) in a mmap'd file? the nice thing > about tdb is that it's LGPL'd. the messages could be saved and > transferred via shared memory; tdb is multi-readable / > multi-writeable, and it would save a bitch-awful job of implementing a > shared memory sockets emulation layer (which i _have_ seen done, > once). The usual response around here is, show us some patches, and we'll let you know ;-) Some test cases showing us where we're deficient would be a great start, btw. --Juan
New Wine Gecko package
Hi all,
The last release of Wine Gecko caused a few regressions. Thanks to
Alexandre, we've found the reason. The bad news is that the fix requires
a new package. I've uploaded RC build to:
http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab
I'd appreciate if people that observe the regression (mostly strange
crashed) could retest bugs with this build. To do so, you will need the
new package and the attached patch. Also quick tests with random apps
would be nice. This is a bugfix release based on the same codebase as
0.9.0 version so I don't expect any new regressions with it.
Also the last debug version was accidentally stripped. It will be fixed
in this release. I'm planning to do the release tomorrow, so it will be
in Git on Friday.
Thanks,
Jacek
>From 35f651d05f04dc80dd85451d48428d5c6174dac2 Mon Sep 17 00:00:00 2001
From: Jacek Caban
Date: Thu, 5 Feb 2009 00:17:09 +0100
Subject: [PATCH] mshtml: Wine Gecko 0.9.1 release.
To: wine-patches
---
dlls/mshtml/htmldoc.c|4 +++-
dlls/mshtml/mshtml_private.h |1 +
dlls/mshtml/mutation.c | 15 +++
dlls/mshtml/nsembed.c|4 +++-
dlls/mshtml/nsiface.idl |3 ++-
5 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c
index 32da2e0..a6aa73f 100644
--- a/dlls/mshtml/htmldoc.c
+++ b/dlls/mshtml/htmldoc.c
@@ -214,8 +214,10 @@ static ULONG WINAPI HTMLDocument_Release(IHTMLDocument2
*iface)
ConnectionPointContainer_Destroy(&This->cp_container);
-if(This->nsdoc)
+if(This->nsdoc) {
+remove_mutation_observer(This->nscontainer, This->nsdoc);
nsIDOMHTMLDocument_Release(This->nsdoc);
+}
if(This->nscontainer)
NSContainer_Release(This->nscontainer);
diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h
index e4c98a7..b67c485 100644
--- a/dlls/mshtml/mshtml_private.h
+++ b/dlls/mshtml/mshtml_private.h
@@ -510,6 +510,7 @@ void NSContainer_Release(NSContainer*);
void init_mutation(NSContainer*);
void set_mutation_observer(NSContainer*,nsIDOMHTMLDocument*);
+void remove_mutation_observer(NSContainer*,nsIDOMHTMLDocument*);
void HTMLDocument_LockContainer(HTMLDocument*,BOOL);
void show_context_menu(HTMLDocument*,DWORD,POINT*,IDispatch*);
diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c
index ea61d5a..ab9649c 100644
--- a/dlls/mshtml/mutation.c
+++ b/dlls/mshtml/mutation.c
@@ -55,6 +55,21 @@ void set_mutation_observer(NSContainer *nscontainer,
nsIDOMHTMLDocument *nshtmld
nsIDOMNSDocument_Release(nsdoc);
}
+void remove_mutation_observer(NSContainer *nscontainer, nsIDOMHTMLDocument
*nshtmldoc)
+{
+nsIDOMNSDocument *nsdoc;
+nsresult nsres;
+
+nsres = nsIDOMHTMLDocument_QueryInterface(nshtmldoc,
&IID_nsIDOMNSDocument, (void**)&nsdoc);
+if(NS_FAILED(nsres)) {
+ERR("Could not get nsIDOMNSDocument: %08x\n", nsres);
+return;
+}
+
+nsIDOMNSDocument_WineRemoveObserver(nsdoc, NSDOCOBS(nscontainer));
+nsIDOMNSDocument_Release(nsdoc);
+}
+
#define IE_MAJOR_VERSION 7
#define IE_MINOR_VERSION 0
diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c
index ee386ac..16ac21e 100644
--- a/dlls/mshtml/nsembed.c
+++ b/dlls/mshtml/nsembed.c
@@ -857,8 +857,10 @@ void update_nsdocument(HTMLDocument *doc)
return;
}
-if(doc->nsdoc)
+if(doc->nsdoc) {
+remove_mutation_observer(doc->nscontainer, doc->nsdoc);
nsIDOMHTMLDocument_Release(doc->nsdoc);
+}
doc->nsdoc = nsdoc;
diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl
index 219ac0c..ef64145 100644
--- a/dlls/mshtml/nsiface.idl
+++ b/dlls/mshtml/nsiface.idl
@@ -23,7 +23,7 @@
* compatible with XPCOM, usable in C code.
*/
-cpp_quote("#define GECKO_VERSION \"0.9.0\"")
+cpp_quote("#define GECKO_VERSION \"0.9.1\"")
cpp_quote("#define GECKO_VERSION_STRING \"Wine Gecko \" GECKO_VERSION")
import "wtypes.idl";
@@ -873,6 +873,7 @@ interface nsIDOMNSDocument : nsISupports
/* Wine extensions */
nsresult WineAddObserver(nsIDocumentObserver *aObserver);
+nsresult WineRemoveObserver(nsIDocumentObserver *aObserver);
nsresult WineAddScriptRunner(nsIRunnable *aRunnable);
}
--
1.6.0.6
Re: Quick and dirty testcases for MS-DOS API?
On Wed, Feb 4, 2009 at 3:24 PM, Detlef Riekenberg wrote: > On Do, 2009-01-29 at 14:30 -0800, Dan Kegel wrote: >> but that requires the Watcom C compiler, and >> "apt-cache search watcom" still comes up empty > > There is a package with an installer: > > http://www.openwatcom.org/ftp/open-watcom-c-linux-1.8RC3 That doesn't look like a .deb. Are they going to provide .deb's and .rpm's, too?
Re: Quick and dirty testcases for MS-DOS API?
On Do, 2009-01-29 at 14:30 -0800, Dan Kegel wrote: > but that requires the Watcom C compiler, and > "apt-cache search watcom" still comes up empty There is a package with an installer: http://www.openwatcom.org/ftp/open-watcom-c-linux-1.8RC3 THe release link in the near feature might be: http://www.openwatcom.org/ftp/open-watcom-c-linux-1.8 -- By by ... Detlef
Re: Fixing AppDB once and for all
How about determining how well an individual app is represented by the test suite? The better the test suite replicates the behaviour of the app, the more likely wine is to support the app. nick *** WARNING: This e-mail (including any attachments) may contain legally privileged, confidential or private information and may be protected by copyright. You may only use it if you are the person(s) it was intended to be sent to and if you use it in an authorised way. No one is allowed to use, review, alter, transmit, disclose, distribute, print or copy this e-mail without appropriate authority. If this e-mail was not intended for you and was sent to you by mistake, please telephone or e-mail me immediately, destroy any hardcopies of this e-mail and delete it and any copies of it from your computer system. Any right which the sender may have under copyright law, and any legal privilege and confidentiality attached to this e-mail is not waived or destroyed by that mistake. It is your responsibility to ensure that this e-mail does not contain and is not affected by computer viruses, defects or interference by third parties or replication problems (including incompatibility with your computer system). Opinions contained in this e-mail do not necessarily reflect the opinions of the Queensland Department of Main Roads, Queensland Transport or Maritime Safety Queensland, or endorsed organisations utilising the same infrastructure. ***
Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar
On Wed, Feb 04, 2009 at 02:15:04PM -0600, Austin English wrote: > On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner wrote: > > Hi, > > > > Targetbuffer length must not be -1. > > > > Ciao, Marcus > > --- > > dlls/mshtml/editor.c |2 +- > > dlls/mshtml/navigate.c |2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c > > index 7cbdf2e..e92cf96 100644 > > --- a/dlls/mshtml/editor.c > > +++ b/dlls/mshtml/editor.c > > @@ -588,7 +588,7 @@ static HRESULT exec_fontname(HTMLDocument *This, DWORD > > cmdexecopt, VARIANT *in, > > > > len = MultiByteToWideChar(CP_ACP, 0, stra, -1, NULL, 0); > > strw = heap_alloc(len*sizeof(WCHAR)); > > -MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, -1); > > +MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, len); > > nsfree(stra); > > > > V_BSTR(out) = SysAllocString(strw); > > diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c > > index 188cdd7..6e41699 100644 > > --- a/dlls/mshtml/navigate.c > > +++ b/dlls/mshtml/navigate.c > > @@ -657,7 +657,7 @@ static void parse_post_data(nsIInputStream > > *post_data_stream, LPWSTR *headers_re > > else > > headers = heap_alloc((len+1)*sizeof(WCHAR)); > > > > -len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, > > headers+headers_len, -1); > > +len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, > > headers+headers_len, len); > > headers_len += len; > > > > ptr2 = ptr; > > -- > > 1.5.6 > > > > > > > > Are these coverity fixes? No, I spotted this problem while debugging something, and just looked through the sourcecode for all occurences. I think I got all of them now. CIao, Marcus
Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar
On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner wrote: > Hi, > > Targetbuffer length must not be -1. > > Ciao, Marcus > --- > dlls/mshtml/editor.c |2 +- > dlls/mshtml/navigate.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c > index 7cbdf2e..e92cf96 100644 > --- a/dlls/mshtml/editor.c > +++ b/dlls/mshtml/editor.c > @@ -588,7 +588,7 @@ static HRESULT exec_fontname(HTMLDocument *This, DWORD > cmdexecopt, VARIANT *in, > > len = MultiByteToWideChar(CP_ACP, 0, stra, -1, NULL, 0); > strw = heap_alloc(len*sizeof(WCHAR)); > -MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, -1); > +MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, len); > nsfree(stra); > > V_BSTR(out) = SysAllocString(strw); > diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c > index 188cdd7..6e41699 100644 > --- a/dlls/mshtml/navigate.c > +++ b/dlls/mshtml/navigate.c > @@ -657,7 +657,7 @@ static void parse_post_data(nsIInputStream > *post_data_stream, LPWSTR *headers_re > else > headers = heap_alloc((len+1)*sizeof(WCHAR)); > > -len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, > headers+headers_len, -1); > +len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, > headers+headers_len, len); > headers_len += len; > > ptr2 = ptr; > -- > 1.5.6 > > > Are these coverity fixes? -- -Austin
Re: mshtml: Implement IHTMLStyle_put_backgroundColor
Hi Ricardo, > hi alistair, > you say it implements the put method but the patch has only the get > method... typo? > Thanks for picking this up. It's a typo, Ill resend shortly. Best Regards Alistair Leslie-Hughes
Re: [PATCH] mshtml: call install_cab_file() with name directly on non-Wine
On Wed, Feb 4, 2009 at 1:11 PM, Marcus Meissner wrote:
> Hi,
>
> A ReactOS developer told me that if the wine_get_dos_file_name() does
> not return a function, we should just pass in the current filename
> to install_cab_file.
>
> So I coded it, but the non-UNIX path is untested.
>
> Wonder why he does not send a patch himself.
Heh maybe his Julliard ranking is not high enough. ;)
> +} else { /* ReactOS mode. */
Maybe this should say Windows mode or Mingw mode.
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
Re: bugzilla stuck?
On Wed, Feb 4, 2009 at 11:36 AM, Dan Kegel wrote: > It seems hung to me at the moment... > > > Back up now. -- -Austin
Re: bugzilla stuck?
Bugzilla is freaking out quite a bit lately. I think this is due to how much busier Bugzilla and the AppDB has become. It will usually clear up on it's own, but it takes 5 to 10 minutes. It is pretty clear that the current box can no longer handle the load. Dan Kegel wrote: > It seems hung to me at the moment... > >
bugzilla stuck?
It seems hung to me at the moment...
Re: X11DRV_XRandR_Cleanup() is not used
Francois Gouget writes: > So my question is: should this function be removed? Or should I simply > send a patch calling it from x11drv_main.c:process_detach(), enclosed > with the appropriate SONAME_LIBXRANDR? You can remove it, it doesn't do anything useful. -- Alexandre Julliard julli...@winehq.org
IPinImpl_QueryInternalConnections() is unused
dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function but it is not actually used anywhere. Is there any reason to keep it? It sort of looks like IPin is a virtual class and that IPin::QueryInternalConnections() is going to be implemented in its descendents like VfwPin as is currently the case. But then VfwPin_QueryInternalConnections() is just as much of a stub so maybe it is it that should go away? -- Francois Gouget http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.
X11DRV_XRandR_Cleanup() is not used
dlls/x11drv/xrandr.c defines a X11DRV_XRandR_Cleanup() function but it is not actually used anywhere. If I remember correctly past wine-devel emails, restoring the right XRandR mode when an application exits can be tricky (especially in case of a crash). So maybe this is why the function is not called, though I'm not sure it's even related. So my question is: should this function be removed? Or should I simply send a patch calling it from x11drv_main.c:process_detach(), enclosed with the appropriate SONAME_LIBXRANDR? -- Francois Gouget http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner
Re: Fixing AppDB once and for all
If you have interest in the future of the AppDB please make sure your ideas are in or referenced by the agenda on the wiki. I think things will go much smoother if we discuss line items from the agenda one by one rather than a random chaos. http://wiki.winehq.org/AppDBUpgrades
Re: [2/3] Add initial "write text" support for VGA graphic modes. Requires mode info unify patch
Jeremiah Flerchinger writes:
> else
> {
> - FIXME("Write %c at (%i,%i) - not yet supported in graphic modes.\n",
> (char)ascii, x, y);
> + dat = vga_fb_window_data;
> + /* get attribute values */
> + fgColor = attr & 0x0F;
> + bgColor = (attr & 0x70)>>4;
> + /* Create DC to draw font on */
> + hDC = CreateCompatibleDC(NULL);
> + if (hDC == 0)
> + {
> + ERR("CreateCompatibleDC FAILED. \n");
> + }
> + /* Create bitmap to draw font on
> + * define bitmap info {size, width, height, planes, bits, compression,
> sizeimage}
> + * origin defaults to top left. negative height makes origin at bottom
> left.
> + */
> + hTempBmp = CreateDIBSection( hDC, &bmi, DIB_RGB_COLORS,
> (void**)&pSrcData, NULL, 0 );
> + if (hTempBmp == NULL)
> + {
> + ERR("CreateDIBSection FAILED. \n");
> + }
You should actually handle the errors, not just print an ERR and go on
using invalid data.
> + /* get a font compatable to old IBM ROM (IBM extended character set)
> */
> + IBM_hFont = (HFONT) GetStockObject( OEM_FIXED_FONT );
> + GetObjectA ( IBM_hFont, sizeof(LOGFONTA), & IBM_lFont );
> + /* scale character & set attributes - FIXME tweak or make better font
> for smaller sizes */
> + IBM_lFont.lfWidth = ModeInfo->CharWidth;
> + IBM_lFont.lfHeight = ModeInfo->CharHeight;
> + /* create new font with desired properties */
> + ModIBM_hFont = CreateFontIndirectA ( & IBM_lFont );
> + if (ModIBM_hFont == NULL)
> + {
> + ERR("CreateFontIndirectA FAILED. \n");
> + }
> + SelectObject(hDC, hTempBmp);
> + SelectObject(hDC, ModIBM_hFont);
> + SetTextColor(hDC, fgColor<<16); /* set text color 0x00bbggrr */
> + SetBkColor(hDC, bgColor<<16); /* set text color 0x00bbggrr */
> + /* define where char is drawn on bitmap */
> + rect.left = 0;
> + rect.top = 0;
> + rect.bottom = ModeInfo->CharHeight-1;
> + rect.right = ModeInfo->CharWidth-1;
> + /* draw char onto temporary bitmap */
> + DrawTextHeight = DrawTextA(hDC, (char *)&ascii, 1, &rect, DT_LEFT);
> + if (DrawTextHeight == 0)
> + {
> + ERR("DrawTextA FAILED. \n");
> + }
> + /* translate from TextRow & TextCol to PixelRow & PixelCol */
> + x = x * ModeInfo->CharWidth;
> + y = y * ModeInfo->CharHeight;
> + /* translate & copy char into display buffer */
> + for (ih = 0; ih < ModeInfo->CharHeight; ih = ih+1)
Please cut down on the number of comments, there's no need to explain
what each line of code is doing, that's adding more noise than
information.
--
Alexandre Julliard
julli...@winehq.org
Re: comctl32: Save and restore colours when adding masked images
Hans Leidekker wrote: > Some lines in this patch were wrapped, please attach it like you do in > your other mails. Hans, thanks for alerting me to the problem. I resent the patch as an attachment - hopefully all is well now. Best regards, Peter Urbanec
Re: comctl32: Save and restore colours when adding masked images
Hi Peter, > This patch will save and restore the colours when adding a masked image > to ImageList. Some lines in this patch were wrapped, please attach it like you do in your other mails. -Hans
Re: mshtml: Implement IHTMLStyle_put_backgroundColor
hi alistair,
you say it implements the put method but the patch has only the get
method... typo?
regards,
ricardo
--
From: "Alistair Leslie-Hughes"
Sent: Wednesday, February 04, 2009 5:02 AM
To:
Subject: mshtml: Implement IHTMLStyle_put_backgroundColor
> Hi,
>
> Changelog:
> mshtml: Implement IHTMLStyle_put_backgroundColor
>
> Best Regards
> Alistair Leslie-Hughes
>
>
>
>
> From fde0238571c3eca78527600d846ff88add6510b0 Mon Sep 17 00:00:00 2001
> From: Alistair Leslie-Hughes
> Date: Wed, 4 Feb 2009 16:01:05 +1100
> Subject: [PATCH] Implement IHTMLStyle_put_backgroundColor
> To: wine-patches
>
> ---
> dlls/mshtml/htmlstyle.c |6 --
> dlls/mshtml/tests/dom.c |6 ++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
> index ad9d095..4964c10 100644
> --- a/dlls/mshtml/htmlstyle.c
> +++ b/dlls/mshtml/htmlstyle.c
> @@ -743,8 +743,10 @@ static HRESULT WINAPI
> HTMLStyle_put_backgroundColor(IHTMLStyle *iface, VARIANT v
> static HRESULT WINAPI HTMLStyle_get_backgroundColor(IHTMLStyle *iface,
> VARIANT *p)
> {
> HTMLStyle *This = HTMLSTYLE_THIS(iface);
> -FIXME("(%p)->(%p)\n", This, p);
> -return E_NOTIMPL;
> +TRACE("(%p)->(%p)\n", This, p);
> +
> +V_VT(p) = VT_BSTR;
> +return get_style_attr(This, STYLEID_BACKGROUND_COLOR, &V_BSTR(p));
> }
>
> static HRESULT WINAPI HTMLStyle_put_backgroundImage(IHTMLStyle *iface,
> BSTR v)
> diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
> index 62a07bc..77075fb 100644
> --- a/dlls/mshtml/tests/dom.c
> +++ b/dlls/mshtml/tests/dom.c
> @@ -2906,6 +2906,12 @@ static void test_default_style(IHTMLStyle *style)
> test_border_styles(style, str);
> SysFreeString(str);
>
> +hres = IHTMLStyle_get_backgroundColor(style, &v);
> +ok(hres == S_OK, "get_backgroundColor: %08x\n", hres);
> +ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v));
> +ok(!V_BSTR(&v), "str=%s\n", dbgstr_w(V_BSTR(&v)));
> +VariantClear(&v);
> +
> hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2,
> (void**)&style2);
> ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres);
> if(SUCCEEDED(hres)) {
> --
> 1.5.4.3
>
>
>
>
Need help for D3DXComputeSphereBounding
Hello, I am trying to implement D3DXComputerSphereBounding. The attached test cases success with a native d3dx9 but fail with a native d3dx8. Can anyone could explain why? Thanks in advance 0002-Try-of-implementation-of-D3DXComputeSphereBounding.patch Description: Binary data
Re: Fixing AppDB once and for all
On Tue, 3 Feb 2009 23:02:12 +0100 Alexander Nicolaysen Sørnes wrote: > What if we add a small questionnaire which will then pick the approprite > Gold/Silver ... rating? That what I like to see.
Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)
Dmitry Timoshkov schrieb: > "Florian Tobias Schandinat" wrote: > >> this test shows a difference between Win9X and NT. (tested on Win98SE >> and WinXP) Some apps expect the Win9X behaviour to work. I don't know >> what's the right way to fix it. Any advice or patch is welcome. > > How do that apps work under NT based Windows versions like XP or Vista? > I have to admit, that I expected it to not work on XP like a bunch of other applications I have. Tried it today and saw that it worked. (that XP machine isn't mine, so testing is a bit difficult) To summarize, this is not preventing at least this App from working at this point.
Re: winedos: Improve PIT emulation.
Alexandre Julliard schrieb: > Florian Tobias Schandinat writes: > >> +/* Convert: time counter -> PIT counter >> + * GetSystemTimeAsFileTime:1000 Hz >> + * PIT frequency: 1193182 Hz */ >> +val = (DWORD)(val - delta*1193182./1000.) % (maxval + 1); > > You should probably use QueryPerformanceCounter as it already uses the > correct frequency. Thanks, will change it and resend the patch with some minor changes.
Re: ideas and questions for implementation of MessageMode in Named Pipes
mwhaaahahah, i just came up with a _horrible_ idea :) how about: ripping out the use of unix-pipes altogether, and replacing them with tdb (trivial database) in a mmap'd file? the nice thing about tdb is that it's LGPL'd. the messages could be saved and transferred via shared memory; tdb is multi-readable / multi-writeable, and it would save a bitch-awful job of implementing a shared memory sockets emulation layer (which i _have_ seen done, once). l.
