Re: riched20: add tests for EM_FORMATRANGE
Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong with the implementation, but the test cases should be ok. Hi Lei, Pretty old patch. (June 2007) I just moved some of my VMware 'boxes' to my new laptop (laptop resolution 1024x800) and I suddenly had some failures. The resolution that VMware can use (with all those borders and the sidebar) is 1044x574. Running the tests fullscreen makes them pass again. You can replicate this by playing with the screen resolution. The smaller the resolution the more test failures. Any idea where I need to look? -- Cheers, Paul. Is this on Windows in VMWare? I'm not getting any riched20 crosstest failures here at 800x600. I can also see errors on my native XP Professional box when running at a resolution of 640x480. -- Cheers, Paul.
[RFC] winedos: Initializations fix
Have I got this right?
Thanks,
-- Andy.
---
Changelog:
winedos: Initializations fix.
diff --git a/dlls/winedos/int21.c b/dlls/winedos/int21.c
index 0c7967f..cbce913 100644
--- a/dlls/winedos/int21.c
+++ b/dlls/winedos/int21.c
@@ -2182,6 +2182,7 @@ static BOOL INT21_FileAttributes( CONTEXT86 *context,
else
{
TRACE( SET FILE CREATION DATE AND TIME, file %s\n, fileA );
+MultiByteToWideChar(CP_OEMCP, 0, fileA, -1, fileW, MAX_PATH);
handle = CreateFileW( fileW, GENERIC_WRITE,
FILE_SHARE_READ | FILE_SHARE_WRITE,
@@ -2207,8 +2208,8 @@ static BOOL INT21_FileAttributes( CONTEXT86 *context,
INT_BARF( context, 0x21 );
else
{
-TRACE( GET FILE CREATION DATE AND TIME, handle %d\n,
- BX_reg(context) );
+TRACE( GET FILE CREATION DATE AND TIME, file %s\n, fileA );
+MultiByteToWideChar(CP_OEMCP, 0, fileA, -1, fileW, MAX_PATH);
handle = CreateFileW( fileW, GENERIC_READ,
FILE_SHARE_READ | FILE_SHARE_WRITE,
Re: wined3d: fix wrong FIXME-Message
The if check isn't that correct either.
If MAX_COMBINED_SAMPLERS = 8 + 3 everything's fine too. d3d9 only supports 8
fixed function frag samplers and 3 vertex samplers at max, so even if we
can't use all GL samplers together, we're still fine if we have 11 samplers
available for the purpose of this test. This should silence the frag=16,
vertex=16, total=16 complaint on d3d10 cards
Am Samstag, 14. März 2009 15:45:58 schrieb André Hentschel:
In comment it sais: 'This is true if vsamplers + MAX_TEXTURES =
max_samplers.'
The if-query asks for MAX_TEXTURES + gl_info-max_vertex_samplers
gl_info-max_combined_samplers,which is ok.
But the FIXME then has to say that it was expected to be smaller than
max_combined_samplers.
---
dlls/wined3d/directx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c
index 2ec60d4..7c67638 100644
--- a/dlls/wined3d/directx.c
+++ b/dlls/wined3d/directx.c
@@ -912,7 +912,7 @@ static BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info
*gl_info) {
MAX_TEXTURES + gl_info-max_vertex_samplers
gl_info-max_combined_samplers) {
FIXME(OpenGL implementation supports %u vertex
samplers and %u total samplers\n,
gl_info-max_vertex_samplers,
gl_info-max_combined_samplers);
-FIXME(Expected vertex samplers + MAX_TEXTURES(=8)
combined_samplers\n);
+FIXME(Expected vertex samplers + MAX_TEXTURES(=8)
= combined_samplers\n);
if( gl_info-max_combined_samplers MAX_TEXTURES )
gl_info-max_vertex_samplers =
gl_info-max_combined_samplers - MAX_TEXTURES;
Re: wined3d: fix wrong FIXME-Message
2009/3/14 Stefan Dösinger ste...@codeweavers.com: The if check isn't that correct either. If MAX_COMBINED_SAMPLERS = 8 + 3 everything's fine too. d3d9 only supports 8 fixed function frag samplers and 3 vertex samplers at max, so even if we can't use all GL samplers together, we're still fine if we have 11 samplers available for the purpose of this test. This should silence the frag=16, vertex=16, total=16 complaint on d3d10 cards D3d9 supports 4 vertex samplers max, but that aside. In d3d10 this is not a problem either, because you don't have fixed function there. On that subject, I think it would make sense to have some flags we can pass to WineDirect3DCreate() to allow us to make some assumptions about what the d3d client library will/won't do. Eg. WINED3D_NO_FIXED_FUNCTION in case of d3d10, or something like WINED3D_STATIC_VB_DECLARATION for ddraw. This would essentially replace the dxVersion field in IWineD3DImpl.
Re: wined3d: fix wrong FIXME-Message
@Stefan Dösinger: The if check isn't that correct either. Its correct, because gl_info http://source.winehq.org/ident?i=gl_info-max_vertex_samplers in my case is 32. I think it is really enough to fix the Message.
Re: [try2] schannel/tests: Fix test on Win2k
Nicolas Le Cam wrote: Try2: This time with the patch... Win2k pro returns 1 Lsa package and 4 user packages. Mark them as broken. Also skip verification of second package's values if only one is reported. Nicolas Le Cam Hi, I did some investigations a few days ago. It looks like the comment Second package: SChannel is not correct. At least in the case of W2K3. I'm not sure if we need more checks (like Name)? -- Cheers, Paul.
[AppDB] Entry for Everquest 2
I just noticed that the entry for Everquest II, the sequel to Everquest, is listed as version 2 under Everquest in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers.
Re: Vacations
Alexandre Julliard wrote: Folks, There won't be any commits next week, as I'll be skiing... Happy skiing and stay safe and warm. James McKenzie
Re: riched20: add tests for EM_FORMATRANGE
Lei Zhang wrote: On Fri, Mar 13, 2009 at 12:01 PM, Paul Vriens paul.vriens.w...@gmail.com wrote: Lei Zhang wrote: Hi, In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE implementation and with my test cases. I'm not sure what was wrong with the implementation, but the test cases should be ok. Hi Lei, Pretty old patch. (June 2007) I just moved some of my VMware 'boxes' to my new laptop (laptop resolution 1024x800) and I suddenly had some failures. The resolution that VMware can use (with all those borders and the sidebar) is 1044x574. Running the tests fullscreen makes them pass again. You can replicate this by playing with the screen resolution. The smaller the resolution the more test failures. Any idea where I need to look? -- Cheers, Paul. Is this on Windows in VMWare? I'm not getting any riched20 crosstest failures here at 800x600. Interesting that this should fail on a VMWare workstation setup. The tests are pretty straightfoward. Also, I have not worked on this due to other pressures of life. Would someone like to take this over and finish it? This would solve a couple of open bug reports and fix some complaints about text rendering. James McKenzie
