Re: setupapi: Indentation fix
Andrew Talbot wrote: > It's a tabs vs spaces thing, but it looks way out on my system. > You might wish to ignore this patch. I had my tab stops set to four spaces instead of eight, which exaggerated the distortion. -- Andy.
RE: include: Deconstify a variable
Francois Gouget [mailto:fgou...@free.fr] wrote: > On Sat, 14 Mar 2009, Andrew Talbot wrote: > > > Correct me if I'm wrong, but I don't think MapLS() takes a > pointer to const. > [...] > > --- a/include/winbase.h > > +++ b/include/winbase.h > [...] > > -WINBASEAPI DWORD WINAPI MapLS(LPCVOID); > > +WINBASEAPI DWORD WINAPI MapLS(LPVOID); > > I could not find MapLS declared in winbase.h in any of the > SDKs I have here. However I found it in win_me/inc16/thunks.h > in an old DDK (Microsoft Windows 2000 DDK) but the declaration was: > > DWORD WINAPI MapLS(DWORD); > > But this being what looks like a 16bit include it probably > does not mean much. > > So that leaves the questions of whether my latest SDK is > recent enough (6.0.6001.18000.367-20080205), and why Wine > declares MapLS in winbase.h. According to this http://support.microsoft.com/kb/195310 it's a 16-32bit thunking only function so it may not mean much on NT based kernels at all. Maybe your SDKs are not to old but to new to contain any reference to these functions :-). Rolf Kalbermatter
Re: include: Deconstify a variable
Francois Gouget wrote: > I could not find MapLS declared in winbase.h in any of the SDKs I have > here. However I found it in win_me/inc16/thunks.h in an old DDK > (Microsoft Windows 2000 DDK) but the declaration was: > > DWORD WINAPI MapLS(DWORD); > > But this being what looks like a 16bit include it probably does not mean > much. > > So that leaves the questions of whether my latest SDK is recent enough > (6.0.6001.18000.367-20080205), and why Wine declares MapLS in winbase.h. > > MapSL(), MapLS() and UnMapLS() would appear to be undocumented functions from the Windows 95 to Windows 2000 era. The article http://support.microsoft.com/kb/195310 is very informative. I think that a const-correct function whose output pointer derives from an input pointer should only make the const promise if it will not withdraw it on return. (Thus, functions like strchr() are not const-correct.) So it seems right to me that MapLS() should take a non-const input pointer. -- Andy.
Re: [AppDB] Entry for Everquest 2
On Wed, 18 Mar 2009 15:58:00 + Ricardo Filipe wrote: > bug links are manually recoverable, searching bugzilla and linking should be > easy, i can do that if you feel you don't have time to. You can find a copy of wine appdb here http://ftp.winehq.org/pub/wine/ So someone may have a old copy of the data base.
Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.
On Wednesday 18 March 2009 22:57:45 Roderick Colenbrander wrote: >> What exactly is the issue with OpenGL on Linux? > > Under OpenGL we have the same issue these days for both Nvidia and > Ati hardware. Check http://bugs.winehq.org/show_bug.cgi?id=13335 > which contains an early version of Alexandre his patch. There are > still some issues with it (some threading one if I remember > correctly) and most importantly on 64-bit Nvidia systems there are > huge slowdowns. I have some Nvidia employee looking at that but > haven't heard back. Thanks, so it is the same problem, except that on Linux mmap fails because large portions of address space have been reserved before 0x8000, and on FreeBSD it fails because everything has been reserved after 0x8000. I still would like to see this patch committed though, to fix bug 17718, but generally because the memory reservation doesn't fix anything and only causes problems.
Re: (try 2)advapi32: base implementation of LsaLookupNames2
Thanks for doing this testing. I think I will move the check to just skip the test. That way maybe that can become the standard for that test. Looking at msdn there are several lsa functions that are xp+ only so we do not want to start blocking the tests on all previous versions also. thanks! -aric Paul Vriens wrote: Aric Stewart wrote: fix tests for win95 --- dlls/advapi32/lsa.c | 51 +++- dlls/advapi32/tests/lsa.c | 82 - 2 files changed, 131 insertions(+), 2 deletions(-) Hi Aric, Just tested this on W2K. All functions but LsaLookupNames2 are available on W2K. This means now all tests (even though there were only 6) are skipped. Not sure it's worth the effort but maybe it's better to test for the existence of LsaLookupNames2 in the appropriate test only?
Re: include: Deconstify a variable
On Sat, 14 Mar 2009, Andrew Talbot wrote: > Correct me if I'm wrong, but I don't think MapLS() takes a pointer to const. [...] > --- a/include/winbase.h > +++ b/include/winbase.h [...] > -WINBASEAPI DWORD WINAPI MapLS(LPCVOID); > +WINBASEAPI DWORD WINAPI MapLS(LPVOID); I could not find MapLS declared in winbase.h in any of the SDKs I have here. However I found it in win_me/inc16/thunks.h in an old DDK (Microsoft Windows 2000 DDK) but the declaration was: DWORD WINAPI MapLS(DWORD); But this being what looks like a 16bit include it probably does not mean much. So that leaves the questions of whether my latest SDK is recent enough (6.0.6001.18000.367-20080205), and why Wine declares MapLS in winbase.h. -- Francois Gouget http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner
Re: (try 2)advapi32: base implementation of LsaLookupNames2
Aric Stewart wrote: fix tests for win95 --- dlls/advapi32/lsa.c | 51 +++- dlls/advapi32/tests/lsa.c | 82 - 2 files changed, 131 insertions(+), 2 deletions(-) Hi Aric, Just tested this on W2K. All functions but LsaLookupNames2 are available on W2K. This means now all tests (even though there were only 6) are skipped. Not sure it's worth the effort but maybe it's better to test for the existence of LsaLookupNames2 in the appropriate test only? -- Cheers, Paul.
Re: shell32/tests: Fix a test on Win2k platform and above.
Nicolas Le Cam wrote: 2009/3/19 Paul Vriens : Nicolas Le Cam wrote: Try2: Follow Vincent Povirk's suggestion of removing calls to SetWindowLongPtr before destroying windows Could someone test this patch on Win9x or WinNT ? On Win2k (and according to test.winehq.org on above platforms) an ABN_POSCHANGED message is sent to the last window that is removed. This patch change the ok to a win_skip in this case. Tell me if you have a better solution. Nicolas Le Cam Hi, The "got unexpected ABN_POSCHANGED notification" messages I had before are now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.) -- Cheers, Paul. Thanks for your tests Paul. Same goes for Win2k. I will try to set up a Win98SE VM this week to test it. Succeeds on my Win98SE box as well (didn't before). -- Cheers, Paul.
Re: shell32/tests: Fix a test on Win2k platform and above.
2009/3/19 Paul Vriens : > Nicolas Le Cam wrote: >> >> Try2: Follow Vincent Povirk's suggestion of removing calls to >> SetWindowLongPtr before destroying windows >> >> Could someone test this patch on Win9x or WinNT ? >> >> On Win2k (and according to test.winehq.org on above platforms) an >> ABN_POSCHANGED message is sent to the last window that is removed. >> >> This patch change the ok to a win_skip in this case. >> >> Tell me if you have a better solution. >> >> Nicolas Le Cam >> >> >> >> >> > Hi, > > The "got unexpected ABN_POSCHANGED notification" messages I had before are > now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.) > > -- > Cheers, > > Paul. > Thanks for your tests Paul. Same goes for Win2k. I will try to set up a Win98SE VM this week to test it. -- Nicolas Le Cam
Re: Summer of Code 2009 is on
On Thursday 19 March 2009 00:17:34 Kai Blin wrote: > > If you're a Wine developer and you want to mentor, let me know. Actualy, the process is a little more involved. You'll have to go to http://socghop.appspot.com/ and create a user handle called "link_id", then tell me that link_id. Should have said that right away, sorry. :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. signature.asc Description: This is a digitally signed message part.
Re: [AppDB] Entry for Everquest 2
Ricardo Filipe gmail.com> writes: > as i said before, it was an uninformed decision, and yes, not enough time was >left for feedback from the maintainers.we thought that appdb WOULD save all the >data when moving, not only tests. it serves as example for us for the future, >unfortunatly with problems to the EQ2 users. as i said before, sorry for that. >at least it serves to not repeat the mistake, we hope you understand.a super >maintainer would not be able to move the data to the new application, only >appdb >admins have that power.votes cannot be restored automatically, people will have >to vote on the new page.bug links are manually recoverable, searching bugzilla >and linking should be easy, i can do that if you feel you don't have time to. Mistakes happen, and I apologize for the irritated undertones of my messages. In the end it was the right thing to do anyways. Any help anybody could provide on tracking down and linking bugs is much appreciated. I'll try and do what I can as time permits. Thanks again for the explanation and the help. :)
Re: shell32/tests: Fix a test on Win2k platform and above.
Nicolas Le Cam wrote: Try2: Follow Vincent Povirk's suggestion of removing calls to SetWindowLongPtr before destroying windows Could someone test this patch on Win9x or WinNT ? On Win2k (and according to test.winehq.org on above platforms) an ABN_POSCHANGED message is sent to the last window that is removed. This patch change the ok to a win_skip in this case. Tell me if you have a better solution. Nicolas Le Cam Hi, The "got unexpected ABN_POSCHANGED notification" messages I had before are now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.) -- Cheers, Paul.
