re: DIB engine
On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote: Stephan Rose wrote: My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say Hey, this is what we are missing/need, here are the specs, go implement. ... So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on... I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now. If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked. Ok, then judging from the last few posts i'll leave DIB be for now seeing how there still seems to be some figuring out to do and I'll check into gdiplus missing bits sometime next week. :) Thanks, Stephan
Re: Its Alive! Patchwatcher is reborn.
On Sun, May 31, 2009 at 3:27 AM, Kai Blin kai.b...@gmail.com wrote: On Sunday 31 May 2009 09:05:36 Zachary Goldberg wrote: All, As you may have noticed in the last WWN I have been working on getting patchwatcher back up on a rather nice server whose cpu time is graciously donated by STWing (stwing.org). I've got it running at the moment at http://winepatch.stwing.upenn.edu/results2/ The most notable issue is that most patches fail to apply and apply claims they're reversed patches. Are you sure you're using git am the right way? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. The code wasn't correctly checking for previously applied patches. Does it look more reasonable now in the number of patch application failures? -Zach
Re: DIB engine
Stephan Rose wrote: On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote: Stephan Rose wrote: My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say Hey, this is what we are missing/need, here are the specs, go implement. ... So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on... I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now. If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked. Ok, then judging from the last few posts i'll leave DIB be for now seeing how there still seems to be some figuring out to do and I'll check into gdiplus missing bits sometime next week. :) Thanks, Stephan I suppose this is as good a time as any to introduce myself. My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.
Re: DIB engine
On Sun, May 31, 2009 at 11:16 AM, Andrew and...@brightnightgames.com wrote: My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future. Welcome to Wine! Be sure when sending patches to break them into small sets, with one change per patch. It makes it much easier to review that way, and if your patch causes a regression, much easier to identify which part if it's in multiple patches. -- -Austin
re: Its Alive! Patchwatcher is reborn.
Congratulations! It's nice to see it running again! Are you running it all on one node, or are you using the distributed mode? Have you been watching patchwatcher's mailbox for partial patch series? That was the biggest chore of running Patchwatcher. At one point they blocked the pipeline of incoming patches, not sure if I fixed that. Having patches back up is bad because they rapidly go stale. - Dan
Re: DIB engine
Austin English wrote: On Sun, May 31, 2009 at 11:16 AM, Andrew and...@brightnightgames.com wrote: My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future. Welcome to Wine! Be sure when sending patches to break them into small sets, with one change per patch. It makes it much easier to review that way, and if your patch causes a regression, much easier to identify which part if it's in multiple patches. Thanks for the welcome! I am definitely doing small commits and following the WineGit wiki page. One concern I have is that the number of patches will probably be over 50 or even 75 -- I'm not sure if it'd be better to submit them all in one go as they're pretty much all alike (just stubbing), or just do batches of 5-10 every couple days as I finish them (so it's not a deluge of patches). Any suggestions?
Re: DIB engine
On Sun, May 31, 2009 at 2:11 PM, Andrew Eikum and...@brightnightgames.com wrote: I am definitely doing small commits and following the WineGit wiki page. One concern I have is that the number of patches will probably be over 50 or even 75 -- I'm not sure if it'd be better to submit them all in one go as they're pretty much all alike (just stubbing), or just do batches of 5-10 every couple days as I finish them (so it's not a deluge of patches). Any suggestions? No need to wait, go ahead and submit a couple. Since you're new to wine, it may take a couple days for them to get committed. Once you've got your feet wet and a few patches submitted, go ahead and submit a few more (5-10) a day. Try to avoid flooding wine-patches. The patches don't depend on each other, and it's not a huge rush to get them all in. And no need to wait to stub everything before sending implementations. If you've got it ready, and it works (add testcases to verify), send it in. Don't sit on your good patches, share them with everyone else :-). -- -Austin
Re: DIB engine
On Sun, May 31, 2009 at 12:45 AM, Stephan Rose ker...@somrek.net wrote: If you're looking for something better specified, try finishing off gdiplus. ... I'll check into gdiplus missing bits sometime next week. :) My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. Excellent! (And Stephan, there's more than enough work to go around, don't worry that Andrew's going to do it all :-) After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future. That's great to hear. Looking forward to seeing your patches. BTW, don't forget to look at http://wiki.winehq.org/GdiPlus, which has a few notes that might be helpful. My archive of Lei's notes at http://kegel.com/wine/sweng/2008/project.html from last year might be useful, too - it was tailored for people new to wine who want to contribute to gdiplus. (Though its big list of bugs is mostly all fixed now, I think only four remain.) - Dan
Re: Its Alive! Patchwatcher is reborn.
On Sun, May 31, 2009 at 2:59 PM, Dan Kegel d...@kegel.com wrote: Congratulations! It's nice to see it running again! Are you running it all on one node, or are you using the distributed mode? I am using the distributed version of the code but for now its just on one machine. I was actually able to get it mostly working using just the provided wine-slave and master.sh. Over the summer I will look into seeing if I can scale it out a bit to a dedicated linux /|| windows slave . It seems plenty fast enough to keep up with wine-patches running just in Wine for now. Have you been watching patchwatcher's mailbox for partial patch series? That was the biggest chore of running Patchwatcher. At one point they blocked the pipeline of incoming patches, not sure if I fixed that. Having patches back up is bad because they rapidly go stale. - Dan I have seen the stale problem (I had the mailbox enabled several days before I let it start processing patches...). I haven't been but will now look out for a partial series. I will be away for the next 2 weeks starting Wednesday so there is a high probability it hangs sometime while I'm gone. It'll provide a good test case when I'm back to try and find a solution in-code =P -Zach
Re: DIB engine
On Sun, 2009-05-31 at 12:23 -0700, Dan Kegel wrote: On Sun, May 31, 2009 at 12:45 AM, Stephan Rose ker...@somrek.net wrote: If you're looking for something better specified, try finishing off gdiplus. ... I'll check into gdiplus missing bits sometime next week. :) My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. Excellent! (And Stephan, there's more than enough work to go around, don't worry that Andrew's going to do it all :-) Hahaha, not worried. Btw, I seem to have a handle on the stringformat alignment bug. By the looks of it I may have a patch for that sometime over the next couple days. Don't know if I will make it today as I have a roughly 5'6 brunette incentive to do something other than write code tonight. :) Stephan
Re: winecfg: Update WinXP version to SP3
On Sun, May 31, 2009 at 1:36 PM, Vitaliy Margolen wine-patc...@kievinfo.com wrote: --- programs/winecfg/appdefaults.c | 2 +- tools/wine.inf.in | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) You forgot to update ntdll/version.c -- -Austin
How Not To Develop On Windows
http://pdh11.blogspot.com/2009/05/how-not-to-develop-on-windows.html is a partial guide to developing Windows GUI apps on Linux using mingw and test them with Wine. Seems like an expanded version of this might belong on the Wine wiki...
Re: Changing default severity in Bugzilla to Normal
2009/5/29 John Klehm xixsimplicity...@gmail.com: On Thu, May 28, 2009 at 1:40 PM, Ken Sharp kennyb...@o2.co.uk wrote: It seems the default severity, enhancement, invites people to select a REALLY SEVERE sounding level instead. I suggest changing the default severity to normal in the hopes of cutting down on the yelling. http://bugs.winehq.org/show_bug.cgi?id=13363 Makes sense to me. It was discussed on that annoying thread about changing severity levels to Low, Medium, High and Critical. Consensus seemed to be that changing the default severity to Normal was a good idea. +1
Remove FIXME keyword from bugzilla
It serves no purpose, after all, 'FIXME's are not bugs'. -- -Austin
Installing ActivePython screws up PATH in Wine?
In Wine, I can happily install mingw and add it to the global PATH by editing the registry key PATH in [System\\CurrentControlSet\\Control\\Session Manager\\Environment] However, once I install ActivePython, something gets screwed up, and from then on, 'PATH' in CMD says PATH=C:\Python26\;;C:\Python26\; even if I remove that bit from that registry key and add other directories. Anyone know what the heck is going on?
Re: Its Alive! Patchwatcher is reborn.
On Sun, May 31, 2009 at 12:05 AM, Zachary Goldberg zg...@bluesata.com wrote: All, As you may have noticed in the last WWN I have been working on getting patchwatcher back up on a rather nice server whose cpu time is graciously donated by STWing (stwing.org). I've got it running at the moment at http://winepatch.stwing.upenn.edu/results2/ There are still many, many kinks to be worked out before I would use this as reliable and/or before I even think about enabling sending to patch authors. But if you're curious thats where the results are going and will likely be in the future. -Zach p.s. Kudos to Dan Kegel for a great walkthrough in the PW readme.txt, and of course for putting patchwatcher together in the first place! Speaking of pre-commit checking, the Wine wiki page for patchwatcher page [1] currently list the following todo items: Check for C++ comments. Check for nameless unions (GCC 2.95). Check for missing \ns in traces/fixmes/etc. Make sure sizeof is not used in traces. These sound like things we can catch with a git pre-commit hook, so developers who use git can fix these even before it hits patchwatcher. [1] http://wiki.winehq.org/PatchWatcher
