Re: Wineboot crashes after upgrading Gecko.
Jacek Caban wrote: Alexandre has found the problem. Commenting FreeLibrary call in close_gecko fixes the problem. Jacek Ok. So do you plan to fix it?
Re: [5/5] WineD3D: Replace the dxVersion with behavior flags
The idea is good, but this needs to be split up.
Re: [5/5] WineD3D: Replace the dxVersion with behavior flags
Am Wednesday 05 August 2009 08:53:19 schrieb Henri Verbeet: The idea is good, but this needs to be split up. You sure? Its a 370 line patch, and I am more worried about fake regressions by having two systems in parallel than regressions of doing this in one big step.
Re: [5/5] WineD3D: Replace the dxVersion with behavior flags
2009/8/5 Stefan Dösinger ste...@codeweavers.com: Am Wednesday 05 August 2009 08:53:19 schrieb Henri Verbeet: The idea is good, but this needs to be split up. You sure? Yes.
Re: shlwapi: Correct AssocCreate Tests
Hello Alistair, Alistair Leslie-Hughes wrote: diff --git a/dlls/shlwapi/tests/assoc.c b/dlls/shlwapi/tests/assoc.c index fd2b868..9a52edb 100644 --- a/dlls/shlwapi/tests/assoc.c +++ b/dlls/shlwapi/tests/assoc.c @@ -252,11 +252,13 @@ static void test_assoc_create(void) ok(hr == E_INVALIDARG, Unexpected result : %08x\n, hr); hr = pAssocCreate(CLSID_QueryAssociations, IID_NULL, (LPVOID*)pqa); -ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */ +ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */ + hr == E_NOINTERFACE , Unexpected result : %08x\n, hr); this looks ugly; the 2 lines can be joined into one without exceeding 80 chars in width. hr = pAssocCreate(IID_NULL, IID_IQueryAssociations, (LPVOID*)pqa); -ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */ +ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */ + hr == E_INVALIDARG , Unexpected result : %08x\n, hr); Same here. hr = pAssocCreate(CLSID_QueryAssociations, IID_IQueryAssociations, (LPVOID*)pqa); bye michael
Re: Interesting find with cppcheck..
Francois Gouget fgou...@free.fr writes: On Tue, 4 Aug 2009, Juan Lang wrote: Still wouldn't hurt to fix them. Well, Alexandre routinely rejects such fixes. It may be worth reconsidering. Just like if you have hundreds of compilation warnings the useful ones get lost in the sea, if such these tools report too many valid leaks, it will be hard to notice the important ones, or the new leaks. In any case I see no reason not to fix those in the conformance tests. Yes they may take a few extra milliseconds to run, but they are not performance critical anyway. If there are real leaks in the tests, then they should be fixed, but hacking the code to silence false positives is not a good idea. There are more and more analysis tools out there, we can't add workarounds for every limitation of every tool. False positives should be reported to the tools authors instead. -- Alexandre Julliard julli...@winehq.org
RE: golly, mime type integration DOES work...
Dan Kegel wrote: [Visual Studio 2005] Repainting after scrolling was a bit lazy, and creating a new project still requires ie6, but it was a nice surprise all the same. I wouldn't be too surprised if that was a VS2005 bug, not a Wine issue -- it also has horrendous redraw problems running under Vista with Aero/DWM, for instance. http://forums.asp.net/p/1088151/1624585.aspx is an example complaint I found when doing a is this just me? search last year. Regards, Ben A L Jemmett. http://flatpack.microwavepizza.co.uk/
Re: golly, mime type integration DOES work...
On Wed, Aug 5, 2009 at 2:49 AM, Ben A L Jemmettben.jemm...@ukonline.co.uk wrote: [Visual Studio 2005] Repainting after scrolling was a bit lazy, and creating a new project still requires ie6, but it was a nice surprise all the same. I wouldn't be too surprised if that was a VS2005 bug, not a Wine issue -- it also has horrendous redraw problems running under Vista with Aero/DWM, for instance. http://forums.asp.net/p/1088151/1624585.aspx is an example complaint I found when doing a is this just me? search last year. The laziness isn't too bad - it's in the text area, happens when scrolling, and clears itself within a tenth of a second. We're probably just not handling bitblt fast enough, or something? - Dan
Re: golly, mime type integration DOES work...
On Wed, Aug 5, 2009 at 2:35 PM, Dan Kegeld...@kegel.com wrote: On Wed, Aug 5, 2009 at 2:49 AM, Ben A L Jemmettben.jemm...@ukonline.co.uk wrote: [Visual Studio 2005] Repainting after scrolling was a bit lazy, and creating a new project still requires ie6, but it was a nice surprise all the same. I wouldn't be too surprised if that was a VS2005 bug, not a Wine issue -- it also has horrendous redraw problems running under Vista with Aero/DWM, for instance. http://forums.asp.net/p/1088151/1624585.aspx is an example complaint I found when doing a is this just me? search last year. The laziness isn't too bad - it's in the text area, happens when scrolling, and clears itself within a tenth of a second. We're probably just not handling bitblt fast enough, or something? - Dan What version of Wine and display drivers are you using? In 1.1.26 I added a bunch of XRender related patches to accelerate already big chunks of bitblt (less roundtrips to X are needed). In some situations it can already boost performance a lot depending on the display drivers. There are more bitblt improvements possible though. For example in case of SRCCOPY, which is the most common blit operation, I can save a 'memcpy' by getting rid of an intermediate buffer. I have some more patches which can dramatically improve rendering performance soon in cases where programs hit dibsection depth conversion. I can't easily say what is making Visual Studio slow but I guess it is a combination of slow drivers (fglrx is quite slow) and bitblt slowness. Roderick
re: cmd: add initial ipconfig
Isn't ipconfig supposed to be external? This change won't help any app that tries to run ipconfig.exe... - Dan
Latency as of yesterday
I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for fun I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.)
Re: Interesting find with cppcheck..
chris ahrendt wrote: Austin English wrote: On Tue, Aug 4, 2009 at 2:07 PM, Juan Langjuan.l...@gmail.com wrote: If the group wants I can run this daily when I run wine test as well.. and post it here just let me know Probably not. Most of the remaining leaks are in the tests or the tools. Since these are short-lived programs, the leaks will get plugged as soon as the programs end anyway. The only exception is the ntdll one, and it only happens when ntdll can't connect to the wineserver, and the process is dying anyway. Still wouldn't hurt to fix them. It may not be worth running daily, but perhaps weekly and see if anything new pops up. Ok will run it weekly then on fridays or want me to do it on major release's? chris How about just before major releases? ;) Thanks, Scott Ritchie
Re: comdlg32: fix problems in calculation of the size of a file dialog. (try 2)
Rein Klazes w...@online.nl writes: fixes bug#17748 try 2: I forgot adding the rc file. It doesn't work here: ../../../tools/runtest -q -P wine -M comdlg32.dll -T ../../.. -p comdlg32_test.exe.so filedlg.c touch filedlg.ok filedlg.c:352: Test failed: testid 0: dialog should not have a WS_SIZEBOX style. filedlg.c:352: Test failed: testid 1: dialog should not have a WS_SIZEBOX style. make[2]: *** [filedlg.ok] Error 2 -- Alexandre Julliard julli...@winehq.org
configure can't find libgsm development files, but they are installed
Since yesterday, configure has been giving me a libgsm development files not found warning even though they are installed on my system. This is on openSUSE 11.1, 32 bit. Is anyone else seeing this, or is something borked on my system? (Any hints as to where I might look would be appreciated.) -- Rosanne DiMesio dime...@earthlink.net
Re: configure can't find libgsm development files, but they are installed
Rosanne DiMesio wrote: Since yesterday, configure has been giving me a libgsm development files not found warning even though they are installed on my system. This is on openSUSE 11.1, 32 bit. Is anyone else seeing this, or is something borked on my system? (Any hints as to where I might look would be appreciated.) Hi, Rosanne. Installing libgsm1-dev version 1.0.12-1 from Debian 5.0 repo works for me. config.log snip: --- configure:5894: checking gsm.h usability configure:5911: gcc -c -g -O2 conftest.c 5 configure:5918: $? = 0 configure:5932: result: yes configure:5936: checking gsm.h presence configure:5951: gcc -E conftest.c configure:5958: $? = 0 configure:5972: result: yes configure:6005: checking for gsm.h configure:6014: result: yes ---
Re: Latency as of yesterday
Susan Cragin wrote: I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for fun I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan Ubuntu has bugs open for sound issues with the newer kernels. (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) Is there a bug logged for this?
Re: Latency as of yesterday
Susan Cragin wrote: I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for fun I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan Ubuntu has bugs open for sound issues with the newer kernels. (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) Is there a bug logged for this? Yes and yes. I looked at the bunch of Ubuntu bugs relating to sound with the newest kernel. There was nothing right on point, so I filed on of my own. 409395. The alsa bug is: 407970 Bottom line -- no working sound in wine right now, that I can figure out. At all. In addition, purging pulseaudio has just gotten much more difficult, as of the last couple of days. I tried yesterday. Directions that worked 2 weeks ago now cause desktop to be removed. (I had to re-install system.)
Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill johan.g...@gmail.com wrote: This patch fixes bug 17215. Since the patch was seemingly dropped, I made some test improvements and resubmit it. The tests pass on Windows XP, and of course Wine. Suggested changelog: In DirectDraw fullscreen mode, make sure the fullscreen window is resized when the display mode changes Johan Gill Since I heard nothing on this, I make a request here /Johan Gill
Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
Am Wednesday 05 August 2009 18:58:42 schrieb Johan Gill: On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill johan.g...@gmail.com wrote: This patch fixes bug 17215. Since the patch was seemingly dropped, I made some test improvements and resubmit it. The tests pass on Windows XP, and of course Wine. Suggested changelog: In DirectDraw fullscreen mode, make sure the fullscreen window is resized when the display mode changes Sorry, I haven't noticed the patch earlier. Please nadd the component the patch addresses in topic, for example ddraw: Resize fullscreen win... - that makes them more visible for me when I look for ddraw/d3d related patches. As for the patch itself WineD3D.dll already has similar window resize code. Do you know why it doesn't resize the window, and if we can make wined3d do this job?
Re: Latency as of yesterday
I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for fun I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan Ubuntu has bugs open for sound issues with the newer kernels. (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) Is there a bug logged for this? Yes and yes. I looked at the bunch of Ubuntu bugs relating to sound with the newest kernel. There was nothing right on point, so I filed on of my own. 409395. The alsa bug is: 407970 Bottom line -- no working sound in wine right now, that I can figure out. At all. In addition, purging pulseaudio has just gotten much more difficult, as of the last couple of days. I tried yesterday. Directions that worked 2 weeks ago now cause desktop to be removed. (I had to re-install system.) The problem has been identified. Stay tuned. This is probably due to a libasound2-plugins and pulseaudio/rtkit skew; the latest libasound2-plugins needs at least pulseaudio 1:0.9.16~test3 and rtkit 0.3. Karmic has an older version of pulseaudio (1:0.9.15) at the moment.
Re: Interesting find with cppcheck..
Scott Ritchie wrote: chris ahrendt wrote: Austin English wrote: On Tue, Aug 4, 2009 at 2:07 PM, Juan Langjuan.l...@gmail.com wrote: If the group wants I can run this daily when I run wine test as well.. and post it here just let me know Probably not. Most of the remaining leaks are in the tests or the tools. Since these are short-lived programs, the leaks will get plugged as soon as the programs end anyway. The only exception is the ntdll one, and it only happens when ntdll can't connect to the wineserver, and the process is dying anyway. Still wouldn't hurt to fix them. It may not be worth running daily, but perhaps weekly and see if anything new pops up. Ok will run it weekly then on fridays or want me to do it on major release's? chris How about just before major releases? ;) Thanks, Scott Ritchie Ok what I will try and do is when . releases go out I will run them and post the results here chris
Re: Latency as of yesterday
Susan Cragin wrote: I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for fun I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) As you noted, this is likely a kernel configuration issue. It's quite easy to mess up a kernel as far as pulse latency is concerned. Thanks, Scott Ritchie
Re: [Bug 19522] Team Fortress 2 (TF2) missing menu fonts
--- Comment #3 from Alexandre Julliard julliard at winehq.org 2009-08-04 13:19:16 --- Please don't suggest that people use the --enable-maintainer-mode flag, that's not meant for normal users. Then how can we be sure user have all requirements installed? --verbose doesn't complain about everything which makes it kind of useless. Vitaliy.
Re: Interesting find with cppcheck..
Scott Ritchie wrote: chris ahrendt wrote: Austin English wrote: On Tue, Aug 4, 2009 at 2:07 PM, Juan Langjuan.l...@gmail.com wrote: If the group wants I can run this daily when I run wine test as well.. and post it here just let me know Probably not. Most of the remaining leaks are in the tests or the tools. Since these are short-lived programs, the leaks will get plugged as soon as the programs end anyway. The only exception is the ntdll one, and it only happens when ntdll can't connect to the wineserver, and the process is dying anyway. Still wouldn't hurt to fix them. It may not be worth running daily, but perhaps weekly and see if anything new pops up. Ok will run it weekly then on fridays or want me to do it on major release's? chris How about just before major releases? ;) I personally like the once a week idea. Gives developers time to fix some of the leaks before the release goes out. James McKenzie
