Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)
On Tue, 25 Aug 2009, Paul Chitescu wrote: [...] > > +courier-1250-96-13.fnt > [...] > > +system-950-96-16.fnt > > Git knows shell glob patterns so why not just a line: > > *.fnt Because that's less accurate. In particular, if we remove a font, the corresponding .fnt file would still be ignored. -- Francois Gouget http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service
Re: tools/wine.inf: fix New Zealand DST
"Austin English" wrote: Two points: 1. These data are auto generated. Where from? The program is attached to http://www.winehq.org/pipermail/wine-patches/2008-March/052474.html 2. Existing data for New Zealand Standard Time,"TZI" do match what XP SP3 has, a new one doesn't. http://www.winehq.org/pipermail/wine-users/2009-August/059237.html That FIXME is harmless. I don't see an indication that date/time APIs return wrong results for him. A test would be to run notepad and press F5. -- Dmitry.
Re: tools/wine.inf: fix New Zealand DST
On Tue, Aug 25, 2009 at 10:07 PM, Dmitry Timoshkov wrote: > "Austin English" wrote: > >> Reported in wine-users. > > Two points: > 1. These data are auto generated. Where from? > 2. Existing data for New Zealand Standard Time,"TZI" do match what > XP SP3 has, a new one doesn't. http://www.winehq.org/pipermail/wine-users/2009-August/059237.html -- -Austin
Re: tools/wine.inf: fix New Zealand DST
"Austin English" wrote: Reported in wine-users. Two points: 1. These data are auto generated. 2. Existing data for New Zealand Standard Time,"TZI" do match what XP SP3 has, a new one doesn't. -- Dmitry.
Re: [RFC] Adding an OpenAL DLL thunk
On Tuesday 25 August 2009 6:40:30 am Stefan Dösinger wrote:
> I'll give it a try with my games. The old thunk from a while ago already
> worked very will with those games.
>
> OpenAL seems to have an extension system like opengl. If there is a
> function that returns an extension string we'll want to remove any
> extension our thunk doesn't know about. However, I can't find any such
> function, but I only did a very quick search
There are functions for both the extension string, and for checking individual
extensions (eg. alcGetString(device, ALC_EXTENSIONS) /
alGetString(AL_EXTENSIONS) return a GL-like list of extensions for ALC and AL
respectively, and alcIsExtensionPresent(device, "foo") /
alIsExtensionPresent("foo") says if extension 'foo' is supported).
However, I don't like the idea of white-listing extensions. IMO, it would be
better to print a FIXME (as it currently does), and add any functions that get
found. Often times it's just new enum tokens, and it would be silly to block
them out because the thunk isn't aware of them.
Re: about video memory detection in wine
I'm sure what will happen to the GL_ATI_meminfo but perhaps it makes sense to unify it with WGL_AMD_gpu_association ? Roderick
Re: [1/5] user32:edit Use a dialog mode after receiving WM_GETDLGCODE message.
Hi Sergey, one very minor comment on this patch: +len = SendMessage(hwEdit, WM_GETTEXTLENGTH, 0, 0); +ok(13 == len, "expected 11, got %d\n", len); Nit: you mean "expected 13", not 11. The same is true for every instance where 13 is the expected length. --Juan
Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)
On Tuesday 25 August 2009 19:27:23 Kirill Smelkov wrote: > Signed-off-by: Kirill Smelkov > --- > fonts/.gitignore | 58 > ++ 1 files changed, 58 > insertions(+), 0 deletions(-) > > diff --git a/fonts/.gitignore b/fonts/.gitignore > index a857f0d..523a9a4 100644 > --- a/fonts/.gitignore > +++ b/fonts/.gitignore > @@ -37,3 +37,61 @@ > /vgasysg.fon > /vgasysr.fon > /vgasyst.fon > + > +courier-1250-96-13.fnt [...] > +system-950-96-16.fnt Git knows shell glob patterns so why not just a line: *.fnt http://www.kernel.org/pub/software/scm/git/docs/gitignore.html
Re: [RFC] Adding an OpenAL DLL thunk
I'll give it a try with my games. The old thunk from a while ago already worked very will with those games. OpenAL seems to have an extension system like opengl. If there is a function that returns an extension string we'll want to remove any extension our thunk doesn't know about. However, I can't find any such function, but I only did a very quick search
Re: shdocvw.inf: add default registry key HKCU, "Software\Microsoft\Internet Explorer\Settings
"Louis. Lenders" writes: > @@ -142,6 +142,7 @@ > HKLM,"Software\Microsoft\Windows\CurrentVersion\URL\Prefixes","www",,"http://"; > [Settings.Reg] > HKCU,"Software\Microsoft\Internet Explorer\Main","Start > Page",2,"http://www.winehq.org"; > HKCU,"Software\Microsoft\Internet Explorer\Main","Search > Page",2,"http://www.google.com"; > +HKCU,"Software\Microsoft\Internet Explorer\Settings",,,"" This will create an empty value that doesn't exist on Windows. Please create a proper value instead. -- Alexandre Julliard julli...@winehq.org
Re: mapi32/tests: Skip tests if no default email client is installed
+static BOOL HaveDefaultMailClient() this should be +static BOOL HaveDefaultMailClient(void) A+ -- Eric Pouech
winemp3.acm: link to system libmpg123.so
im getting undefined references to mpg123_feedseek. im on amd64, building a 32 bit wine, so of course i have a 32 bit lib of mpg123 around, which however seems to export mpg123_feedseek_64 instead. could that be covered too please? (i have reports that this is happening on plain x86 boxes too.) Robert
Re: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior
Jeff Zaroyko writes: > What is incorrect is that GetLocaleInfo is reading the override from > the registry which it should not do hence the special casing where the > value of sLanguage as a profile or registry entry is not the > corresponding value for LOCALE_SLANGUAGE, but the corresponding value > for LOCALE_SABBREVLANGNAME. In retrospect this is a side issue and > probably requires further questioning of the existing way overrides > are handled. My point is that "sLanguage" apparently means LOCALE_SABBREVLANGNAME instead of LOCALE_SLANGUAGE, so you can just change that mapping and everything should work fine. I don't see why you'd need a special case for it. -- Alexandre Julliard julli...@winehq.org
Re: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior
On Mon, Aug 24, 2009 at 9:22 PM, Alexandre Julliard wrote: > Jeff Zaroyko writes: > >> This fixes bug 15181, test included - passes on Windows 95, 2003, XP, >> 2008, Vista and Windows 7 beta that I've tested. >> >> From 52ff2d29ba9fbffbe8da46a7523338e8b946bbcd Mon Sep 17 00:00:00 2001 >> From: Jeff Zaroyko >> Date: Sun, 23 Aug 2009 12:38:17 +1000 >> Subject: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows >> behavior >> >> As a Profile entry and under Control Panel\International sLanguage is not >> LOCALE_SLANGUAGE but instead appears to be LOCALE_SABBREVLANGNAME. >> >> I've verified this is the case for 95, XP, 2003, 2008, Vista and Win 7. >> >> With the sLanguage override set GetLocaleInfo for LOCALE_SLANGUAGE still >> returns the LOCALE_SLANGUAGE string and not the "override", which suggests >> that the Control Panel\International sLanguage override should be ignored >> by GetLocaleInfo for LOCALE_SLANGUAGE. > > You shouldn't need any special casing for this, just change the existing > mappings to use the appropriate value. > I don't see why the mapping should be changed, the one for get_locale_value_name is correct. The nls mappings are also correct. What is incorrect is that GetLocaleInfo is reading the override from the registry which it should not do hence the special casing where the value of sLanguage as a profile or registry entry is not the corresponding value for LOCALE_SLANGUAGE, but the corresponding value for LOCALE_SABBREVLANGNAME. In retrospect this is a side issue and probably requires further questioning of the existing way overrides are handled. I've submitted a patch that creates the correct registry and profile entry, which fixes the first issue and submit a test marked todo_wine for the second issue. Jeff
