Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE

2009-09-26 Thread Detlef Riekenberg 
On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote:
 * sti: test behavior of creation with the A/W functions versus
 STI_VERSION_FLAG_UNICODE

Using the name sti_tests is bad. The short sti is enough.
You forgot the license notice
We usually cast the result of GetProcAddress() as (void *).
That is not perfect, but much better to read.

-- 
 
By by ... Detlef

Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation

2009-09-26 Thread Detlef Riekenberg 
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote:
 +todo_wine ok(SUCCEEDED(hres), get_hash failed: 0x%08x\n,
 hres);
 +if(SUCCEEDED(hres)){
 +if(str_pass)
 +ok(strcmp_wa_null(str, exp) == 0, expected retrieved
 hash to be L\%s\, was: %s\n, exp, wine_dbgstr_w(str));
 +else
 +todo_wine ok(strcmp_wa_null(str, exp) == 0, expected
 retrieved hash to be L\%s\, was: %s\n, exp, wine_dbgstr_w(str));
 +}
 +}
 +

Your Patch is hard to read.
Please split the long lines (3 parts are easy)
The whole patch can be split in smaller patches.


 +static void perform_test(const struct location_test* test)

In the case of a test failure or a crash, there is no chance to know,
which test-set failed.

A suffix (protocol name or line number) at the start of every
ok() can be used to make the normal output as silent as possible.

Using a trace before you call perform_tests() works also.
That produce a bit noise in the result file, but the test binary is
smaller.



-- 
 
By by ... Detlef

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Juan Lang 
Hi Wilfried, minor comment on this patch:

 hBitTemp = SelectObject( hMemDC, hXorBits );
+
+UINT bltFlag = 0;

C89 doesn't allow you to mix code and declarations like this.  You'll
have to declare bltFlag at the top of the block.
--Juan

Appinstall now supports standalone testing

2009-09-26 Thread Austin English 
Howdy all,

I've tweaked appinstall slightly so that anyone can run it without
needing an ssh webserver to host the files. Simply do:
$ wget http://winezeug.googlecode.com/svn/trunk/appinstall/appinstall.sh
$ sh appinstall.sh

That will download all the programs and run the tests. The results
will be stored in `cwd`/appinstall-$date. Subsequent test runs of
course will have the downloads cached, so they'll be much quicker.

A couple things to note: you can change the tag name by doing:
$ sh appinstall.sh tagname

The result directory will then be `cwd`/appinstall-tagname.

Lastly, you can override the version of wine used with:
$ WINE=~/wine-git/wine sh appinstall.sh

So now you have no excuse not to test your dangerous patches before
sending to wine-patches ;-).

-- 
-Austin

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Vitaliy Margolen 
Wilfried Pasquazzo wrote:
 Best regards,
 
 Subject: Make DrawIconEx 2 additional tests (now passes all tests)
 Subject: Make DrawIconEx pass a test

You should really combine these 2 patches. You are modifying the same exact
code and breaking it between patches (for some programs).

Vitaliy.