Re: A Handle Cache?
On 06/09/2010 04:54 PM, Max TenEyck Woodbury wrote: > While Reading the developer's guide, I noticed that it said that > translating windows' handles was always done by the server. I may have > misunderstood this. Since interaction between the client and server > requires at least two context switches and context switches are fairly > heavy duty operations, would it make sense to cache handle lookups on > the client? You haven't read all the manual it seems. Wine already does cache file descriptors - the only piece of information related to handles that clients can cache. Everything else is inter-process and can't be cached / handled in client. Vitaliy.
A Handle Cache?
While Reading the developer's guide, I noticed that it said that translating windows' handles was always done by the server. I may have misunderstood this. Since interaction between the client and server requires at least two context switches and context switches are fairly heavy duty operations, would it make sense to cache handle lookups on the client?
Re: gameux.dll implementation stub
Am 08.06.2010 12:56, schrieb Mariusz Pluciński: Hello As you maybe know, I'm working on implementation of Game Explorer in the Google Summer of Code. Main part of my work is now implementing gaming APIs stored in gameux.dll library. I already sent patches with headers, and I'm currently in the stage when stubs are ready to start real implementation. Unfortunately (for me) Wine is now in freeze stage, so I can't send patches with new library to wine-patches. Instead, Vincent Povirk suggested me to send them here to get feedback. It's very important to me to know is my way of implementation valid, cause changing something now is probably easier than modifying it in future. Attached patches creates initial implementation of gameux library, adds implementation of IClassFactory interface and stubs of four interfaces' implementations: IGameExplorer, IGameExplorer2, IGameStatistics and IGameStatisticsMgr. They also add initial tests for each interface. Each test now checks behavior of CoCreateInstance function while trying to create given interface. To create library, I used parts of code created by Alistair Leslie-Hughes, attached by him to bug 21261. Thanks in advance Hi Mariusz, It looks like you are mixing tabs and spaces. I guess spaces are always preferred, since tabs could be equal to 4 or 8 spaces (or any other value), which could make the code less readable. Cheers Rico
Re: Call for translators
hey paul, i believe i can get to them this weekend as i said. 2010/6/9 Paul Vriens : > On 05/27/2010 07:37 PM, Ricardo Filipe wrote: >> >> i'm adding myself to the list atm. i'll finish the portuguese portugal >> translations next week. > > Hi Ricardo, > > Will you be able to do the translations or should we let Miguel have a go? > > -- > Cheers, > > Paul. >
Re: Call for translators
On 05/27/2010 07:37 PM, Ricardo Filipe wrote: i'm adding myself to the list atm. i'll finish the portuguese portugal translations next week. Hi Ricardo, Will you be able to do the translations or should we let Miguel have a go? -- Cheers, Paul.
Re: Change a malloc() to a HeapAlloc()
On Wed, Jun 9, 2010 at 9:08 PM, Peter Davies wrote: >> The patch is also wrong. > Why? What difference does malloc() over HeapAlloc() make? (this is arguably a > case for not sending the patch in the first place) This is because wpp_lookup_mem is only referenced in the wpp_callbacks structure, which is passed to wpp_set_callbacks. Code where callbacks are set and invoked is in libs/wpp/, which is a native library (will not compile to a dll), so it will clean up using standard free(). HeapAlloc/HeapFree should always be used in windows-based code, except when it interfaces with other code that doesn't. In any case, HeapAlloc/HeapFree and malloc/free should never be mixed up (allocate with one, free with the other). Octavian
Re: Change a malloc() to a HeapAlloc()
On 9 June 2010 19:08, Peter Davies wrote: >> We use real names here. This patch probably will not be committed until it >> is resubmitted. > Ops! I've mis-configured my mail client > >> The patch is also wrong. > Why? What difference does malloc() over HeapAlloc() make? (this is arguably a > case for not sending the patch in the first place) > > There is nothing that bugs me more than not being told why I'm wrong. Where does the allocated variable get freed? Has that been changed from free to HeapFree? Does it get realloced? - Reece
Re: [PATCH] [WinHelp]: implemented ExecFile macro (fix for #23054)
Eric Pouech writes:
> +static void CALLBACK MACRO_ExecFile(LPCSTR pgm, LPCSTR args, LONG cmd_show,
> LPCSTR topic)
> {
> -WINE_FIXME("(\"%s\", \"%s\", %u, \"%s\")\n", str1, str2, u, str3);
> +static HINSTANCE (WINAPI *shell_exec)(HWND, LPCSTR, LPCSTR, LPCSTR,
> LPCSTR, INT);
> +HINSTANCE ret = 0;
> +
> +WINE_TRACE("(\"%s\", \"%s\", %u, \"%s\")\n", pgm, args, cmd_show, topic);
> +if (!shell_exec)
> +{
> +HANDLE h;
> +
> +if ((!(h = GetModuleHandle("shell32.dll")) && !(h =
> LoadLibraryA("shell32.dll"))) ||
> +!(shell_exec = (void*)GetProcAddress(h, "ShellExecuteA")))
> +{
> +WINE_ERR("Couldn't load shell32.ShellExecute\n");
> +}
> +}
Why not call ShellExecuteA directly?
--
Alexandre Julliard
julli...@winehq.org
Re: Change a malloc() to a HeapAlloc()
> We use real names here. This patch probably will not be committed until it > is resubmitted. Ops! I've mis-configured my mail client > The patch is also wrong. Why? What difference does malloc() over HeapAlloc() make? (this is arguably a case for not sending the patch in the first place) There is nothing that bugs me more than not being told why I'm wrong. Peter
Re: Three year sever outstanding bug requiring minor fix
velociraptor Genjix wrote at Jun 9, 2010 8:52 AM > >Hey, >Please look into this issue, >http://bugs.winehq.org/show_bug.cgi?id=15118 >It seems like a fairly trivial fix which renders this application useless. A >detailed >description of the implementation needed is provided in that ticket. If it were a 'trival' fix, it would have been a long time ago. Something that looks, on the surface, to be simple, maybe very complex. For instance, I have been working on a fix for one function in the richedit area has taken over four years. Now as to your concern, tough. This project, for the most part is volunteer. So, if you want it fixed, do it yourself or find someone who can. Otherwise, you'll have to wait for someone to come by, find this interesting and then fix it. There is a part of the project that is paid, and they work for a company called CodeWeavers. Maybe they have found a fix and incorporated it into their product line. That you'll have to pay for. Remember, we fix things as WE find the time and the incorporation process is very strict. This takes time and some folks will pick up a project, only to set it down because they become busy with other things in life or they just don't have the tenancity to see it through. James McKenzie
Re: Two enhancement requests for winetricks
On Wed, Jun 9, 2010 at 3:45 AM, Dan Kegel wrote: > I suppose winetricks could create uninstaller entries for even > the little verbs... that would be the windows way of doing things. +1 for this idea. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
Re: Three year sever outstanding bug requiring minor fix
Hello Fakename, 2010/6/9 velociraptor Genjix : > Hey, > Please look into this issue, > http://bugs.winehq.org/show_bug.cgi?id=15118 > It seems like a fairly trivial fix which renders this application useless. A > detailed description of the implementation needed is provided in that > ticket. > Thank you Wine is run by volunteers, you cannot tell others what to do since they work on wine voluntary. If you want the bug fixed, your best bet is to try to fix it yourself. We can likely help you if you can program in C, but just posting 'please fix this bug for me' is rude and selfish. Cheers, Maarten
Three year sever outstanding bug requiring minor fix
Hey, Please look into this issue, http://bugs.winehq.org/show_bug.cgi?id=15118 It seems like a fairly trivial fix which renders this application useless. A detailed description of the implementation needed is provided in that ticket. Thank you _ http://clk.atdmt.com/UKM/go/19780/direct/01/ Do you have a story that started on Hotmail? Tell us now
Re: How to change text on winehq.org ?
On Wed, Jun 9, 2010 at 15:28, Marco Meijer wrote: > Hi WineDevs, > > I made the patch to change the text on winehq and sent it to wine-patches > but still no change. > Do I have to do something else ? > > link to patch: > http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html > > kind regards, > > Marco Meijer Your patch seems OK to me. It probably has been forgotten for some reason. Just resend it (you may add a (resend) to the subject line as well) Frédéric
Re: How to change text on winehq.org ?
Hi WineDevs, I made the patch to change the text on winehq and sent it to wine-patches but still no change. Do I have to do something else ? link to patch: http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html kind regards, Marco Meijer http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html Op 6-5-10 17:57, James Mckenzie schreef: Hi WineDevs, If make the packages for mandriva on sourceforge. And the text on the download page on the website (winehq,org) for mandriva is getting old. Who can I write a mail to change the text ? I already tried web-admin ad winehq.org some weeks ago but no reaction so far. The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. Are you familiar with this process? James McKenzie
Re: Two enhancement requests for winetricks
On Wed, Jun 9, 2010 at 3:03 AM, Octavian Voicu wrote: > If you implement a status feature for every trick, you can change the > main UI into a list of checkboxes, with the installed tricks already > ticked. Right, of course. I had even realized that before. I guess I was just in 'no' mode... - Dan
Re: Two enhancement requests for winetricks
Thanks a lot. Regarding your comment on id=127 "want uninstall": Could this useage (use winetricks ONLY on a relatively empty .wine directory to troubleshoot) be documented on every place in the winetricks documentation directories ? This is not the way the documentation feels at: http://wiki.winehq.org/winetricks e.g. a short point explaining this, and that there is NO way to remove winetricks will help here. At this point, even the Ubuntu standard wine packaging includes winetricks. This leaves end-users with the impression that they are integral part of wine, and thus maintained. Wine has been maturing. I now have a stable Windows environment, which required a few winetricks a year ago. This was then reasonable. I really will not anymore remove the .wine directory to delete all installed applications including keys & settings. If I can help with starting an uninstaller, I am willing to put in some time: A helpful step for me as a user would be to begin with a few cases that can simply be implemented (e.g. cc580, which I could remove recently due to a bug fix). I also see some application-like entries (7zip, firefox, gecko, python, vlc, wmp) where the package uninstaller may work. Dan Kegel wrote: OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht
Re: [1/3] msi: Create directories right before installing files.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2538 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5408: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5427: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5452: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5471: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8261: Test failed: RegQueryValueExA failed 2 (0) install.c:9173: Test failed: got 6 expected 0 install.c:9179: Test failed: got 6 expected 0 install.c:9182: Test failed: got 6 expected 0 install.c:9184: Test failed: file removed install.c:9329: Test failed: key not created
Re: wine in the news in spain
On Wed, Jun 9, 2010 at 10:49 AM, Dan Kegel wrote: > Hmm, I wonder what "Presto" is, Autotranslated from www.presto.es: "Presto is the program [for] budgets, measurements, times, health and safety, quality and cost control for building and civil works more prevalent in Hispanic countries." > and which CAD suites they use. They probably use the CAD programs that are compatible with Presto, maybe from the same company that makes Presto. Anyway, they are all proprietary and they don't even have demos, so don't see them working very soon unless it happens after fixing other applications that happen to have the same problems. Octavian
Re: Two enhancement requests for winetricks
On Wed, Jun 9, 2010 at 9:35 AM, Dan Kegel wrote: > If you or anyone else wants to submit patches to implement a way to > uninstall things, please go ahead. The user interface would be a challenge, > though. I'd rather not have an uninstall verb for each regular verb. If you implement a status feature for every trick, you can change the main UI into a list of checkboxes, with the installed tricks already ticked. Any change in tick state would result in the installation/uninstallation of that trick. After clicking ok, you would get a summary of the actions before proceeding: tricks to be installed and tricks to be uninstalled . Octavian
Re: Change a malloc() to a HeapAlloc()
On 9 June 2010 05:42, James McKenzie wrote: > We use real names here. This patch probably will not be committed until it > is resubmitted. > The patch is also wrong.
wine in the news in spain
Saw this just now: http://www.osor.eu/news/es-zaragozas-move-to-complete-open-source-desktop-going-to-plan "Zaragoza's move to complete open source desktop going to plan by Gijs Hillenius — published on Jun 08, 2010 The move by the city of Zaragoza to an open source desktop is making good progress. All of the city's civil servants now use open source tools including Thunderbird, VLC, Firefox and OpenOffice. And this year some seven hundred of the city's 2800 desktop PCs will have seen their proprietary operating system replaced by the Linux open source alternative. ... "It is not possible to move all applications to the open source platform. For example tools for Computer Aided Design and Optical Character Recognition, can't be replaced by open source alternatives. But proprietary and open source software can live together. And if we really can't find an open source option, we resort to Virtualbox and Wine to provide users their proprietary application." ... Their web site does mention a bit about wine, too: http://zaragozaciudad.net/azlinux/2009/septiembre.php (autotranslated): "24/09/2009 How we use WINE ... Microsoft Access: Access we have hundreds of applications that lack of time and means we can not migrate to an Open Source environment. WINE can emulate many of them even though the code should be reviewed, compiled and compacted again. A particular case is still unresolved are the Access applications that generate a mail merge with Word documents. OCR: for now we have not found an efficient alternative to the use of OCR software that "emulate" Windows OCR software with WINE Transactional environment: the client for our transactional environment is old and only works for Windows environments so that the use of WINE has been indispensable In contrast we must also say that some applications could not be emulated with WINE as Presto or Nokia PC Suite. So far WINE has not been useful to emulate CAD applications. In conclusion we can say that WINE is a useful tool in some cases and allows us to move forward in the migration to Open Source environment as alternatives to proprietary software are available and the height of these." Hmm, I wonder what "Presto" is, and which CAD suites they use. - Dan
Re: Two enhancement requests for winetricks
On Wed, Jun 9, 2010 at 12:41 AM, Tom Wickline wrote: > $ wine uninstaller ? > > Everything wont be listed in the uninstaller, single dll's and font changes > wont be listed. > The unistaller could maybe be used for Firefox, Steam etc.. I suppose winetricks could create uninstaller entries for even the little verbs... that would be the windows way of doing things.
Re: Two enhancement requests for winetricks
On Wed, Jun 9, 2010 at 2:35 PM, Dan Kegel wrote: > > If you or anyone else wants to submit patches to implement a way to > uninstall things, please go ahead. The user interface would be a > challenge, > though. I'd rather not have an uninstall verb for each regular verb. > - Dan > > $ wine uninstaller ? Everything wont be listed in the uninstaller, single dll's and font changes wont be listed. The unistaller could maybe be used for Firefox, Steam etc.. Tom
