Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4262 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4261 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4260 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: tools/winebuild: add missing separators
On Tue, Aug 3, 2010 at 9:57 PM, Austin English wrote: > -- > -Austin > > > > The colons aren't decorative separators, but rather determine which short arguments expect a parameter as per the requirements of getopt/getopt_long. With your patch applied: $ tools/winebuild/winebuild -h tools/winebuild/winebuild: option requires an argument -- 'h'
Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4251 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1497: Test failed: Got color 000a246a, expected 00ff or near visual.c:1503: Test failed: Got color 006b8bbd, expected 00ff or near visual.c:1509: Test failed: Got color 00ff, expected 0080 or near visual.c:1515: Test failed: Got color 00ff, expected 0080 or near
Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4250 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4248 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:323: Test failed: wrong exit code : 0103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD67.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2284 != 2046 debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:316: Test failed: wrong exit code : 0103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtE239.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2384 != 2046 Timeout
Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4246 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 3)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4245 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found
Re: regedit: Added Hebrew translation
On 8/3/10 4:58 AM, Yaron Shahrabani wrote: > How can I compile a single RC file? After configuring Wine, go to the directory containing the RC file and type in a Terminal: make .res where is the part of the filename before the '.rc' extension. So if you wanted to compile only He.rc for regedit, you'd first 'cd' to /programs/regedit and then type 'make He.res'. Chip
Re: Should we expect Liberation fonts to be installed?
On 08/03/2010 03:09 PM, David Gerard wrote: > On 3 August 2010 21:57, Scott Ritchie wrote: > >> This bug, for instance, prevents Photoshop from working unless there is >> an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 >> Wine doesn't seem to respect system-level fontconfig aliases, so even >> though Liberation Sans is installed on the system Photoshop won't try to >> use it in place of Arial. > > > This is an excellent idea, except that the Liberation fonts are really > horrible. I've *tried* using them for general text use and they make > me want to gouge my eyes out. > > Is there really no reasonable way to detect the system font settings > in GNOME or KDE? And where detection fails, a Wine control panel > perhaps? > > > - d. Well, if we did use the fontconfig aliases, you'd be seeing the Liberation fonts unless you had the real Arial installed ;) Thanks, Scott Ritchie
Re: regedit: Added Hebrew translation
How can I compile a single RC file? Yaron Shahrabani On Tue, Aug 3, 2010 at 12:39 PM, Alexandre Julliard wrote: > Yaron Shahrabani writes: > > > Hope everything is cool this time :) > > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > > +WS_BORDER > > +WS_EX_LAYOUTRTL > > +FONT 8, "MS Shell Dlg" > > That's not valid syntax. Please try to compile at least the files you > are changing, if you can't do a full build. > > -- > Alexandre Julliard > julli...@winehq.org >
Re: Should we expect Liberation fonts to be installed?
On 3 August 2010 21:57, Scott Ritchie wrote: > This bug, for instance, prevents Photoshop from working unless there is > an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 > Wine doesn't seem to respect system-level fontconfig aliases, so even > though Liberation Sans is installed on the system Photoshop won't try to > use it in place of Arial. This is an excellent idea, except that the Liberation fonts are really horrible. I've *tried* using them for general text use and they make me want to gouge my eyes out. Is there really no reasonable way to detect the system font settings in GNOME or KDE? And where detection fails, a Wine control panel perhaps? - d.
Should we expect Liberation fonts to be installed?
I was looking through our fairly large collection of open font bugs and realized that things might be a lot simpler if we took some opinionated positions and just declared certain fonts to be dependencies and expected all packagers to provide them. This is similar to bundling our own Tahoma, except much less work. This bug, for instance, prevents Photoshop from working unless there is an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 Wine doesn't seem to respect system-level fontconfig aliases, so even though Liberation Sans is installed on the system Photoshop won't try to use it in place of Arial. But if however we assumed that Liberation Sans was installed, we could make things much better: a link/substitution for Arial->Liberation Sans could be provided in our own registry (and similarly for Times New Roman and Courier). An alternative is to simply symlink to the Liberation Fonts in /usr/share/wine/fonts as though they were our own shipped fonts (like Tahoma). This would make Photoshop think Arial was present and keep it functional. Ideally the real Arial would be displayed if it was installed (eg through winetricks corefonts or by installing the distro-provided corefonts package). A related question is whether to show "Arial" in the list of fonts (eg notepad) when we're actually just providing a substituted Arial. My inclination says no, however I'm not sure how it works internally and what an application would expect. Thanks, Scott Ritchie
Re: [PATCH 2/4] include/shlobj.h: SHILCreateFromPath takes both CSTR and WSTR
Andrew Eikum writes: > This is different from the latest PSDK, but Wine's SHILCreateFromPath > accepts both types, so we shouldn't make compiler warnings about it. If there are warnings with the Windows headers there should be warnings with the Wine ones too. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)
On 08/02/2010 05:49 PM, Jeff Cook wrote: --- dlls/winealsa.drv/waveinit.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) -int scan_devices = (fixedpcmdev == -1); +/* we always want to scan_devices; otherwise, if a default is set and the +appropriate registry keys are not set, only the default device will be seen +by wine. This is undesirable, for instance, if you have separate cards for +capture and playback, like a USB microphone for capture */ +int scan_devices = 1; Please make it possible to force old behavior via registry. This was done for a reason - some devices were crashing during initialization, some were taking way too long to initialize. Vitaliy
Re: wiki slightly broken still?
[to list as well] On 3 August 2010 15:07, Dimi Paun wrote: > On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: >> How difficult would it be to use ReCaptcha? >> http://www.google.com/recaptcha > Hm, don't know. We could hack our version to support recaptcha, > but I'm not familiar with the code base, and I don't have the > time right now. But I can take patches if someone is willing > to do it. The MoinMoin developers consider TextCHA inherently superior and so have no interest in writing a reCaptcha interface: http://moinmo.in/FeatureRequests/ReCaptcha (Note also the problems people have had with TextCHA: it becomes too much work to write the questions and to answer the questions.) If someone wants reCaptcha in MoinMoin, it appears they will need to write it all themselves. - d.
Re: wiki slightly broken still?
On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: > How difficult would it be to use ReCaptcha? > > http://www.google.com/recaptcha Hm, don't know. We could hack our version to support recaptcha, but I'm not familiar with the code base, and I don't have the time right now. But I can take patches if someone is willing to do it. -- Dimi Paun Lattica, Inc.
Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)
On 08/02/2010 05:48 PM, Jeff Cook wrote:
Moved check to conform with C90.
+if (mastelem) {
+/* Master control */
...
+} else {
Please follow file's format.
Vitaliy
Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)
On 08/02/2010 05:50 PM, Jeff Cook wrote:
-
+
You adding trailing spaces here.
+} else {
+default_used = 1;
}
Please follow files' format - curly braces go on separate line. Also you
don't need braces for one line "else".
Vitaliy.
Re: [PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)
On 08/02/2010 05:49 PM, Jeff Cook wrote: --- dlls/winealsa.drv/waveinit.c | 9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) +sprintf(description, "%s %d:%d", snd_pcm_info_get_name(infop), snd_pcm_info_get_card(infop), Please use snprintf to prevent possible buffer overflow. +memcpy(ww->ds_desc.szDesc, description, +min( (sizeof(ww->ds_desc.szDesc) - 1), strlen(description)) ); This does not guarantee that ww->ds_desc.szDesc will be \0 terminated. Vitaliy.
Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)
W dniu 03.08.2010 13:28, Nikolay Sivov pisze:
On 8/3/2010 13:58, Mariusz Pluciński wrote:
---
dlls/gameux/Makefile.in | 1 +
dlls/gameux/factory.c | 5 ++
dlls/gameux/gamestatistics.c | 153
++
dlls/gameux/gameux_private.h | 1 +
dlls/gameux/regsvr.c | 9 +++
5 files changed, 169 insertions(+), 0 deletions(-)
create mode 100644 dlls/gameux/gamestatistics.c
+ TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath),
openType, pOpenResult, ppiStats);
+ FIXME("stub\n");
+ return E_NOTIMPL;
No need for duplicated traces, add one FIXME with full parameter output
in it.
I hope my patches are acceptable despite of this. But in the future I'll
avoid it, thanks.
Re: wiki slightly broken still?
On Thu, Jul 29, 2010 at 18:01, Dimi Paun wrote: > Now that this issue is fixed, we can look again at the spam > problem. It was suggested that we use a 'TextChas' for non > logged in users: > http://moinmo.in/HelpOnSpam > > But it seems it's not too easy to come up with decent questions. > Should we try it? How difficult would it be to use ReCaptcha? http://www.google.com/recaptcha Thanks, Alex
Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)
On 8/3/2010 13:58, Mariusz Pluciński wrote:
---
dlls/gameux/Makefile.in |1 +
dlls/gameux/factory.c|5 ++
dlls/gameux/gamestatistics.c | 153
++
dlls/gameux/gameux_private.h |1 +
dlls/gameux/regsvr.c |9 +++
5 files changed, 169 insertions(+), 0 deletions(-)
create mode 100644 dlls/gameux/gamestatistics.c
+TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath),
openType, pOpenResult, ppiStats);
+FIXME("stub\n");
+return E_NOTIMPL;
No need for duplicated traces, add one FIXME with full parameter output
in it.
Re: [5/5] wined3d: Fix NaN and Inf generation in msvc
Am 03.08.2010 um 02:47 schrieb Vitaly Budovski: > The INFINITY macro is part of C99, but for NaN, why not use something > like sqrt(-1) ? We don't use C99 features in Wine, some compilers don't support them. sqrt(-1) may or may not work, but it will be essentially the same as 0.0 / 0.0. Compilers may complain about sqrt(-1) just as they do with the 0.0 / 0.0 division.
Re: [PATCH 5/6] winealsa.drv: Don't open the same card on every loop. (resend)
Jeff Cook writes: > @@ -753,7 +753,7 @@ static int ALSA_ScanDevices(int directhw, > char *pcmname = NULL; > snd_pcm_t *pcm; > > -sprintf(defaultpcmname, "default"); > +sprintf(defaultpcmname, "default:%d", card); We used to do that, but it was changed because it's not correct, cf. bug 10942. -- Alexandre Julliard julli...@winehq.org
Re: regedit: Added Hebrew translation
Yaron Shahrabani writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > +WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile at least the files you are changing, if you can't do a full build. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)
David Hedberg writes:
> +static LRESULT resize_namespacetree(NSTC2Impl *This)
> +{
> +RECT rc;
> +TRACE("%p\n", This);
> +
> +GetClientRect(This->hwnd_main, &rc);
> +SetWindowPos(This->hwnd_tv, HWND_TOP, rc.left, rc.top,
> + rc.right, rc.bottom, SWP_SHOWWINDOW);
Again, that's not the correct usage of SetWindowPos. You don't want to
show or activate it. What you probably want is MoveWindow.
--
Alexandre Julliard
julli...@winehq.org
Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)
Jeff Cook wrote:
> What compiler are you running? It works fine for me and I don't see
> any errors or warnings.
You are passing the compiler the wrong flags:
-Wdeclaration-after-statement is set by default in Wine.
> On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard
> wrote:
>> Jeff Cook writes:
>>
>>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
>>> for (id = 0; id < mmixer->chans; ++id)
>>> {
>>> line *mline = &mmixer->lines[id];
>>> +if (!mline->elem)
>>> +{
>>> +break;
>>> +}
>>> int ofs = CONTROLSPERLINE * id;
>> You can't do that:
>>
>> mixer.c: In function ‘fillcontrols’:
>> mixer.c:252: error: ISO C90 forbids mixed declarations and code
bye
michael
Re: GetVolumeInformationA: please test this on MS-Windows
On Mon, Aug 2, 2010 at 9:43 PM, wrote: > Jeff Zaroyko wrote: > >>Would you mind supplying a new binary? > Testbot did it for us: job #4154 > https://testbot.winehq.org/JobDetails.pl?Key=4154 > > Regards, > Jörg Höhle This new #4154 binary doesn't have any failures when run from the MinGW shell: volume.c:345: Tests skipped: Please re-run from another device than C: volume: 392 tests executed (0 marked as todo, 0 failures), 1 skipped. Only the earlier binary from #4014 does as per the earlier email. Jeff
