re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
Mikko wrote: > Communicating with an external server is an option, but I don't > know which would be a good server for testing. https://mail.google.com ? Be sure to skip if you can't connect.
Re: [2/2] attrib/tests: added tests for some flags
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5041 Your paranoid android. === W98SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! Timeout Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2KPROSP4 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WXPPROSP3 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K3R2SESP2 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WVISTAADM (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K8SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PRO (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (64 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode w
Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5038 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43
Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation (try2)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5039 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42
Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation (try2)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5040 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42
Re: gdi32/tests: Fix a typ description in test_logpen.
Gerald Pfeifer wrote: winebot claims this is causing a tons of test failures on W98SE, but that doesn't make sense at all. Gerald: What is the job id on the testbot? I don't see a failure message in Wine-Devel. James McKenzie
Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5037 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43
Re: [1/5] urlmon: Implemented IUriBuilder_{Get/Set}Fragment (try 2)
Hi Thomas, On 9/5/10 8:10 PM, Thomas Mullaly wrote: Changes since previous attempt: 1. Perform lazy allocation/copy of a URI property when the IUriBuilder_Get* function is called, instead of always allocating when the IUriBuilder is created (addresses Jacek's comments). 2. Created helper functions for Get/Set calls to the IUriBuilder to cut back on code duplication. 3. Added a bit flag member to the UriBuilder object, so that it can store which properties have been changed. It looks much better now. There is one problem remaining (that I think can be fixed in a follow-up patch): +This->modified_props |= Uri_HAS_FRAGMENT; +return set_builder_component(&This->fragment,&This->fragment_len, pwzNewValue, '#'); The modifier_props should be set only on success. To achieve so, I think it would be cleaner to pass a flag to be set to set_buildier_component. Jacek
Re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
The patch list requests me to write tests for this patch. I would do that, but there is a problem: I need a fully initialized schannel security context to use DecryptMessage. To acquire one I need to communicate with a server component. Wine is lacking an implementation of at least the AcceptSecurityContext function, so at the moment I cannot do a self-contained test. Communicating with an external server is an option, but I don't know which would be a good server for testing. Implementing the server-side stuff is another, but might take quite a while and I'd like to see this patch applied soon as it's required to play several recent Ubisoft games. Mikko On 30.08.2010 19:37, Mikko Rasa wrote: --- dlls/secur32/schannel.c | 50 ++ 1 files changed, 45 insertions(+), 5 deletions(-)
Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE
On 09/05/2010 11:52 AM, David Laight wrote: Not to mention the bloatage of using 'inline' for something that size I modified my patch accordingly but as I can't check the preserveWhiteSpace property, I have to wait. Anyway, thanks for all your advices !
Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE
On Thu, Sep 02, 2010 at 12:10:26PM +0200, Alexandre Julliard wrote:
> Alexandre Goujon writes:
>
> > +static inline BSTR bstr_trim(const BSTR str)
> > +{
...
> > +}
>
> That's ugly and inefficient, especially since the common case is to not
> modify it.
Not to mention the bloatage of using 'inline' for something that size.
David
--
David Laight: da...@l8s.co.uk
Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.
On Wed, Sep 01, 2010 at 05:40:35PM +0200, Alexandre Julliard wrote: > Jeff Cook writes: > > > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > > } > > > > /* Add master channel, uncounted channels and an extra for capture > > */ > > -mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > > +/* Do not add the extra channel needed for capture on half-duplex > > capture cards > > + like snd_usb_audio mics */ > > +if (micelem && !mastelem && !captelem) > > +mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + > > !!micelem; > > +else > > +mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + > > !!micelem + 1; > > This statement wasn't exactly clear before, but now it's really > impossible to follow. Please rewrite this in a way that makes sense to a > casual reader. Clearly it should be: mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + (micelem && !mastelem && !captelem); ducks quickly ... :-) David -- David Laight: da...@l8s.co.uk
Re: msvcp90: Fix 64-bit compilation warnings
On Wed, Sep 01, 2010 at 11:56:40AM +0200, Alexandre Julliard wrote:
> Piotr Caban writes:
>
> > @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase,
> > 12)
> > basic_string_char* __thiscall MSVCP_basic_string_char_erase(
> > basic_string_char *this, size_t pos, size_t len)
> > {
> > -TRACE("%p %d %d\n", this, pos, len);
> > +TRACE("%p %d %d\n", this, (int)pos, (int)len);
>
> You should be casting to long, otherwise you'll potentially truncate the
> value.
In which case the format specifiers need to be %ld as well...
David
--
David Laight: da...@l8s.co.uk
