Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
W dniu 17.10.2010 01:45, Vincent Povirk pisze:
+1
+if (!prc)
+{
+UINT width, height;
+hr = IWICBitmapSource_GetSize(This-source,width,height);
+if (FAILED(hr)) return hr;
+rc.X = 0;
+rc.Y = 0;
+rc.Width = width;
+rc.Height = height;
+prc =rc;
+}
Any reason you didn't use this approach in the other functions?
I don't know really. Doing a memcpy to a local rectangle seems a more
natural way to do it, as I don't really like to modify input arguments.
In this case I guess I just blindly copied an existing solution that I
found later during the review of the other codecs.
If you want I can unify the implementations so that all of them look
like the one above.
Website: Change language string
Where does the translation of Change Language string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani Hebrew translator
Re: Website: Change language string
On 10/17/2010 12:21 PM, Yaron Shahrabani wrote: Where does the translation of Change Language string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani Hebrew translator Hi Yaron, See http://source.winehq.org/git/website.git/?a=commitdiff;h=6f11f1577987817638e1f95b55d195d64fa1e83d -- Cheers, Paul.
Re: Website: Change language string
Thanks Paul :) Yaron Shahrabani Hebrew translator
Translation of the AppDB
Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. Kind regards, Yaron Shahrabani Hebrew translator
Re: RTL in console windows
On 15/10/10 16:06, Yaron Shahrabani wrote: So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). If Windows doesn't do it, I don't think we should. Then again, it is my understanding that in some places, Windows does do it. Powershell, was pointed out by Michael Kaplan (http://blogs.msdn.com/b/michkap/archive/2010/10/07/10072032.aspx - myth 6). I have not tested it myself, but if that is correct, we need to do it like Windows does it, under the same circumstances. Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... This is irrelevant. Our standard of operation is what Windows does. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: Set base direction of web site to RTL language for Hebrew
Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...
Re: RTL in console windows
On Sun, Oct 17, 2010 at 1:52 PM, Shachar Shemesh shac...@shemesh.bizwrote: On 15/10/10 16:06, Yaron Shahrabani wrote: So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). If Windows doesn't do it, I don't think we should. Assuming Wine should offer support to versions prior to Windows XP there should be a support. Then again, it is my understanding that in some places, Windows does do it. Powershell, was pointed out by Michael Kaplan ( http://blogs.msdn.com/b/michkap/archive/2010/10/07/10072032.aspx - myth 6). I have not tested it myself, but if that is correct, we need to do it like Windows does it, under the same circumstances. Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... This is irrelevant. Our standard of operation is what Windows does. I was not asking what the Arabs or Persian did, I was asking if Microsoft did the same with the Arabic and Persian versions of Windows. Arabs and Persians, please tell us how did Windows versions prior to XP natively handled your languages in console windows (cmd/command etc.). Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Ubuntu Package Archive is back!
When I switched Ubuntu package hosting to a launchpad PPA (away from manual .deb hosting), one thing lost was the ease of archiving old versions, since Launchpad doesn't provide this. I've written some scripts to manually copy the packages from the PPA to form a new archive and am hosting it at the old location http://wine.budgetdedicated.com/archive/ -- currently it carries all the Wine packages that have been on the Ubuntu Wine PPA since 1.3.3 or so. The main use of the archive is to aid in regression testing - installing from packages is much easier/quicker than recompiling from source, and will help you narrow down the last working/nonworking wine version before doing a proper git bisect. All I have to do is run the script every time I update the PPA with new Wine packages, and it's good. Due to server space issues, I don't plan to archive daily package builds (which is my next project). Thanks, Scott Ritchie
Re: Set base direction of web site to RTL language for Hebrew
On 17/10/10 13:52, Yaron Shahrabani wrote: Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless... I will accept and admit your accusation of me not being psychic in sensing your incoming patches. Your patches are, indeed, more comprehensive than mine, but I believe they are inferior in at least one important aspect. You direct the code to load styles-rtl.css instead of styles.css. This encourages future site maintainers to perform changes to the CSS that will break the RTL version of it, due to not noticing the existence of the rtl version. I believe the approach I took, of including styles.css, and then including a second css only aimed at correcting the what needs to be corrected, would work better in the long run. Another manifestation of this difference can be seen when you place a dir= directive on the body tag of content_print.template. This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: Set base direction of web site to RTL language for Hebrew
On Sun, Oct 17, 2010 at 2:18 PM, Shachar Shemesh shac...@shemesh.bizwrote: On 17/10/10 13:52, Yaron Shahrabani wrote: Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless... I will accept and admit your accusation of me not being psychic in sensing your incoming patches. Your patches are, indeed, more comprehensive than mine, but I believe they are inferior in at least one important aspect. For some reason I got your patch only half an hour ago so I was absolutely sure you sent it way later... You direct the code to load styles-rtl.css instead of styles.css. This encourages future site maintainers to perform changes to the CSS that will break the RTL version of it, due to not noticing the existence of the rtl version. I believe the approach I took, of including styles.css, and then including a second css only aimed at correcting the what needs to be corrected, would work better in the long run. It is actually a linked CSS file... I used @import (styles.css) in order to maintain the original CSS, its the same approach you took only from a different point of view and practically there's no difference... (I can switch the method in a matter of click :) ). Another manifestation of this difference can be seen when you place a dir= directive on the body tag of content_print.template. This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used. So they should be combined? Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: Ubuntu Package Archive is back!
On Sun, Oct 17, 2010 at 2:01 PM, Scott Ritchie sc...@open-vote.org wrote: When I switched Ubuntu package hosting to a launchpad PPA (away from manual .deb hosting), one thing lost was the ease of archiving old versions, since Launchpad doesn't provide this. I've written some scripts to manually copy the packages from the PPA to form a new archive and am hosting it at the old location http://wine.budgetdedicated.com/archive/ -- currently it carries all the Wine packages that have been on the Ubuntu Wine PPA since 1.3.3 or so. The main use of the archive is to aid in regression testing - installing from packages is much easier/quicker than recompiling from source, and will help you narrow down the last working/nonworking wine version before doing a proper git bisect. All I have to do is run the script every time I update the PPA with new Wine packages, and it's good. Due to server space issues, I don't plan to archive daily package builds (which is my next project). Thanks, Scott Ritchie That's awesome! Ive been using your PPA for a really long time until I started compiling wine by myself! Keep up the good work and thank you very much! Yaron Shahrabani Hebrew translator
Re: Set base direction of web site to RTL language for Hebrew
On 17/10/10 15:00, Yaron Shahrabani wrote: Another manifestation of this difference can be seen when you place a dir= directive on the body tag of content_print.template. This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used. So they should be combined? I think, no. I think the RTL file should only contain RTL related stuff, and will therefor be okay to use it also in the content_print file, without adding a tag to the body. Just MHO. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: Set base direction of web site to RTL language for Hebrew
On Sun, Oct 17, 2010 at 3:07 PM, Shachar Shemesh shac...@shemesh.bizwrote: On 17/10/10 15:00, Yaron Shahrabani wrote: Another manifestation of this difference can be seen when you place a dir= directive on the body tag of content_print.template. This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used. So they should be combined? I think, no. I think the RTL file should only contain RTL related stuff, and will therefor be okay to use it also in the content_print file, without adding a tag to the body. Currently the RTL file I created contains only RTL stuff (and imports the other). It could be loaded in addition to the winehq_styles.css (where is this file anyway?) in content_print.template, this will solve the entire problem and ensures the site would look at its best. Kind regards, Yaron Shahrabani. Just MHO. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd.http://www.lingnu.com
Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
On 10/17/2010 01:59 AM, Krzysztof Nowicki wrote: Doing a memcpy to a local rectangle seems a morenatural way to do it Not really. Doing RECT = RECT is the natural way to do it. Don't use memcpy to copy one structure to another structure of the same type. Vitaliy.
Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.
On Sat, Oct 16, 2010 at 1:41 PM, Mike Kaplinskiy mike.kaplins...@gmail.com wrote: On Thu, Oct 14, 2010 at 10:08 PM, Erich Hoover ehoo...@mines.edu wrote: ... DWORD flags; unsigned int n_iovecs; unsigned int first_iovec; + WSABUF *control; struct iovec iovec[1]; } ws2_async; I would prefer control declared above n_iovecs purely for organizational purposes (params first, buffers and info about them last). Also you can't just store the passed in WSABUF pointer; it may be stack allocated and may disappear before the overlapped call completes. You could just add control and control_len instead of using WSABUF. That's why in the original version I had those parameters split out; however, I realized that since the length parameter gets modified by WSARecvMsg that it is impossible for the WSAMSG structure (or any of its parameters) to disappear before WSARecvMsg completes. I have re-written the tests (see patch 4 at the end) to show that this structure gets modified even when an overlapped request is used and results in modification of the structure at a later time, the results from the test bot can be found here: https://testbot.winehq.org/JobDetails.pl?Key=6250 + /* Insufficient room for control headers */ + errno = EINVAL; This should probably be ENOMEM then. On that note, it would be nice to test what windows actually does when you don't give it enough space (like 1 byte). We should probably rewrite that function at some point since I'm not sure what errno it returns anymore. This is odd, I must have copy-pasted the wrong error code from the recvmsg() manual page. I've investigated this issue more and discovered that the code should actually be EMSGSIZE. This change and the corresponding tests can be found in my revised patches (at the end), I've also included support for reporting back the MSG_CTRUNC flag. +#ifdef IP_PKTINFO + case WS_IP_PKTINFO: +#endif You probably don't need the ifdef. convert_sockopt will just fail. I did this to match how IP_HDRINCL was done nearby, should this really be changed? + hdr.Control.buf = pktbuf; .len = sizeof(pktbuf)? The length parameter is declared within the loop, otherwise it gets resized (as mentioned earlier) when WSARecvMsg is called. Thank you so much for all your help, I hope you find the following to be more to your liking. [1/4] include: Add IP_PKTINFO response structure. http://www.compholio.com/wine-kane/patches/2010-10-17/0001-include-Add-IP_PKTINFO-response-structure.patch [2/4] include: Add macros for retrieving control message headers. http://www.compholio.com/wine-kane/patches/2010-10-17/0002-include-Add-macros-for-retrieving-control-message-he.patch [3/4] ws2_32: Add support for WSARecvMsg and IP_PKTINFO. http://www.compholio.com/wine-kane/patches/2010-10-17/0003-ws2_32-Add-support-for-WSARecvMsg-and-IP_PKTINFO.patch [4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO. http://www.compholio.com/wine-kane/patches/2010-10-17/0004-ws2_32-tests-Add-regression-tests-for-WSARecvMsg-and.patch Erich Hoover ehoo...@mines.edu
Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
On 10/17/2010 22:46, Tomasz Michno wrote: --- dlls/mscms/tests/Makefile.in |3 ++- dlls/mscms/transform.c |2 ++ 2 files changed, 4 insertions(+), 1 deletions(-) You forgot to add new file to a patch.
Re: [PATCH] Compiling Wine at Ubuntu 10.10
Original-Nachricht Datum: Sat, 16 Oct 2010 17:26:49 +0200 Von: Detlef Riekenberg wine@web.de An: Gerold Jens Wucherpfennig gjwucherpfen...@gmx.net CC: wine-devel@winehq.org Betreff: Re: [PATCH] Compiling Wine at Ubuntu 10.10 On Sa, 2010-10-16 at 10:02 +0200, Gerold Jens Wucherpfennig wrote: You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. You can't do that. Your patch will break the build on many systems. Yes I only made the patch, because I couldn't find a solution by googling. It was a hot fix for me just to get wine compiled... Are you missing libxxf86vm1 or libxxf86vm-dev? No. If you still get a compilation error in dlls/winex11.drv you will need to add the flag -lXxf86vm. cd dlls/winex11.drv/ make = works here on a clean 32bit build (ubuntu 10.10 / x86_64) Hm, that's strange. Let's see if other people need my fix... With kind Regards, Gerold -- GMX DSL Doppel-Flat ab 19,99 euro;/mtl.! Jetzt auch mit gratis Notebook-Flat! http://portal.gmx.net/de/go/dsl
