Re: Linux kernel and game performance?
On 26/10/10 01:26, Dan Kegel wrote: The game runs a secondary timing thread with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms and sends events to the main thread to tell it that a new frame is needed. On Linux the necessary timing accuracy is not available, so it wavers between 16ms and 20ms. I thought TICKLESS did away with the timer resolution issues. Also, I'm not aware of any easy high frequency timers in Windows. Which API does it use? Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: comdlg32: Added Hebrew translation.
What is wrong with the patch? Yaron Shahrabani Hebrew translator 2010/10/23 Yaron Shahrabani sh.ya...@gmail.com Verified by Paul Vriens
Re: comdlg32: Added Hebrew translation.
On 10/26/2010 10:59 AM, Yaron Shahrabani wrote: What is wrong with the patch? Yaron Shahrabani Hebrew translator 2010/10/23 Yaron Shahrabani sh.ya...@gmail.com mailto:sh.ya...@gmail.com Verified by Paul Vriens Nothing: http://source.winehq.org/git/wine.git/?a=commit;h=bf948338ae0d22c37dbbde4275f810584447a6d8 -- Cheers, Paul.
Re: [PATCH 2/2] wer/tests: Add initial tests
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === WINEBUILD (build) === Make failed
Re: [PATCH] kernel32: Export recent wer functions
Detlef Riekenberg wine@web.de writes: @@ -1156,7 +1156,20 @@ @ stdcall WaitForSingleObjectEx(long long long) @ stdcall WaitNamedPipeA (str long) @ stdcall WaitNamedPipeW (wstr long) +@ stub WerGetFlags @ stdcall WerRegisterFile(wstr long long) +@ stub WerRegisterMemoryBlock +@ stub WerRegisterRuntimeExceptionModule +@ stub WerSetFlags +@ stub WerUnregisterFile +@ stub WerUnregisterMemoryBlock +@ stub WerUnregisterRuntimeExceptionModule +@ stub WerpCleanupMessageMapping +@ stub WerpInitiateRemoteRecovery +@ stub WerpNotifyLoadStringResource +@ stub WerpNotifyLoadStringResourceEx +@ stub WerpNotifyUseStringResource +@ stub WerpStringLookup Adding stubs is not a good idea. If you have an app that calls these you need to provide a proper stub function. -- Alexandre Julliard julli...@winehq.org
Re: Linux kernel and game performance?
On Tue, Oct 26, 2010 at 7:23 AM, Shachar Shemesh shac...@shemesh.biz wrote: The game runs a secondary timing thread with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms and sends events to the main thread to tell it that a new frame is needed. On Linux the necessary timing accuracy is not available, so it wavers between 16ms and 20ms. I thought TICKLESS did away with the timer resolution issues. There might still be some, and there are lots of knobs to tweak on the kernel, perhaps default settings are not optimal. Also, I'm not aware of any easy high frequency timers in Windows. Which API does it use? I think he said Sleep().
Re: Linux kernel and game performance?
On 26/10/10 14:09, Dan Kegel wrote: On Tue, Oct 26, 2010 at 7:23 AM, Shachar Shemeshshac...@shemesh.biz wrote: I thought TICKLESS did away with the timer resolution issues. There might still be some, and there are lots of knobs to tweak on the kernel, perhaps default settings are not optimal. More details would certainly be welcome. Also, I'm not aware of any easy high frequency timers in Windows. Which API does it use? I think he said Sleep(). My mistake. I was referring to sub-millisecond precision, which is irrelevant to this discussion. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
Aric Stewart a...@codeweavers.com writes: +ERR( perform byte seek --\n); You still have a ton of such debug ERRs in there. +*buf = NULL; +TRACE(Requesting %llu %u\n, ofs, len); Don't use %ll formats. -- Alexandre Julliard julli...@winehq.org
Re: [1/4] msxml3: libxml2 error/warning callback functions (try 2)
Adam Martinson amartin...@codeweavers.com writes: +len = vsnprintf(NULL, 0, msg, ap); +buf = heap_alloc(len+1); +vsnprintf(buf, len+1, msg, ap); vsnprintf can also return -1, check how this is done in other places. -- Alexandre Julliard julli...@winehq.org
Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
Timeout does not seem related to my patch (Anyway, I dont see how this patch could cause a timeout) Second failure is harmless A+ David 2010/10/25 Stefan Leichter stefan.leich...@camline.com Am Monday 25 October 2010 20:11:35 schrieb David Adam: Any problems with patch? A+ David -- Forwarded message -- From: David Adam david.adam.c...@gmail.com Date: 2010/10/24 Subject: ddraw: Add tests for the foreground window set by SetCooperativeLevel To: wine-patches wine-patc...@winehq.org http://source.winehq.org/patches/ shows test failures on windows for your patch. Not sure if the failures were caused by your patch. Bye Stefan
Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
David Adam david.adam.c...@gmail.com writes: @@ -33,8 +33,9 @@ static LPDIRECTDRAW lpDD = NULL; static LPDIRECTDRAWSURFACE lpDDSPrimary = NULL; static LPDIRECTDRAWSURFACE lpDDSBack = NULL; static WNDCLASS wc; -static HWND hwnd; +static HWND hwnd, hwnd2; static int modes_cnt; +static BOOL success; That boolean make much sense, especially with this name. If you want to check that you have a valid window you should test the window handle. Same with your createwindow function, it should simply return the handle. -- Alexandre Julliard julli...@winehq.org
First contact
Hi all wine developers, I read this mailing list for about one year I guess but I think I never send a message. Because until this Monday, I was a spectator, now I wanna become an actor, I want to learn how to hack wine :). I don't have a lot of time, 1 hour/week, maybe more, but I just want to fix some bugs, if I find some, and maybe more in the future. I'll take my time. For info, I'm a video game developers for 2 years, so I'm a C++ programmer, I know nothing about C (except what I know from the C++) and even if I'm using exclusively linux (ubuntu) for 3/4 years at home, I'm not comfortable with the POSIX development environment... Not that I'm a fan of Visual C++/Visual Assist but I always use those tools (at school and then at work) and wanted to learn something else. I decided to start with a game (Paraworld, but it could be anything) which can't load a level : when I hit the start game button, I got the loading screen, the music etc. but nothing append. The mouse is still reacting, the music still playing but nothing is loading. There is nothing in the trace too, so I tried with the WINEDEBUG=+relay, error!! I ended quickly with a log 300Mo before seeing the main menu! I've seen that there is a patch which allows user to control when debug trace will be display, but I don't know how to find it. I found this page : http://www.mail-archive.com/wine-devel@winehq.org/msg05542.html But I can't find the archive (the patch file), is there a place where we could download patches? Maybe my question is very simple, but I'm a beginner so be indulgent, please :). Other question, is there a way with winedbg to pause program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. This is possible with VCC, maybe it's not with winedbg? Anyway, thank you for your time, and I want to congratulate all the wine developers for their amazing work, win is getting better and better everyday thanks to you, Andréas --Not sent from an iPhone.
Re: First contact
For the patch, I think I understand the concept (I never use git before and never apply a patch), I have to selection the diff text and save it into a file (let's say debug.patch) and then type : git apply debug.patch Is that right? I got some error with this patch. I've try with a more recent version found here : http://repo.or.cz/w/wine/hacks.git/commitdiff/2daf55e8eeca89d5c2bb82381151277b6f9e70aa?hp=946767fae100f84c826157950b868908b6cc2464 But I got some errors in keyboard.c. Anyone has a solution? Andréas On Wed, Oct 27, 2010 at 12:44 AM, Andréas LIVET andreas.li...@gmail.comwrote: Hi all wine developers, I read this mailing list for about one year I guess but I think I never send a message. Because until this Monday, I was a spectator, now I wanna become an actor, I want to learn how to hack wine :). I don't have a lot of time, 1 hour/week, maybe more, but I just want to fix some bugs, if I find some, and maybe more in the future. I'll take my time. For info, I'm a video game developers for 2 years, so I'm a C++ programmer, I know nothing about C (except what I know from the C++) and even if I'm using exclusively linux (ubuntu) for 3/4 years at home, I'm not comfortable with the POSIX development environment... Not that I'm a fan of Visual C++/Visual Assist but I always use those tools (at school and then at work) and wanted to learn something else. I decided to start with a game (Paraworld, but it could be anything) which can't load a level : when I hit the start game button, I got the loading screen, the music etc. but nothing append. The mouse is still reacting, the music still playing but nothing is loading. There is nothing in the trace too, so I tried with the WINEDEBUG=+relay, error!! I ended quickly with a log 300Mo before seeing the main menu! I've seen that there is a patch which allows user to control when debug trace will be display, but I don't know how to find it. I found this page : http://www.mail-archive.com/wine-devel@winehq.org/msg05542.html But I can't find the archive (the patch file), is there a place where we could download patches? Maybe my question is very simple, but I'm a beginner so be indulgent, please :). Other question, is there a way with winedbg to pause program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. This is possible with VCC, maybe it's not with winedbg? Anyway, thank you for your time, and I want to congratulate all the wine developers for their amazing work, win is getting better and better everyday thanks to you, Andréas --Not sent from an iPhone. -- Not sent from an iPhone.
Re: First contact
On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET andreas.li...@gmail.com wrote: For the patch, I think I understand the concept (I never use git before and never apply a patch), I have to selection the diff text and save it into a file (let's say debug.patch) and then type : git apply debug.patch Is that right? I got some error with this patch. Yes. I've try with a more recent version found here : http://repo.or.cz/w/wine/hacks.git/commitdiff/2daf55e8eeca89d5c2bb82381151277b6f9e70aa?hp=946767fae100f84c826157950b868908b6cc2464 But I got some errors in keyboard.c. Anyone has a solution? You may have to manually fix the patch, keyboard.c may have changed since the patch was made. BTW, please bottom post on wine mailing lists. -- -Austin
Re: First contact
On Wed, Oct 27, 2010 at 00:44, Andréas LIVET andreas.li...@gmail.com wrote: Other question, is there a way with winedbg to pause program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. Press Ctrl-C in the terminal where you run winedbg, or send the program you're debugging a SIGINT manually. -- Remco
Re: First contact
On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET andreas.livet at gmail.com wrote: For the patch, I think I understand the concept (I never use git before and never apply a patch), I have to selection the diff text and save it into a file (let's say debug.patch) Copy and paste sometimes screws up patches. Better to save the patch to a file some other way. In particular, I usually use wget. For the patch you mentioned, one command to fetch the patch is wget http://repo.or.cz/w/wine/hacks.git/patch/2daf55e8eeca89d5c2bb82381151277b6f9e70aa?hp=946767fae100f84c826157950b868908b6cc2464 http://marc.info/?l=wine-patches is another good place to search for uncommitted patches; that site does a good job of saving the patches as hyperlinks you can use with wget. See also http://kegel.com/academy/opensource.html and http://kegel.com/wine/qa/ for a few tips. Welcome aboard. I hope you have more than 1 hour / week, it takes a while to come up the learning curve. - Dan
Re: First contact
On Wed, Oct 27, 2010 at 1:04 AM, Austin English austinengl...@gmail.comwrote: On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET andreas.li...@gmail.com wrote: For the patch, I think I understand the concept (I never use git before and never apply a patch), I have to selection the diff text and save it into a file (let's say debug.patch) and then type : git apply debug.patch Is that right? I got some error with this patch. Yes. I've try with a more recent version found here : http://repo.or.cz/w/wine/hacks.git/commitdiff/2daf55e8eeca89d5c2bb82381151277b6f9e70aa?hp=946767fae100f84c826157950b868908b6cc2464 But I got some errors in keyboard.c. Anyone has a solution? You may have to manually fix the patch, keyboard.c may have changed since the patch was made. BTW, please bottom post on wine mailing lists. -- -Austin Thanks for your response Austin, I finally manage to apply the patch (just the line number to change). Weirdly it did not work as expected (it's like the game is launch twice when I hit F12), but I'll investigate. Andreas -- Not sent from an iPhone.
