Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
It definitely could. I just thought that would result in a lot of ugly probe array definitions. Nevertheless, if you think it would be cleaner, I could definitely migrate it over, without too much effort. Travis. On Tue, Nov 2, 2010 at 4:18 AM, Henri Verbeet hverb...@gmail.com wrote: On 2 November 2010 07:20, Travis Athougies iamm...@gmail.com wrote: +/* Repeatedly call a shader 32 times with linearly varying values and test the results against + an array of floats using the given epsilon */ Why can't this just use the existing framework? -- Travis Athougies
Re: [PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.
On 11/5/10 9:39 PM, Austin Lund wrote:
On 5 November 2010 22:35, Alexandre Julliardjulli...@winehq.org wrote:
Austin Lundaustin.l...@gmail.com writes:
+static void init_tbsize_results(void) {
+tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(),
HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t));
+tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, {
+{ 0, 2, 23, 24}, { 23, 2, 46, 24}, { 46, 2, 54, 24},
+{ 54, 2, 77, 24}, { 77, 2, 100, 24} } };
That syntax is not portable, please avoid it.
What C standard is desired? C89?
C89, yes. C99, no.
James McKenzie
Re: [PATCH 2/4] mshtml: Added IOmNavigator::get_plugins implementation.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=6855
Your paranoid android.
=== W2K3R2SESP2 (32 bit dom) ===
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PRO (32 bit dom) ===
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PROX64 (32 bit dom) ===
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PROX64 (64 bit dom) ===
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
Re: [PATCH 3/4] mshtml: Added IDispatchEx support to HTMLStyleSheetsCollection object.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=6856
Your paranoid android.
=== W2K3R2SESP2 (32 bit dom) ===
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PRO (32 bit dom) ===
dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B}
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PROX64 (32 bit dom) ===
dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B}
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
=== W7PROX64 (64 bit dom) ===
dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B}
dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}
Re: [PATCH 2/4] quartz: Fix PullPin_EnumMediaTypes
Is there some reason you chose to add an additional function for this, rather than fill in pPinImpl-pin.pFuncsTable? I ask because I was working on this issue last night and submitted an attachment to Bug #24782 for people to try: http://bugs2.winehq.org/attachment.cgi?id=31770 Erich Hoover ehoo...@mines.edu
Re: [PATCH 2/4] quartz: Fix PullPin_EnumMediaTypes
Hi Eich, 2010/11/7 Erich Hoover ehoo...@mines.edu: Is there some reason you chose to add an additional function for this, rather than fill in pPinImpl-pin.pFuncsTable? I ask because I was working on this issue last night and submitted an attachment to Bug #24782 for people to try: http://bugs2.winehq.org/attachment.cgi?id=31770 Mostly consistency, the other functions from pFuncsTable are overridden as well in case of the parser and winegstreamer. Cheers, Maarten
Re: [PATCH 1/6] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6859 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9
Re: [PATCH 2/6] [Msvcrt*]: now using the macros for parameter checking for wcsncat_s (and fixed the test)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6861 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9
Strange test bot results
Hi Ge, how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams) ---BeginMessage--- VM StatusNumber of test failures WINEBUILDcompleted W98SEcompleted 0 WNT4WSSP6completed 0 W2KPROSP4completed 0 WXPPROSP3completed 0 W2K3R2SESP2 completed 0 WVISTAADMcompleted 0 W2K8SE completed 0 W7PROcompleted 0 W7PROX64 completed 0 W7PROX64 completed 0 === WINEBUILD (build) === No build failures found === W98SE (32 bit string) === No test failures found === WNT4WSSP6 (32 bit string) === No test failures found === W2KPROSP4 (32 bit string) === No test failures found === WXPPROSP3 (32 bit string) === No test failures found === W2K3R2SESP2 (32 bit string) === No test failures found === WVISTAADM (32 bit string) === No test failures found === W2K8SE (32 bit string) === No test failures found === W7PRO (32 bit string) === No test failures found === W7PROX64 (32 bit string) === No test failures found === W7PROX64 (64 bit string) === No test failures foundApplying patch Checking patch /var/lib/winetestbot/wine-git/dlls/msvcr90/tests/msvcr90.c... Checking patch /var/lib/winetestbot/wine-git/dlls/msvcrt/string.c... Checking patch /var/lib/winetestbot/wine-git/dlls/msvcrt/tests/string.c... Applied patch /var/lib/winetestbot/wine-git/dlls/msvcr90/tests/msvcr90.c cleanly. Applied patch /var/lib/winetestbot/wine-git/dlls/msvcrt/string.c cleanly. Applied patch /var/lib/winetestbot/wine-git/dlls/msvcrt/tests/string.c cleanly. Making test executable make: Entering directory `/var/lib/winetestbot/build-mingw32/dlls/msvcrt/tests' i686-pc-mingw32-gcc -c -I../../../../wine-git/dlls/msvcrt/tests -I. -I../../../../wine-git/include -I../../../include -I../../../../wine-git/include/msvcrt -I../../../../wine-git/dlls/msvcrt/tests/.. -DWINE_STRICT_PROTOTYPES -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -g -O2 -D_WIN32 -fno-builtin -o string.o ../../../../wine-git/dlls/msvcrt/tests/string.c ../../../../build-native/tools/winegcc/winegcc -b i686-pc-mingw32 -B../../../../build-native/tools/winebuild --sysroot=../../.. -fasynchronous-unwind-tables -mno-cygwin cpp.o data.o dir.o environ.o file.o headers.o heap.o locale.o misc.o printf.o scanf.o signal.o string.o time.o testlist.o -o msvcrt_test.exe ../../../libs/port/libwine_port.a make: Leaving directory `/var/lib/winetestbot/build-mingw32/dlls/msvcrt/tests' Making test executable make: Entering directory `/var/lib/winetestbot/build-mingw64/dlls/msvcrt/tests' x86_64-w64-mingw32-gcc -c -I../../../../wine-git/dlls/msvcrt/tests -I. -I../../../../wine-git/include -I../../../include -I../../../../wine-git/include/msvcrt -I../../../../wine-git/dlls/msvcrt/tests/.. -DWINE_STRICT_PROTOTYPES -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O2 -fno-builtin -o string.o ../../../../wine-git/dlls/msvcrt/tests/string.c ../../../../build-native/tools/winegcc/winegcc -b x86_64-w64-mingw32 -m64 -B../../../../build-native/tools/winebuild --sysroot=../../.. -fasynchronous-unwind-tables -mno-cygwin cpp.o data.o dir.o environ.o file.o headers.o heap.o locale.o misc.o printf.o scanf.o signal.o string.o time.o testlist.o -o msvcrt_test.exe ../../../libs/port/libwine_port.a make: Leaving directory `/var/lib/winetestbot/build-mingw64/dlls/msvcrt/tests'msvcrt:string start - - string.c:444: Tests skipped: strcpy_s not found string.c:498: Tests skipped: strcat_s not found string.c:562: Tests skipped: _mbsnbcpy_s not found string.c:609: Tests skipped: wcscpy_s not found string.c:656: Tests skipped: _wcsupr_s not found string.c:940: Tests skipped: strnlen not found string.c:971: Tests skipped: _strtoi64 or _strtoui64 not found string.c:1220: Tests skipped: Japanese_Japan.932 locale not available string.c:1264: Tests skipped: Skipping _gcvt tests string.c:1300: Tests skipped: Skipping _itoa_s tests string.c:1399: Tests skipped: Skipping _strlwr_s tests string.c:1458: Tests skipped: skipping wcsncat_s tests string.c:1497: Tests skipped: Skipping _mbsnbcat_s tests string.c:1622: Tests skipped: Skipping _ultoa_s tests string: 1248 tests executed (0 marked as todo, 0 failures), 14 skipped. msvcrt:string done (0)msvcrt:string start - - string.c:444: Tests skipped: strcpy_s not found string.c:498: Tests skipped: strcat_s not found string.c:562: Tests skipped: _mbsnbcpy_s not found string.c:609: Tests skipped: wcscpy_s not found string.c:656: Tests skipped: _wcsupr_s not found
[no subject]
From: Eric Pouech how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? Yeah, that's a bit weird. The only thing I can think of is some kind of timing issue, but looking at the code that seems unlikely in this case. So basically, I don't have a clue. Ge.
Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
On 11/07/2010 04:06 PM, David Hedberg wrote: -ok(hr == S_OK, got (0x%08x)\n, hr); +ok(hr == S_OK || hr == E_FAIL /* Win7 */, got (0x%08x)\n, hr); This can't be correct. It either works or it fails. Can't be both at the same time. You should look into why it's failing on Win7 and correct the test so it succeeds. Vitaliy
Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
On Mon, Nov 8, 2010 at 01:22, Vitaliy Margolen wine-de...@kievinfo.com wrote: - ok(hr == S_OK, got (0x%08x)\n, hr); + ok(hr == S_OK || hr == E_FAIL /* Win7 */, got (0x%08x)\n, hr); This can't be correct. It either works or it fails. Can't be both at the same time. You should look into why it's failing on Win7 and correct the test so it succeeds. I guess it makes the test a bit less useful for catching any errors, but reading between the lines at msdn makes me suspect that passing NULL for the pidl here simply doesn't work under Windows 7. I just tried the same thing on a IShellFolderView created from the windows directory and it gave the same result (still the default shellview I guess). Assuming for the moment that this is indeed the only result you'd ever get, should I find a way to skip it on windows 7 or mark one of the results as broken? I don't quite see either alternative as very helpful in this case, but I might be wrong. David
Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
On 11/7/10 6:41 PM, David Hedberg wrote: On Mon, Nov 8, 2010 at 01:22, Vitaliy Margolenwine-de...@kievinfo.com wrote: -ok(hr == S_OK, got (0x%08x)\n, hr); +ok(hr == S_OK || hr == E_FAIL /* Win7 */, got (0x%08x)\n, hr); This can't be correct. It either works or it fails. Can't be both at the same time. You should look into why it's failing on Win7 and correct the test so it succeeds. I guess it makes the test a bit less useful for catching any errors, but reading between the lines at msdn makes me suspect that passing NULL for the pidl here simply doesn't work under Windows 7. I just tried the same thing on a IShellFolderView created from the windows directory and it gave the same result (still the default shellview I guess). Assuming for the moment that this is indeed the only result you'd ever get, should I find a way to skip it on windows 7 or mark one of the results as broken? I don't quite see either alternative as very helpful in this case, but I might be wrong. Just my .02 USD (in other words, 2 cents) as a long term QA person, not as a Wine Developer. A test should not fail unless that is the desired result. However, marking an existing test as having new failure condition is not correct. Now, it may be true that the test passes up to and including Windows2008 but now fails on Windows7. Thus a second test case needs to be developed that is only for Windows7 and the remaining test skipped for Windows7. Something like what we do for Unicode tests for Windows9x/ME. This is not the first test that a failure will be a pass on Windows7 where a failure is not desired on prior versions of Windows. Unfortunately, I don't know what to do at this point, but maybe there is a new function that exists only in Windows7 for shell32 that can be used for the test. James McKenzie
Re: [PATCH] wined3d: correctly guess_card_vendor() for gallium r600 drivers
On Sun, Nov 7, 2010 at 2:08 PM, Brian Paterni bpate...@gmail.com wrote: Hello, I've been receiving a couple unrecognized GL_VENDOR fixme's lately and decided to poke around wine's source. I've found that wined3d_guess_card_vendor does not return the correct enum for people running mesa's r600g driver, and now that r600g returns AMD gpu chip as part of openGL's renderer string, we can easily use that to check for AMD (ATI) hardware: --- dlls/wined3d/directx.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 32d2431..3908c5f 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1373,11 +1373,10 @@ static enum wined3d_pci_vendor wined3d_guess_card_vendor(const char *gl_vendor_s if (strstr(gl_vendor_string, ATI) || strstr(gl_vendor_string, Advanced Micro Devices, Inc.) || strstr(gl_vendor_string, X.Org R300 Project) + || (strstr(gl_vendor_string, X.Org) strstr(gl_renderer, AMD)) || strstr(gl_renderer, R100) || strstr(gl_renderer, R200) - || strstr(gl_renderer, R300) - || strstr(gl_renderer, R600) - || strstr(gl_renderer, R700)) + || strstr(gl_renderer, R300)) return HW_VENDOR_ATI; if (strstr(gl_vendor_string, Intel(R)) -- 1.7.2.3 Howdy Brian, You're mixing tabs and spaces. Please use consistent spacing, as the rest of the file does. -- -Austin
Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
On 8 November 2010 11:49, James McKenzie jjmckenzi...@earthlink.net wrote: Thus a second test case needs to be developed that is only for Windows7 and the remaining test skipped for Windows7. Something like what we do for Unicode tests for Windows9x/ME. Isn't the rule that the tests should only check windows versions before testing behaviour if that is what applications to a similar thing, otherwise the test isn't required?
Re: [PATCH] wined3d: correctly guess_card_vendor() for gallium r600 drivers
On Sun, Nov 07, 2010 at 06:48:22PM -0800, Austin English wrote: Howdy Brian, You're mixing tabs and spaces. Please use consistent spacing, as the rest of the file does. Indeed, I was wondering about that... Also, I realized after submitting my previous email that checking for X.Org in gl_vendor_string is probably unnecessary as well, so I removed that portion from the following: --- dlls/wined3d/directx.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 32d2431..fa5b5cb 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1373,11 +1373,10 @@ static enum wined3d_pci_vendor wined3d_guess_card_vendor(const char *gl_vendor_s if (strstr(gl_vendor_string, ATI) || strstr(gl_vendor_string, Advanced Micro Devices, Inc.) || strstr(gl_vendor_string, X.Org R300 Project) +|| strstr(gl_renderer, AMD) || strstr(gl_renderer, R100) || strstr(gl_renderer, R200) -|| strstr(gl_renderer, R300) -|| strstr(gl_renderer, R600) -|| strstr(gl_renderer, R700)) +|| strstr(gl_renderer, R300)) return HW_VENDOR_ATI; if (strstr(gl_vendor_string, Intel(R)) -- 1.7.2.3
Re: PGP key signing party at WineConf
On Thu, Nov 4, 2010 at 7:09 AM, Shachar Shemesh shac...@shemesh.biz wrote: Hi all, During WineConf we will be holding a key signing party, organized by your truly. The wiki page for WineConf has been updated with details on how to participate, and I have set up a page explaining the process for people who have never participated before. Please email your keys to me, with the subject WineConf key signing (so that my spam filters don't eat it up). The wineconf wiki page, in case you are not up to date, is at http://wiki.winehq.org/WineConf2010 The key signing page is at http://wiki.winehq.org/KeySigningParty Howdy Shachar, I've noticed a few pgp/gpg websites that say the key should have the persons FULL name. Is the full name required, or is just my First/Last name sufficient? Thanks for organizing this, by the way :-). -- -Austin
Re: PGP key signing party at WineConf
On 08/11/10 08:44, Austin English wrote: Howdy Shachar, I've noticed a few pgp/gpg websites that say the key should have the persons FULL name. Is the full name required, or is just my First/Last name sufficient? Thanks for organizing this, by the way :-). In a nutshell - it depends. I, as an example, have a middle name that I seldom (i.e. - never) use. It does not appear on my PGP key. The real rule for what a PGP key should contain is your identifying name. It might well be that some of the party's participants will refuse to sign your key if the names on your key and on your identifying certificate are not 100% identical. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
On 8 November 2010 04:45, Austin Lund austin.l...@gmail.com wrote: On 8 November 2010 11:49, James McKenzie jjmckenzi...@earthlink.net wrote: Thus a second test case needs to be developed that is only for Windows7 and the remaining test skipped for Windows7. Something like what we do for Unicode tests for Windows9x/ME. Isn't the rule that the tests should only check windows versions before testing behaviour if that is what applications to a similar thing, otherwise the test isn't required? The rule is not to check Windows version, but to infer the DLL version (e.g. by checking for methods only available in newer versions of Windows). That way, installing a new version of shlwapi.dll via Internet Explorer on older systems does not break those tests. In this case, the older behaviour is deprecated, so at least needs a: todo_wine ok(broken(hr == S_OK) /* = Vista */ || hr == E_FAIL /* Win7 */, ...) or the test case needs to be removed (as different versions of Windows have conflicting behaviour, so applications cannot rely on either). If an application requires this to work the test should be: ok(hr == S_OK /* Required by SomeApp */ || broken(hr == E_FAIL) /* Win7 */, ...) - Reece
