Re: [1/1][user32.dll]Adding Arabic Translation resources

2011-01-17 Thread James McKenzie 

On 1/8/11 7:05 PM, Nowres wrote:

From a5d9d1e4599ce5a6c2f45df7948182401526f997 Mon Sep 17 00:00:00 2001
From: Nowres Rafid >

Date: Sun, 9 Jan 2011 00:54:00 +
Subject: [user32]Adding Arabic translation resources


[Patch code deleted]

Your patches are appearing in both the message and as a separate 
attachment.  Also, your patches will not apply to current git code.  Can 
you check your patches before sending them to the Patches list and 
please check if your git is current.  Please review the Wiki article on 
how to create and send patches, please.

James McKenzie

Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, dxdiagn, pngfilt; new svn repo, download url

2011-01-17 Thread Rosanne DiMesio 
On Mon, 17 Jan 2011 12:33:28 -0700
Vitaliy Margolen  wrote:

> Isn't that exactly why we marked all other scripts like this a "third party 
> unsupported tools"? If you moving the same direction, then winetricks will 
> fall into the same category - if you using it, ask Dan, don't bother asking 
> people on forum, filing bugs, etc.
> 

We already treat winetricks like that. I know I'm constantly telling users to 
reinstall to a clean wineprefix with no winetricks. The winetricks wiki page 
tells users explicitly not to report bugs here if they have used winetricks to 
install native dlls, and has a link to winezeug to report bugs in winetricks 
itself. I don't see any of that changing.

That said, I do think winetricks has become bloated. JMHO.

-- 
Rosanne DiMesio

Re: Winetricks game verbs - good or bad? (was: Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, ...)

2011-01-17 Thread Dan Kegel 
On Mon, Jan 17, 2011 at 8:31 PM, Vitaliy Margolen
 wrote:
> On 01/17/2011 01:15 PM, Dan Kegel wrote:
>> What concrete problems do you see with winetricks having
>> verbs for popular games?
>
> Does it cover Steam'ed versions?
> Different languages?

I'm curious why you ask - would covering (or not covering) Steam or
different languages lead to poor quality bug reports?
I guess you're afraid of people complaining about the tool and not about Wine?

> How about conflicts between setups for different games under one wineprefix?
> Or conflicts with existing installed software under the same wineprefix?
>
> The only scenario that would be fine with me, if winetricks will allow new
> prefix only for complete software installs. And refuse to install into
> existing one.

The author of PlayOnLinux agrees with you; that's how that tool works.

I do have code for that, but I haven't turned it on yet, since it
raises some UI issues.
I could make it the default for app installs once I iron those out.
- Dan

Re: Winetricks game verbs - good or bad? (was: Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, ...)

2011-01-17 Thread Vitaliy Margolen 

On 01/17/2011 01:15 PM, Dan Kegel wrote:

What concrete problems do you see with winetricks having
verbs for popular games?

Does it cover Steam'ed versions? Different languages?
How about conflicts between setups for different games under one wineprefix?
Or conflicts with existing installed software under the same wineprefix?

The only scenario that would be fine with me, if winetricks will allow new 
prefix only for complete software installs. And refuse to install into 
existing one.


Vitaliy.

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-17 Thread Erich Hoover 
On Sun, Jan 16, 2011 at 1:01 PM, Jacek Caban  wrote:
> On 1/15/11 12:14 AM, Erich Hoover wrote:
>> ...
>> +    hres = 
>> IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, 
>> (LPVOID*)&target);
> document may be NULL here.

Sorry, I'll take care of that.

>> +    hres = IOleCommandTarget_Exec(target, NULL, cmdID, cmdexecopt, pvaIn, 
>> pvaOut);
>
> Please write a test case for this. MSDN seems wrong in this case. It 
> indicates in one place that we should use CGID_MSHTML as group GUID, and NULL 
> in the other. The test should make it clean, which version is true.

I've looked into trying to do this test case and I'm at a bit of a
loss.  It appears that whatever I try to do the "webbrowser" tests
hijack the IOleCommandTarget, so I'm not really testing what the
"real" target does.  It instead calls the test-specific
OleCommandTarget_QueryStatus, though that test does not report any
error on the ever-so-significant line:
ok(!pguidCmdGroup, "pguidCmdGroup != MULL\n");

On a side note, do I need to resend the other two patches in that set?
 They are not dependent on this patch.

Erich Hoover
ehoo...@mines.edu

Winetricks game verbs - good or bad? (was: Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, ...)

2011-01-17 Thread Dan Kegel 
On Mon, Jan 17, 2011 at 7:33 PM, Vitaliy Margolen
 wrote:
> On 01/17/2011 11:30 AM, Dan Kegel wrote:
>> New version 20110117-alpha adds the following new verbs:
>>
>> firefox4 - beta9 of Firefox's new web browser
>> ut3 - the first-person shooter Unreal Tournament 3 (requires dvd)
>
> Isn't that exactly why we marked all other scripts like this a "third party
> unsupported tools"?

I suspect PlayOnLinux got the cold shoulder because they
use old versions of wine, they use their own patches,
they don't have a 'real' version control system for game scripts, and
they didn't communicate with the wine community.
So problem reports from PlayOnLinux users weren't very
helpful for Wine developers.

Winetricks doesn't encourage users to run old or patched wine,
and I'm not a stranger on wine-devel.

In fact, if we play our cards right, winetricks might actually
reduce the number of clueless support requests.
People have trouble following the HOWTOs in the appdb.
A winetricks verb for a game should be like a perfectly
automated little implementation of the HOWTO, with
bug workarounds clearly marked, and skipped automatically
when using new enough wine.  Better still, since it's
automated, we can run it nightly to make sure it doesn't break.

What concrete problems do you see with winetricks having
verbs for popular games?
- Dan

Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, dxdiagn, pngfilt; new svn repo, download url

2011-01-17 Thread Vitaliy Margolen 

On 01/17/2011 11:30 AM, Dan Kegel wrote:

New version 20110117-alpha adds the following new verbs:

firefox4 - beta9 of Firefox's new web browser
ut3 - the first-person shooter Unreal Tournament 3 (requires dvd)


Isn't that exactly why we marked all other scripts like this a "third party 
unsupported tools"? If you moving the same direction, then winetricks will 
fall into the same category - if you using it, ask Dan, don't bother asking 
people on forum, filing bugs, etc.


I beg to reconsider, from a useful tool to install missing pieces winetricks 
will be yet another automated tool to break Wine.


Vitaliy.

New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, dxdiagn, pngfilt; new svn repo, download url

2011-01-17 Thread Dan Kegel 
Another fortnight, another winetricks.

New version 20110117-alpha adds the following new verbs:

firefox4 - beta9 of Firefox's new web browser
ut3 - the first-person shooter Unreal Tournament 3 (requires dvd)
hegemonygold_demo - the strategy game Hegemony Gold,
dxdiag - Microsoft's native dxdiag app

plus many less noticable improvements.  It should be
ready to replace classic winetricks now... let me know if
you find it lacking.

Also, to celebrate the new version (and foil domain squatters),
I've given it an easier to remember download url:
  http://winetricks.org/winetricks-alpha

and svn repository / bug tracker:
  http://winetricks.googlecode.com

(The old download url at kegel.com/wine/winetricks-alpha will
still work, they're symlinked.)

Changelog:

Dan Kegel:
Added new verbs dxdiag, dxdiagn, firefox4, pngfilt
vc2005express: switched to offline installer to make regression testing easier
ie6: make png images work (thanks to Qian Hong for the bug report)
Allow changing -q from main menu
Experimentally mention WINEPREFIX in window title to help avoid user confusion
Don't make zenity bigger than the screen, if we can help it.
Leave less cruft in wineprefix (in particular, autohotkey)
Sped up script a bit more in cygwin

Phil Blankenship:
Ported most of the remaining verbs from classic winetricks

Shannon Vanwagner:
Added new verb hegemenygold_demo

Scott Jackson:
Added new verb ut3

Re: msvcrt: Add _atoflt and _atoflt_l implementations (try2)

2011-01-17 Thread Alexandre Julliard 
Nikolay Sivov  writes:

> I'm not sure about MSVCR_ types inside msvcr80, for wrappers it's
> enough to have an empty struct pointers, if we really need proper
> types please let me know.

You should be using the real definitions from the msvcrt headers. Also
you want the implementation in msvcr90, that's where the common
implementations and tests go.

-- 
Alexandre Julliard
julli...@winehq.org

Re: Fail to use USB-Key/USB-Shield with wine USB patch :cannot start service 'SCardSvr':win error code:0x00000424

2011-01-17 Thread Saulius Krasuckas 
* On Mon, 17 Jan 2011, Qian Hong wrote:
> 
> Dear all, after replacing winscard.dll by native windows dll and
> setting the native winscard.dll by default with winecfg,
> I got a new result,Screenshot here: http://goo.gl/7gWbt ,
> this is  the same as that the regist is modified in Windows XP:
> http://goo.gl/VNn2N

Thanks for investigation:)
You should open new bug for this, I guess.

> wine tokenadmin.exe
> 
> fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50086 0x
> fixme:wtsapi:WTSQuerySessionInformationA Stub (nil) 0x 8
> 0x32f2c4 0x32f2c0
> fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50086 0x
> fixme:win:RegisterDeviceNotificationA (hwnd=0x20072,
> filter=0xe8e9c4,flags=0x) returns a fake device notification
> handle!
> fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50086 0x
> fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50086 0x
> fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50086 0x
> fixme:win:UnregisterDeviceNotification (handle=0xcafecafe), STUB!
  ...
> After using native wtsapi32.dll and winsta.dll, there is no
> fixme:wtsapi message.

It seems these fixmes are harmless, so none of these two overrides should 
be needed.  This should be verified only after fixing previous stuff, IMHO.

> $ wine tokenadmin.exe
> fixme:win:RegisterDeviceNotificationA (hwnd=0x10090,
> filter=0xe8e9c4,flags=0x) returns a fake device notification
> handle!
> fixme:win:UnregisterDeviceNotification (handle=0xcafecafe), STUB!
> 
> I know that the native user32.dll is not compatible with wine. I'm
> afraid that I have no idea now.

What's not working now with this configuration for you?
Probably could be reported with via separate bugreport:)

> But if possible, I'll be gladly to help to test everything about wine 
> usb supporting.

Well, IIRC the USB patch you mentioned isn't officially supported by Wine 
(for now), so you could ask it's author Alexander Morozov and then Wine 
headquarters (here or on IRC) on how to integrate it public way (if 
possible in short run at all).

This would probably lead to several or even more additional bug reports.


S.

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-17 Thread James McKenzie 

On 1/17/11 1:07 AM, Dmitry Timoshkov wrote:

James McKenzie  wrote:


+ok (16 == sentLogFontA.lfHeight, "Height not set to 12 for System Font. Height 
is %d\n", sentLogFontA.lfHeight);

12?

Fixed in the next test patch.

+ok (96 == ry, "DPI for screen does not equal 96 it is %d\n", ry);
+ok (-240 == CharFont1ANSI.yHeight /* Wine */|| 195 == CharFont1ANSI.yHeight /* 
Windows */, "y Height of System Character is "
+"not -240 or 195 but is %d\n", CharFont1ANSI.yHeight);
+ok (16 == abs(CharFont1ANSI.yHeight) * ry / 1440 /*Wine*/|| 13 == 
abs(CharFont1ANSI.yHeight) * ry / 1440 /*Windows*/, \
+"Character Height of System character set is not 16 but %d\n", 
abs(CharFont1ANSI.yHeight) * ry / 1440);
+ok (0 == CharFont1ANSI.yOffset, "Character Offset for System character set is 
not zero but %x\n", CharFont1ANSI.yOffset);
+ok (7 == tma.tmAveCharWidth, "Average Character Width for System character set 
is %d\n", tma.tmAveCharWidth);
+ok (15 == tma.tmMaxCharWidth /*Wine*/ || 14 == tma.tmMaxCharWidth /*Windows*/, 
"Maximum Character Width for System character set " \
+"is %d\n", tma.tmMaxCharWidth);

Please use normal not reversed comparisons here and everywhere else, that
style improves nothing.
Actually this did catch an error where I used equal (=) instead of equal 
to (==) and that is a couple of best coding practice books that I use.  
However, for the final patch, this will be removed in its entirety.  
There is a difference between what Windows is returning and what Wine is 
returning but that is not the purpose of this patch.


James McKenzie

Re: Fail to use USB-Key/USB-Shield with wine USB patch :cannot start service 'SCardSvr':win error code:0x00000424

2011-01-17 Thread Alexander Morozov 
> I have winedumped all the .sys files and tared them together here:
> http://goo.gl/bEu03
Drivers import smclib.sys and wmilib.sys which are not implemented. And I 
doubt that they will be implemented soon (or ever).
Also winscard way seems to me to be more right in this case.

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-17 Thread Dmitry Timoshkov 
James McKenzie  wrote:

> +ok (16 == sentLogFontA.lfHeight, "Height not set to 12 for System Font. 
> Height is %d\n", sentLogFontA.lfHeight);

12?

> +ok (96 == ry, "DPI for screen does not equal 96 it is %d\n", ry);
> +ok (-240 == CharFont1ANSI.yHeight /* Wine */|| 195 == 
> CharFont1ANSI.yHeight /* Windows */, "y Height of System Character is "
> +"not -240 or 195 but is %d\n", CharFont1ANSI.yHeight);
> +ok (16 == abs(CharFont1ANSI.yHeight) * ry / 1440 /*Wine*/|| 13 == 
> abs(CharFont1ANSI.yHeight) * ry / 1440 /*Windows*/, \
> +"Character Height of System character set is not 16 but %d\n", 
> abs(CharFont1ANSI.yHeight) * ry / 1440);
> +ok (0 == CharFont1ANSI.yOffset, "Character Offset for System character 
> set is not zero but %x\n", CharFont1ANSI.yOffset);
> +ok (7 == tma.tmAveCharWidth, "Average Character Width for System 
> character set is %d\n", tma.tmAveCharWidth);
> +ok (15 == tma.tmMaxCharWidth /*Wine*/ || 14 == tma.tmMaxCharWidth 
> /*Windows*/, "Maximum Character Width for System character set " \
> +"is %d\n", tma.tmMaxCharWidth);

Please use normal not reversed comparisons here and everywhere else, that
style improves nothing.

Also comments like /*Wine*/ and /*Windows*/ suggest that the tests deserve
at least a todo_wine around them.

Testing a return value of SendMessage() everywhere is also highly recommended
to make sure that the call really has any affect.

-- 
Dmitry.

Re: wined3d: don't set cube and volume POW2 caps if np2 textures are supported

2011-01-17 Thread Stefan Dösinger 
Am Sonntag 16 Januar 2011, 23:54:58 schrieb Henri Verbeet:
> Did this patch go anywhere? AFAIK Matteo already fixed the tests.

I believe I resent it, but maybe it got lost. I'll check.


signature.asc
Description: This is a digitally signed message part.