Re: [PATCH] advapi32: Set *lpSize properly in GetUserNameA (try2)
On Sat, Jul 02, 2011 at 11:49:44AM +0300, Alex Stanev wrote: --- dlls/advapi32/advapi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c index e135fa5..7025a21 100644 --- a/dlls/advapi32/advapi.c +++ b/dlls/advapi32/advapi.c @@ -65,7 +65,7 @@ GetUserNameA( LPSTR lpszName, LPDWORD lpSize ) ret = GetUserNameW( buffer, sizeW ); if (ret) -WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); +*lpSize = WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); else *lpSize = sizeW; For completeness, the else part also needs to convert the wide character cound in sizeW to the A character cound in *lpSize. Not sure how though. Ciao, Marcus
Re: Glitch-free iTunes?
On Mon, Jul 4, 2011 at 04:44, Keith Curtis keit...@gmail.com wrote: ... In general, people can work where they want, but it is better if some work is prioritized. Well indeed volunteers work where they want, but also on the parts they're good at (not everybody is interested, and if they're are, they can lack the expertise in that domain). If you try to force contributors to work on something they don't like (or refuse work on sthg else), they generally won't agree, and probably even stop contributing altogether. Now it's probably different for codeweavers employees, and I'm sure they have priorities, but they don't necessarily match yours. You don't need to use the buglist for this. When Linus finds a bug he needs fixed before he can make a release, he posts to the LKML and all the developers read it and the relevant ones respond. Typically he reverts, but sometimes he requests help, and he gets it within hours. He doesn't wait for someone to check in code that works. This isn't about a random bug. IIRC you were basically talking about adding USB support which, as Damjan pointed out, needs a lot of work to be complete. ... Regards, -Keith http://keithcu.com/ Just my 2 ¢ Frédéric
Re: Random crashes while running (cmd) test runner
On Sat, Jul 02, 2011 at 09:31:52PM +0200, Frédéric Delanoy wrote: Hi folks, I'm in the process of writing a couple of cmd tests (on top of master, not of my currently pending patches), and I at times have problems where none of the tests is actually performed, but the test suite still returns without any error indication, e.g. batch.c:306: running TEST_BUILTINS.CMD test... batch: 7 tests executed (0 marked as todo, 0 failures), 0 skipped. which many more tests should be performed After checking with winedbg --gdb it gets a SIGSEGV I tried to reproduce with a mimimal output file and expected file, and get weird results. Say you have the following files: test_builtins.cmd @echo off echo should fail empty line and test_builtins.cmd.exp dir empty line When I run make testclean make test in programs/cmd/tests, I get the following (first line of .exp file executed somehow...) batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is - Directory of Z:\path\to\wine\programs\cmd\tests 2/07/2011 20:56 DIR . 2/07/2011 14:34 DIR .. 2/07/2011 2:3411,074 batch.c ... batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. If I run /wine winedbg --gdb programs/cmd/tests/cmd.exe_test.exe.so and run (c)ont, I get a SIGSEGV: Program received signal SIGSEGV, Segmentation fault. 0x7bc481f2 in HEAP_MakeInUseBlockFree (subheap=0x110014, pArena=0x1106a8) at heap.c:640 640 size += (pFree-size ARENA_SIZE_MASK) + sizeof(ARENA_FREE); If you could run this with export WINEDEBUG=+heap This should show the heap corruption way earlier, but gets a lot of debugoutput. Redirect to a file, and look for the first instancnes of corruption. Add more debugging to WINEDEBUG to see where it does fail... Ciao, Marcus
Re: Random crashes while running (cmd) test runner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 04.07.2011 um 10:28 schrieb Marcus Meissner: export WINEDEBUG=+heap WINEDEBUG=warn+heap adds the corruption checking but not the debug output -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOEXvvAAoJEN0/YqbEcdMwN6IP/RTfEAVHWl+Mj2W7IsZCaXch RRkIf+7K0i5/55nICEFkLXyb5qGnsOWsqfsRjsjD/7ts3izOlAPYUiKWIUKAbJL/ 3u8KP4R+iD6ce9KbTbh0bR6+Dp0Ma0c+qyAUBTXsZxKO6tTHUjnVtDykoLfT9hO9 Vu/XwPE+ndQjA7ctij7FnLfPSWTDzH1S+7ndpFGxAbM0zmrZKbh40NFL9PO0AD+n teOt+lVlIjb97wPdD8gEWaHdqxFJxp1ibzzXTdF9bHZe53W31hSTJXQI7OWw+Ara Pm2SonEztDF95tAb9MgWvlE4jyXGxe6olYIVNV6vXFpkV6CzwBePKElnLO65U5T1 wW2FGrh7KY6BrOGaKax9KVwKkHIhc5uwxFzhHhojrvjcIdJRrz4PyaD5/dEJE14o B31xR3zM0lBvhtGFV81ytj6+RqIPoCV2MOpvk2YnkGmSnr7Y1Tpp/jz9pto28JER 0cV/u5ZKE1OSr3JnOXGCF0mybkmjzQ7JY6HV65bHl51gHCq2tNxsEIU/Z3QUwdrB +6zm+3ZKY1NkUztBy94F9zMvhyDrMxGbAZ4Fa2JVCin98K/0zGyalj/WNlO0AaO8 SiL6ypDXcqmt/a7NxgBldNM+HQqYlupzfqtiltVx45h88O/L66gVxYLqh+hzSDqm zr6esW7FhqYGWdGuclVO =0F0m -END PGP SIGNATURE-
Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
On Sun, Jul 3, 2011 at 6:25 PM, Dylan Smith dylan.ah.sm...@gmail.com wrote: The latest ConvertPointRepsToAdjacency patches look good. Good I'll sit on a bit and send ConvertAdjacencyToPointReps to wine-patches in the meantime.
Re: Random crashes while running (cmd) test runner
2011/7/4 Stefan Dösinger stefandoesin...@gmx.at: Am 04.07.2011 um 10:28 schrieb Marcus Meissner: export WINEDEBUG=+heap WINEDEBUG=warn+heap adds the corruption checking but not the debug output I get the following: batch.c:306: running TEST_BUILTINS.CMD test... batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is - (dir output) err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c8a0 tail overwritten at 0x11c8bc (byte 0/12 == 0x64) batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. See http://pastebin.com/T4E63M5S for full log and heap dump Frédéric
Re: uuid: Add CLSID_DestinationList
Hi André, On 07/03/11 13:35, André Hentschel wrote: --- dlls/uuid/uuid.c |1 + include/shobjidl.idl |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c index d4ad2ae..0ad0425 100644 --- a/dlls/uuid/uuid.c +++ b/dlls/uuid/uuid.c @@ -123,6 +123,7 @@ DEFINE_GUID(CLSID_TF_CategoryMgr, 0xA4B544A1,0x438D,0x4B41,0x93,0x25,0x8 DEFINE_GUID(CLSID_TF_LangBarMgr, 0xebb08c45,0x6c4a,0x4fdc,0xae,0x53,0x4e,0xb8,0xc4,0xc7,0xdb,0x8e); DEFINE_GUID(CLSID_TF_DisplayAttributeMgr, 0x3ce74de4,0x53d3,0x4d74,0x8b,0x83,0x43,0x1b,0x38,0x28,0xba,0x53); DEFINE_GUID(CLSID_TaskbarList, 0x56fdf344,0xfd6d,0x11d0,0x95,0x8a,0x00,0x60,0x97,0xc9,0xa0,0x90); +DEFINE_GUID(CLSID_DestinationList, 0x77f10cf0,0x3db5,0x4966,0xb5,0x20,0xb7,0xc5,0x4f,0xd3,0x5e,0xd6); DEFINE_GUID(GUID_TFCAT_TIP_KEYBOARD, 0x34745c63,0xb2f0,0x4784,0x8b,0x67,0x5e,0x12,0xc8,0x70,0x1a,0x31); DEFINE_GUID(GUID_TFCAT_TIP_SPEECH, 0xB5A73CD1,0x8355,0x426B,0xA1,0x61,0x25,0x98,0x08,0xF2,0x6B,0x14); DEFINE_GUID(GUID_TFCAT_TIP_HANDWRITING, 0x246ecb87,0xc2f2,0x4abe,0x90,0x5b,0xc8,0xb3,0x8a,0xdd,0x2c,0x43); diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 1b4d385..8b6b735 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -3293,6 +3293,8 @@ interface ICustomDestinationList : IUnknown HRESULT AbortList(); } +cpp_quote(EXTERN_C const CLSID CLSID_DestinationList;) + /* * ShellObjects typelibrary */ This should be declared as coclass in shobjidl.idl, it's part of my recent patch. Jacek
Re: [1/6] wined3d: rename the rt mask generation functions (try 2)
Hi Alexandre, Please don't apply those patches yet, I just noticed that they cause some issues with backbuffer offscreen rendering. Thanks, Stefan On Saturday 02 July 2011 11:57:22 Stefan Dösinger wrote: This patch is unmodified, patch 2 moves the bulk of the new code into context.c rather than state.c to reduce the number of functions exported in wined3d_private.h signature.asc Description: This is a digitally signed message part.
Re: Random crashes while running (cmd) test runner
On Mon, Jul 04, 2011 at 12:32:47PM +0200, Frédéric Delanoy wrote: 2011/7/4 Stefan Dösinger stefandoesin...@gmx.at: Am 04.07.2011 um 10:28 schrieb Marcus Meissner: export WINEDEBUG=+heap WINEDEBUG=warn+heap adds the corruption checking but not the debug output I get the following: batch.c:306: running TEST_BUILTINS.CMD test... batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is - (dir output) err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c8a0 tail overwritten at 0x11c8bc (byte 0/12 == 0x64) batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. See http://pastebin.com/T4E63M5S for full log and heap dump The first error appears around line 328: trace:heap:RtlAllocateHeap (0x11,7062,001c): returning 0x11c898 err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c898 tail overwritten at 0x11c8b4 (byte 0/12 == 0x64) Heap: 0x11 Next: 0x11 Sub-heaps: 0x110014 Free lists: Block Stat SizeId It would be interesting to know what happened there in the testsuite. You could e.g. add +relay or similar. Ciao, Marcus
Re: Random crashes while running (cmd) test runner
On Mon, Jul 4, 2011 at 13:37, Marcus Meissner meiss...@suse.de wrote: On Mon, Jul 04, 2011 at 12:32:47PM +0200, Frédéric Delanoy wrote: 2011/7/4 Stefan Dösinger stefandoesin...@gmx.at: Am 04.07.2011 um 10:28 schrieb Marcus Meissner: export WINEDEBUG=+heap WINEDEBUG=warn+heap adds the corruption checking but not the debug output I get the following: batch.c:306: running TEST_BUILTINS.CMD test... batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is - (dir output) err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c8a0 tail overwritten at 0x11c8bc (byte 0/12 == 0x64) batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. See http://pastebin.com/T4E63M5S for full log and heap dump The first error appears around line 328: trace:heap:RtlAllocateHeap (0x11,7062,001c): returning 0x11c898 err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c898 tail overwritten at 0x11c8b4 (byte 0/12 == 0x64) Heap: 0x11 Next: 0x11 Sub-heaps: 0x110014 Free lists: Block Stat Size Id It would be interesting to know what happened there in the testsuite. You could e.g. add +relay or similar. http://pastebin.com/6bV5BGQc
Re: Random crashes while running (cmd) test runner
On Mon, Jul 04, 2011 at 02:01:31PM +0200, Frédéric Delanoy wrote: On Mon, Jul 4, 2011 at 13:37, Marcus Meissner meiss...@suse.de wrote: On Mon, Jul 04, 2011 at 12:32:47PM +0200, Frédéric Delanoy wrote: 2011/7/4 Stefan Dösinger stefandoesin...@gmx.at: Am 04.07.2011 um 10:28 schrieb Marcus Meissner: export WINEDEBUG=+heap WINEDEBUG=warn+heap adds the corruption checking but not the debug output I get the following: batch.c:306: running TEST_BUILTINS.CMD test... batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is - (dir output) err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c8a0 tail overwritten at 0x11c8bc (byte 0/12 == 0x64) batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. See http://pastebin.com/T4E63M5S for full log and heap dump The first error appears around line 328: trace:heap:RtlAllocateHeap (0x11,7062,001c): returning 0x11c898 err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x11c898 tail overwritten at 0x11c8b4 (byte 0/12 == 0x64) Heap: 0x11 Next: 0x11 Sub-heaps: 0x110014 Free lists: Block Stat Size Id It would be interesting to know what happened there in the testsuite. You could e.g. add +relay or similar. http://pastebin.com/6bV5BGQc 003c:Call ntdll.RtlAllocateHeap(0011,,001c) ret=7effad94 trace:heap:RtlAllocateHeap (0x11,7062,001c): returning 0x1213d8 003c:Ret ntdll.RtlAllocateHeap() retval=001213d8 ret=7effad94 003c:Call KERNEL32.TlsGetValue() ret=7effc041 003c:Ret KERNEL32.TlsGetValue() retval=00120b28 ret=7effc041 003c:Call KERNEL32.TlsGetValue() ret=7effc041 003c:Ret KERNEL32.TlsGetValue() retval=00120b28 ret=7effc041 003c:Call KERNEL32.CreateFileA(7effd262 test.cmd,4000,,,0002,0080,) ret=7effaf5a err:heap:HEAP_ValidateInUseArena Heap 0x11: block 0x1213d8 tail overwritten at 0x1213f4 (byte 0/12 == 0x64) Heap: 0x11 Next: 0x11 Sub-heaps: 0x110014 As it happens right before the test.cmd creation, it is very likely the function static const char* replace_escaped_spaces(const char *data, DWORD size, DWORD *new_size) At least the final \0 seems not to be counted during the HeapAlloc() in this function, perhaps just adding +1 in the HeapAlloc() will help. Ciao, Marcus
Re: Glitch-free iTunes?
Hi Keith, WINE in general does many things, and you've got a big team now. Your contributor list shows 1250 and you've got 2M lines of code. Few of these contributors remain active. Most had small contributions. The total number of contributors obviously can only increase over time, but the number of active contributors has always remained small. But really, what are we talking about? Talk is cheap. Code isn't. Your contributions are welcome. --Juan
Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12181 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 03/10] server+user32: Added GetRawInputDeviceList implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12182 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 10/10] server+user32: Added RIDEV_NOLEGACY raw input device flag implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12189 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 05/10] user32: Added GetRawInputDeviceInfoA implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12184 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 09/10] server+user32: Added GetRawInputData implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12188 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 04/10] server+user32: Added GetRawInputDeviceInfoW implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12183 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 07/10] server+user32: Added RegisterRawInputDevices implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12186 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 06/10] server+user32: Added GetRegisteredRawInputDevices implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12185 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: [PATCH 08/10] user32: Added GetRawInputBuffer implementation (try 12)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12187 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout
Re: Glitch-free iTunes?
On 07/02/2011 03:46 PM, Keith Curtis wrote: Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my_itunes.html You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith Everyone (with very few if any exceptions) who works on Wine does so because they want to. Priorities are set by each person for themselves. That is simply a fact of life when it comes to community developed software. You are, of course, entitled to your opinion of what is important but you need to persuade rather than trying to command compliance with your wishes. One of the most effective ways to assure progress on a particular piece of Wine is to put your own effort into improving that particular piece. In the case of iTunes, one of the early steps would be to examine the log Wine produces when you try to install it or run it. This is likely to show that some particular function is not implemented or is not implemented properly. Next, write a test that demonstrates what should happen. Make sure it works on recent native Windows versions. Submit the new test as a patch. Then fix Wine so that it passes that test and does not fail any existing tests due to your changes. Once the test patch has been accepted, check that you changes to Wine pass the new test. Finally, submit your change to Wine. At that point there will be one less thing that keeps iTunes from running on Wine. Other things you need to keep in mind: 1. Does it run on Windows? iTunes is an Apple product and it could be that it has been intentionally implemented so that it does not run on Microsoft's OS. 2. Are there legal issues that would keep it from being run under Wine? 3. Assure that your code meets the Wine style.
Re: Glitch-free iTunes?
On 4 July 2011 15:32, Juan Lang juan.l...@gmail.com wrote: But really, what are we talking about? Talk is cheap. Code isn't. Your contributions are welcome. In principle yes, but having worked for Microsoft complicates that a bit.
Re: Glitch-free iTunes?
Am 04.07.2011 20:08, schrieb max: 1. Does it run on Windows? iTunes is an Apple product and it could be that it has been intentionally implemented so that it does not run on Microsoft's OS. Why then providing a Windowsversion??? :) -- Best Regards, André Hentschel
Re: Glitch-free iTunes?
On 07/04/2011 02:15 PM, André Hentschel wrote: Am 04.07.2011 20:08, schrieb max: 1. Does it run on Windows? iTunes is an Apple product and it could be that it has been intentionally implemented so that it does not run on Microsoft's OS. Why then providing a Windowsversion??? :) So you are saying it runs on MS Windows. That answers the question. Thanks.
Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
Am 04.07.2011 16:29, schrieb Vincas Miliūnas: Changelog: Hi, even if you have 10 patches, maybe first try to get the tests in. Divide and Conquer! That's at least a bit less mess on wine-patches for now, and is easier for you and AJ i guess. -- Best Regards, André Hentschel
Re: Glitch-free iTunes?
None of the Linux kernel developers are paid by Linus nor can be fired by him. Linus never forces people to respond to his mails or to work on anything. What has happened is that the team has realized that having goals and leadership has led to good results, and Linus is a good leader, and so they follow along. If Linus says something needs to be worked on, it happens. The rest of the people keep doing their own work. I'm not suggesting to force people to work on iTunes. However, it shouldn't take too much prodding for people to want Linux to work with one of the most important hardware product lines. It is sad that Linux in 2011 cannot run iTunes. This is the fault of WINE and Apple. Maybe the work has been slow. I can't speak to how quickly you are moving, only the results. I have read through your code some years ago. The software that existed was high quality. You keep getting bigger and better. I understand you have a lot of work to do. That is why I suggest priorities or goals. They help manage large workloads. From the outside, you appear to be working on things randomly, and you can do better. Regards, -Keith http://keithcu.com/
Re: Glitch-free iTunes?
On 7/4/11 7:50 PM, Keith Curtis wrote: None of the Linux kernel developers are paid by Linus nor can be fired by him. Linus never forces people to respond to his mails or to work on anything. What has happened is that the team has realized that having goals and leadership has led to good results, and Linus is a good leader, and so they follow along. If Linus says something needs to be worked on, it happens. The rest of the people keep doing their own work. I think you missed my point. There is a 'leader' for Linux and that person just happens to be Linus. Whether or not he wants that position is pointless. He has it. Linux is and will remain his 'baby'. There is NO such person, that I'm aware of for Wine. Thus if I happen to 'need' to have a few functions in Wine I have two options: 1. File a bug report, categorize it, define it and then hope that someone has the skills and desire to fix the problem I've identified. 2. File a bug report, categorize it, define it and then fix it myself. I have two bug reports that I have worked on and now I'm working on code to bring those functions into Wine, with assistance from other Wine developers to insure that my code is high enough quality and is implemented properly. You have the same options as does everyone else. And yes, if you look through Wine's bugzilla you will see very old bugs (that is why I mentioned the DIB Engine, it is bug 421 and is almost ten years old) to bugs filed yesterday. All need love and attention. Some bug reports were opened only to be closed when this did not happen. Also, remember what is important to you may not be so for the entire project. That is why I'm working on code. Those functions are important to me, but to the overall project no so. There is one other difference between the LKM project and Wine. The Linux Kernel is essential to the functioning of Linux. Wine is only essential to getting well-behaved Windows programs to run on Linux/UNIX. There are some programs that started the project, many years ago, that are no longer available or now have Linux/UNIX equivalents. James
Re: oleaut32: use the locale settings for digit group sizes
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12210 Your paranoid android. === WNT4WSSP6 (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x Format #,#: expected 0x, '12,34,56,789', got 0x, '123,456,789' === WVISTAADM (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x Format #,#: expected 0x, '12,34,56,789', got 0x, '123,456,789' === W2K8SE (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x Format #,#: expected 0x, '12,34,56,789', got 0x, '123,456,789' === W7PRO (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x Format #,#: expected 0x, '12,34,56,789', got 0x, '123,456,789'
Re: Glitch-free iTunes?
I bring up Linus because he can focus efforts. You don't need Linus. You just need the same result -- focused efforts. There is another name for this concept -- teams. Maybe WINE needs sub-teams? I assure you that the problem isn't for lack of resources. I know you feel busy and perhaps that I'm just wasting your time. However, you have accomplished so much already. Year after year, you accomplish more, and yet you just think that it is hopeless or something. Are you masochists? If you are going to do the work, make goals worthy. And one worthy goal is iTunes runs better than on Windows. If you had that as a goal 5 years ago, you would have succeeded by now. I can think of more goals around Ableton, Office 2010, etc. but for now let's get the hardware working! I understand that WINE has many apps that you want to work. You are doing well. It is just missing some features that are not being caught by your random work. I know you'll get there, in the next 10 years. Perhaps by the time Apple no longer matters you'll have it working. I have my own projects, but I appreciate your interest in my patches. However, I find that my way to contribute is to report social bugs and suggested patches. It can be though about in terms of: planning, priorities, goals, leaders, teams, etc. There are multiple ways to fix this. Regards, -Keith http://keithcu.com/
Re: GSoC: dinput8 Action Mapping
Hi guys. Now that all the initial patches are in I have several smaller tasks to work on as listed here http://lfzawacki.heroku.com/wine/published/Road+Map and hopefully they're more straightforward. I've already started working on getting EnumDevicesBySemantics correct with joysticks and the passed flags and, after that, BuildActionMap for the joysticks will follow. Maybe now it's time to discuss how to implement EnumDevicesBySemantics as a crosscall, but I really don't know how to do it (or if it's worth it) and everywhere I look in dinput I see similar cases of this duplication pattern. Another thing that I've been thinking is that I might as well end up rolling a version of ConfigureDevices (http://msdn.microsoft.com/en-us/library/microsoft.directx_sdk.idirectinput8.idirectinput8.configuredevices%28v=VS.85%29.aspx) because so far I've seen two of the games affected by bug 8754 use it to configure controls. I've not had time to find and test all of them, but if someone on the list knows about other games that use it I'd like to be informed. Last but not least, thanks for Wylda for testing NFSU and keeping bug 8754 informed. I actually can't run the game properly, most likely because of the crappy intel graphics card in my laptop. Anyway, feedback on the tasks is welcome. --- lfz
Re: Glitch-free iTunes?
On Tue, Jul 5, 2011 at 4:50 AM, Keith Curtis keit...@gmail.com wrote: None of the Linux kernel developers are paid by Linus nor can be fired by him. Linus never forces people to respond to his mails or to work on anything. What has happened is that the team has realized that having goals and leadership has led to good results, and Linus is a good leader, and so they follow along. If Linus says something needs to be worked on, it happens. The rest of the people keep doing their own work. I'm not suggesting to force people to work on iTunes. However, it shouldn't take too much prodding for people to want Linux to work with one of the most important hardware product lines. It is sad that Linux in 2011 cannot run iTunes. This is the fault of WINE and Apple. Maybe the work has been slow. I can't speak to how quickly you are moving, only the results. I have read through your code some years ago. The software that existed was high quality. You keep getting bigger and better. It's easy for Linus to ask people to fix regressions, and they get it done in a few hours, under threat of their patches getting thrown out. Unlike the kernel (and to its detriment), we have regression tests which work even better for that, because they stop bad code from getting committed in the first place, and during a release freeze extra efforts are made to reduce regressions. But adding a new feature is something completely different, because it's not a matter of fixing existing code, but producing new code. I understand you have a lot of work to do. That is why I suggest priorities or goals. They help manage large workloads. From the outside, you appear to be working on things randomly, and you can do better. If: I = importance of a bug W = work needed then I/W is the probability the bug gets fixed eg. Wine doesn't compile - I is huge - fix is rapid a small typo - W is tiny - fix is rapid iTunes has native alternatives, few people have iXxx devices, Apple fans generally use MacOS anyway - I is small fix requires device drivers, changes to multiple systems, knowledge of Windows and Wine internals - W is large So the I/W for iTunes is tiny. In fact the only reason it might get fixed by me is because iXxx devices are part of the larger group of USB devices, thus making I larger without increasing W. It's worth noting W is always large for hardware problems. Serial port support in Wine has also dragged on for years, had many bugs and regressions, needed kernel changes for some USB to serial converters, and still doesn't always work because the kernel API is too limited. Relative mouse events needed X changes and have also dragged on. Sound support in Wine has also taken forever. From what I see this isn't unique to Wine, hardware support is the bane of every open source project - even the kernel doesn't always boot. We could really use some kind of public hardware test farm. You're convinced me to prioritize my work on USB support, but it will still be +/- end of 2011, with luck. Regards, -Keith http://keithcu.com/ Damjan
