IPv6 issue on TestBot?
Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it from my desktop very annoying. $ time wget -4 --quiet http://testbot.winehq.org/ real0m2.150s user0m0.000s sys 0m0.000s $ time wget -6 --quiet http://testbot.winehq.org/ ... still stuck after 6+ minutes $ telnet -6 testbot.winehq.org Trying 2001:888:2000:38:1000::2... ... same thing According to http://test-ipv6.com/ my desktop is configured just fine and I only have trouble with the TestBot. Could this be a firewall problem? (testbot exposing an IPv6 address but the firewall dropping any IPv6 packets) In the mean time I'm going to use my laptop which is still IPv4 only :-/ -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ A black hole is just God dividing by zero.
Re: [PATCH 02/21] vbscript: Added function compiler implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14220 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 05/21] vbscript: Added function invocation supprot to do_icall
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14221 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 02/21] vbscript: Added function compiler implementation
On 09/14/11 13:05, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14220 Your paranoid android. Here are results of combined patch series submitted manually to testbot: https://testbot.winehq.org/JobDetails.pl?Key=14219 Jacek
Re: [PATCH 08/21] vbscript: Added sub argument tests
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14222 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 09/21] vbscript: Added exit sub statement implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14223 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 19/21] vbscript: Added interp_xor implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14230 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 10/21] vbscript: Added support for sub local variables
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14224 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found
Re: [PATCH 06/21] vbscript: Added function arguments compiler implementation
On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban ja...@codeweavers.com wrote:
--- a/dlls/vbscript/compile.c
+++ b/dlls/vbscript/compile.c
@@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx,
function_decl_t *decl, functi
func-code_ctx = ctx-code;
func-type = decl-type;
+func-arg_cnt = 0;
if(decl-args) {
...
+}else {
+decl-args = NULL;
I think you want to set func-args to NULL at the last line.
Cheers,
Octavian
Re: [PATCH 06/21] vbscript: Added function arguments compiler implementation
On 09/14/11 13:47, Octavian Voicu wrote:
On Wed, Sep 14, 2011 at 1:56 PM, Jacek Cabanja...@codeweavers.com wrote:
--- a/dlls/vbscript/compile.c
+++ b/dlls/vbscript/compile.c
@@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx,
function_decl_t *decl, functi
func-code_ctx = ctx-code;
func-type = decl-type;
+func-arg_cnt = 0;
if(decl-args) {
...
+}else {
+decl-args = NULL;
I think you want to set func-args to NULL at the last line.
Yeah, good catch, thanks.
Jacek
Re: [PATCH 1/3] server: certain access flags are illegal for OpenMutex
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14233 Your paranoid android. === WNT4WSSP6 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2KPROSP4 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WXPPROSP3 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K3R2SESP2 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WVISTAADM (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K8SE (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PRO (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (64 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5
re: [PATCH 11/21] vbscript: Added function parser implementation
Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). On Wed, Sep 14, 2011 at 7:17 AM, build...@kegel.com wrote: This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/35 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 Errors: vbscript.c:443: Test failed: expected OnEnterScript vbscript.c:444: Test failed: expected OnLeaveScript make: *** [vbscript.ok] Error 2
Re: [PATCH 11/21] vbscript: Added function parser implementation
Hi Dan, On 09/14/11 16:49, Dan Kegel wrote: Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). Thanks for the report, I've sent a fixed version.
Re: [PATCH 11/21] vbscript: Added function parser implementation
On Wed, Sep 14, 2011 at 7:56 AM, Jacek Caban ja...@codeweavers.com wrote: Hi Dan, On 09/14/11 16:49, Dan Kegel wrote: Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). Thanks for the report, I've sent a fixed version. Great. That's the first win for the warn+heap buildbot, I think.
quartz: Fix converting between the media time and REFTIME
Hi, I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. Is quartz very decoupled from the underlying audio information? Who stops the clock (if at all) while the stream is paused? BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell http://bugs.winehq.org/show_bug.cgi?id=20232#c10 However every time I tried, I found mciqtz too underpowered to be able to reasonably use it. :-( Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: wine wintest.exe mcishell open foo.wav alias w type mpegvideo status w length play w from 0 notify wait close w # lots of other commands are available open foo.avi alias a type mpegvideo window a state show status a length play a from 0 close a Omit the type mpegvideo and mciwave or mciavi will be used instead of mciqtz32.dll Regards, Jörg Höhle
Re: quartz: Fix converting between the media time and REFTIME
On Wed, Sep 14, 2011 at 9:07 AM, joerg-cyril.hoe...@t-systems.com wrote: I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. At least for what I've been dealing with so far quartz uses dsound for handling the underlying buffers. So, I would imagine if you've solved the quirks for dsound then you've likely handled quartz as well. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. There are a few different ways to *return* time in quartz, but it appears that everything comes down to the reference clock eventually. Have you looked at REFERENCE_TIME and IReferenceClock?.http://msdn.microsoft.com/en-us/library/dd377507%28v=vs.85%29.aspx Is quartz very decoupled from the underlying audio information? From my exploration it appears to be, but I'm not an expert yet. In the patch you're replying to I just corrected the time conversion between IMediaSeeking (which uses REFERENCE_TIME, LONGLONG measured in 100ns) and IMediaPosition (which uses REFTIME, double measured in seconds). I am trying to look into the time handling further though, as the background music stutters horribly in Fallout 3 (though it works great in Fallout New Vegas). Who stops the clock (if at all) while the stream is paused? At least in Wine the reference clock is not stopped when a stream is paused. When pausing the clock is retrieved and stored (MediaControl_Pause) and then on resume it is retrieved again and adjusted to create a new start time (MediaControl_Run). From the reading I've done I don't think there is a way to stop the reference clock, aside from writing and using your own custom clock. I hope that helps somewhat. I'm not sure exactly what you're trying to do wrt. testing quartz, but if there's some way I can help then please let me know. Erich Hoover ehoo...@mines.edu
Re: quartz: Fix converting between the media time and REFTIME
Hey, On 09/14/2011 05:07 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. Is quartz very decoupled from the underlying audio information? Who stops the clock (if at all) while the stream is paused? There are 3 different times in quartz which makes it all confusing. However, wine just saves the time when pausing, and subtracts the difference when running again, so for audio clocks it would be a noop, but for wall clocks it's necessary to continue it again without skipping for the amount of time paused. http://msdn.microsoft.com/en-us/library/dd374626%28v=vs.85%29.aspx There is also a separate time for seeking, where it corresponds to the time in the file, for example when you seek to 03:10 in a video. This makes it kind of confusing, and wine doesn't handle it completely right in the parsers iirc, but with wineqtdecoder and winegstreamer, that isn't much of an issue. :) BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell http://bugs.winehq.org/show_bug.cgi?id=20232#c10 However every time I tried, I found mciqtz too underpowered to be able to reasonably use it. :-( Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: wine wintest.exe mcishell open foo.wav alias w type mpegvideo status w length play w from 0 notify wait close w # lots of other commands are available open foo.avi alias a type mpegvideo window a state show status a length play a from 0 close a Omit the type mpegvideo and mciwave or mciavi will be used instead of mciqtz32.dll I have some mciqtz changes in http://repo.or.cz/w/wine/multimedia.git/blobdiff/327ce94048dba45c0ed8f727b44aaae6c71a92db..0dc86046e6bec6b0a308c9aab19b8ca4b1c08958:/dlls/mciqtz32/mciqtz.c But I lost track, so I don't know how valid those are still.
[RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl
Hello.
I've seen that this patch is in pending state, and I would like to
know what is the problem with it. Also, if commenting the tests isn't a
policy you want to enforce (that I would understand), I'm ready to skip
them on wine, but how to?
Those tests were made with midl from Visual Studio 10, with or without
/Os option, and ran smoothly.
http://www.winehq.org/pipermail/wine-patches/2011-August/106200.html
Regards.
Jérôme.
Le 06/09/2011 00:50, Jérôme Gardou a écrit :
Also, the added function which seems to be useless permits to detect
the problem that the next patch fixes.
Enable -Oif, and the test of server.c line 947 (after patch
application) will fail.
---
dlls/rpcrt4/tests/server.c | 46
++
dlls/rpcrt4/tests/server.idl |1 +
2 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/dlls/rpcrt4/tests/server.c b/dlls/rpcrt4/tests/server.c
index eb8f061..9eaf7cc 100644
--- a/dlls/rpcrt4/tests/server.c
+++ b/dlls/rpcrt4/tests/server.c
@@ -36,6 +36,8 @@
static const char *progname;
static BOOL old_windows_version;
+/* To know if the IDL file was parsed with or without widl -Oif or midl /Oif */
+static BOOL old_midl_flags;
static HANDLE stop_event;
@@ -604,6 +606,10 @@ int __cdecl s_echo_ranged_int(int n)
return n;
}
+void __cdecl s_some_ranged_func(int n)
+{
+}
+
void __cdecl s_get_ranged_enum(renum_t *re)
{
*re = RE3;
@@ -811,6 +817,7 @@ basic_tests(void)
str_t str;
se_t se;
renum_t re;
+ unsigned long exception;
ok(int_return() == INT_CODE, RPC int_return\n);
@@ -939,6 +946,42 @@ basic_tests(void)
x = echo_ranged_int(100);
ok(x == 100, echo_ranged_int() returned %d instead of 100\n, x);
+/* Crashes on wine
+ exception = 0;
+ RpcTryExcept
+ {
+ x = echo_ranged_int(150);
+ }
+ RpcExcept(TRUE)
+ {
+exception = RpcExceptionCode();
+ }
+ RpcEndExcept
+ if(old_midl_flags)
+ {
+ok(x == 150, echo_ranged_int() returned %d instead of 0\n, x);
+ok(exception == 0, echo_ranged_int() threw an exception : %lu\n,
exception);
+ }
+ else
+ {
+ok(x == 100, echo_ranged_int() returned %d instead of throwing
exception\n, x);
+ok(exception == RPC_X_BAD_STUB_DATA, Wrong exception : %lu\n, exception);
+ }
+
+ exception = 0;
+ RpcTryExcept
+ {
+ x = echo_ranged_int(75);
+ }
+ RpcExcept(TRUE)
+ {
+exception = RpcExceptionCode();
+ }
+ RpcEndExcept
+ ok(x == 75, echo_ranged_int() returned %d instead of 0\n, x);
+ ok(exception == 0, echo_ranged_int() threw an exception : %lu\n,
exception);
+*/
+
if (!old_windows_version)
{
get_ranged_enum(re);
@@ -1626,6 +1669,9 @@ START_TEST(server)
InitFunctionPointers();
+ /* Detect -Oif flags */
+ old_midl_flags = ((RPC_SERVER_INTERFACE*)s_IServer_v0_0_s_ifspec)-Flags ==
0;
+
if (pGetUserNameExA)
{
ULONG size = 0;
diff --git a/dlls/rpcrt4/tests/server.idl b/dlls/rpcrt4/tests/server.idl
index c7c7237..39d6940 100644
--- a/dlls/rpcrt4/tests/server.idl
+++ b/dlls/rpcrt4/tests/server.idl
@@ -364,6 +364,7 @@ cpp_quote(#endif)
typedef [range(RE_MIN, RE_MAX)] enum renum renum_t;
typedef [range(0, 100)] int rint_t;
rint_t echo_ranged_int([range(0, 100)] int n);
+ void some_ranged_func([in, range(0,50)] int n);
void get_ranged_enum([out] renum_t *re);
void context_handle_test(void);
Re: [RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl
Jérôme Gardou jerome.gar...@laposte.net writes: Hello. I've seen that this patch is in pending state, and I would like to know what is the problem with it. Also, if commenting the tests isn't a policy you want to enforce (that I would understand), I'm ready to skip them on wine, but how to? I already explained the problem, I'll have a go at fixing it properly when I find the time, but of course you are welcome to beat me to it... -- Alexandre Julliard julli...@winehq.org
Re: cmd/tests: Add RENAME tests
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14246 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation
Something's rotten in git today...
It might be just me, but I've seen five very strange test failures today out of about 30 build/test runs. Has anybody else noticed problems? Here they are, most recent first: http://buildbot.kegel.com/builders/runtests-default/builds/72 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c touch service.ok err:rpc:I_RpcGetBuffer no binding err:rpc:I_RpcGetBuffer no binding service.c:152: Test failed: Expected success, got error 1060 err:rpc:I_RpcGetBuffer no binding service.c:176: Test failed: Expected ERROR_SERVICE_DOES_NOT_EXIST, got 123 ... ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c touch file.ok file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\removeme\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:946: Test failed: CreateFileA failed on \\?\C:, hFile 0x, err=2, should be 0 ... http://buildbot.kegel.com/builders/runtests-default/builds/70 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist make: *** [action.ok] Error 1 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c touch install.ok install.c:5393: Test failed: Directory not created ... make: *** [install.ok] Error 8 http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/68 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c touch service.ok ... service.c:2084: Test failed: Winetest Sleep Service: QueryServiceStatusEx() failed le=1727 service.c:2085: Test failed: Winetest Sleep Service: should be stopped state=ff service.c:2092: Test failed: Winetest Sleep Service: the second try should yield the same error: 1728 != 1727 service.c:2098: Test failed: Winetest Sleep Service: 1727 != ERROR_SERVICE_NOT_ACTIVE service.c:2099: Test failed: Winetest Sleep Service: should be stopped state=deadbeef service.c:2188: Test failed: 1728 != ERROR_SERVICE_REQUEST_TIMEOUT service.c:2223: Test failed: Expected success, got error 6 ... make: *** [service.ok] Error 20 http://buildbot.kegel.com/builders/runtests-default/builds/67 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist
