Re: [PATCH 1/2] gdi32: Add a string table resource for the translation.
On Tue, 18 Oct 2011 16:14:36 +0200, Alexandre Julliard wrote: Akihiro Sagawa sagawa@gmail.com writes: @@ -1,7 +1,7 @@ EXTRADEFS = -D_GDI32_ MODULE= gdi32.dll IMPORTLIB = gdi32 -IMPORTS = advapi32 +IMPORTS = advapi32 user32 You don't want to import user32 from gdi32. LoadStringW is in user32.dll. Should I use DELAYIMPORTS instead? -- Akihiro Sagawa
Re: [PATCH] kernel32: Output message to stderr in UTF-8
Alex Henrie alexhenri...@gmail.com wrote: -WideCharToMultiByte( CP_ACP, 0, msgW, -1, msg, sizeof(msg), NULL, NULL ); +WideCharToMultiByte( CP_UTF8, 0, msgW, -1, msg, sizeof(msg), NULL, NULL ); MESSAGE( wine: %s, msg ); Try CP_UNIXCP intead. -- Dmitry.
Re: [3/7] d3d9/tests: Add a test for locking partial blocks (try 2)
On 18 October 2011 17:37, Henri Verbeet hverb...@gmail.com wrote: patch 3/7. The point is that test_lockrect_offset() is about the offset calculation, not so much about what valid rectangles for block based formats are.
Re: Regression testing breakthrough
Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? Then one could write a simple wine regression bisect tool that implements similar semantics to git bisect, but would essentially wrap wget. Then in your server you could have an index file which is a list of the sha commit ids. This would save the user having to clone a 26Gb repository when most of the commits will be irrelevant. Extra bonus points for doing a better job of compressing the small deltas between binaries*, rather than compressing full wine builds. Joel * Are binaries deterministic like this? or do they tend to be completely scrambled? On 18 October 2011 at 09:45 Damjan Jovanovic damjan@gmail.com wrote: Hi Since the beginning, I've had issues with regression testing. Despite the fact it's very useful, it takes forever, it's easy to make a mistake (especially during reverse regression testing), users find it too long and technical, and only a small minority of regressions are ever bisected. And several patches need backporting to allow older versions of Wine to compile and run on today's make, gcc, and libraries - this is the case even for the 1.0.x releases from less than 3 years ago! The problem is of course compilation. configure takes at least 40 seconds, without any way to speed it up on multi-core CPUs. make takes 5 minutes, and it's only taking longer as Wine gets bigger. Compilation is fundamentally complex and technical to users. But what if we had precompiled binaries, and regression testing consisted of just running different versions of Wine? Wine binaries take up about 122 MB and take over 5 minutes to compile. There's now 35770 commits between 36def4af0ca85a1d0e66b5207056775bcb3b09ff (Release 1.0) and origin. That's about 4.4 terrabytes of storage and over 4 months of compilation, if each of those versions had to be compiled and installed into its own prefix, way beyond what most users are willing or able to store or do. Most patches however end up affecting only a few binary files in the end, and compiling successive versions allows make to be very quick. So I've written a tool that compiles Wine and adds each commit's binaries into a Git repository. It knows how to compile old versions of Wine (currently as far back as 1.0). It knows that commits affecting only ANNOUNCE, .gitignore, and files in dll/ or programs/ ending with .c and such don't need to go through the endlessly slow configure, only make. It is stateless: if interrupted, it can resume from the last successful commit. It works around bugs in GNU make (you won't believe how many there are...). This tool compiled all 35000 or so commits from Wine 1.0 to around 4th October 2011 in only 7 days, generating a Git repository of Wine binaries that's only 26 gigabytes in size. Regression testing with binaries is a pleasure: it takes only a few seconds :-) on each bisection. I bisected a 16 step regression in just 20 minutes, and most of that time was spent running the application and dealing with 2 X-server crashes. I haven't figured out how to make the binaries available to users. Few users can clone a 26 gigabyte repository, and even fewer places can serve that much to multiple users. Maybe Git can compress it further? The other idea I had is that users should be able to regression test through a GUI tool. Maybe the GUI tool can just download and run the +/- 122 MB binary snapshots for specific commits, instead of having the entire binary repository locally? Any other ideas? Would you like to see this tool? Can I send an attachment with it? Thank you Damjan Jovanovic
Re: Anyone wants to ban spammer on forum
On 2011-10-19 (October, Wednesday) 02:37:41 Vitaliy Margolen wrote: On 10/18/2011 07:37 PM, Vitaliy Margolen wrote: So any admins actually watching and want to bad roberbdib3a on forum? Also why aren't every moderator has these rights to block spammers, since we have only one forum. So no takers? I'm guessing we need more forum admins then, so more timezones can be covered. I agree. I and other morerators have deleted spam messages, but the spammer kept using the same account to post more. Inability to ban spammer's account is frustrating. I would happely volonteer to be forum admin so I can ban spammers.
Re: [3/7] d3d9/tests: Add a test for locking partial blocks (try 2)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 19.10.2011 um 11:49 schrieb Henri Verbeet: On 18 October 2011 17:37, Henri Verbeet hverb...@gmail.com wrote: patch 3/7. The point is that test_lockrect_offset() is about the offset calculation, not so much about what valid rectangles for block based formats are. Tbh I don't see the point in separating those two since both are determined by the block size, but OK. -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOnsGzAAoJEN0/YqbEcdMw3TkP/Rbg9Of3+rt2VGa+5WfEMQm+ 9RMhEEKczrRESh2vqDTpgufsIvGOwrbAmeDG7s89KpUwIBKawyoJhg2lR84/hwH5 DCyUxqKqYDbZzQt84AxHhEUfSvqCa7K4myLIT4BK1IFksI81NSVDTuYL/DtOWuFN KCx2J+z/BlZsURpJM2bGOmDbdy3iLuTYtSNuZFmjNbYVKYKSF3vGXQ1gUEmAdOFn i4BT+WhpFaVBN/YxXIlmwQ7lWuwiJwWDZZAiIAyTZAp+n9H0VE6P49y4kpH8otab AC3p5VV2QlmQyG2iir6WkYX4N/9z8cq6Mv/FRC87IZsIWPAS05XlJdAdWUlaAvO6 Gm81Gxd3WILnKtYvp9g2xhqesd4ZSVQyXNonglcLmKLIbR7hEGm7MWW+V7gyZrCF pjLDMlsg9h8ket7Dcpi9hA/q/8ChYh/dw7LKR8fbAcujgiCQaS3aork/O3CnVenu GO6rZtqFOj19gDcClbD07h8bDnPvKLMeCXNt7S4QIUhrQ8LAzLG1YDHogDxmNAau EDdq4dkfuabbJkMSiDeRAGsMHY99fSk+7fB8pOsEx2AgP2GnfynePboshsDVp3ri 0pKMklL4/2EsYZjca4x6ejqh2+iTdwlWiddIQa60vV9XolEHp4/TM4tIKCUdzfzJ fT3zosKQ6ZakgJ3KopoS =XwMm -END PGP SIGNATURE-
Re: Regression testing breakthrough
On Wed, Oct 19, 2011 at 14:08, Joel Holdsworth j...@airwebreathe.org.uk wrote: Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of 36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? tar.xz would compress better Then one could write a simple wine regression bisect tool that implements similar semantics to git bisect, but would essentially wrap wget. Then in your server you could have an index file which is a list of the sha commit ids. This would save the user having to clone a 26Gb repository when most of the commits will be irrelevant. Cloning a multi-gig repository is a no-go for many (most?) people, especially for a regression testing they might do only once or twice... Extra bonus points for doing a better job of compressing the small deltas between binaries*, rather than compressing full wine builds. Maybe you could use stuff like xdelta or bsdiff, but then you may have some issues IMO: - (not sure) you should use them on non-compressed files (e.g. .tar) to get small diffs - the total size of individual diffs to download could exceed a single, full, download (especially for old regressions) To make regression faster/easier, we could (in a script of some sort) - phase 1: detect the release range failure (failed between wine-1.X.N and wine-1.X.N+1) using only release binaries [or instruct people to do that first using their distrib packages, like RegressionTesting does IIRC] - phase 2: perform bisect between these two releases Just my 2 ¢ Frédéric
Re: [PATCH 1/2] gdi32: Add a string table resource for the translation.
Akihiro Sagawa sagawa@gmail.com writes: On Tue, 18 Oct 2011 16:14:36 +0200, Alexandre Julliard wrote: Akihiro Sagawa sagawa@gmail.com writes: @@ -1,7 +1,7 @@ EXTRADEFS = -D_GDI32_ MODULE= gdi32.dll IMPORTLIB = gdi32 -IMPORTS = advapi32 +IMPORTS = advapi32 user32 You don't want to import user32 from gdi32. LoadStringW is in user32.dll. Should I use DELAYIMPORTS instead? No, you should do it by hand using kernel32 resource functions. And you should do that only when needed, not on every startup. -- Alexandre Julliard julli...@winehq.org
Re: Anyone wants to ban spammer on forum
On 19/10/11 03:37, Vitaliy Margolen wrote: On 10/18/2011 07:37 PM, Vitaliy Margolen wrote: So any admins actually watching and want to bad roberbdib3a on forum? Also why aren't every moderator has these rights to block spammers, since we have only one forum. So no takers? I'm guessing we need more forum admins then, so more timezones can be covered. I rarely use the forums but if it's that bad I would happily look in a few times a day. UTC+1 Vitaliy.
Re: Regression testing breakthrough
On 19/10/11 13:43, Frédéric Delanoy wrote: On Wed, Oct 19, 2011 at 14:08, Joel Holdsworthj...@airwebreathe.org.uk wrote: Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of 36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? tar.xz would compress better tar.lzma?
Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.
Patches 5-7 failed on WINEDEBUG=warn+heap here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so palette.c touch palette.ok ... palette.c:104: Test failed: getColor=0028 Might be flaky; patch 8 passed. patches 9 and 10 aren't done testing yet. On Wed, Oct 19, 2011 at 6:18 AM, build...@kegel.com wrote: This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/673 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 Errors: alarum: failed command was ../../../wine gdi32_test.exe.so palette.c palette.c:104: Test failed: getColor=0028 make: *** [palette.ok] Error 1 * Call to xpconnect wrapped JSObject produced this error: * * Call to xpconnect wrapped JSObject produced this error: * GnuTLS error: A TLS packet with unexpected length was received.
Re: Regression testing breakthrough
On Wed, Oct 19, 2011 at 02:42:29PM +0100, Ken Sharp wrote: On 19/10/11 13:43, Frédéric Delanoy wrote: On Wed, Oct 19, 2011 at 14:08, Joel Holdsworthj...@airwebreathe.org.uk wrote: Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of 36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? tar.xz would compress better tar.lzma? Having tars of all builds would be way larger I guess. GIT compresses and shares objects that are the same. Ciao, Marcus
Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.
On Wed, Oct 19, 2011 at 06:46:49AM -0700, Dan Kegel wrote: Patches 5-7 failed on WINEDEBUG=warn+heap here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so palette.c touch palette.ok ... palette.c:104: Test failed: getColor=0028 Might be flaky; patch 8 passed. patches 9 and 10 aren't done testing yet. It's because I wanted to move SetPixel and GetPixel in separate patches. I added a temporary todo_wine in patch 5 (SetPixel) to prevent this test failure, which then got removed in patch 8 (GetPixel). Huw.
Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.
On Wed, Oct 19, 2011 at 6:59 AM, Huw Davies h...@codeweavers.com wrote: On Wed, Oct 19, 2011 at 06:46:49AM -0700, Dan Kegel wrote: Patches 5-7 failed on WINEDEBUG=warn+heap here: palette.c:104: Test failed: getColor=0028 Might be flaky; patch 8 passed. patches 9 and 10 aren't done testing yet. It's because I wanted to move SetPixel and GetPixel in separate patches. I added a temporary todo_wine in patch 5 (SetPixel) to prevent this test failure, which then got removed in patch 8 (GetPixel). Sounds like your temporary todo_wine didn't quite do the trick...?
Re: Regression testing breakthrough
On Wed, Oct 19, 2011 at 15:50, Marcus Meissner meiss...@suse.de wrote: On Wed, Oct 19, 2011 at 02:42:29PM +0100, Ken Sharp wrote: On 19/10/11 13:43, Frédéric Delanoy wrote: On Wed, Oct 19, 2011 at 14:08, Joel Holdsworthj...@airwebreathe.org.uk wrote: Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of 36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? tar.xz would compress better tar.lzma? Having tars of all builds would be way larger I guess. GIT compresses and shares objects that are the same. Ciao, Marcus You're talking about using a git tree just to store binaries for each committed patch, I suppose? But then you would have to download the whole repository (which can be quite big) to get compression benefits, right?
Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.
On Wed, Oct 19, 2011 at 07:04:02AM -0700, Dan Kegel wrote: Sounds like your temporary todo_wine didn't quite do the trick...? Ah, I see. I was getting a failure on 111 and not 104, presumably due to different XServers. Anyway they all pass again after the entire series is applied. Huw.
Re: Regression testing breakthrough
On Wed, Oct 19, 2011 at 04:18:50PM +0200, Frédéric Delanoy wrote: On Wed, Oct 19, 2011 at 15:50, Marcus Meissner meiss...@suse.de wrote: On Wed, Oct 19, 2011 at 02:42:29PM +0100, Ken Sharp wrote: On 19/10/11 13:43, Frédéric Delanoy wrote: On Wed, Oct 19, 2011 at 14:08, Joel Holdsworthj...@airwebreathe.org.uk wrote: Alternatively, have you considered doing a .tar.gz of every build snapshot, and placing that on a server somewhere? e.g. a folder full of 36def4af0ca85a1d0e66b5207056775bcb3b09ff.tar.gz files? tar.xz would compress better tar.lzma? Having tars of all builds would be way larger I guess. GIT compresses and shares objects that are the same. Ciao, Marcus You're talking about using a git tree just to store binaries for each committed patch, I suppose? But then you would have to download the whole repository (which can be quite big) to get compression benefits, right? True, yes. Ciao, Marcus
Re: Anyone wants to ban spammer on forum
On Wednesday 19 October 2011 14:08:14 L. Rahyen wrote: On 2011-10-19 (October, Wednesday) 02:37:41 Vitaliy Margolen wrote: On 10/18/2011 07:37 PM, Vitaliy Margolen wrote: So any admins actually watching and want to bad roberbdib3a on forum? Also why aren't every moderator has these rights to block spammers, since we have only one forum. So no takers? I'm guessing we need more forum admins then, so more timezones can be covered. I agree. I and other morerators have deleted spam messages, but the spammer kept using the same account to post more. Inability to ban spammer's account is frustrating. I would happely volonteer to be forum admin so I can ban spammers. The past few days there's been spam messages every few minutes and as soon as you ban an account an other one appears. Obviously the bots have figured out the answer to the captcha. signature.asc Description: This is a digitally signed message part.
Re: Anyone wants to ban spammer on forum
On 10/19/2011 10:21 AM, Tijl Coosemans wrote: The past few days there's been spam messages every few minutes and as soon as you ban an account an other one appears. Obviously the bots have figured out the answer to the captcha. Alrighty then, time for me to change the question... Done! The new question is: What operating system does Wine run applications from? Should be obvious for a human. -N
Re: Anyone wants to ban spammer on forum
On 10/19/2011 11:21 AM, Tijl Coosemans wrote: On Wednesday 19 October 2011 14:08:14 L. Rahyen wrote: On 2011-10-19 (October, Wednesday) 02:37:41 Vitaliy Margolen wrote: On 10/18/2011 07:37 PM, Vitaliy Margolen wrote: So any admins actually watching and want to bad roberbdib3a on forum? Also why aren't every moderator has these rights to block spammers, since we have only one forum. So no takers? I'm guessing we need more forum admins then, so more timezones can be covered. I agree. I and other morerators have deleted spam messages, but the spammer kept using the same account to post more. Inability to ban spammer's account is frustrating. I would happely volonteer to be forum admin so I can ban spammers. The past few days there's been spam messages every few minutes and as soon as you ban an account an other one appears. Obviously the bots have figured out the answer to the captcha. Any way to determine IP address and do something like failtoban and lock the IP our for a few hours. This should be a firewall function not forum software. Paul R.
Re: Anyone wants to ban spammer on forum
On 19/10/11 16:49, Jeremy Newman wrote: On 10/19/2011 10:21 AM, Tijl Coosemans wrote: The past few days there's been spam messages every few minutes and as soon as you ban an account an other one appears. Obviously the bots have figured out the answer to the captcha. Alrighty then, time for me to change the question... Done! The new question is: What operating system does Wine run applications from? Should be obvious for a human. Including the human who wrote the bot? -N
Re: 80141: vbscript: Added Global_IsEmpty implementation
Hi Jacek, build failed here... did you forget #include assert.h ? On Wed, Oct 19, 2011 at 9:56 AM, build...@kegel.com wrote: This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/715 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: global.c: In function 'Global_IsEmpty': global.c:281:5: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration] make[1]: *** [global.o] Error 1 make: *** [dlls/vbscript] Error 2 make: *** Waiting for unfinished jobs
Re: Fix Bug 23124 with an ln -s
On Tue, Oct 18, 2011 at 17:25, Ken Sharp kennyb...@o2.co.uk wrote: http://bugs.winehq.org/show_bug.cgi?id=23124 Could someone tell me if the attached patch would actually work? It does compile and works correctly with LANG=en_PH.utf-8 but I'm don't know that: 1. Using an ln -s is acceptable, nor if it will work given some file systems may be unable to use soft links. This will break the mingw/cygwin builds, as well as compiling on fat32 (already broken, but let's not make it worse..). You'll need to do this using autoconf/Makefile magic, $(LN_S), which will use `cp -p` on systems that don't support `ln -s`. -- -Austin
Re: vbscript: Added Global_IsEmpty implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15010 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: vbscript: Added Global_IsEmpty implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15010 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: [PATCH 2/2] vbscript: Added Global_IsEmpty implementation
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15011 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: Bug 28791: ensure that dashes value is not 0 for PS_USERSTYLE linestyles
damian dixon damian.di...@gmail.com writes: diff --git a/dlls/winex11.drv/pen.c b/dlls/winex11.drv/pen.c index b677515..71b1bea 100644 --- a/dlls/winex11.drv/pen.c +++ b/dlls/winex11.drv/pen.c @@ -108,7 +108,7 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen ) case PS_USERSTYLE: physDev-pen.dash_len = min(elp-elpNumEntries, MAX_DASHLEN); for(i = 0; i physDev-pen.dash_len ; i++) -physDev-pen.dashes[i] = min(elp-elpStyleEntry[i], 255); +physDev-pen.dashes[i] = min(elp-elpStyleEntry[i], 255) ? min(elp-elpStyleEntry[i], 255) : 1; Removing 0 entries (and merging the adjacent entries) would probably be more correct. It could also use some test cases. -- Alexandre Julliard julli...@winehq.org
Re: Bug 28791: ensure that dashes value is not 0 for PS_USERSTYLE linestyles
Just removing the zeros will shift the pattern to the left potentially producing an effect that is not expected. I will take a look at what happens on Windows to see what needs to be replicated. On 19 October 2011 20:05, Alexandre Julliard julli...@winehq.org wrote: damian dixon damian.di...@gmail.com writes: diff --git a/dlls/winex11.drv/pen.c b/dlls/winex11.drv/pen.c index b677515..71b1bea 100644 --- a/dlls/winex11.drv/pen.c +++ b/dlls/winex11.drv/pen.c @@ -108,7 +108,7 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen ) case PS_USERSTYLE: physDev-pen.dash_len = min(elp-elpNumEntries, MAX_DASHLEN); for(i = 0; i physDev-pen.dash_len ; i++) -physDev-pen.dashes[i] = min(elp-elpStyleEntry[i], 255); +physDev-pen.dashes[i] = min(elp-elpStyleEntry[i], 255) ? min(elp-elpStyleEntry[i], 255) : 1; Removing 0 entries (and merging the adjacent entries) would probably be more correct. It could also use some test cases. -- Alexandre Julliard julli...@winehq.org
Re: Anyone wants to ban spammer on forum
On 10/19/2011 09:49 AM, Jeremy Newman wrote: On 10/19/2011 10:21 AM, Tijl Coosemans wrote: The past few days there's been spam messages every few minutes and as soon as you ban an account an other one appears. Obviously the bots have figured out the answer to the captcha. Alrighty then, time for me to change the question... Done! The new question is: What operating system does Wine run applications from? Should be obvious for a human. Hope that won't upset users of other well known OS g. Any ETA on the new version of PHPBB? Vitaliy.
