Re: cmd: Avoid mixing signed and unsigned type in conditional expression
2011/10/27 Michael Stefaniuc :
> On 10/27/2011 02:09 PM, Frédéric Delanoy wrote:
>> On Thu, Oct 27, 2011 at 08:38, Eric Pouech wrote:
>>> why do we check for ptr being null or not, when we deref ptr one line above?
>>
if (*ptr == '\n') ptr++;
- WCMD_output_asis_len(message, (ptr) ? ptr - message :
strlenW(message), handle);
+ WCMD_output_asis_len(message, (ptr) ? (DWORD)(ptr - message) :
strlenW(message), handle);
if (ptr) {
numChars = 0;
if (++line_count >= max_height - 1) {
>>
>> It's dereferenced but incremented afterwards, so might be null after that
>> line
> Only if ptr wraps around ;)
Yeah right. Don't know where I saw a * before the ptr in (ptr)...
Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)
2011/10/28 André Hentschel : > Am 28.10.2011 19:42, schrieb Bruno Jesus: > ... > btw: if there is no dependencies than you don't need numbered patchsets Agreed. Sorry again. Best wishes, Bruno
Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)
Am 28.10.2011 19:42, schrieb Bruno Jesus: > On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> +/* Max ATR size defined by ISO-7816 */ >>> +#define MAX_ATR_SIZE 33 >> >> I don't see that one in my PSDK, where does it come from? > > My bad, apologies. I copied it from Vincent Hardy patch series but in > fact the variable should be name SCARD_ATR_LENGTH and should be in > winsmcrd.h. I'm still not using these defines yet so if possible I > would like the [2/2] to be commited if no mistakes are found in it, btw: if there is no dependencies than you don't need numbered patchsets -- Best Regards, André Hentschel
Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)
On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +/* Max ATR size defined by ISO-7816 */ >> +#define MAX_ATR_SIZE 33 > > I don't see that one in my PSDK, where does it come from? My bad, apologies. I copied it from Vincent Hardy patch series but in fact the variable should be name SCARD_ATR_LENGTH and should be in winsmcrd.h. I'm still not using these defines yet so if possible I would like the [2/2] to be commited if no mistakes are found in it, I'll resend this one later. Best wishes, Bruno
Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)
Bruno Jesus <00cp...@gmail.com> writes: > +/* Max ATR size defined by ISO-7816 */ > +#define MAX_ATR_SIZE 33 I don't see that one in my PSDK, where does it come from? -- Alexandre Julliard julli...@winehq.org
kernel32: Update English resource
I suspect this is the wrong way to update the US English resource for an .mc file. Could anyone comment? Thanks >From bcf976540aa3707e2b39f8133799e50e9fab9580 Mon Sep 17 00:00:00 2001 From: Ken Sharp Date: Fri, 28 Oct 2011 15:57:52 +0100 Subject: [PATCH 2/2] kernel32: Update English (Neutral) resource --- dlls/kernel32/winerror.mc | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/kernel32/winerror.mc b/dlls/kernel32/winerror.mc index 9f69784..fcd2092 100644 --- a/dlls/kernel32/winerror.mc +++ b/dlls/kernel32/winerror.mc @@ -276,7 +276,7 @@ No spool space MessageId=63 SymbolicName=ERROR_PRINT_CANCELLED Language=ENU -Print cancelled +Print canceled . MessageId=64 SymbolicName=ERROR_NETNAME_DELETED @@ -881,7 +881,7 @@ More data available MessageId=240 SymbolicName=ERROR_VC_DISCONNECTED Language=ENU -Session cancelled +Session canceled . MessageId=254 SymbolicName=ERROR_INVALID_EA_NAME @@ -1741,7 +1741,7 @@ No network MessageId=1223 SymbolicName=ERROR_CANCELLED Language=ENU -Operation cancelled by user +Operation canceled by user . MessageId=1224 SymbolicName=ERROR_USER_MAPPED_FILE @@ -3496,7 +3496,7 @@ No interfaces MessageId=1818 SymbolicName=RPC_S_CALL_CANCELLED Language=ENU -RPC call cancelled +RPC call canceled . MessageId=1819 SymbolicName=RPC_S_BINDING_INCOMPLETE @@ -3536,7 +3536,7 @@ Security package error MessageId=1826 SymbolicName=RPC_S_NOT_CANCELLED Language=ENU -Thread not cancelled +Thread not canceled . MessageId=1827 SymbolicName=RPC_X_INVALID_ES_ACTION -- 1.7.5.1
Re: basic_ifstream implementation
On Fri, Oct 28, 2011 at 01:30, Josh Juran wrote: > I appreciate your (and others') willingness to provide feedback. > Unfortunately, my job in this case is to make certain apps work (by hack or > by crack) and move on. What you could do is add/update the AppDB entry for this program, and link to your bug (hence patch). Frédéric
Re: Antw.: signal_arc.c failing to cross-compile
Thanks Andre, I realize that I'm breaking some new ground here and I don't mind doing the legwork. I just like to first post to make sure someone hasn't already tried this and found a solution before I spend too much time on it. It looks like you have been trying to cross-compile for Android as well. I'm guessing you must have hit this missing header file as well? Regards, Roger R. Cruz On Oct 28, 2011, at 3:05 AM, "André Hentschel" wrote: > Thats not a problem of cross compiling to ARM, but of android. Android is not > Linux, not fully. Maybe i can find a solution, but only maybe. BTW all the > problems you will find are Android specific. > > Gesendet mit meinem HTC > > - Reply message - > Von: "Roger Cruz" > An: "wine-devel@winehq.org" > Betreff: signal_arc.c failing to cross-compile > Datum: Fr., Okt. 28, 2011 06:46 > > > Hi Andre et al, > > Wondering if any of you know how to get around this? The compiler is barfing > at the lack of ucontext_t when doing a typedef of SIGCONTEXT. > > Thanks in advance, > > Roger R. Cruz > > arm-linux-androideabi-gcc -c -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll > -I. -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include > -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe > -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings > -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: > expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: > expected declaration specifiers or '...' before 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'restore_context': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: > 'sigcontext' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: (Each > undeclared identifier is reported only once > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for > each function it appears in.) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: > expected ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'segv_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'SIGCONTEXT' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'context' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: ISO > C90 forbids mixed declarations and code > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: > implicit declaration of function 'setup_exception_record' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'trap_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: > implicit declaration of function 'save_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'fpe_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: > implicit declaration of function 'save_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: > implicit declaration of function 'restore_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'int_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'abrt_handler': > /home/rcruz/sandbox/win
Re: ntdll: Make the VirtualProtect tests pass under Wine. Resend.
Dmitry Timoshkov writes: > Updated to current git. > --- > dlls/kernel32/tests/virtual.c | 16 > dlls/ntdll/virtual.c |3 +++ > 2 files changed, 3 insertions(+), 16 deletions(-) This completely breaks Wine here. There are several places where we use WRITECOPY for protections, they would have to be fixed first. -- Alexandre Julliard julli...@winehq.org
Re: signal_arc.c failing to cross-compile
Hi! Android is hopeless, its C library (bionic) is a very trimmed down and bug ridden version of the BSD library. The Android devel team is not willing to fix any bugs unless they affect native Android applications or Dalvik. In particular the .so loader and related initialization is broken. dlopen() doesn't properly call initializers, dlclose() doesn't work at all. Unless a proper C library is installed on the target systems (and a matching cross-toolchain used for compiling) there are no chances wine will run on Android. Many of the libraries required for Wine will not work properly with bionic even if they may compile. Paul On Friday 28 October 2011 07:46:26 am Roger Cruz wrote: > Hi Andre et al, > > Wondering if any of you know how to get around this? The compiler is > barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. > > Thanks in advance, > > Roger R. Cruz > > > arm-linux-androideabi-gcc -c > -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. > -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include > -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe > -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings > -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: > expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: > expected declaration specifiers or '...' before 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'restore_context': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: > 'sigcontext' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: > (Each undeclared identifier is reported only once > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for > each function it appears in.) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: > expected ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'segv_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'SIGCONTEXT' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'context' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: > ISO C90 forbids mixed declarations and code > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: > implicit declaration of function 'setup_exception_record' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'trap_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: > implicit declaration of function 'save_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'fpe_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: > implicit declaration of function 'save_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: > implicit declaration of function 'restore_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'int_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'abrt_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'usr1_handler': >
Antw.: signal_arc.c failing to cross-compile
Thats not a problem of cross compiling to ARM, but of android. Android is not Linux, not fully. Maybe i can find a solution, but only maybe. BTW all the problems you will find are Android specific. Gesendet mit meinem HTC - Reply message - Von: "Roger Cruz" An: "wine-devel@winehq.org" Betreff: signal_arc.c failing to cross-compile Datum: Fr., Okt. 28, 2011 06:46 Hi Andre et al, Wondering if any of you know how to get around this? The compiler is barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. Thanks in advance, Roger R. Cruz arm-linux-androideabi-gcc -c -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: expected declaration specifiers or '...' before 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'restore_context': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: 'sigcontext' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: (Each undeclared identifier is reported only once /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for each function it appears in.) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: expected ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'segv_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'SIGCONTEXT' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'context' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: ISO C90 forbids mixed declarations and code /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: implicit declaration of function 'setup_exception_record' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'trap_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: implicit declaration of function 'save_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'fpe_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: implicit declaration of function 'save_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: implicit declaration of function 'restore_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'int_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'abrt_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'usr1_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:758: error: too many arguments to function 'restore_context' make[1]: *** [signal_arm.o] Error 1
