Re: dlls: Remove unneeded include directives in resource files.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15373 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: taskmgr: Give a name and statically initialize PerfDataCriticalSection.
On Mon, 14 Nov 2011, Francois Gouget wrote:
[...]
static CRITICAL_SECTIONPerfDataCriticalSection;
+static CRITICAL_SECTION_DEBUG PerfDataCriticalSection_debug =
+{
+0, 0, PerfDataCriticalSection,
+{ PerfDataCriticalSection_debug.ProcessLocksList,
PerfDataCriticalSection_debug.ProcessLocksList },
+ 0, 0, { (DWORD_PTR)(__FILE__ : PerfDataCriticalSection) }
+};
[...]
+PerfDataCriticalSection.DebugInfo-Spare[0] = 0;
DeleteCriticalSection(PerfDataCriticalSection);
Actually I think unsetting Spare[0] is wrong for statically initialized
critical sections because it causes RtlDeleteCriticalSection() to do an
RtlFreeHeap() on DebugInfo which happens to also be statically
allocated. So I'll rework this patch and some of my previous patches.
--
Francois Gouget fgou...@codeweavers.com
Re: winemaker: Be less picky when detecting the target type
On Fri, 11 Nov 2011, André Hentschel wrote:
seen some broken project files which still worked with msvc but not with
winemaker
---
tools/winemaker |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/winemaker b/tools/winemaker
index 2ee79ea..921f8ef 100755
--- a/tools/winemaker
+++ b/tools/winemaker
@@ -589,16 +589,16 @@ sub source_scan_project_file($$$)
#print $prj_name;
next;
} elsif (/^# TARGTYPE/) {
-if (/[[:space:]]0x0101$/) {
+if (/0x.*101$/) {
The various .* worry me a bit. Would something like [0-9a-fA-F]* be
permissive enough?
--
Francois Gouget fgou...@free.fr http://fgouget.free.fr/
Broadcast message : fin du monde dans cinq minutes, repentez vous !
Re: [1/5]usp10: break with a better understanding on the handling of bidi strengths
Aric Stewart a...@codeweavers.com writes:
+if (strength)
+{
+str = strength[cnt];
+if (pwcInChars[cnt] == Numeric_space)
+str_space = TRUE;
+else
+str_space = FALSE;
+}
str_space is not used for anything.
--
Alexandre Julliard
julli...@winehq.org
Vista/w2k8/w7 users, please test mmdevapi with exclusive mode disabled
Hi, Please test mmdevapi again using testbot job #15369 with exclusive mode disabled. Brian, it seems like you had some other app use audio while performing the tests. This would explain the DEVICE_IN_USE error: render.c:427: Test failed: Initialize(exclus., 8000x 8x1) returns 8889000a and the subsequent crash. My new version of the tests should prevent crashes in such a situation. Saulius, you need not perform many tests because of random GetPosition/Padding failures. I've not yet changed that part of the tests. Thank you for repeated testing, Jörg Höhle
Re: winemaker: Be less picky when detecting the target type
On 11/14/2011 04:04 AM, Francois Gouget wrote:
On Fri, 11 Nov 2011, André Hentschel wrote:
seen some broken project files which still worked with msvc but not with
winemaker
---
tools/winemaker |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/winemaker b/tools/winemaker
index 2ee79ea..921f8ef 100755
--- a/tools/winemaker
+++ b/tools/winemaker
@@ -589,16 +589,16 @@ sub source_scan_project_file($$$)
#print $prj_name;
next;
} elsif (/^# TARGTYPE/) {
-if (/[[:space:]]0x0101$/) {
+if (/0x.*101$/) {
The various .* worry me a bit. Would something like [0-9a-fA-F]* be
permissive enough?
I think he was trying to match x too. At a very minimum the match needs to
be less greedy (.*?).
Vitaliy.
Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try2)
Piotr Caban pi...@codeweavers.com writes:
+static void set_wow64_environment(WCHAR **env)
+{
+static const WCHAR archW[]=
{'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0};
+static const WCHAR arch6432W[] =
{'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','W','6','4','3','2',0};
This stuff needs to be done depending on the 32/64 architecture of the
child process, so it probably shouldn't be done here. The variables
will be reset on every process startup anyway.
--
Alexandre Julliard
julli...@winehq.org
Re: Vista/w2k8/w7 users, please test mmdevapi with exclusive mode disabled
On Mon, Nov 14, 2011 at 2:29 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, Please test mmdevapi again using testbot job #15369 with exclusive mode disabled. With exclusive mode enabled (both 32bit and 64bit): render: 884 tests executed (0 marked as todo, 49 failures), 1 skipped. With exclusive mode disabled: 32bit: render: 884 tests executed (0 marked as todo, 43 failures), 1 skipped. 64bit: render: 884 tests executed (0 marked as todo, 44 failures), 1 skipped. I attached logs for you. Cheers, Matijn render.c:159: Returned periods: 10. ms 3. ms render.c:171: pwfx: 009BCA08 render.c:172: Tag: fffe render.c:173: bits: 32 render.c:174: chan: 6 render.c:175: rate: 48000 render.c:176: align: 24 render.c:177: extra: 22 render.c:182: Res: 32 render.c:183: Mask: 3f render.c:184: Alg: FLOAT render.c:242: Initialize(duration=0) GetBufferSize is 1440 render.c:306: Returned latency: 14.3853 ms render.c:317: Test failed: SetEventHandle returns render.c:379: IsSupported(exclus., 8000x 8x1) disabled render.c:379: IsSupported(exclus., 8000x 8x2) disabled render.c:379: IsSupported(exclus., 8000x16x1) disabled render.c:379: IsSupported(exclus., 8000x16x2) disabled render.c:379: IsSupported(exclus., 11025x 8x1) disabled render.c:379: IsSupported(exclus., 11025x 8x2) disabled render.c:379: IsSupported(exclus., 11025x16x1) disabled render.c:379: IsSupported(exclus., 11025x16x2) disabled render.c:379: IsSupported(exclus., 12000x 8x1) disabled render.c:379: IsSupported(exclus., 12000x 8x2) disabled render.c:379: IsSupported(exclus., 12000x16x1) disabled render.c:379: IsSupported(exclus., 12000x16x2) disabled render.c:379: IsSupported(exclus., 16000x 8x1) disabled render.c:379: IsSupported(exclus., 16000x 8x2) disabled render.c:379: IsSupported(exclus., 16000x16x1) disabled render.c:379: IsSupported(exclus., 16000x16x2) disabled render.c:379: IsSupported(exclus., 22050x 8x1) disabled render.c:379: IsSupported(exclus., 22050x 8x2) disabled render.c:379: IsSupported(exclus., 22050x16x1) disabled render.c:379: IsSupported(exclus., 22050x16x2) disabled render.c:379: IsSupported(exclus., 44100x 8x1) disabled render.c:379: IsSupported(exclus., 44100x 8x2) disabled render.c:379: IsSupported(exclus., 44100x16x1) disabled render.c:379: IsSupported(exclus., 44100x16x2) disabled render.c:379: IsSupported(exclus., 48000x 8x1) disabled render.c:379: IsSupported(exclus., 48000x 8x2) disabled render.c:379: IsSupported(exclus., 48000x16x1) disabled render.c:379: IsSupported(exclus., 48000x16x2) disabled render.c:379: IsSupported(exclus., 96000x 8x1) disabled render.c:379: IsSupported(exclus., 96000x 8x2) disabled render.c:379: IsSupported(exclus., 96000x16x1) disabled render.c:379: IsSupported(exclus., 96000x16x2) disabled render.c:374: Test failed: IsFormatSupported(0, 48000x 8x1) returns 88890008 render.c:379: IsSupported(shared , 48000x 8x2) render.c:374: Test failed: IsFormatSupported(0, 48000x16x1) returns 88890008 render.c:379: IsSupported(shared , 48000x16x2) render.c:824: Testing shared mode render.c:851: Latency: 14.3853 ms render.c:863: BufferSize 24000 estimated fragment 480 render.c:887: Clock Frequency 1152000 render.c:916: data at 00661000 render.c:931: Test failed: Start failed: 88890014 render.c:942: Test failed: Position should have been further along... render.c:946: Test failed: Stop failed: 0001 render.c:955: Test failed: Start failed: 88890014 render.c:962: padding 24000 past sleep #2 render.c:967: Test failed: Stop failed: 0001 render.c:974: padding 24000 position 0 past stop #2 render.c:981: Test failed: Position should have been further along... render.c:1007: data at 00661000 render.c:1023: Test failed: Start failed: 88890014 render.c:1030: position 0 past 100ms sleep #3 render.c:1031: Test failed: Position should have been further along... render.c:1036: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests. render.c:1040: Test failed: Reset while playing: render.c:1043: Test failed: Stop failed: 0001 render.c:1050: padding 0 position 0 past stop #3 render.c:1071: Test failed: Start failed: 88890014 render.c:1077: data at 00661000 for prefill 22500 render.c:1106: hpctime 357 after 350ms render.c:: Test failed: Position should have been further along... render.c:1125: hpctime 465 pcpos 468 render.c:1130: padding 22500 position 0/0 slept 450ms iteration 0 render.c:1131: Test failed: Position should have been further along... render.c:1164: data at 006E4D60 (small 1500) render.c:1125: hpctime 581 pcpos 584 render.c:1130: padding 24000 position 0/0 slept 550ms iteration 1 render.c:1131: Test failed: Position should have been further along... render.c:1164: data at (small 0) render.c:1166: Test failed: NULL buffer returned render.c:1125: hpctime 700 pcpos 703 render.c:1130: padding 24000 position 0/0 slept 650ms iteration 2 render.c:1131: Test failed: Position should have been further along... render.c:1164: data at (small 0) render.c:1166:
Re: [PATCH 2/5] d3d10: Add a stub ID3D10StateBlock implementation.
On 11/14/2011 23:11, Henri Verbeet wrote:
+static ULONG STDMETHODCALLTYPE d3d10_stateblock_Release(ID3D10StateBlock
*iface)
+{
+struct d3d10_stateblock *stateblock = impl_from_ID3D10StateBlock(iface);
+ULONG refcount = InterlockedIncrement(stateblock-refcount);
+
+TRACE(%p decreasing refcount to %u.\n, stateblock, refcount);
+
+if (!refcount)
+HeapFree(GetProcessHeap(), 0, stateblock);
+
+return refcount;
+}
Decrement maybe?
