Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.
Akihiro Sagawa wrote:
> -static const struct test_data
> +const int font[] =
> {
> -int id, weight, height, dpi;
> +ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT,
> DEFAULT_GUI_FONT
> +/* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */
> +};
> +const struct test_data
> +{
Please add back 'static' to test_data and add it to font.
--
Dmitry.
Re: [PATCH] winepulse.drv: Add PulseAudio driver
What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.
