Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply
Re: d3dx9_36 [patch 3 of 3]: Implementation of D3DXSHMultiply2
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19586 Your paranoid android. === WINEBUILD (build) === Patch failed to apply
Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19594 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28
Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 Looks like testbot picked up wrong e-mail sequence. It looks like an e-mail delivery problem in the mailing list software, and it is getting pretty annoying. -- Dmitry.
Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
Dmitry Timoshkov dmi...@baikal.ru wrote: Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 Looks like testbot picked up wrong e-mail sequence. It looks like an e-mail delivery problem in the mailing list software, and it is getting pretty annoying. Just in case sent precompiled version of the tests to testbot once again, and they passed: https://testbot.winehq.org/JobDetails.pl?Key=19596 -- Dmitry.
Re: wbemprox: Add a Win32_LogicalDisk class stub.
On Wed, 2012-06-27 at 11:34 +0300, John Yani wrote:
+static void fill_logicaldisk( struct table *table )
+{
+static const WCHAR fmtW[] = {'%','u',0};
+WCHAR device_id[11];
+struct record_logicaldisk *rec;
+UINT num_rows = 1;
+FIXME(returns a fake logical disks table\n);
+if (!(table-data = heap_alloc( sizeof(*rec) * num_rows )))
+{
+return;
+}
+rec = (struct record_networkadapter *)(table-data);
This should be (struct record_logicaldisk *)(table-data);
+sprintfW( device_id, fmtW, 0 );
+rec-device_id= heap_strdupW( device_id );
+
+TRACE(created %u rows\n, num_rows);
+table-num_rows = num_rows;
+}
You don't need the num_rows variable since it's a fixed value. You
also don't need to build the device id, it can just be a static string.
Re: [4/4] gdiplus: Add a bunch of tests for TIFF image properties.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19595 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2812: Test failed: 0: expected property size 17 or 36, got 44 image.c:2812: Test failed: 2: expected property size 144 or 0, got 152 image.c:2812: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2812: Test failed: 0: expected property size 17 or 36, got 44 image.c:2812: Test failed: 2: expected property size 144 or 0, got 152 image.c:2812: Test failed: 3: expected property size 20 or 0, got 28
Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale
2012/6/27 Nozomi Kodama nozomi.kod...@yahoo.com:
-@ stub D3DXSHScale(ptr long ptr ptr)
+@ stdcall D3DXSHScale(ptr long ptr ptr)
...
+FLOAT* WINAPI D3DXSHScale(FLOAT *out, UINT order, CONST FLOAT *a,
CONST FLOAT scale)
The last parameter doesn't match between the function prototype and
the spec entry. Also, apparently MSDN agrees with your prototype,
while the docs in the last DirectX SDK have a pointer there. I guess
the tests demonstrate that the parameter is actually a plain float...
+for (i = 0; i 100; i++)
+{
+a[i] = (FLOAT)i;
+b[i] = (FLOAT)i;
+}
No need to cast.
+D3DXSHScale(b, order, a, 5.0f);
Not important, but you could also verify that the returned pointer is == b.
+/* D3DXSHScale does not modify the elements of the array after the
order * order-th element */
Can you please indent those comments?
+return;
+}
That's not needed at all.
Also, while you're at it, you should probably merge the two for loops
in the test, like Francois did in
http://www.winehq.org/pipermail/wine-patches/2012-June/115464.html
Re: [1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.
Vincent Povirk madewokh...@gmail.com wrote:
static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
UINT *puiWidth, UINT *puiHeight)
{
-FIXME((%p,%p,%p): stub\n, iface, puiWidth, puiHeight);
+BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
+TRACE((%p,%p,%p)\n, iface, puiWidth, puiHeight);
-return E_NOTIMPL;
+if (!This-source)
+return WINCODEC_ERR_WRONGSTATE;
+
+*puiWidth = This-width;
+*puiHeight = This-height;
+
+return S_OK;
This patch and remaning patches in the sequence completely miss any
parameter checking.
--
Dmitry.
Re: [1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.
Good point. I'll resend with parameter checking.
On Wed, Jun 27, 2012 at 11:25 AM, Dmitry Timoshkov dmi...@baikal.ru wrote:
Vincent Povirk madewokh...@gmail.com wrote:
static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
UINT *puiWidth, UINT *puiHeight)
{
- FIXME((%p,%p,%p): stub\n, iface, puiWidth, puiHeight);
+ BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
+ TRACE((%p,%p,%p)\n, iface, puiWidth, puiHeight);
- return E_NOTIMPL;
+ if (!This-source)
+ return WINCODEC_ERR_WRONGSTATE;
+
+ *puiWidth = This-width;
+ *puiHeight = This-height;
+
+ return S_OK;
This patch and remaning patches in the sequence completely miss any
parameter checking.
--
Dmitry.
ODBC on 64bit system
Hello all, Is it possible to run a 32bit application using 64bit ODBC drivers? I already checked that standard 32bit wine compilation does not work - but will it work with WoW64? I am trying to get an application to connect to SQL Server via tdsodbc, but unfortunately tdsodbc:i386 in ubuntu 11.10 is broken... Regards, Daniel
Re: wbemprox: Add a Win32_LogicalDisk class stub.
On Wed, 2012-06-27 at 14:41 +0300, John Yani wrote:
+static void fill_logicaldisk( struct table *table )
+{
+static const WCHAR device_id[] = {'0',0};
+struct record_logicaldisk *rec;
+FIXME(returns a fake logical disks table\n);
+if (!(table-data = heap_alloc( sizeof(*rec) )))
+{
+return;
+}
+rec = (struct record_logicaldisk *)(table-data);
+rec-device_id= heap_strdupW( device_id );
+table-num_rows = 1;
+TRACE(created %u rows\n, table-num_rows);
+}
There's no need to create a copy of device_id. Just assign it to
rec-device_id and remove COL_FLAG_DYNAMIC from the column definition.
Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
On 27/06/2012 7:35 PM, Dmitry Timoshkov wrote: Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 Looks like testbot picked up wrong e-mail sequence. It looks like an e-mail delivery problem in the mailing list software, and it is getting pretty annoying. The winehq.org mailserver only allows one SMTP connection per relaying IP, so emails sent at the same time are likely to be received out of order unless the relaying mailserver only transfers emails sequentially. -- Ben Peddell IT Support Bowen, Collinsville and Proserpine Catholic schools http://klightspeed.killerwolves.net/
Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
Ben Peddell klightsp...@netspace.net.au wrote: Looks like testbot picked up wrong e-mail sequence. It looks like an e-mail delivery problem in the mailing list software, and it is getting pretty annoying. The winehq.org mailserver only allows one SMTP connection per relaying IP, so emails sent at the same time are likely to be received out of order unless the relaying mailserver only transfers emails sequentially. It doesn't explain the lost of some e-mails. For instance patch tracker may see 2 of 5 patches while http://www.winehq.org/pipermail/wine-patches lists 3 of 5. -- Dmitry.
Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19625 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28
Re: [1/5] windowscodecs: Implement MetadataHandler_GetValue. Take 2. Resend.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19631 Your paranoid android. === WVISTAADM (32 bit metadata) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation
Re: po: add missing url tag to nl.po
On Wed, 27 Jun 2012, Austin English wrote: http://bugs.winehq.org/show_bug.cgi?id=31038 Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie a -href=http://wiki.winehq.org/Gecko voor details. +href=http://wiki.winehq.org/Gecko/a voor details. Note that this is missing a lot more than just /a. This should be: Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie a href=\http://wiki.winehq.org/Gecko\;http://wiki.winehq.org/Gecko/a voor details. Fortunately it looks like nl is the only such case. -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.
