Re: [PATCH 1/8] hhctrl.ocx: Implement HH_CLOSE_ALL.
On 07/05/12 18:31, Erich E. Hoover wrote: On Thu, Jul 5, 2012 at 3:09 AM, Jacek Caban ja...@codeweavers.com wrote: ... While it's not about this particular patch, I can see that you're changing hhctrl.ocx to the point where it has an useful API (as opposed to simple hh.exe-like help viewer). It is really nice to see, thanks. It would be great to have some tests for this. Please consider adding them (I'm sure you already have some code for testing, so I imagine it would be mostly integrating it with Wine test suite). Once the get/set HH_WINTYPE commands are in then the only thing that remains in order to construct tests is the ability to build CHM files. I've been working on trying to get HTML Help Workshop to be able to compile CHM files, but so far this endeavor has not met with much success. We already have a trivial .chm file in itss tests. It's compiled by HTML Help Workshop on Windows. You probably could do the same for hhctrl.ocx. Just make sure others will be able to reproduce the file if needed. Did you see anything in these patches that you would like changed? I just noticed a double-free mistake, so I'm going to resubmit with that fixed when I get a chance and can include any suggestions you might have. Sorry I couldn't get to this sooner. I will review them in a moment. Jacek
Re: [PATCH 1/9] hhctrl.ocx: Implement HH_CLOSE_ALL (resend).
On 07/09/12 02:13, Erich E. Hoover wrote:
+case HH_CLOSE_ALL: {
+struct list *ptr;
+HHInfo *info;
+
+LIST_FOR_EACH(ptr, window_list)
+{
+info = LIST_ENTRY(ptr, HHInfo, entry);
+TRACE(Destroying window %s.\n, debugstr_w(info-pszType));
+if (info-WinType.hwndHelp)
+DestroyWindow(info-WinType.hwndHelp);
+list_remove(info-entry);
+}
How is it supposed to work? AFAICS you're destroying windows, removing
info object from the list and forget about it. If your intention is to
destroy these objects, then ReleaseHelpViewer seems more appropriate.
Also moving list_remove call to ReleaseHelpViewer seems preferable, so
that it's removed from the list regardless of the reason for being
destroyed. Same for list_add_tail, shouldn't it be done in CreateHelpViewer?
Jacek
Re: [PATCH 3/4] d3dx9/tests: Add effect parameter value GetMatrixPointerArray() test.
2012/7/8 Rico Schüller kgbric...@web.de:
---
dlls/d3dx9_36/tests/effect.c | 90
++
1 files changed, 90 insertions(+), 0 deletions(-)
Hi Rico,
maybe it's just me misunderstanding this, but:
+FLOAT fvalue[EFFECT_PARAMETER_VALUE_ARRAY_SIZE];
+D3DXMATRIX *matrix_pointer_array[sizeof(fvalue)/sizeof(D3DXMATRIX)];
+UINT l, k, m, element;
+
+for (element = 0; element = res_desc-Elements + 1; ++element)
+{
+memset(fvalue, 0xab, sizeof(fvalue));
+for (l = 0; l element; ++l)
+{
+matrix_pointer_array[l] = (D3DXMATRIX *)fvalue[l *
sizeof(**matrix_pointer_array) / sizeof(*matrix_pointer_array)];
+}
I don't quite understand what you're trying to achieve with
sizeof(**matrix_pointer_array) / sizeof(*matrix_pointer_array). As
far as I can see, that depends on the size of the pointer (32/64 bits)
and I'm not sure that the offset should change in that case. Maybe you
meant to use sizeof(float) as divisor?
Re: Re-enable editing on the forum?
On Sun, 8 Jul 2012 07:11:13 -0700 Dan Kegel d...@kegel.com wrote: No objection here. Seems like an obvious thing to do. I'll do it later today if nobody objects. Thanks, Dan. I've unstickied the Editing is disabled thread and posted a note that editing has been re-enabled. Now, another housekeeping matter: http://forum.winehq.org currently lists Wine Users under WineHQ Mailing Lists and says This forum is linked to the wine-users mailing list, and http://www.winehq.org/site/forums still says The mailing lists and forum are interlinked. Messages sent to one automatically propagate to the other. I can correct the forum.winehq.org page myself via the admin interface (assuming no one objects), but someone (Jeremy?) needs to correct the other page. -- Rosanne DiMesio dime...@earthlink.net
Re: [PATCH 1/9] hhctrl.ocx: Implement HH_CLOSE_ALL (resend).
On Mon, Jul 9, 2012 at 3:31 AM, Jacek Caban ja...@codeweavers.com wrote: ... How is it supposed to work? AFAICS you're destroying windows, removing info object from the list and forget about it. If your intention is to destroy these objects, then ReleaseHelpViewer seems more appropriate. Also moving list_remove call to ReleaseHelpViewer seems preferable, so that it's removed from the list regardless of the reason for being destroyed. Same for list_add_tail, shouldn't it be done in CreateHelpViewer? That makes sense, I'll correct this and resubmit. Is there anything else you would like me to change? Erich
Re: [PATCH 2/4] ieframe: Added more DoVerb tests
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19863 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3472: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3435: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3410: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c005 at 0040AF8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2627: Test failed: expected GetOverridesKeyPath webbrowser.c:2632: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2633: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3052: Test failed: doc_disp == NULL webbrowser: unhandled exception c005 at 00402FCA
Re: [PATCH 3/4] ieframe: Added init_test helper
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19864 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3325: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3325: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3325: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3476: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3325: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3441: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3419: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c005 at 0040AF8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2627: Test failed: expected GetOverridesKeyPath webbrowser.c:2632: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2633: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3052: Test failed: doc_disp == NULL webbrowser: unhandled exception c005 at 00402FCA
Re: [PATCH 4/4] vbscript: Added support for exit for stateemnt in 'for in' loops
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19865 Your paranoid android. === WINEBUILD (build) === Patch failed to apply
Re: [PATCH 3/4] d3dx9/tests: Add effect parameter value GetMatrixPointerArray() test.
Am 09.07.2012 16:17, schrieb Matteo Bruni:
2012/7/8 Rico Schüllerkgbric...@web.de:
---
dlls/d3dx9_36/tests/effect.c | 90
++
1 files changed, 90 insertions(+), 0 deletions(-)
Hi Rico,
maybe it's just me misunderstanding this, but:
+FLOAT fvalue[EFFECT_PARAMETER_VALUE_ARRAY_SIZE];
+D3DXMATRIX *matrix_pointer_array[sizeof(fvalue)/sizeof(D3DXMATRIX)];
+UINT l, k, m, element;
+
+for (element = 0; element= res_desc-Elements + 1; ++element)
+{
+memset(fvalue, 0xab, sizeof(fvalue));
+for (l = 0; l element; ++l)
+{
+matrix_pointer_array[l] = (D3DXMATRIX *)fvalue[l *
sizeof(**matrix_pointer_array) / sizeof(*matrix_pointer_array)];
+}
I don't quite understand what you're trying to achieve with
sizeof(**matrix_pointer_array) / sizeof(*matrix_pointer_array). As
far as I can see, that depends on the size of the pointer (32/64 bits)
and I'm not sure that the offset should change in that case. Maybe you
meant to use sizeof(float) as divisor?
Hi Matteo,
yes, the array increment has to be constantly 16. So sizeof(FLOAT) is
correct. Thanks for the hint, it needs to be corrected in some other
cases, too. I'll send some new patches to fix the issues.
Cheers
Rico
Re: Re-enable editing on the forum?
On Mon, 9 Jul 2012 20:18:13 +0200 Schiermeier Software schiermeier.softw...@web.de wrote: Guten Abend Rosanne, but someone (Jeremy?) needs to correct the other page. maybe you want to send a patch to: WineHQ - patch wine-patc...@winehq.org subject: [website] your subject I'm sure it's very easy for someone who knows what they're doing. That person is not me. -- Rosanne DiMesio dime...@earthlink.net
Re: winetricks dotnet40 fails verifier because System.EnterpriseServices.Wrapper.dll missing?
On Mon, Jul 9, 2012 at 1:42 PM, Hans Leidekker h...@codeweavers.com wrote: That file does seem to be on disc, but somewhere else: c:/windows/Microsoft.NET/Framework/v4.0.30319/System.EnterpriseServices.Wrapper.dll Not sure how serious it is that that's misplaced. Have other folks seen this? This should be fixed by 45473a65a0a1fe2e61809d80f6d09bb96f923126. Indeed it is. Thanks! - Dan
