Re: Wine, fullscreen applications, and RandR 1.2
On 5 September 2012 22:45, Andy Ritger arit...@nvidia.com wrote: On Wed, Sep 05, 2012 at 11:26:23AM -0700, Henri Verbeet wrote: From Wine's point of view, we'd just get a bunch of extra code to maintain because nvidia does things differently from everyone else. Eventually, I hope NVIDIA isn't unique about this approach to viewport configuration. The drawbacks aren't NVIDIA-specific. The concern about added code maintenance to Wine is fair; is that concern lessened if the details of viewport configuration are abstracted by a new standard library? A little, but adding extra dependencies isn't without its costs either. You'd also have to wait a fair bit before it ends up in common distributions. (And that means things like Debian stable or RHEL, not Ubuntu Fedora.) Perhaps there's a use case for a big screen setup, but that too is something that's probably best handled on the RandR / X server level instead of Wine. I don't think we can have it both ways: * RandR 1.1 gives you one big screen per X screen; the user can configure what is within that big screen via NVIDIA's MetaModes. * RandR 1.2 gives applications control of each individual CRTC/output. Are you suggesting we go back to something more like RandR 1.1? I imagine you could configure things in e.g. xorg.conf so that the displays show up as a single CRTC / output instead of individual CRTCs, perhaps depending on how the MetaModes are setup. Or perhaps there's some way to make this fit it with some of the new functionality in RandR 1.5. The main point though is that there's no reasonable way for Wine to decide to do one or the other automatically. We could of course add a configuration option for that, but at that point it makes more sense to do it globally for all applications in RandR or the X server. I don't think you can actually do immersive gaming properly without support from the application though, you'll get fairly significant distortion at the edges if you just render to such a setup as if it was a single very wide display. I'm sorry; I don't understand the distortion concern. Are you referring to the bezel of the monitor occupying physical space, but not pixel space in the X screen? I believe people often address that by configuring dead space in the X screen between their monitors. No, I mean the distortion caused by perspective projection, because you're essentially projecting a spherical world onto a flat screen. An application that is aware of this could e.g. use a separate camera for each display to mitigate this, or perhaps adjust the projection matrix. Since we have some differing viewpoints that won't be quickly resolved, how about as a compromise we add a way for users to force Wine from RandR 1.2 back to RandR 1.1? That would at least let users achieve some of the configurations they cannot configure with top of tree. If that seems fair, what is the preferred configuration mechanism to do that? Just a simple environment variable? You could perhaps extend the existing UseXRandR registry setting (see dlls/winex11.drv/x11drv_main.c) to take a version number. It's not something we've heard a lot of users about though.
Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests
Hi, Here is proper run: https://testbot.winehq.org/JobDetails.pl?Key=21409 Jacek
Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21412 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: wined3d: Add AMD Radeon HD 7700 series and HD 7800 series graphics cards
On 6 September 2012 15:27, Jiang Yike future...@asia.com wrote: This patch adds the recognition of AMD Radeon HD 7700 series and HD 7800 series graphics cards. This patch has whitespace errors.
Re: [PATCH 6/6] msvcrt: Fixed RTTI structure on 64-bit systems
Piotr Caban pi...@codeweavers.com writes: --- dlls/msvcrt/cpp.c | 129 ++-- dlls/msvcrt/cxx.h | 114 +-- 2 files changed, 155 insertions(+), 88 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c touch cpp.ok cpp.c:405: Test failed: bad rtti for e wine: Unhandled exception 0xe06d7363 at address 0x7b84a70a (thread 0025), starting debugger... Unhandled exception: C++ exception(object = 0x0022f870, type = 0x2b780f15a760) in 64-bit code (0x7b84a70a). Register dump: rip:7b84a70a rsp:0022f680 rbp:2b780f1635f0 eflags:0202 ( - -- I - - - ) rax:0022f6c0 rbx:0022f6a0 rcx:0022f6a0 rdx: rsi:0022f838 rdi:0022f6d8 r8:2b780f15a760 r9:0022f820 r10:2161746164204954 r11:2b780d5712b0 r12:0022fa90 r13:00013198 r14:7b8739b0 r15:7fbe8000 Stack dump: 0x0022f680: 0022f6a0 ff00ff00 0x0022f690: 0x0022f6a0: 0001e06d7363 0x0022f6b0: 7b84a70a 0003 0x0022f6c0: 19930520 0022f870 0x0022f6d0: 2b780f15a760 0022f870 0x0022f6e0: 0022f858 2b780ef3c000 0x0022f6f0: 0022f858 0021 0x0022f700: 00013198 7b8739b0 0x0022f710: 7fbe8000 2b780eefafdc 0x0022f720: 0002c005 0x0022f730: 2b780d54eb28 2b780d3224e0 Backtrace: =0 0x7b84a70a RaiseException+0xba(code=is not available, flags=is not available, nbargs=is not available, args=is not available) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32 (0x2b780f1635f0) 1 0x2b780eee29c1 _CxxThrowException+0x30(object=is not available, type=is not available) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:1109] in msvcrt (0x2b780f1635f0) 2 0x2b780eee3242 MSVCRT___RTtypeid+0x171(cppobj=0x2b780f1635f0) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:901] in msvcrt (0x2b780f1635f0) 3 0x2b780ec60326 func_cpp+0x20c5() [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/dlls/msvcrt/tests/cpp.c:411] in msvcrt_test (0x2b780f1635f0) 4 0x2b780ec5c82c main+0x28b(argc=is not available, argv=is not available) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/include/wine/test.h:557] in msvcrt_test (0x0003) 5 0x2b780ec8dc42 __wine_spec_exe_entry+0xa1(peb=is not available) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in msvcrt_test (0x2b780d2f38f0) 6 0x7b873a61 start_process+0xb0(peb=0x7fbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1052] in kernel32 (0x2b780ec8dba0) 7 0x2b780db5982e call_thread_func+0x6d(entry=0x7b8739b0, arg=0x7fbef000, frame=is not available) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3230] in ntdll (0x7fff5630f450) 8 0x2b780db52f1a call_thread_entry_point+0x29() in ntdll (0x7fff5630f450) 9 0x2b780db24a56 start_process+0x15(kernel_start=is not available) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2653] in ntdll (0x7fff5630f450) 10 0x2b780cfcd283 wine_call_on_stack+0x12() in libwine.so.1 (0x7fff5630f450) 11 0x2b780cfcd2d9 wine_switch_to_stack+0x8(func=is not available, arg=is not available, stack=is not available) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x7fbef000) 12 0x2b780db2a500 LdrInitializeThunk+0x45f(kernel_start=0x7b8739b0, unknown2=is not available, unknown3=is not available, unknown4=is not available) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2709] in ntdll (0x7fbef000) 13 0x7b879ebd __wine_kernel_init+0x91c() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1255] in kernel32 (0x2b780ddbb800) 14 0x2b780db2ad74 __wine_process_init+0x143() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2918] in ntdll (0x7fff56310700) 15 0x2b780cfcb488 wine_init+0x297(argc=0x3, argv=0x7fff56310bf8, error=, error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x7fff56310700) 16 0x7bf00da2 main+0x71(argc=0x3,
Re: [PATCH 1/3] [cmd] move issues when overwriting files
Ann and Jason Edmeades ja...@edmeades.me.uk writes:
@@ -1709,8 +1709,13 @@ void WCMD_move (void)
WINE_TRACE(Source '%s'\n, wine_dbgstr_w(src));
WINE_TRACE(Dest '%s'\n, wine_dbgstr_w(dest));
-/* If destination exists, prompt unless /Y supplied */
-if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) {
+/* If we have src == dest, skip moving this one */
+if (strcmpW(src,dest)==0) ok = FALSE;
You can't detect identical files by comparing file names.
--
Alexandre Julliard
julli...@winehq.org
Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)
Alexandre Goujon ale.gou...@gmail.com writes: @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const DVD_READ_STRUCTURE *structure, } if (ioctl(dev, DVD_READ_STRUCT, s) 0) - return STATUS_INVALID_PARAMETER; +/* Will be converted into ERROR_INVALID_FUNCTION */ +return (errno == ENOMEDIUM) ? STATUS_INVALID_DEVICE_REQUEST : STATUS_INVALID_PARAMETER; That doesn't make much sense, you probably want to use FILE_GetNtStatus. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)
Piotr Caban pi...@codeweavers.com writes: try2: - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.
Qian Hong fract...@gmail.com writes: @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) bufW[0] = 0; bufA[0] = 0; -ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), FAMILY (family name) could not be read\n); +ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) || + get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES), You should avoid that sort of thing, it will be hard to debug, particularly since get_ttf_nametable_entry itself has ok() calls. Store the result in a variable instead. -- Alexandre Julliard julli...@winehq.org
Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.
I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.
Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21417 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout
Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout
Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout
