Re: [2/2] windowscodecs: Add a bunch of GIF metadata tests.

2012-09-12 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21528

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply




Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation

2012-09-12 Thread Ken Thomases
On Sep 12, 2012, at 2:17 PM, James Eder wrote:

 -valSize = sizeof(longVal);
 -if (!sysctlbyname(hw.cpufrequency, longVal, valSize, NULL, 0))
 -cpuHz = longVal;

I haven't tried building, but this would still leave the warning about longVal 
being declared but never used, right?  I don't see you removing that 
declaration.

Regards,
Ken





Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome

2012-09-12 Thread Michael Stefaniuc
After talking to Henri on irc, please ignore this patch. There are
patches out there to enumerate more devices than the primary one and
then the flags do play a role.

On 09/12/2012 11:08 PM, Michael Stefaniuc wrote:
 ---
  dlls/ddraw/main.c |5 +
  1 files changed, 1 insertions(+), 4 deletions(-)
 
 diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c
 index 61e8ec9..b79b12e 100644
 --- a/dlls/ddraw/main.c
 +++ b/dlls/ddraw/main.c
 @@ -377,12 +377,9 @@ HRESULT WINAPI 
 DirectDrawEnumerateExA(LPDDENUMCALLBACKEXA Callback, void *Contex
DDENUM_NONDISPLAYDEVICES))
  return DDERR_INVALIDPARAMS;
  
 -if (Flags)
 -FIXME(flags 0x%08x not handled\n, Flags);
 -
  TRACE(Enumerating default DirectDraw HAL interface\n);
  
 -/* We only have one driver by now */
 +/* We have only one driver (primary) which is always enumerated 
 regardless of the flags */
  __TRY
  {
  static CHAR driver_desc[] = DirectDraw HAL,
 

bye
michael




dssenh: implementing the dssenh cryptographic service provider

2012-09-12 Thread Marek Chmiel
Hello all,
over the summer I had a chance to complete the regression test suite
for the DSSENH cryptographic provider; thank you to those that helped
along the way. I am currently researching how to implement the actual
provider, and any suggestions would be greatly appreciated. A question
I have is: RSAENH AND DSSENH both use the same encryption algorithms
(I am not 100% sure about that yet), so for example could I use one
that was written for RSAENH or shall I write those functions on my own
using Libtomcrypt?

Thank you.
--Marek




Re: dssenh: implementing the dssenh cryptographic service provider

2012-09-12 Thread Juan Lang
Hi Marek,

On Wed, Sep 12, 2012 at 2:57 PM, Marek Chmiel kcm...@gmail.com wrote:
 Hello all,
 over the summer I had a chance to complete the regression test suite
 for the DSSENH cryptographic provider; thank you to those that helped
 along the way. I am currently researching how to implement the actual
 provider, and any suggestions would be greatly appreciated. A question
 I have is: RSAENH AND DSSENH both use the same encryption algorithms
 (I am not 100% sure about that yet), so for example could I use one
 that was written for RSAENH or shall I write those functions on my own
 using Libtomcrypt?

There are some algorithms in common, e.g. MD5 and SHA1. For these, I
think you'd want to copy/paste the existing implementation from rsaenh
into dssenh. There are other algorithms, e.g. DSS aka DSA, e.g. DH,
that are not. For these, I think you'd want to use an existing
implementation, but since none exists in Wine, you'd have to import
new code.  libtomcrypt's license makes it relatively easy to use.

Hope that helps,
--Juan




Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.

2012-09-12 Thread Vincent Povirk
 +stream = create_stream(IMD_data, sizeof(IMD_data));

Er, where is create_stream defined? I don't see it in git or a previous patch.




Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.

2012-09-12 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote:

  +stream = create_stream(IMD_data, sizeof(IMD_data));
 
 Er, where is create_stream defined? I don't see it in git or a previous patch.

It's added by 5373f8520d2fec729730aaa6a3278cefa46f9414

-- 
Dmitry.




Re: [2/2] windowscodecs: Create Graphic Control Extension metadata block for a GIF frame.

2012-09-12 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21552

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply




Translations of the About Pages

2012-09-12 Thread Kyle Auble
I just submitted a draft rewrite of WineHQ's About page in English that
integrates some things from the wiki page, but there are still Hebrew
and Spanish about pages on the wiki. I started working on translating
the Spanish one, but realized someone else should probably do it after
one paragraph, and my Hebrew is even weaker.

I think the goal is still to move all central pages to WineHQ so I'd
like to remove those versions from the wiki soon too. If any Hebrew or
Spanish-speaking contributors would prefer to work from the wiki content
though, I can leave it up for a while. If you would rather translate
from the new English version to keep the different translations in sync
though, I'll go ahead and clean up the wiki some more.

- Kyle