Re: Overriding the check for ownership of a prefix
On 9/20/12 3:07 AM, Francois Gouget wrote: On Wed, 19 Sep 2012, Scott Ritchie wrote: [...] There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Wine checks the ownership of the $WINEPREFIX directory right? So wouldn't touching a file in $WINEPREFIX before starting Wine work? system.reg would be a good candidate. Alternatively, create/delete some other file. Yes, unfortunately unionfs displays a sort of mixed permission structure: files are owned by the user once they are modified, but the hosting directory name itself can't be modified in this way, which is exactly what Wine checks.
Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats.
> @@ -2123,6 +2125,8 @@ static void move_bitmap(GpBitmap *dst, GpBitmap *src,
> BOOL clobber_palette)
> if (dst->metadata_reader)
> IWICMetadataReader_Release(dst->metadata_reader);
> dst->metadata_reader = src->metadata_reader;
> +dst->prop_count = src->prop_count;
> +dst->prop_item = src->prop_item;
> if (dst->image.stream)
> IStream_Release(dst->image.stream);
> dst->image.stream = src->image.stream;
I think you should be freeing dst->prop_item here.
> @@ -2850,6 +2923,12 @@ GpStatus WINGDIPAPI GdipGetAllPropertyItems(GpImage
> *image, UINT size,
>
> if (prop_count != count || prop_size != size) return InvalidParameter;
>
> +if (((GpBitmap *)image)->prop_item)
> +{
> +memcpy(buf, ((GpBitmap *)image)->prop_item, prop_size);
> +return Ok;
> +}
> +
> reader = ((GpBitmap *)image)->metadata_reader;
> if (!reader) return PropertyNotFound;
I think you have to change the values here so they point into the user buffer.
> +typedef GpStatus (*metadata_reader_func)(GpBitmap *bitmap, IWICBitmapDecoder
> *decoder, UINT frame);
...
> +if (metadata_reader)
> +metadata_reader(bitmap, decoder, active_frame);
> +else if (IWICBitmapFrameDecode_QueryInterface(frame,
> &IID_IWICMetadataBlockReader, (void
Either your metadata reader function should return void, or you should
check the returned status.
Otherwise, this looks good to me.
Re: jscript: Added support for RegExp.$* properties
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21683 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found
Re: Overriding the check for ownership of a prefix
On Wed, 19 Sep 2012, Scott Ritchie wrote: [...] > There is one major snag, however: unionfs displays the owner as root until the > user has modified/copied it. This means Wine refuses to launch as the user > with the "root-owned" prefix. Wine checks the ownership of the $WINEPREFIX directory right? So wouldn't touching a file in $WINEPREFIX before starting Wine work? system.reg would be a good candidate. Alternatively, create/delete some other file. -- Francois Gouget http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0
