Re: cmd: /r is equivalent to /c

2012-10-02 Thread Dmitry Timoshkov 
Ken Sharp  wrote:

> -  if (tolowerW(c)=='c') {
> +  if (tolowerW(c)=='c'||'r') {

In C it doesn't work this way.

-- 
Dmitry.

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-02 Thread Rosanne DiMesio 
On Tue, 2 Oct 2012 23:48:22 +0200
"newsletter [at] Schiermeier-Software"  
wrote:

> 
> Please Rosane, help us...!
> 
> Thanks a lot!
> 

I'd love to, but if the AppDB has a way to ban users, I don't have access to 
it. I've already deleted the comments from the Office 2007 page (twice), and it 
looks like someone else deleted them from the Photoshop page. 

I tried deleting the spammer's account, and the system asked me if I really 
wanted to, but it didn't delete it even after I said yes. I'm not sure that 
would have helped anyway, as he could easily just create a new account. We 
really do need some sort of moderation for AppDB comments similar to what's on 
the forum. 

The spammer's display name is menujusukses, email is rian_barka...@ymail.com.


-- 
Rosanne DiMesio

Re: ImmIsUIMessageA/W

2012-10-02 Thread André Hentschel 
Am 02.10.2012 21:23, schrieb Aric Stewart:
> I have a proposed patch that I have tested with World of Tanks and it does 
> not cause http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on 
> either mac or Linux.
> 
> Would you be able to test it and confirm that I am not reintroduction the 
> issues?

doesn't work here with WoT v0.6.4, after loading i get a black screen caused by 
a loop:

$WINEDEBUG=imm WINEPREFIX=~/.winewot/ wine WorldOfTanks.exe 
err:menubuilder:init_xdg error looking up the desktop directory
trace:imm:DllMain 0x7df3, 1, 0x1
fixme:win:EnumDisplayDevicesW ((null),0,0xeb0518,0x), stub!
fixme:win:EnumDisplayDevicesW ((null),1,0xeb0518,0x), stub!
trace:imm:DllMain 0x7e59, 1, (nil)
trace:imm:ImmGetContext (nil)
trace:imm:ImmGetContext (nil)
fixme:win:EnumDisplayDevicesW ((null),0,0x32eafc,0x), stub!
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 3, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
fixme:toolhelp:Heap32ListFirst : stub
fixme:d3d:swapchain_init The application requested more than one back buffer, 
this is not properly supported.
Please configure the application to use double buffering (1 back buffer) if 
possible.
fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1.
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
fixme:avrt:AvSetMmThreadCharacteristicsW (L"Audio",0x4aaea24): stub
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
fixme:d3d9:Direct3DShaderValidatorCreate9 stub
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 3, (nil)
ImportError: No module named BWAutoImport
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
fixme:win:EnumDisplayDevicesW ((null),0,0x32e940,0x), stub!
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
trace:imm:ImmIsUIMessageW ((nil), 200, 0, 25166336)
trace:imm:ImmIsUIMessageW ((nil), ff, 0, 2024552)
trace:imm:ImmIsUIMessageW ((nil), ff, 0, 2024552)
fixme:thread:NtQueryInformationThread Cannot get kerneltime or usertime of 
other threads
trace:imm:ImmGetContext 0x20058
trace:imm:IMM_GetThreadData Thread Data Created
trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407
trace:imm:LoadDefaultWineIME Attempting to fall back to wine default IME
trace:imm:ImeInquire 
trace:imm:ImeSelect 0x14970fd8 TRUE
trace:imm:ImmGetDefaultIMEWnd Default is 0x20062
trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407
trace:imm:ImmCreateContext Created context 0x14970fd8
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:ImmGetConversionStatus 0x14970fd8 0x32f024 0x32f028
trace:imm:ImmSetOpenStatus 0x14970fd8 1
trace:imm:IME_WindowProc Incoming Message 0x81  (0x, 0x0032ef6c)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Incoming Message 0x83  (0x, 0x0032edb4)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Non-standard message 0x83
trace:imm:IME_WindowProc Incoming Message 0x1  (0x, 0x0032ef6c)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Incoming Message 0xc  (0x, 0x0032e2f0)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Non-standard message 0xc
trace:imm:IME_WindowProc Incoming Message 0x5  (0x, 0x00010001)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Non-standard message 0x5
trace:imm:IME_WindowProc Incoming Message 0x3  (0x, 0x)
trace:imm:ImmGetContext 0x20058
trace:imm:ImmGetContext returning 0x14970fd8
trace:imm:IME_WindowProc Non-standard message 0x3
trace:imm:ImmNotifyIME (0x14970fd8, 3, 0, 6)
trace:imm:NotifyIME 0x14970fd8 3 0 6
trace:imm:NotifyIME IMC_SETOPENSTATUS
trace:imm:ImmGetDefaultIMEWnd Default is 0x20062
trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407
trace:imm:ImmSetConversionStatus 0x14970fd8 0 0
trace:imm:ImmSetOpenStatus 0x14970fd8 1
fixme:imm:ImmReleaseContext (0x20058, 0x14970fd8): stub
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:DllMain 0x7df3, 2, (nil)
trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0)
trace:imm:ImmGetDefaultIMEWnd Default is 0x20062
trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407
trace:imm:IME_Wind

AppDB: Could someone please block this Spammer (UCE)

2012-10-02 Thread newsletter [at] Schiermeier-Software 
Hello everybody,

could someone of the AppDB admin team please block this UCE-Mails
which comes via AppDB-notifications?

I'm speaking about this:
1.) Tue, 02 Oct 2012 04:58:05 -0500

2.) Tue, 02 Oct 2012 12:01:08 -0500

3.) Tue, 02 Oct 2012 15:11:12 -0500

4.) Tue, 02 Oct 2012 15:35:39 -0500


Please Rosane, help us...!

Thanks a lot!

-- 

Gruss von
Joerg Schiermeier

Re: ImmIsUIMessageA/W

2012-10-02 Thread Aric Stewart 
I have a proposed patch that I have tested with World of Tanks and it does not cause 
http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on either mac or Linux.


Would you be able to test it and confirm that I am not reintroduction the 
issues?

thanks!
-aric

On 9/25/12 2:54 PM, Henri Verbeet wrote:

On 25 September 2012 21:12, André Hentschel  wrote:

I don't remember the app, be free to patch it in again, at best with tests.


Wasn't that for World of Tanks?

commit e0b590c50292c367e1c8bffb6f7b2775539e82a1
Author: Aric Stewart 
Date:   Tue Oct 2 14:20:35 2012 -0500

imm32: in ImmIsUIMessage redirect message to default hwnd if no hwnd is 
specified

diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c
index 64933c2..0df4b05 100644
--- a/dlls/imm32/imm.c
+++ b/dlls/imm32/imm.c
@@ -1924,6 +1924,9 @@ BOOL WINAPI ImmIsUIMessageA(
 (msg == WM_MSIME_QUERYPOSITION) ||
 (msg == WM_MSIME_DOCUMENTFEED))
 {
+if (!hWndIME)
+hWndIME = ImmGetDefaultIMEWnd(NULL);
+
 if (hWndIME)
 SendMessageA(hWndIME, msg, wParam, lParam);
 
@@ -1954,6 +1957,9 @@ BOOL WINAPI ImmIsUIMessageW(
 (msg == WM_MSIME_QUERYPOSITION) ||
 (msg == WM_MSIME_DOCUMENTFEED))
 {
+if (!hWndIME)
+hWndIME = ImmGetDefaultIMEWnd(NULL);
+
 if (hWndIME)
 SendMessageW(hWndIME, msg, wParam, lParam);

Re: shell32/tests: Write proper tests for CommandLineToArgvW().

2012-10-02 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21949

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: shell32/tests: Write proper tests for CommandLineToArgvW().

2012-10-02 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21950

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 7/7] mshtml: Added script 'for' and 'event' attributes tests

2012-10-02 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21945

Your paranoid android.


=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

2012-10-02 Thread Jacek Caban 
Hi Marcus,

On 10/01/12 23:00, Marcus Meissner wrote:
> Hi,
>
> Various coverity issues complain about user-after-free scenarios,
> all involving this code path.
>
> I strongly think if call_ret signals error, we also need to return
> an error condition to avoid the callers from proceeding as if nothing
> happened.
>
> Second reiteration with Jaceks comment applied

Sorry for not catching this later, I was concentrated on your comment
instead of the code, but the important thing is that true call_ret means
success (and wininet doing request asynchronously is signalled as an
error). It means that in this case we want to return RPC_S_OK. What is
the exact problem?

Jacek

Re: wininet/tests(1/2): Test CommitUrlCacheEntry with the original URL parameter

2012-10-02 Thread Piotr Caban 

On 10/02/12 03:30, Juan Lang wrote:
+/* On the other hande, GetUrlCacheEntryInfoEx allows you to query the
+ * original URL.
+ */
There's a typo, should be "On the other hand".

+/* Strangely, you can create a cache entry redirected to itself. */
+ret = CreateUrlCacheEntry(test_url, 0, "html", filenameA, 0);
+ok(ret, "CreateUrlCacheEntry failed with error %d\n", GetLastError());
+create_and_write_file(filenameA, &zero_byte, sizeof(zero_byte));
+ret = CommitUrlCacheEntry(test_url, filenameA, filetime_zero, 
filetime_zero,

+NORMAL_CACHE_ENTRY, NULL, 0, NULL, test_url);
In this case original url is ignored. Probably it's a more appropriate 
comment.


Your test is leaving an entry in index.dat file. Please remove 
test_original_url entry from cache after testing it.


Cheers,
Piotr

Re: [PATCH 2/3] vbscript: Added LTrim() implementation

2012-10-02 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21943

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [PATCH 1/3] vbscript: Added Trim() implementation

2012-10-02 Thread Marvin 
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21942

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: wininet(2/2): Fail to commit a url cache entry when the original URL is specified and no local filename is given

2012-10-02 Thread Piotr Caban 

On 10/02/12 03:31, Juan Lang wrote:
@@ -3084,6 +3084,11 @@ static BOOL CommitUrlCacheEntryInternal(
 SetLastError(ERROR_INVALID_PARAMETER);
 return FALSE;
 }
+if (lpszOriginalUrl && !lpszLocalFileName)
+{
+SetLastError(ERROR_INVALID_PARAMETER);
+return FALSE;
+}
 if (lpszOriginalUrl)
 WARN(": lpszOriginalUrl ignored\n");

The function should succeed if lpszOriginalUrl is specified and it 
operates on history container. Probably the check for lpszLocalFileName 
with  STICKY_CACHE_ENTRY is also redundant.


I guess that the lpszLocalFileName should be validated in following way:
if(pContainer->default_entry_type==NORAML_CACHE_ENTRY && 
!lpszLocalFileName) {

SetLastError(ERROR_INVALID_PARAMETER);
return FALSE;
}

I haven't check what happens for cookies containers.

Cheers,
Piotr