Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)
On 04/01/2013 08:16 AM, Henri Verbeet wrote: I think it's ok for the tests to be todo_wine, but we do want ddraw coverage for this in the tests. Fine by me. But that will take a few days since I'll have to familiarize myself with ddraw first. :) In the meantime, should I resend this patchset (with the reset_device() change included) so that it can be reviewed and committed while I'm busy with ddraw (and send the ddraw tests in a separate patch), or is this patchset unacceptable until I include the ddraw tests? Thanks, Sam
Re: uxtheme/tests: Don't test for themed app
André Hentschel n...@dawncrow.de writes: @@ -84,18 +84,14 @@ static void test_IsThemed(void) SetLastError(0xdeadbeef); bThemeActive = pIsThemeActive(); trace(Theming is %s\n, (bThemeActive) ? active : inactive); +ok( GetLastError() == ERROR_SUCCESS || +broken(GetLastError() == ERROR_FILE_NOT_FOUND /* Win2k8 */), +Expected ERROR_SUCCESS, got 0x%08x\n, +GetLastError()); Testing last error when there's no failure is not useful. -- Alexandre Julliard julli...@winehq.org
Re: d3dx9 [patch1/3, try 2]: Do not use relative error for small numbers
2013/4/1 Nozomi Kodama nozomi.kod...@yahoo.com Since there are only at most 7 significant digits for a float, we must not be too picky about the expected difference for small numbers -#define relative_error(exp, out) ((exp == 0.0f) ? fabs(exp - out) : (fabs(1.0f - (out) / (exp +#define relative_error(exp, out) (fabs(exp) 0.01f ? fabs(exp - out) : fabs(1.0f - (out) / (exp))) This doesn't make much sense. Being floating point numbers, they have the same relative precision regardless of the magnitude of the value (as long as you are inside the range of representable values and excluding special values and denormals, but that should be irrelevant to our case here). If using a larger tolerance for the test in patch 2 makes it pass, then I think that's all you have to change. Otherwise you need to figure out why the test result differs so much from the expected value. Slightly unrelated, I think we should use fabsf() instead of fabs() there. We are already using fabsf() in a bunch of places, including d3dx9 tests, so there shouldn't be problems with that.
Fwd: GSoC 2013 Ideas Page
I cleaned this up a couple months ago and removed completed/obsolete projects, but it needs further improvements (mostly new ideas). Please contribute any ideas that you have. Thanks! -Austin -- Forwarded message -- From: Carol Smith car...@google.com Date: Tue, Apr 2, 2013 at 1:41 PM Subject: GSoC 2013 Ideas Page To: Carol Smith car...@google.com Hi there, You're receiving this email because we've reviewed your application for GSoC 2013. We're currently disappointed with the quality of your Ideas Page and would like to give you an opportunity to improve it and your chances of getting into GSoC this year. Please review the FAQs on Ideas Pageshttp://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2013/help_page#3._What_is_an_Ideas_list as well as the Mentor Manual section about creating an ideaspagehttp://en.flossmanuals.net/GSoCMentoring/making-your-ideas-page/ . You have 24 hours from now to improve your ideas page.We will review it again tomorrow. Please let me know if you have any questions. Cheers, Carol -- -Austin
Re: GSoC 2013 Ideas Page
On Tue, Apr 2, 2013 at 2:31 PM, Austin English austinengl...@gmail.comwrote: I cleaned this up a couple months ago and removed completed/obsolete projects, but it needs further improvements (mostly new ideas). Please contribute any ideas that you have. Thanks! -Austin -- Forwarded message -- From: Carol Smith car...@google.com Date: Tue, Apr 2, 2013 at 1:41 PM Subject: GSoC 2013 Ideas Page To: Carol Smith car...@google.com Hi there, You're receiving this email because we've reviewed your application for GSoC 2013. We're currently disappointed with the quality of your Ideas Page and would like to give you an opportunity to improve it and your chances of getting into GSoC this year. Please review the FAQs on Ideas Pageshttp://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2013/help_page#3._What_is_an_Ideas_list as well as the Mentor Manual section about creating an ideaspagehttp://en.flossmanuals.net/GSoCMentoring/making-your-ideas-page/ . You have 24 hours from now to improve your ideas page.We will review it again tomorrow. Please let me know if you have any questions. Cheers, Carol -- -Austin Forgot the wiki url: http://wiki.winehq.org/SummerOfCode -- -Austin
