Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)
Nikolay Sivov писал 03.04.2013 15:56: > On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina wrote: > >> Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that? Yes, it is... I have to write the test? Links: -- [1] mailto:taty...@etersoft.ru
Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 2)
Austin English wrote: > Try 2: use cdecl calling convention > -@ stub __crtSetUnhandledExceptionFilter > +@ cdecl __crtSetUnhandledExceptionFilter(ptr) > kernel32.SetUnhandledExceptionFilter It's not acceptable to mix calling conventions when forwarding an API with number of arguments != 0. -- Dmitry.
Re: cmd: Remove a pointless linefeed in an error message.
Sorry for nagging ;) Wasn't the convention to assume an 80-character wide terminal? This line would wrap, then. So the linefeed is not totally pointless here. Please correct me, if I'm mistaken. Best regards, Julian Am Mittwoch, den 03.04.2013, 16:07 +0200 schrieb Francois Gouget: > --- > programs/cmd/cmd.rc |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/cmd/cmd.rc b/programs/cmd/cmd.rc > index c3cdb52..d464cab 100644 > --- a/programs/cmd/cmd.rc > +++ b/programs/cmd/cmd.rc > @@ -360,5 +360,5 @@ Enter HELP for further information on any of > the above commands.\n" >WCMD_NOOPERAND, "Expected an operand.\n" >WCMD_NOOPERATOR, "Expected an operator.\n" >WCMD_BADPAREN, "Mismatch in parentheses.\n" > - WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12),\n > hexadecimal (0x34) or octal (056).\n" > + WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12), > hexadecimal (0x34) or octal (056).\n" > }
Re: [PATCH 1/2] winspool.drv/tests: Add DocumentProperties test with empty pDeviceName.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24941 Your paranoid android. === WINEBUILD (build) === Can't determine base name
Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 2, resend)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24942 Your paranoid android. === WINEBUILD (build) === Can't determine base name
Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.
On Wed, Apr 03, 2013 at 02:33:06PM +0200, Marcus Meissner wrote: > Hi, > > I have one concern ... > > Licensing. > > GNUTLS is (L)GPLv3+ these days. > Wine will now turn into a LPGLv3+ licensed binary (not the sources, just > the binaries will turn into it implicitly by linking against gnutls 3). After talking to my legal council ... it is only a problem for GPLv2 -> GPLv3 http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility So please ignore me. Ciao, Marcus
Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.
Hi,
I have one concern ...
Licensing.
GNUTLS is (L)GPLv3+ these days.
Wine will now turn into a LPGLv3+ licensed binary (not the sources, just
the binaries will turn into it implicitly by linking against gnutls 3).
Ciao, Marcus
On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote:
> ---
> configure.ac | 13 -
> 1 file changed, 13 deletions(-)
>
>
> diff --git a/configure.ac b/configure.ac
> index d8f2e8d..080e961 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -66,8 +66,6 @@ AC_ARG_WITH(openal,
> AS_HELP_STRING([--without-openal],[do not use OpenAL]),
> AC_ARG_WITH(opencl,AS_HELP_STRING([--without-opencl],[do not use
> OpenCL]),
> [if test "x$withval" = "xno"; then ac_cv_header_CL_cl_h=no;
> ac_cv_header_OpenCL_opencl_h=no; fi])
> AC_ARG_WITH(opengl,AS_HELP_STRING([--without-opengl],[do not use
> OpenGL]))
> -AC_ARG_WITH(openssl, AS_HELP_STRING([--without-openssl],[do not use
> OpenSSL]),
> -[if test "x$withval" = "xno"; then
> ac_cv_header_openssl_err_h=no; ac_cv_header_openssl_ssl_h=no; fi])
> AC_ARG_WITH(osmesa, AS_HELP_STRING([--without-osmesa],[do not use the
> OSMesa library]))
> AC_ARG_WITH(oss, AS_HELP_STRING([--without-oss],[do not use the OSS
> sound support]))
> AC_ARG_WITH(png, AS_HELP_STRING([--without-png],[do not use PNG]),
> @@ -469,8 +467,6 @@ AC_CHECK_HEADERS(\
> netinet/in_systm.h \
> netinet/tcp.h \
> netinet/tcp_fsm.h \
> - openssl/err.h \
> - openssl/ssl.h \
> png.h \
> poll.h \
> port.h \
> @@ -1604,15 +1600,6 @@ fi
> WINE_NOTICE_WITH(fontconfig,[test "x$ac_cv_lib_soname_fontconfig" = "x"],
> [fontconfig ${notice_platform}development files not found,
> fontconfig won't be supported.])
>
> -dnl Check for SSL
> -if test "$ac_cv_header_openssl_err_h" = "yes" -a
> "$ac_cv_header_openssl_ssl_h" = "yes"
> -then
> -WINE_CHECK_SONAME(ssl,SSL_library_init)
> -WINE_CHECK_SONAME(crypto,BIO_new_socket)
> -fi
> -WINE_WARNING_WITH(openssl,[test "x$ac_cv_lib_soname_ssl" = "x" -o
> "x$ac_cv_lib_soname_crypto" = "x"],
> - [OpenSSL ${notice_platform}development files not found, SSL
> won't be supported.])
> -
> dnl Check for gsm codec
> if test "$ac_cv_header_gsm_h" = "yes" -o "$ac_cv_header_gsm_gsm_h" = "yes"
> then
>
>
Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)
On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina wrote: > Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value > pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that?
Re: ieframe: Added GoForward tests.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24939 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3065: Test failed: doc_disp == NULL webbrowser: unhandled exception c005 at 00402F21
Re: Hi Res Icons
Joel Holdsworth writes: > As you can see here, scaling the iexplore icons really shows the > limits of this artwork. The line caps are wrong in several places. The > worst being in the highlight of the yellow swoosh at the bottom - you > see the highlight doesn't line up with the border. A lot of things > don't quite line up correctly. It still looks better than the scaled up 48x48 version we'd get otherwise ;-) But yes, if someone wants to work on improving this it would certainly be welcome. > Also, I don't know how much this work is being driven by CodeWeavers > Mac product, but another approach would be to for CodeWeavers to > solicit contract work or a bounty for this. Jakub or Lapo might be > more able to make time on those terms - but of course I don't know if > that's a deal they or CodeWeavers would be interested in making. It's just something I was playing with, it's not a priority for CodeWeavers at all. > Finally, I've rebased my patch for the joy.cpl icon. It doesn't have a > 256px icon though. Is this wanted? Ultimately yes, though at the moment the Mac driver doesn't show the large icon for control panel apps. -- Alexandre Julliard julli...@winehq.org
Hi Res Icons
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alexandre (+ Others), I notice you've been working on hi-res icons. I just have a couple of comments to chip in. So 2 years ago when I was doing the wine icon refresh, I decided not to try and tackle the problem of hi-res icons. Just getting the normal sized icons merged had proved to be a gargantuan task that took me over a year to complete - I didn't have the stomach to embark on another round of artwork. We also didn't support PNG icons in those days. As you can see in these hi-res icon patches, scaling icons is never as simple as people think. http://source.winehq.org/git/wine.git/blob/HEAD:/programs/iexplore/iexplore.svg As you can see here, scaling the iexplore icons really shows the limits of this artwork. The line caps are wrong in several places. The worst being in the highlight of the yellow swoosh at the bottom - you see the highlight doesn't line up with the border. A lot of things don't quite line up correctly. Moreover what were sharp single pixel lines in the 48x48 image have become fat strokes, which look rather play-schoolish to my eye. The solution is to have dedicated artwork specifically for these large sizes. This has been done in the Mango icon project: http://jimmac.musichall.cz/i.php?i=MIME2 http://jimmac.musichall.cz/i.php?i=git3 http://jimmac.musichall.cz/i.php?i=Tango-NG This is the work of Jakub Steiner and Lapo Calamandrei. They did a workshop on how to do this artwork here: https://www.youtube.com/watch?v=2T7833s2MJI Notice the fine detailing and beautiful shading. In the network filter they even used a paper texture for the card of the folder! These guys have done a fantastic job. So I wanted to sound out how much desire there is for this for Wine. I'm probably not going to be able to contribute this myself, due to time constraints. I wondered if there were any other developers cum artists interested in having a go. 2 years ago I asked Jakub if he would be interested in doing this, but he said he was quite busy. It might be worth reaching out to him or Lapo again, to see if they'd like to contribute. Also, I don't know how much this work is being driven by CodeWeavers Mac product, but another approach would be to for CodeWeavers to solicit contract work or a bounty for this. Jakub or Lapo might be more able to make time on those terms - but of course I don't know if that's a deal they or CodeWeavers would be interested in making. Another source of volunteers might be the tango-artists ML, but I don't know how many there are there. Finally, I've rebased my patch for the joy.cpl icon. It doesn't have a 256px icon though. Is this wanted? Best Regards Joel Holdsworth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRW/TtAAoJEIsWlGmq62IgaEcIAJYY9q/B3fA2AZQnR5M41qWn Q84e/5jrc1u2w1skmWAkCNdHNHu/R6AURklQ0Hysbnzxp+5GfftPHTKkRzA59cgs jVmkTSiqdVGGeGDRW2YWAcaFiH25xEOqSb9APzMLT4IRVypLbTwWYWhAsaZCa6+0 1USLRakqs5SF7+lCt5VcSHqiko/HPZZsTtNZYDy7cE4DPoNGbajPR9/0fEUfOEj+ b6xyu62tzPHfUcH4hj7YLa7ukJhq2Hh2ELA6gXnjr6yk+pZfx2uMTtfPZ4joWZzw 1DVcyoTkmeCOnasKJU2Obj7vdWgZxWG+WG4KTneH9a+rkSLo6T6Jojae+BXU4O8= =tNa1 -END PGP SIGNATURE-
Re: [PATCH 1/5] wined3d: Make fullscreen windows use HWND_TOPMOST instead of HWND_TOP. (try 3)
I think this series looks good.
