Re: GSoC 2013 has begun!
On Tue, May 28, 2013 at 2:50 PM, Austin English wrote: > Howdy, > > Wine has accepted 4 student proposals for Google Summer of Code 2013: > George Stephanos, "Registry - implement merging between HKCR and > HKCU\Software\Classes" mentored by Detlef Riekenberg > Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies > John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by > Nikolay Sivov > Zhan Jianyu, "Improve and add missing feature of vbscript component" > mentored by Jacek Caban > > Welcome to Wine and good luck on your projects! > > As a reminder, here are the next few big dates: > May 27th - June 17: community bonding period. Students/mentors should > use this time to iron out details of the project, learn the code base > and get to know others on the project. > > June 17: coding officially begins > > July 29th - Aug 2nd: mid-term reviews are submitted. > > Mentors/students, please feel free to contact me or André Hentschel if > you have any GSoC administrative/procedural questions. Otherwise use > wine-devel or ask your mentor for help with learning the Wine > development process/codebase/etc. > > -- > -Austin A quick follow up. If anyone would like to assist mentoring any of the accepted projects, please let me know and I'll add you as an additional mentor. -- -Austin
re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten
Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite the result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in parse_skin_mesh_info. Cheers Rico On 28.05.2013 22:16, Alexandre Julliard wrote: +if (SUCCEEDED(hr)) +hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index, + (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT; +if (FAILED(hr)) +goto end; +} + +hr = D3D_OK;
Re: dinput: Update existing joystick values after setting the range property
On Sun, Apr 14, 2013 at 2:25 PM, Bassi, Gurmail wrote: > ePSXe polls the joystick immediately after setting the axis range property, > and uses the returned values as its 'centered' calibrated values - therefore > the existing joystick state values must be remapped to the new range (or else > the joystick may not have the full range of motion) > > > This patch has been tested on Ubuntu 12.04.1 LTS x86-64, and the behaviour > confirmed to match Microsoft's DirectInput implementation on Windows XP > 32-bit (Microsoft's DirectInput seems to update the existing joystick values > to the new range prior to polling even if the joystick hasn't been moved) > > > --- > dlls/dinput/joystick.c | 47 +++ > 1 file changed, 47 insertions(+) Hi Gurmail, This appears to have caused a regression, see http://bugs.winehq.org/show_bug.cgi?id=33496 (normally I'd cc you on the bug, but you don't seem to have a bugzilla account). -- -Austin
Re: [PATCH] slc: Fix return type
Le 29/05/2013 12:06, Detlef Riekenberg a écrit :
--
By by ... Detlef
---
dlls/slc/slc.c | 31 +++
include/slpublic.h |2 +-
2 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c
index e7416f1..7fc9b93 100644
--- a/dlls/slc/slc.c
+++ b/dlls/slc/slc.c
@@ -1,6 +1,7 @@
/*
*
* Copyright 2008 Alistair Leslie-Hughes
+ * Copyright 2010 Detlef Riekenberg
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -28,15 +29,8 @@
WINE_DEFAULT_DEBUG_CHANNEL(slc);
-DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue)
-{
-FIXME("(%s) stub\n", debugstr_w(lpszValueName) );
-
-return SL_E_RIGHT_NOT_GRANTED;
-}
-
/***
- * DllMain (CLUSAPI.@)
+ * DllMain (slc.@)
*
*/
BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved)
@@ -51,3 +45,24 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason,
LPVOID lpvReserved)
}
return TRUE;
}
+
+/***
+ * SLGetWindowsInformationDWORD (slc.@)
+ *
+ * check the license and return the value for the given name
+ *
+ * PARAMS
+ * name[i] application related value name to check
+ * pvalue [o] ptr, where the value for the given name should be saved
+ *
+ * RETURNS
+ * Success: S_OK
+ * Failure: A HRESULT error code
+ *
+ */
+HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue)
+{
+FIXME("(%s, %p) stub\n", debugstr_w(name), pvalue);
+
+return SL_E_RIGHT_NOT_GRANTED;
+}
diff --git a/include/slpublic.h b/include/slpublic.h
index a2c6d42..5553787 100644
--- a/include/slpublic.h
+++ b/include/slpublic.h
@@ -29,7 +29,7 @@ extern "C" {
#define SLCAPI DECLSPEC_IMPORT
#endif
-SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue);
+SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *);
#ifdef __cplusplus
I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)
Re: (try 2)macdrv: rework the way we handle cursor position and composition text
On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 + > dlls/winemac.drv/event.c| 5 --- > dlls/winemac.drv/ime.c | 85 + > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 6 +-- > 5 files changed, 29 insertions(+), 77 deletions(-) > > > <0014-macdrv-rework-the-way-we-handle-cursor-position-and-co.txt> Looks good to me. -Ken
Re: macdrv: rework the way we handle cursor position and composition text
ok, resent. -aric On 5/29/13 12:38 PM, Ken Thomases wrote: > On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > >> --- >> dlls/winemac.drv/cocoa_window.m | 9 + >> dlls/winemac.drv/event.c| 3 -- >> dlls/winemac.drv/ime.c | 85 >> + >> dlls/winemac.drv/macdrv.h | 1 - >> dlls/winemac.drv/macdrv_cocoa.h | 5 +-- >> 5 files changed, 29 insertions(+), 74 deletions(-) > > I know I reviewed this several times, but I failed to notice until now: you > didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry > in the table in dbgstr_event(). > > -Ken >
Re: macdrv: rework the way we handle cursor position and composition text
On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 + > dlls/winemac.drv/event.c| 3 -- > dlls/winemac.drv/ime.c | 85 + > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 5 +-- > 5 files changed, 29 insertions(+), 74 deletions(-) I know I reviewed this several times, but I failed to notice until now: you didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry in the table in dbgstr_event(). -Ken
Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.
Hi, Fabian. You forgot to attach patches 2 and 3.
Re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
On Wed, May 29, 2013 at 01:10:56PM +0200, Maarten Lankhorst wrote: > NAK. > > + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); > + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); > Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning > primary_pwfx to NULL? > CopyFormat will only return NULL if HeapAlloc fails (actually, CopyFormat will probably crash). I've stopped caring about out of memory conditions since they add way too much error handling code and we can't reasonably recover from them anyway. Andrew
Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
Hi, You're right. This can be simplified. Will send a patch. Thanks. Christian 2013/5/29 gurketsky > Hi, > > just saw that a bit late. Is there a reason for the rewrite of hr? > > Could any call return anything other than D3D_OK and succeed (maybe > S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both > cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to > overwrite the result anyway to D3D_OK on success, so I see no reason to > change the hr to D3D_OK in parse_skin_mesh_info. > > Cheers > Rico > > > On 28.05.2013 22:16, Alexandre Julliard wrote: > >> +if (SUCCEEDED(hr)) >> +hr = mesh_data->skin_info->lpVtbl->** >> SetBoneOffsetMatrix(mesh_data-**>skin_info, index, >> + (const D3DMATRIX*)(data + nb_influences * >> (sizeof(DWORD) + sizeof(FLOAT; >> +if (FAILED(hr)) >> +goto end; >> +} >> + >> +hr = D3D_OK; >> > >
Re: Increment, Decrement, and Assignment Operators
Stephen Leibowitz writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH] gdi32: Ask for a newer FreeType version
Detlef Riekenberg writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( >"Wine cannot find the FreeType font library. To enable Wine to\n" >"use TrueType fonts please install a version of FreeType greater > than\n" > - "or equal to 2.0.5.\n" > + "or equal to 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" >"http://www.freetype.org\n";); > return FALSE; > } > @@ -3749,6 +3750,7 @@ sym_not_found: >"Wine cannot find certain functions that it needs inside the > FreeType\n" >"font library. To enable Wine to use TrueType fonts please upgrade\n" >"FreeType to at least version 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" That's not useful. There are probably very few users who still have such an old Freetype, and even if they do, telling them about vertical metrics will only confuse them. -- Alexandre Julliard julli...@winehq.org
GSoC 2013 has begun!
Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin
