Re: [PATCH] gdi32: do not overwrite variables (Coverity) (resubmit)

2013-06-17 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes:

 Hi,

 CID 743138,743137,743136
 wrote a DWORD (32bit) into a SHORT (16bit) entity.

 Not sure what is wrong with this one... it is a pretty clear bug to me.

It's a bug, but it can be fixed in a better way. That helper function is
badly designed.

-- 
Alexandre Julliard
julli...@winehq.org




Re: Update Italian translation

2013-06-17 Thread Matteo Bruni
2013/6/16 Fabian Ebner f.ebne...@gmail.com:
 ---
   po/it.po | 40 ++--
   1 file changed, 14 insertions(+), 26 deletions(-)

 #: joy.rc:42
 msgid 
 After disabling or enabling a device, the connected joysticks won't be 
 updated here until you restart this applet.
 msgstr 
+Dopo disattivare o attivare un dispositivo, i joystick connessi non saranno 
+attualizzati qui, fino al riavvio dell'applet.

That sounds like broken Italian (or a word-by-word translation), maybe
something like Dopo aver disattivato o attivato un dispositivo, i
joystick connessi non saranno aggiornati fino al riavvio
dell'applet.? The original English message has probably some room for
improvement too.

 #: jscript.rc:39
 msgid 'return' statement outside of function
-msgstr 
+msgstr Istruzione 'return' fouri dalla funzione

Typo.




Re: po: Update Italian translation (try 2)

2013-06-17 Thread Matteo Bruni
2013/6/17 Fabian Ebner f.ebne...@gmail.com:
 Fixed a typo and a sentence, thanks to Matteo
 ---
  po/it.po | 40 ++--
  1 file changed, 14 insertions(+), 26 deletions(-)

 #: jscript.rc:39
 msgid 'return' statement outside of function
-msgstr 
+msgstr Istruzione 'return' fouri della funzione

Sorry, but this is worse...




Re: ole32: Do not fail if partial blocks are read

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 1:28 PM, Aric Stewart a...@codeweavers.com wrote:

 fixes bug 25346

Actually this patch fixes bug 33821. Bug 25346 is older than the
regression and was only affected by it.

 ---
  dlls/ole32/storage32.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)


Best wishes,
Bruno




Re: po: Update Italian translation (try 2)

2013-06-17 Thread Fabian Ebner

Am 17.06.2013 18:56, schrieb Matteo Bruni:

2013/6/17 Fabian Ebner f.ebne...@gmail.com:

Fixed a typo and a sentence, thanks to Matteo
---
  po/it.po | 40 ++--
  1 file changed, 14 insertions(+), 26 deletions(-)

  #: jscript.rc:39
  msgid 'return' statement outside of function
-msgstr 
+msgstr Istruzione 'return' fouri della funzione

Sorry, but this is worse...


Sorry, I'm no native speaker. I learned some Italian at school, but it's 
not perfect.

Now, I've seen my mistake: fouri instead of fuori

Thanks again for the review




Re: Web based translation tool

2013-06-17 Thread André Hentschel
On 04.04.2012 16:05, Michal Čihař wrote:
 Hi
 
 Dne Thu, 15 Mar 2012 10:12:14 -0500
 Aric Stewart a...@codeweavers.com napsal(a):
 
 I do not know if Weblate will work or not.

 Basically we have 3 big requirements that have been sticking points for 
 various solutions.

 1) Real Names and e-mails for all contributors

 2) Individual attribution for all translations. So we know exactly who 
 changed what string.

 3) Generate incremental diffs/patches/change sets divided based on 
 translator.

 Generally it is #2 that has been the hardest for projects to cope with.
 
 I think Weblate now does all you request here. The software still has
 some rough edges, but I want to polish them on way to 1.0 release in
 upcoming weeks.

Hi all,
meanwhile there's Weblate 1.5, it seems to have what we want.
Is there still a reason not to use it for Wine?
Otherwise, could someone on the codeweavers side please have look at 
integrating it?




Re: Web based translation tool

2013-06-17 Thread Aric Stewart
Hi,

I just wanted to say that I have not totally abandoned this.  A few months ago 
I again contacted my contacts at the various web translations sites and go no 
new good news. Still nothing gave us everything we needed.

I have been super busy with other work (hence the smaller number of patches as 
well) so I have not had time to really dig into weblate.  I have it bookmarked 
and want to dig.  Very first pass seemed to have very little information about 
what is required and how to set it up.

I have some more time this week so I will give it a much more serious look and 
try to see what I can find out. 

-aric

On 6/17/13 4:30 PM, André Hentschel wrote:
 On 04.04.2012 16:05, Michal Čihař wrote:
 Hi

 Dne Thu, 15 Mar 2012 10:12:14 -0500
 Aric Stewart a...@codeweavers.com napsal(a):

 I do not know if Weblate will work or not.

 Basically we have 3 big requirements that have been sticking points for
 various solutions.

 1) Real Names and e-mails for all contributors

 2) Individual attribution for all translations. So we know exactly who
 changed what string.

 3) Generate incremental diffs/patches/change sets divided based on
 translator.

 Generally it is #2 that has been the hardest for projects to cope with.

 I think Weblate now does all you request here. The software still has
 some rough edges, but I want to polish them on way to 1.0 release in
 upcoming weeks.
 
 Hi all,
 meanwhile there's Weblate 1.5, it seems to have what we want.
 Is there still a reason not to use it for Wine?
 Otherwise, could someone on the codeweavers side please have look at 
 integrating it?
 
 




Re: po: Update Spanish translation

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 6:05 PM, André Hentschel n...@dawncrow.de wrote:
 I recently started to learn spanish, so i did this easy fixes with best 
 knowledge, though without guaranty
 ---
  po/es.po | 60 ++--
  1 file changed, 18 insertions(+), 42 deletions(-)

  #: joy.rc:64
 -#, fuzzy
 -#| msgid Available formats
  msgid Available Effects
 -msgstr Formatos disponibles
 +msgstr Formatos efectos

Efectos disponibles makes more sense than Formatos efectos, I
guess this was a typo.

 #: netstat.rc:33
 msgid Sent
-msgstr 
+msgstr Envió

Envió is present tense, the past tense would be Enviado.

Best wishes,
Bruno