Re: Wine Gecko 2.24-beta1

2013-08-17 Thread Zhenbo Li
I've tested some websites, and found that these pages have problems:

http://mail.163.com (it will make gecko crash)
http://huaban.com   (nothing can be shown)
http://douban.com   (no pictures)
http://html5test.com/   (can't load page, and I'm sure that it's
not a regression)

I've tested them with Firefox + flashblock, so I think they are not
caused by flash.

I'm glad to do more tests to contribute Gecko.

Cheers.

2013/8/14 Jacek Caban :
> Hi all,
>
> It's time to do another update of Wine Gecko, so I prepared a new beta
> build. It's already on Sourceforge [1]. Until server-side support for
> auto install of the package is committed [2], its manual installation is
> required [3]. I attached a patch to Wine that is required for the new Gecko.
>
> Anything that uses MSHTML is worth testing. All help with testing is
> appreciated!
>
> Cheers,
> Jacek
>
> [1] https://sourceforge.net/projects/wine/files/Wine%20Gecko/2.24-beta1/
> [2] http://source.winehq.org/patches/data/97881
> [3] http://wiki.winehq.org/Gecko
>
>
>



-- 
Have a nice day!
Zhenbo Li




Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)

2013-08-17 Thread Nikolay Sivov

On 8/17/2013 21:05, John Chadwick wrote:

Nikolay, does this patch look good to you? I was advised on
#winehackers to get some acknowledgement that the patch is OK.
Hopefully doing so can get things moving along.

Yes, it looks ok. Idea is to have xmlChar closer to actual libxml2 calls 
that need it,

instead of spreading with every top level call, and it does that.




Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)

2013-08-17 Thread John Chadwick
Nikolay, does this patch look good to you? I was advised on
#winehackers to get some acknowledgement that the patch is OK.
Hopefully doing so can get things moving along.




Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-17 Thread Ken Sharp



On 17/08/13 09:02, Frédéric Delanoy wrote:

Hwang YunSong (황윤성)


Looks like UTF-8 works fine, so you could always use your real Chinese name.

황윤성 is Korean I believe.



Re: PLEASE add bug links!

2013-08-17 Thread Rosanne DiMesio
On Sat, 17 Aug 2013 15:37:33 +0100
Ken Sharp  wrote:


> I can, and do, search Bugzilla for that. It is a massive PITA having to 
> do it but a script would make it easier, however...
> 
>

Users can add bug links, so if someone would run an updated script and post the 
results we could post it on the forum and ask users to help. It worked last 
time.


-- 
Rosanne DiMesio 




Re: PLEASE add bug links!

2013-08-17 Thread Ken Sharp



On 17/08/13 13:36, Rosanne DiMesio wrote:

On Sat, 17 Aug 2013 13:07:32 +0200
André Hentschel  wrote:



So this is just with no link in "Show Apps affected by this bug"?
Beside it being outdated i think it's not exactly what Ken wants,


I can, and do, search Bugzilla for that. It is a massive PITA having to 
do it but a script would make it easier, however...




I think what Ken wants is for people to add the bug links when they create the 
bug so we don't periodically wind up with thousands of unlinked bugs that have 
to be cleaned up.


Spot on.

It may seem counter-productive but I agree that you shouldn't be forced 
to create an AppDB account, despite it not hurting in the slightest. The 
problem though is that most people do have both accounts, they're just 
too damned lazy to attach the bug link.


As a general rule the AppDB admins and the Bugzilla triage team are the 
same people, and it's these poor buggers that have to clean up all the 
mess where people could be doing it themselves.


Many a hand makes light work...
Do your part...
Dig for victory...
etc.




Re: [PATCH 4/6] oleaut32: TKIND_ALIAS improvements

2013-08-17 Thread Piotr Caban

On 08/16/13 21:40, Andrew Eikum wrote:

@@ -8502,7 +8502,7 @@ static HRESULT WINAPI 
ICreateTypeLib2_fnCreateTypeInfo(ICreateTypeLib2 *iface,
  info->cbSizeInstance = 2;
  break;
  case TKIND_ALIAS:
-info->cbSizeInstance = -0x75;
+info->cbSizeInstance = 4;
  break;
  default:
  FIXME("unrecognized typekind %d\n", info->typekind);

cbSizeInstance and cbAligment value depends on alias type. As long as 
alias type is not set cbSizeInstance stores some strange values (-0x75 
is matching what one of native versions of dll stores there).


Both of these values should be set in SetTypeDescAlias function.




Re: PLEASE add bug links!

2013-08-17 Thread Rosanne DiMesio
On Sat, 17 Aug 2013 13:07:32 +0200
André Hentschel  wrote:

> 
> So this is just with no link in "Show Apps affected by this bug"?
> Beside it being outdated i think it's not exactly what Ken wants,
>
 
I think what Ken wants is for people to add the bug links when they create the 
bug so we don't periodically wind up with thousands of unlinked bugs that have 
to be cleaned up. I also think that's not going to happen as long as bug links 
can't be added from Bugzilla, when you're creating the report. Not everyone has 
an AppDB account or wants one, and they shouldn't be obligated to create one 
just to file a bug. http://bugs.winehq.org/show_bug.cgi?id=16284 (My guess is 
that's probably never going to be fixed because it involves changes to Bugzilla 
code.)


-- 
Rosanne DiMesio 




RFC: winedev guide multimedia chapter patch

2013-08-17 Thread Frédéric Delanoy
Hi guys,

I've been updating the wine multimedia paths of the wine dev guide,
but I'm not really familiar with that area of Wine, so could you
please have a look at the attached patch to check if it seems correct?
I checked the code a bit but I'm not sure how outdated the guide is.

For easier "testing", just clone
http://source.winehq.org/git/docs.git, apply the patch and run
./configure, then 'make winedev-guide.html' in the "en/" subdirectory.

Thanks,

Frédéric Delanoy
From 4f20de43d0803702d6364a5d2adbe37f7cad2a3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= 
Date: Wed, 7 Aug 2013 17:50:58 +0200
Subject: [docs] winedev: Update wine multimedia DLLs paths
Reply-To: wine-devel 

---
 en/winedev-multimedia.sgml | 137 +
 1 file changed, 77 insertions(+), 60 deletions(-)

diff --git a/en/winedev-multimedia.sgml b/en/winedev-multimedia.sgml
index a38d7a2..1225b14 100644
--- a/en/winedev-multimedia.sgml
+++ b/en/winedev-multimedia.sgml
@@ -7,12 +7,30 @@
 
 
 
-  The implementation can be found in the
-  dlls/winmm/ directory (and in many of its
-  subdirectories), but also in dlls/msacm/
-  (for the audio compression/decompression manager) and
-  dlls/msvideo/ (for the video
-  compression/decompression manager).
+  The implementation can be found in a number of directories:
+  
+
+  
+dlls/winmm/, dlls/mmsystem.dll16/ and dlls/msacm32.drv/
+  
+
+
+  
+dlls/msacm32/ and dlls/msacm.dll16/ (for the audio 
compression/decompression
+manager)
+  
+
+
+  
+dlls/msvfw32/ and dlls/msvideo.dll16/ (for the video
+compression/decompression manager).
+  
+
+  
 
 
 
@@ -21,8 +39,8 @@
   
The multimedia stuff is split into 3 layers. The low level (device
drivers), mid level (MCI commands) and high level abstraction layers.
-The low level layer has also some helper DLLs (like the MSACM/MSACM32
-and MSVIDEO/MSVFW32 pairs).
+The low level layer has also some helper DLLs (like the 
msacm32/msacm.dll16
+and msvfw32/msvideo.dll16 pairs).
   
 
   
@@ -163,10 +181,10 @@ Kernel space |Client applications
  |  |  v v v | |   v v  v v
  |  |   +---+---+-+-+
  |  |   | waveInXXX |   | mciXXX  | *playSound* |
- |  |   | waveOutXXX|   | | mmioXXX | WinMM.dll
+ |  |   | waveOutXXX|   | | mmioXXX | winmm.dll
  |  |   | midiInXXX |   | | timeXXX |   32-bit
  |  |   | midiOutXXX|   | | driverXXX   |
- |  |   | midiStreamXXX |   | | | 
MMSystem.dll
+ |  |   | midiStreamXXX |   | | | 
mmsystem.dll16
  |  |   | mixerXXX  |   | | |   16-bit
  |  |   | auxXXX+---+   +---+ mmThread| |
  |  |   | joyXXX| Call back | mmTask  | |
@@ -177,7 +195,7 @@ Kernel space |Client applications
 +-+  |  |   +-++--+
 |HW driver|<--->|*.drv|| mci*.drv |
 +-+  |  |   +--+   +---+
- |  ||  msacm.drv  || mciwave  |
+ |  || msacm32.drv || mciwave  |
  |  |+--+   +---+
  |  | | midimap.drv || mcimidi  |
  |  | +-++---+
@@ -238,7 +256,7 @@ Kernel space |Client applications
   
 
   
-   There are two specific low level drivers (msacm.drv for wave 
input/output,
+There are two specific low level drivers (msacm32.drv for wave 
input/output,
 midimap.drv for MIDI output only). These drivers (also present
 in Windows):

@@ -303,21 +321,21 @@ Kernel space |Client applications
   
 
   
-   Wave mapper (msacm.drv)
+Wave mapper (msacm32.drv, mmsystem.dll16)
 

  The Wave mapper device allows to load on-demand audio codecs
  in order to perform software conversion for the types the
  actual low level driver (hardware). Those codecs are
- provided through the standard ACM drivers in MSACM32 DLL.
+  provided through the standard ACM drivers in msacm32 or msacm.dll16 
DLL.

 

  Wave mapper driver implementation can be found in
- dlls/winmm/wavemap/ directory. This
- driver heavily relies on MSACM and MSACM32 DLLs which can be
- found in dlls/msacm and
-  dlls/msacm32. Those DLLs load ACM
+  dlls/

Re: PLEASE add bug links!

2013-08-17 Thread André Hentschel
Am 16.08.2013 23:02, schrieb Rosanne DiMesio:
> On Fri, 16 Aug 2013 20:51:19 +0100
> Ken Sharp  wrote:
> 
>>
>> I believe someone managed to run a script to find the unlinked bugs. I 
>> can't remember who it was now, sadly, and I don't know if it was 
>> server-side, which would obviously be quicker.
>>
>>
> Dan Kegel. http://kegel.com/wine/unlinked.html
> 

So this is just with no link in "Show Apps affected by this bug"?
Beside it being outdated i think it's not exactly what Ken wants,
we should rather have a script that goes through every App in AppDB
and searches for Bugs with the App name in the Summary.
That could be tricky, e.g. "StarCraft I" will rather find bugs for
"StarCraft II" than a search for "StarCraft".




Re: imm32/tests: Fix a trailing '\n' in an ok() call.

2013-08-17 Thread Qian Hong
> -ok(ic != NULL, "ImmLockIMC failed\n!");
> +ok(ic != NULL, "ImmLockIMC failed!\n");

Oh, good catch... Thanks!


-- 
Regards,
Qian Hong

-
http://www.winehq.org




Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-17 Thread Frédéric Delanoy
On Sat, Aug 17, 2013 at 5:57 AM, xulixin  wrote:
> Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other
> format?

Not sure, most people (at least non-Chinese) use firstname lastname
convention, but I guess you should use the same convention as other
Chinese-speaking committers.

Here's a list I extracted from AUTHORS file that *look* Chinese to me
(don't know if they're really Chinese, or Korean, or from another
Asian country):
Chae Jong Bin
Cheer Xiao
Chia-I Wu
Hwang YunSong (황윤성)
Jau-Horng Chen
Jay Yang
Qian Hong
Qingchuan Wang
Qingdoa Daoo
Shi Quan He
Wei-Lun Chao
Weisheng Li
Xiang Li
XueFeng Chang
Yong Chi
Yuxi Zhang
Zhangrong Huang
Zhan Jianyu

Hope this helps,

Frédéric Delanoy