Re: [4/6] kernel32: Make serial tests self-contained.
* On Thu, 15 Aug 2013, Dmitry Timoshkov wrote: > dlls/kernel32/tests/comm.c | 284 > ++--- > 1 file changed, 167 insertions(+), 117 deletions(-) ... > --- a/dlls/kernel32/tests/comm.c > +++ b/dlls/kernel32/tests/comm.c > @@ -1486,7 +1588,7 @@ static void test_WaitRing(HANDLE hcom) > success, err, evtmask, after-before, after1-before); > > ok(evtmask & EV_RING, "Failed to detect EV_RING: 0x%08x, expected > 0x%08x\n", > - evtmask, EV_RING); > + evtmask, EV_CTS); Is everything OK with the constants here? S.
Re: oledb32: Add IDataSourceLocator support (try 5)
On 8/21/2013 10:16, Alistair Leslie-Hughes wrote: Hi, Updated naming. You updated method names only, what's left : +typedef struct DataSourceImpl +HRESULT create_data_source(IUnknown *outer, void **obj) +static const IDataSourceLocatorVtbl DataSourceVtbl = Also you most likely don't need these: +#include "wine/unicode.h" +#include "wine/list.h" Changelog: oledb32: Add IDataSourceLocator support Best Regards Alistair Leslie-Hughes
Re: oledb32: Add IDataSourceLocator support (try 4)
On 8/21/2013 09:15, Alistair Leslie-Hughes wrote:
Hi,
Use helper functions for memory
Changelog:
oledb32: Add IDataSourceLocator support
Best Regards
Alistair Leslie-Hughes
It looks okay, but I suggest to fix a naming:
+typedef struct DataSourceImpl
+{
+IDataSourceLocator IDataSourceLocator_iface;
+LONG ref;
+
+} DataSourceImpl;
+static HRESULT WINAPI datasource_QueryInterface(IDataSourceLocator *iface,
REFIID riid, void **ppvoid)
etc.
IDataSource is another interface, and it's confusing to name locator
after it - dslocator_* naming used in CF is
short enough and descriptive to use it everywhere.
Re: Willing to join Wine
On Tue, Aug 20, 2013 at 3:13 AM, Priyank Bhatt wrote: > I want to work for Wine . I'm a third year undergraduate Student , I > have done my elimentary course on machine learning algorithm . I am > also familiar with C/C++ and some what of Python . > Please suggest what all do I need to learn or read so as to start > contributing to the open source community of mlpack. As an amateur and as > per your free slots what project form the idea's page should I work on ? If you want to work on Wine, the best place to start would be: http://wiki.winehq.org/Developers Though your email seems like a copy/paste from a GSoC application for mlpack...note that GSoC has already started, you'd have to wait until next year (and put more effort than a simple copy/pasted email). -- -Austin
Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.
On Tue, Aug 20, 2013 at 07:06:13PM +0200, Fabrice Bauzac wrote:
> +if (g_inmmdevices_count == 0) {
> +return MMSYSERR_BADDEVICEID;
> +}
Looks like the indentation is bad here.
Also please submit the patch to wine-patches. Patches aren't picked up
from wine-devel.
Thanks for the fix!
Andrew
Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.
Hello,
Indeed, WID_Open certainly suffers from the same problem.
Here is the patch for both.
>From 51cee06af9f5901ca7310aad1077d4b07472da1e Mon Sep 17 00:00:00 2001
From: Fabrice Bauzac
Date: Tue, 20 Aug 2013 05:37:53 +0200
Subject: winmm: fix WOD_Open() and WID_Open() WAVE_MAPPER no-device case.
WOD_Open() and WID_Open() now return MMSYSERR_BADDEVICEID in case
WAVE_MAPPER is requested and no device is present.
Fixes #34305.
---
dlls/winmm/waveform.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c
index 752e64d..bb91a22 100644
--- a/dlls/winmm/waveform.c
+++ b/dlls/winmm/waveform.c
@@ -1228,6 +1228,9 @@ static LRESULT WOD_Open(WINMM_OpenInfo *info)
WINMM_MMDevice *mmdevice;
if(WINMM_IsMapper(info->req_device)){
+if (g_outmmdevices_count == 0) {
+return MMSYSERR_BADDEVICEID;
+}
devices = g_out_mapper_devices;
mmdevice = read_map(g_out_map, 0);
lock = &g_devthread_lock;
@@ -1317,6 +1320,9 @@ static LRESULT WID_Open(WINMM_OpenInfo *info)
HRESULT hr;
if(WINMM_IsMapper(info->req_device)){
+if (g_inmmdevices_count == 0) {
+return MMSYSERR_BADDEVICEID;
+}
devices = g_in_mapper_devices;
mmdevice = read_map(g_in_map, 0);
lock = &g_devthread_lock;
--
1.8.1.2
Thanks!
Best regards
Fabrice
Re: [PATCH 2/4] oleaut32: Implement ICreateTypeInfo::SetTypeDescAlias
On 08/20/13 16:57, Andrew Eikum wrote:
@@ -10530,8 +10541,28 @@ static HRESULT WINAPI
ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac
+This->cbSizeInstance = VARIANT_DataSize(This->tdescAlias->vt,
This->pTypeLib->ptr_size);
+if(!This->cbSizeInstance){
+FIXME("Wrong size for variant type! 0x%x\n", This->tdescAlias->vt);
+This->cbSizeInstance = 4;
+}
+
+This->cbAlignment = 4;
The This->cbAlignment should be also depending on alias type (e.g. it's
1 for VT_I1).
Re: Sort the AUTHORS file by their last names.
Non-Dutch names like Van Buggenhaut can be placed under V instead. -- Tae Wong
Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.
On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote: > Hello, > > This patch intends to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34305 > > The bug: basically, when there is no sound device and the user tries > to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read_map() > with device index 0 without first checking whether the number of > devices is greater than 0. > Looks good to me, thanks. I tested on Windows 7, and the error code is correct. By the way, the waveIn path (WID_Open) has the same bug. Feel free to fix that, too, if you want. Or I'll submit a patch myself later. Andrew
Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)
On 20 August 2013 13:16, Stefan Dösinger wrote: > Am 2013-08-20 13:12, schrieb Henri Verbeet: >> Somewhat related, I don't think there's really a reason to have >> both "allocatedMemory" and "heap_memory" anymore. It should >> probably just be called "sysmem". That's a cleanup that doesn't >> necessarily belong in this patch though. > Surfaces can still have DIBs. We're also assigning memory returned by > glMapBuffer[Range] to resource.allocatedMemory, > Yeah, but you should be able to tell what kind of memory "sysmem" is from the resource flags, you don't need the extra pointer for that.
Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-20 13:12, schrieb Henri Verbeet: > I think this should either be called > wined3d_resource_allocate_sysmem() and live in resource.c, or > accept any np2 alignment and be called something along the lines of > wined3d_memalign(). The former probably makes the most sense at > this point. Ok. > Somewhat related, I don't think there's really a reason to have > both "allocatedMemory" and "heap_memory" anymore. It should > probably just be called "sysmem". That's a cleanup that doesn't > necessarily belong in this patch though. Surfaces can still have DIBs. We're also assigning memory returned by glMapBuffer[Range] to resource.allocatedMemory, although that should probably be changed. The main problem with the latter is that buffers can be mapped multiple times. Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSE1AZAAoJEN0/YqbEcdMwgVYP/irliNpSGEvrH/kIwQHrVD7U Xq0umCSvvZm1K2V1FysG/27L7FB1GNQaD/mMH9mTIKVUUKrC+CciTnNqi42ki1I9 PtdfqRemQ7e/+GoAyfNwP7coIuRKbBH5ZvTVPRvy0rNHW9IEUwr7mWOBbE2NZgeJ eBoHIjwoKCw7oeWV8CYbjhINeJlYoOAva2pAFE/d0D629mielIRdKIc4oc0fa+oD f9LPKOe4NTPP/3Xu87PVg5QfnlpZu78h+WmTNJRwCi8GdzXKL6zTPeKFGOn9/+5T 6i/i7oYxw84R1R13Vv2BxgHoqkC93CUofDKGPGViGG/cxr5q22+VnHScWp2YrEGN 7Fjey+6TIeTd+h4urxNhNdfDerigIKMTTl4yBVtL9VNagxv2E1ow2m08NeaUF+9J /5MHq5cWjRi+34V2mD2N1sU6LcwCCVPTq/xL7lYLgHWYL7LTAkQau113nzgrwrT9 EVieN5od56oyCdzmQFqX3z7IBSZ9l/kirMjcGQeFnD4eaF1v2uE+/73X955HgbqW 3pjqXEEPsPLXllh5hnm86Bt5XbbSrY42Gx4o5X4uWn/OSt6oZctoh3mXTxgW7eIQ qBcFR4i2WIvk++ZM6cSNkKHbUNXR1DEb5YUo2NtiU4y3WTDg6qA3kKC+Wf1vQS69 aFF9hb7e9dr4BCCnt66k =ecTB -END PGP SIGNATURE-
Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)
On 20 August 2013 12:07, Stefan Dösinger wrote:
> +void *wined3d_alloc_resource_mem(SIZE_T size)
> +{
> +void **p;
> +SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p);
> +void *mem;
> +
> +if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align)))
> +return NULL;
> +
> +p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1;
> +*p = mem;
> +
> +return ++p;
> +}
I think this should either be called
wined3d_resource_allocate_sysmem() and live in resource.c, or accept
any np2 alignment and be called something along the lines of
wined3d_memalign(). The former probably makes the most sense at this
point.
Somewhat related, I don't think there's really a reason to have both
"allocatedMemory" and "heap_memory" anymore. It should probably just
be called "sysmem". That's a cleanup that doesn't necessarily belong
in this patch though.
Willing to join Wine
I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all do I need to learn or read so as to start contributing to the open source community of mlpack. As an amateur and as per your free slots what project form the idea's page should I work on ?
Re: kernel32: Fix required buffer length for locale values from registry
Nikolay Sivov writes: > http://bugs.winehq.org/show_bug.cgi?id=32169 > > Locale info to override is stored as REG_SZ and supposed to be > null-terminated, They are supposed to, but it's not guaranteed. The code should be able to cope with non-terminated strings. -- Alexandre Julliard julli...@winehq.org
Re: oledb32: Implement IErrorRecord AddErrorRecord
On 20/08/2013 7:29 PM, Nikolay Sivov wrote: On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. I'll update it to be a deep copy. Alistair
Re: oledb32: Implement IErrorRecord AddErrorRecord
On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: Hi, Yes we do just take the pointer (pErrorInfo) passed in. MSDN states that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. Changelog: oledb32: Implement IErrorRecord AddErrorRecord Best Regards Alistair Leslie-Hughes
Re: riched20: Use \ulnone instead of \ul0 for no underline.
On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: > Testing on Windows (by saving rtf documents with wordpad and viewing > them with notepad) shows that it uses \ulnone instead of \ul0 to end > underline. Wine and Windows are both able to read either one. I think these are symonyms and indeed Windows seems to use \ulnone, so this looks good to me. Huw.
