Re: rpcss: Convert to a service

2013-10-02 Thread Andrew Cook
Ignore this, for some reason this randomly forks a huge number of rpcss
instances, and decided to not do so while i was testing it

On 03/10/13 14:00, Andrew Cook wrote:
> ---
>  dlls/rpcrt4/rpc_epmap.c | 40 ---
>  programs/rpcss/Makefile.in  |  2 +-
>  programs/rpcss/rpcss_main.c | 97
> +++--
>  tools/wine.inf.in   | 11 +
>  4 files changed, 104 insertions(+), 46 deletions(-)
> 
> 





Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.

2013-10-02 Thread Dmitry Timoshkov
Dmitry Timoshkov  wrote:

> diff --git a/server/file.c b/server/file.c
> index 2ecf97c..94d3060 100644
> --- a/server/file.c
> +++ b/server/file.c
> @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access )
>  
>  access = generic_file_map_access( access );
>  if (access & FILE_READ_DATA)  mode |= 4;
> -if (access & FILE_WRITE_DATA) mode |= 2;
> +if (access & (FILE_WRITE_DATA|FILE_APPEND_DATA)) mode |= 2;
>  if (access & FILE_EXECUTE)mode |= 1;
>  return mode;
>  }

I don't think that this patch should be in 'superseded' state.

-- 
Dmitry.




Looking for an icon for the Mac driver: generic program running under Wine

2013-10-02 Thread Ken Thomases
Hi,

I have a need for a new icon in Wine and I'm hoping somebody with some 
graphics-design skills might be able to create it.

The Mac driver attempts to extract an icon from the executable to use for the 
Dock icon of its process.  This is also the icon that appears in the 
Command-Tab application switcher.  This often works, but not always.  When it 
doesn't, the Dock just uses the generic "Unix executable" icon from Mac OS X.  
You can see that here: .  It's not very nice.

I would prefer to have a Wine-specific generic program icon.


Any graphic designer care to take on the task of creating such an icon?


I'm told Wine has been using the Tango icons as the template for its.  Tango 
provides application-x-executable.svg at 
 that might be 
suitable.  That could be badged with the Wine glass logo to produce an icon for 
a program running under Wine.

On the other hand, if this icon were to be used only by the Mac driver, it 
might be more appropriate to use a Mac-themed icon.

Some time back, Jeremiah posted an archive of icons.  
  That 
included one which had a miniature Mac window badged with the Wine glass logo.  
I'm not sure of the copyright/licensing situation with that icon.  It's 
bitmap-only, not vector, but that might be fine for a Mac-only icon.  It does 
have some issues with rough edges around the window, rather than a smooth 
alpha-blended edge.

Although Mac app icons can go up to 1024x1024 pixels (512x512 "points" at 2x 
resolution for Retina displays), this icon would only appear in the Dock and 
the application switcher.  So, it needn't be larger than 256x256 pixels 
(128x128@2x).

Thanks,
Ken





Re: [5/5] ws2_32: Always return the source address from WSAAccept.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2610

Your paranoid android.


=== wxppro (32 bit sock) ===
sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0

=== w2008s64 (32 bit sock) ===
sock.c:519: Test failed: oob_server (618): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 74AA9799

=== w2008s64 (64 bit sock) ===
sock.c:519: Test failed: oob_server (600): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 




Re: [4/5] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2609

Your paranoid android.


=== wxppro (32 bit sock) ===
sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0

=== w2008s64 (32 bit sock) ===
sock.c:519: Test failed: oob_server (520): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 74AA9799

=== w2008s64 (64 bit sock) ===
sock.c:519: Test failed: oob_server (78c): unexpectedly at the OOB mark: 0




Re: [3/5] ws2_32: Add some tests for getpeername.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2608

Your paranoid android.


=== wxppro (32 bit sock) ===
sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 71AB8D62

=== w2008s64 (32 bit sock) ===
sock.c:519: Test failed: oob_server (320): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 74AA9799

=== w2008s64 (64 bit sock) ===
sock.c:509: Test failed: oob_server (808): unexpectedly at the OOB mark: 0
sock.c:519: Test failed: oob_server (808): unexpectedly at the OOB mark: 0




Re: [2/5] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2607

Your paranoid android.


=== wxppro (32 bit sock) ===
sock.c:519: Test failed: oob_server (108): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 71AB8D62

=== w2008s64 (32 bit sock) ===
sock.c:519: Test failed: oob_server (7c4): unexpectedly at the OOB mark: 0
sock: unhandled exception c005 at 74AA9799

=== w2008s64 (64 bit sock) ===
sock.c:519: Test failed: oob_server (470): unexpectedly at the OOB mark: 0




Re: [1/2] gdi32: Fix the B spacing value of empty glyph. (try 3)

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2605

Your paranoid android.


=== wvista (32 bit font) ===
The test timed out

=== w2008s64 (32 bit font) ===
Failure running script in VM: network read timed out




Re: [2/2] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Alexandre Julliard
Akihiro Sagawa  writes:

> ---
>  dlls/gdi32/freetype.c   |   12 
>  dlls/gdi32/tests/font.c |5 +
>  2 files changed, 13 insertions(+), 4 deletions(-)

It looks like something is not quite right, this is causing strange
spacing, for instance in the About dialog.
 
-- 
Alexandre Julliard
julli...@winehq.org




Re: I'm not sure why it was rejected

2013-10-02 Thread Vincent Povirk
> I guess if you SetLastError to not implemented you cannot return S_OK too

It doesn't make sense to use SetLastError at all for functions
returning HRESULT.




Re: [PATCH 2/7] qedit/tests: Use the W version of FindResource().

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2455

Your paranoid android.


=== w2008s64 (32 bit mediadet) ===
mediadet.c:149: Test failed: CoCreateInstance failed: 80040154
mediadet: unhandled exception c005 at 0040184A

=== w2008s64 (64 bit mediadet) ===
mediadet.c:149: Test failed: CoCreateInstance failed: 80040154
mediadet: unhandled exception c005 at 004017A3




Re: [PATCH 4/7] msvcr90/tests: Use the W form of CreateEvent().

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2457

Your paranoid android.


=== wxppro (32 bit msvcr90) ===
No test summary line found




Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote:
> On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa  wrote:
> > I cannnot make sure my patch 99266 was rejected.
> 
> I can't really tell why it was rejected but I can tell there are mixed
> space/tabs in the SetLastError lines.
> 
> I guess if you SetLastError to not implemented you cannot return S_OK too
> 
> Try comparing your patch with other patches that added new dlls. It
> looks like you're missing the changes in configure and Makefile.in.
> http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=commit&s=new+dll

no, he is not as they are autogenerated.

Last open issue was the incorrect licenses.

Ciao, Marcus




Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa  wrote:
> I cannnot make sure my patch 99266 was rejected.

I can't really tell why it was rejected but I can tell there are mixed
space/tabs in the SetLastError lines.

I guess if you SetLastError to not implemented you cannot return S_OK too

Try comparing your patch with other patches that added new dlls. It
looks like you're missing the changes in configure and Makefile.in.
http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=commit&s=new+dll

Regards,
Bruno




I'm not sure why it was rejected

2013-10-02 Thread Akira Nakagawa

  
  
I cannnot make sure my patch

99266 was
rejected.
  




Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2432

Your paranoid android.


=== build (build) ===
Patch failed to apply




Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2433

Your paranoid android.


=== build (build) ===
Patch failed to apply




Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2430

Your paranoid android.


=== build (build) ===
Patch failed to apply




Re: Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2434

Your paranoid android.


=== wxppro (32 bit comm) ===
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
No test summary line found
Failure running script in VM: network read timed out

=== w2008s64 (32 bit comm) ===
comm.c:1670: test_AbortWaitCts timeout 500 handle 00C4
comm.c:1637:  Changing CommMask on the fly for handle 00C4 after timeout 500
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
No test summary line found
Failure running script in VM: network read timed out

=== w7pro64 (32 bit comm) ===
comm.c:1670: test_AbortWaitCts timeout 500 handle 0130
comm.c:1637:  Changing CommMask on the fly for handle 0130 after timeout 500
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1094: Test failed: WriteFile failed with a timeout
comm.c:1096: Test failed: GetOverlappedResult reported error 996
comm.c:1097: Test failed: expected 64000, written 0
Timeout

=== w2008s64 (64 bit comm) ===
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
Timeout

=== w7pro64 (64 bit comm) ===
comm.c:887: WaitCommEvent for EV_TXEMPTY took 0 ms (timeout 1000)
comm.c:1670: test_AbortWaitCts timeout 500 handle 00CC
comm.c:1637:  Changing CommMask on the fly for handle 00CC after 
timeout 500
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:1064: Test failed: WaitCommEvent failed with a timeout
comm.c:1075: recovering after WAIT_TIMEOUT...
comm.c:1086: Test failed: WaitCommEvent error 0
comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
Timeout




Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2431

Your paranoid android.


=== build (build) ===
Patch failed to apply




Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2429

Your paranoid android.


=== build (build) ===
Patch failed to apply




Re: [5/5] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Marvin
Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2426

Your paranoid android.


=== wvista (32 bit font) ===
The test timed out

=== w2008s64 (32 bit font) ===
Failure running script in VM: network read timed out

=== w2008s64 (64 bit font) ===
Failure running script in VM: network read timed out




Re: kernel32: Add tests for job objects (try 3)

2013-10-02 Thread Nikolay Sivov

On 10/2/2013 12:58, Andrew Cook wrote:

+if(!pCreateJobObjectW) {
+win_skip("No job object support\n");
+return;
+}
Once you checked that I suppose you don't need to check for 
pIsProcessInJob being null, or it still could happen?



+if (option && strcmp(option, "wait") == 0) {
+/* for job object tests */
+Sleep(3000);
+return;
+}

Is it really necessary?




Re: winemac: Reapply display modes when switching back to app after "escaping" with Command-Tab.

2013-10-02 Thread Ken Thomases
On Oct 1, 2013, at 11:24 PM, Ken Thomases wrote:

> May fix bug .

Should fix bug , too.

-Ken