Clang Static analysis

2013-10-13 Thread C.W. Betts 
I have been doing a Clang static analysis of Wine on OS X using the one 
provided at http://clang-analyzer.llvm.org and storing the results on my 
PogoPlug drive. If someone wants to see the results, please tell me and I'll 
set up your e-mail. You will need a free PogoPlug account to view them. While 
the contents are zipped, they expand to about 1.2 GB. They are displayed as 
basic HTML pages, so you don't need anything special other than a web browser 
to see the results.

Or you could click on this link for the analysis of 1.7.4: 
http://ppl.ug/ND-7PZ3cSzM/

Re: MSYS touch.exe timestamp resolution issue on Wine-1.6

2013-10-13 Thread Peter Rosin 
On 2013-10-12 23:28, Alan W. Irwin wrote:
 Under MSYS bash.exe if I use the touch command I only get 1-second
 resolution when reading the results.
 
 bash.exe-3.1$ touch touch1.test touch2.test
 bash.exe-3.1$ ls --full-time touch*.test
 -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.0 -0700 touch1.test
 -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.0 -0700 touch2.test
 
 Would somebody be willing to make the above test for MSYS on
 the Microsoft version of Windows (which I don't have access to) to see
 if time stamps  are being read with 1-second resolution as above. That test
 should help distinguish whether this is a Wine issue or else an MSYS
 issue.

I tested this on Windows 7, with MSYS 1.0.18, and I get the exact same
experience. ls --full-time has a one second resolution (on NTFS, I expect
a two second resolution on FAT, at least for some FAT variations).

 I have also done some tests with the MSYS find.exe and make.exe
 commands, and in all cases touch2.test is not newer than touch1.text.
 This can be an important issue for the make command where one-second
 time resolution can potentially screw up file dependencies.
 
 If I use the equivalent Linux ls (and find and make) commands to read the
 time stamps on the above files, then touch2.test is newer than touch1.text,
 e.g.,

Same here if I use an equivalent Cygwin ls, i.e. the actual time stamps are
more fine grained than MSYS is capable of detecting.

 wine@raven ls --full-time touch*.test
 -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.39100 -0700 touch1.test
 -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.40800 -0700 touch2.test
 
 So I think this implies the MSYS touch.exe command is writing
 high-resolution (i.e., millisecond) time stamps, and it is only
 reading that high-resolution time stamp that seems to be an
 issue for MSYS on Wine.

Indeed.

Since Cygwin has a different view, the situation should improve with MSYS 2.

Cheers,
Peter

Re: ntdll: Support pinning module refcount with LdrAddRefDll()

2013-10-13 Thread Dmitry Timoshkov 
Nikolay Sivov nsi...@codeweavers.com wrote:

 +FreeLibrary(mod);

Please add the tests for FreeLibrary return value.

-- 
Dmitry.

Re: ntdll: Support pinning module refcount with LdrAddRefDll()

2013-10-13 Thread Nikolay Sivov 

On 10/14/2013 05:21, Dmitry Timoshkov wrote:

Nikolay Sivov nsi...@codeweavers.com wrote:


+FreeLibrary(mod);

Please add the tests for FreeLibrary return value.


Makes sense, thanks.