Re: gdiplus: Create a full BITMAPINFO to prevent clobbering memory with palette data.
On 05/03/10 02:35, Dan Kegel wrote: See also http://bugs.winehq.org/show_bug.cgi?id=21613 Thanks, I hadn't looked in bugzilla for it, only looked at it as winetest started failing on most wine installs. Also just noticed that my log entry was back to front and it was of course crashing due to reading invalid memory, and not writing. Alasdair
Re: CPPCheck Dec 29
On 30/12/09 03:55, chris ahrendt wrote:
I just ran CPP check this evening and got the following :
rpcrt4/rpc_transport.c 490 (error) Uninitialized variable smb_floor
761 (error) Uninitialized variable pipe_floor
885 (error) Uninitialized variable tcp_floor
If you look at the code :
static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data,
const char *networkaddr,
const char *endpoint)
{
twr_empty_floor_t *smb_floor;
twr_empty_floor_t *nb_floor;
size_t size;
size_t networkaddr_size;
size_t endpoint_size;
TRACE((%p, %s, %s)\n, tower_data, networkaddr, endpoint);
networkaddr_size = networkaddr ? strlen(networkaddr) + 1 : 1;
endpoint_size = endpoint ? strlen(endpoint) + 1 : 1;
size = sizeof(*smb_floor) + endpoint_size + sizeof(*nb_floor) +
networkaddr_size;
if (!tower_data)
return size;
It is correct in that these three are not initialised and could point to
anything on the local stack.
Additionally if you look above you can get potentially a bogus return..
Additionally for tcp_floor:
static size_t rpcrt4_ip_tcp_get_top_of_tower(unsigned char *tower_data,
const char *networkaddr,
unsigned char tcp_protid,
const char *endpoint)
{
twr_tcp_floor_t *tcp_floor;
twr_ipv4_floor_t *ipv4_floor;
struct addrinfo *ai;
struct addrinfo hints;
int ret;
size_t size = sizeof(*tcp_floor) + sizeof(*ipv4_floor);
TRACE((%p, %s, %s)\n, tower_data, networkaddr, endpoint);
if (!tower_data)
return size;
Same problem here as well
Chris
Looks like a CPPCheck bug, sizeof is a unary operator and not a
function, those variables never get dereferenced. The ()s in those
expressions are actually unneeded as sizeof only needs them for type
names and not variables.
Alasdair
Re: Unable to cleanly install cups-devel.i686 on a Fedora 12 x86_64 machine
On 10/12/09 18:46, Paul Chitescu wrote: On Thursday 10 December 2009 08:37:22 pm Alex Villacís Lasso wrote: I have just updated my setup to Fedora 12 on 64 bits, and I want to compile Wine for this setup. I followed the instructions at: http://wiki.winehq.org/WineOn64bit on the section for Fedora 12. However, I have the following error when trying to install the packages as directed by the wiki: Error en la verificación de la transacción: file /usr/bin/cups-config from install of cups-devel-1:1.4.2-7.fc12.i686 conflicts with file from package cups-devel-1:1.4.2-7.fc12.x86_64 Resumen de errores - What I understand from this is that /usr/bin/cups-config is provided by both packages, and cannot be marked as shared by both packages. I want to have both 32 and 64-bit support for compiling programs that use CUPS. Does this problem have a clean workaround? Or should I complain instead to the Fedora packagers? Hi! Unfortunately in RPM based distros that use side-by-side multiarch libraries (as opposed to chroot) it's not possible to have multiple architecture devel version of most (if not all) packages. Not only config programs are clashing but include files too. Lots of the multiarch devel packages live quite happly side by side. Looks like this used to work but got broken with F12 see https://bugzilla.redhat.com/show_bug.cgi?id=540620. Alasdair
Re: Compiling a particular version of Wine
On 10/10/09 22:11, Danila Sentiabov wrote: Hi, everyone. A n00b problem here :-) I can't figure out how to compile an old version of Wine with git. One could always get the latest version with git fetch git rebase origin, but now I need 1.1.28 for testing purposes. Already tried some lame things and stared at manpages for about half an hour with no success :-) Could someone please help me in this matter? -- Best regards, Danila Sentiabov aka dsent This is what I would do. [...@hal wine-git]$ git checkout -b my28 wine-1.1.28 Switched to a new branch 'my28' [...@hal wine-git]$ git describe wine-1.1.28 [...@hal wine-git]$ cat VERSION Wine version 1.1.28 The when you are finished with it. [...@hal wine-git]$ git checkout master Switched to branch 'master' [...@hal wine-git]$ git describe wine-1.1.31 [...@hal wine-git]$ git branch -d my28 Deleted branch my28 (was f6f458a). Alasdair
Re: Another machine passing tests
Michael Stefaniuc wrote: Hi Alasdair, Alasdair Sinclair wrote: Would you mind sharing what hardware that's on? You're using Fedora 10, right? Sure, Its a Dell XPS1530 laptop (core 2 duo T8100), 4GB Ram, GeForce 8600M GT. Running fedora 10 x86-64 (recently upgraded from 9) all latest patches applied, desktop is Gnome. do you have SELinux enabled? I figure no as the default F10 SELinux breaks Wine. Hmm ... you might have inherited the sane boolean setting from F9 and thus aren't affected. Yes SELinux is enabled. I eventually managed to get it configured to allow wine to run. I think with something like the following. $ setsebool -P allow_execmod 1 $ chcon -t execmem_exec_t /home/ams/wine/bin/wine-preloader Which is a bit hackish, but seems to work, and it's possible there's settings I've forgotten about when I installed F9. bye michael Alasdair
Re: Another machine passing tests
Austin English wrote: On Mon, Dec 15, 2008 at 6:38 PM, Alasdair Sinclair alasda...@dsl.pipex.com wrote: Austin English wrote: On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg zg...@bluesata.com wrote: All, It seems we have another machine which passes all tests on Wine http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ Huzzah! --Zach Who's machine is that, Aric's? Hi Thats my machine. It seems to fluctuate between one and two errors, I guess this time I got lucky this time. Alasdair Would you mind sharing what hardware that's on? You're using Fedora 10, right? Sure, Its a Dell XPS1530 laptop (core 2 duo T8100), 4GB Ram, GeForce 8600M GT. Running fedora 10 x86-64 (recently upgraded from 9) all latest patches applied, desktop is Gnome. It's also running the proprietary Nvidia drivers packaged by rpmfusion. Alasdair
Re: Another machine passing tests
Austin English wrote: On Mon, Dec 15, 2008 at 2:04 PM, Zachary Goldberg zg...@bluesata.com wrote: All, It seems we have another machine which passes all tests on Wine http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ Huzzah! --Zach Who's machine is that, Aric's? Hi Thats my machine. It seems to fluctuate between one and two errors, I guess this time I got lucky this time. Alasdair
Re: Which graphics cards really pass the conformance tests, again?
Dan Kegel wrote: When I put together the current patchwatcher box, I made sure to get a graphics card based on a recent nvidia chip. http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx seemed recent enough, but I still get buttloads of conformance test failures in d3d and ddraw. So, which graphics cards exactly don't get any d3d or ddraw conformance test failures? Are there any? If there are, I want to get one on the patchwatcher box so I can cut back the huge blacklist a bit. Thanks, Dan My laptops (XPS 1530) nvidia 8600M GT passes all the tests with a few skips. See http://test.winehq.org/data/36d01401dc734e049b28748d3d8418c291c7b0d1/wine_xp_as-fed9-lap/report.html Regards Alasdair
Re: Alexandre Julliard : server: Class and global atoms should not be local to a window station.
Hi
This patch breaks firefox-1.5 on fedora core 4 (x86-64).
err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59}
not registered
err:ole:CoGetClassObject no class object
{4955dd33-b159-11d0-8fcf-00aa006bcc59} could be created for for context 0x1
fixme:ole:CoCreateInstance no classfactory created for CLSID
{4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154
wine: Unhandled page fault on write access to 0x001a at address
0x6033e436 (thread 0009), starting debugger...
WineDbg starting on pid 0x8
Unhandled exception: page fault on write access to 0x001a in 32-bit
code (0x6033e436).
fixme:dbghelp:sffip_cb NIY on
'c:\builds\tinderbox\Fx-Mozilla1.8\WINNT_5.2_Depend\mozilla\xpcom\build\xpcom_core.pdb'
Register dump:
CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:0063
EIP:6033e436 ESP:7fa0f790 EBP:7fa0f7c0 EFLAGS:00010246( - 00
-RIZP1)
EAX:0001 EBX:7f5e866c ECX: EDX:7fa0f704
ESI: EDI:7fa0fd18
Stack dump:
0x7fa0f790: 0001002a 7f5c580a 0001002a 0113
0x7fa0f7a0: 139c 7fca1cf9 7f5e866c
0x7fa0f7b0: 7fa0f7c0 7f5e866c 0001002a 7fa0fd18
0x7fa0f7c0: 7fa0f800 7f5c6490 6033e417 0001002a
0x7fa0f7d0: 0113 139c 7e270598
0x7fa0f7e0: 7fa0f9ac 7fa0f824 7f595f80 0113
0200: sel=1007 base=7fe6a000 limit=1fff 32-bit rw-
Backtrace:
=1 0x6033e436 in xpcom_core (+0x2e436) (0x6033e436)
2 0x7f5c6490 WINPROC_CallWndProc+0x70(hwnd=register not in topmost
frame, wParam=0x0, lParam=0x139c) [/ppp/wine/wine-git/dlls
/user/winproc.c:418] in user32 (0x7f5c6490)
3 0x7f5cd2de CallWindowProcW+0x12e(func=0x7f624c34, hwnd=0x1002a,
msg=0x113, wParam=0x0, lParam=0x139c) [/ppp/wine/wine-git/dll
s/user/winproc.c:3095] in user32 (0x7f5cd2de)
4 0x7f5926ff DispatchMessageW+0xaf(msg=0x7fa0fd18)
[/ppp/wine/wine-git/dlls/user/message.c:3001] in user32 (0x7f5926ff)
fixme:dbghelp:sffip_cb NIY on
'c:\builds\tinderbox\Fx-Mozilla1.8\WINNT_5.2_Depend\mozilla\browser\app\firefox.pdb'
5 0x0051866b in firefox (+0x11866b) (0x0051866b)
6 0x007fd417 in firefox (+0x3fd417) (0x007fd417)
7 0x00401012 in firefox (+0x1012) (0x00401012)
8 0x7fc8a00c start_process+0xec(arg=0x0)
[/ppp/wine/wine-git/dlls/kernel/process.c:845] in kernel32 (0x7fc8a00c)
9 0xf7fcc4f7 wine_switch_to_stack+0x17 in libwine.so.1 (0xf7fcc4f7)
Alexandre Julliard wrote:
Module: wine
Branch: refs/heads/master
Commit: 9873494ced8405113381266b4d99c2a9f3002cb1
URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=9873494ced8405113381266b4d99c2a9f3002cb1
Author: Alexandre Julliard [EMAIL PROTECTED]
Date: Wed Mar 22 22:13:40 2006 +0100
server: Class and global atoms should not be local to a window station.
---
dlls/user/tests/winstation.c | 43 +-
server/atom.c| 27 --
server/class.c | 24 ---
3 files changed, 62 insertions(+), 32 deletions(-)
diff --git a/dlls/user/tests/winstation.c b/dlls/user/tests/winstation.c
index 4bc1941..a595718 100644
--- a/dlls/user/tests/winstation.c
+++ b/dlls/user/tests/winstation.c
