Re: Add mousewheel support to riched20
Joris Huizer wrote: Why not like +SystemParametersInfoW(SPI_GETWHEELSCROLLLINES,0, pulScrollLines, 0); +gcWheelDelta = GET_WHEEL_DELTA_WPARAM(wParam); +if (gcWheelDelta = WHEEL_DELTA pulScrollLines) + nPos += pulScrollLines * (-gcWheelDelta / WHEEL_DELTA) * 8; just seems simpler; It doesn't work quite that way. GET_WHEEL_DELTA_WPARAM() can return both positive and negative numbers so the abs() is still essential. It's a question of taste whether to put it on to: gcWheelDelta -= GET_WHEEL_DELTA_WPARAM(wParam); or on to: nPos += pulScrollLines * (-gcWheelDelta / WHEEL_DELTA) * 8; Me, I like the first one but I don't really care one way or the other. - Hannu Valtonen [EMAIL PROTECTED]
Regression in comctl32 Treeview (breaks Filezilla, mIRC)
Hannu Valtonen wrote: Hi, The following patch: ChangeSet ID:15259 CVSROOT:/opt/cvs-commit Module name:wine Changes by:[EMAIL PROTECTED]2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard [EMAIL PROTECTED] Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the New site button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?download and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?download I would appreciate it if some comctl32 messaging guru could step up and take look at this problem Heh, my friend complained about his mIRC not working either. The same patch breaks mIRC as well. i.e. if you connect then as soon as you're about to join a channel the program freezes completely. Any comctl32 guru want to take a look? - Hannu Valtonen [EMAIL PROTECTED]
Regression in comctl32 Treeview (breaks Filezilla)
Hi, The following patch: ChangeSet ID: 15259 CVSROOT:/opt/cvs-commit Module name:wine Changes by: [EMAIL PROTECTED] 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard [EMAIL PROTECTED] Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the New site button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?download and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?download I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen [EMAIL PROTECTED] +358408030179
Re: DINPUT device unacquire (mouse) fix
Andreas Mohr wrote: But don't you think keyboard and joystick might need the same code?? (keyboard has it as well, but with completely different code -- mess) This could probably be cleaned up. I have a patch semi-ready which does the same for keyboard/joystick using the existing scheme.. but I was wondering whether or not we should clean up this mess? Any opinions? Should I a) send the fixes for keyboard/joystick using the existing scheme or b) should we start reusing/cleaning the code? If the answer turns out to be b) and you/someone else doesn't want to take the job I'm going to need a bit of handholding as I'm rather new to Wine development. - Hannu Valtonen [EMAIL PROTECTED]
