Re: DDRAW: Fix reference counting

2005-09-19 Thread Jakov af Wallby
On Mon, Sep 19, 2005 at 09:27:05AM +0200, Stefan D?singer wrote:
> Hi,
> > Why do you increase the refcount by 2? Since you add and release them in
> > the same functions, it is not really necessary and just adds complexity
> > to the code.
> Well, Windows does so for some reason, and after what I've seen with Empire 
> Earth, I suspect that there are some apps out there which depend on things 
> like this. It's unlikely, but I would not be surprised if that happens.

In that case, it would be really beneficial with a unit test.
Both as documentation and to see what Windows does.

-- 
regards,
Jakob


It's is not, it isn't ain't, and it's it's, not its, if you mean it
is.  If you don't, it's its.  Then too, it's hers.  It isn't her's.  It
isn't our's either.  It's ours, and likewise yours and theirs.
-- Oxford University Press, Edpress News





Re: Make running tests on a visible desktop a mandatory requirement

2005-03-08 Thread Jakov af Wallby
On Wed, Mar 09, 2005 at 12:03:01AM +0800, Dmitry Timoshkov wrote:
> Hello,
> 
> it appears that new test for a visible desktop works fine, time to make
> running tests on a visible desktop a mandatory requirement.


Will this not mean no winrash tests any more, only manual ones?

I haven't got around to reprogram winrash yet, you know...



-- 
regards,
Jakob


It's is not, it isn't ain't, and it's it's, not its, if you mean it
is.  If you don't, it's its.  Then too, it's hers.  It isn't her's.  It
isn't our's either.  It's ours, and likewise yours and theirs.
-- Oxford University Press, Edpress News