Wine gecko: javascript in the frame
Hi! Javascript which is defined in the frame doesn't work. There is a test in attachement. Run index.html in 'wine iexplore' Correct events for this test (checked up in IE and Firefox): 1. "call f_right script" message 2. "call onLoad" message during loading 3. "call myOnClick" message after click to link Wine gecko ignores all these events. Do you have any advice? Thanks. -- Best regards, Konstantin Kondratyuk. text f_right
Re: gdi32: Correct order of matrix elements in World transform
Oops, this patch is not full.
I think, there is code with bad index also:
/* Extra transformation specified by caller */
if (lpmat && !is_identity_MAT2(lpmat))
{
FT_Matrix extraMat;
extraMat.xx = FT_FixedFromFIXED(lpmat->eM11);
extraMat.xy = FT_FixedFromFIXED(lpmat->eM21); // <<<<<<<
extraMat.yx = FT_FixedFromFIXED(lpmat->eM12); // <<<<<<<
extraMat.yy = FT_FixedFromFIXED(lpmat->eM22);
pFT_Matrix_Multiply(&extraMat, &transMat);
pFT_Matrix_Multiply(&extraMat, &transMatUnrotated);
needsTransform = TRUE;
}
What can I do? Send second fix? Or send "full" patch for both transformations?
--
Best regards,
Konstantin Kondratyuk.
Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item
Hi, Jacek!
On Friday 19 December 2008 18:04:45 Jacek Caban wrote:
> You're duplicating the code that handles VT_I4 case. Please avoid it.
Do you think, this code will be better? And can I truncate "VT_I4" from trace?
if(V_VT(&name) == VT_I4 || V_VT(&name) == VT_INT) {
int i;
if (V_VT(&name) == VT_I4) {
i = V_I4(&name);
TRACE("name is VT_I4: %d\n", i);
}
else {
i = V_INT(&name);
TRACE("name is VT_INT: %d\n", i);
}
if(i < 0)
return E_INVALIDARG;
if(i >= This->len)
return S_OK;
*pdisp = (IDispatch*)This->elems[i];
IDispatch_AddRef(*pdisp);
TRACE("Returning pdisp=%p\n", pdisp);
return S_OK;
}
And about my test for this problem - it's OK?
--
Best regards,
Konstantin Kondratyuk.
Re: mshtml: Add some interfaces in mshtml.idl (try 2) (resend)
On Thursday 11 December 2008 17:28:03 Konstantin Kondratyuk wrote: > Add: > ILineInfo > IDisplayPointer > IDisplayPointer > IHTMLComputedStyle > IDisplayServices > IMarkupServices This patch is wrong. Please, ignore it. -- Best regards, Konstantin Kondratyuk.
IServiceProvider::QueryService tests
In dlls/mshtml/tests/htmldoc.c there is a comment:
/*
* Services used by HTMLDocument:
*
* IOleUndoManager
* IInternetSecurityManager
* ITargetFrame
* {D5F78C80-5252-11CF-90FA-00AA0042106E}
* HTMLFrameBase
* IShellObject
* {3050F312-98B5-11CF-BB82-00AA00BDCE0B}
* {53A2D5B1-D2FC-11D0-84E0-006097C9987D}
* {AD7F6C62-F6BD-11D2-959B-006097C553C8}
* DefView (?)
* {6D12FE80-7911-11CF-9534-C05BAE0B}
* IElementBehaviorFactory
* {3050F429-98B5-11CF-BB82-00AA00BDCE0B}
* STopLevelBrowser
* IHTMLWindow2
* IInternetProtocol
* IWebBrowserApp
* UrlHostory
* IHTMLEditHost
* IHlinkFrame
*/
It is confirmed by tests? I have not found.
It seems to me, also there should be IHTMLEditServices interface support. How
it is correct to add the test on IServiceProvider::QueryService?
Thanks.
--
Best regards,
Konstantin Kondratyuk.
Re: mshtml: Add new interfaces into mshtml.idl (try 2)
Hello, Alistair! On Monday 24 November 2008 14:59:30 you wrote: > Non of the Functions in IMarkupPointer should be marked as retval, > likewise for IMarkupContainer. > > IElementSegment functions are in the wrong order, likewise for > ISelectionServicesListener, ISelectionServices and IHTMLEditServices. > Also you will need to double check the [] values, since you have retval > where they are not needed. > > If you have a copy of the mshtml.tlb you can verify the interfaces by > using wine's oleview program. Is it possible to consider results of oleview it is unique the true? The attribute "retval" is not present in one of adding interfaces. And your advice ([out, size_is(*pcch)]) > HRESULT Right([in] BOOL fMove,[out] MARKUP_CONTEXT_TYPE* pContext,[out] > IHTMLElement** ppElement,[in, out] long* pcch,[out, size_is(*pcch)] OLECHAR* > pchText) does not prove to be true (from oleview's results). I have checked up and have corrected an order of methods in all interfaces. But oleview has shown a method in IHTMLEditServices which is not described in MSDN (http://msdn.microsoft.com/en-us/library/aa704048(VS.85).aspx): HRESULT _stdcall SelectRange( [in] IMarkupPointer* pStart, [in] IMarkupPointer* pEnd, [in] _SELECTION_TYPE eType); What is correct? Thanks for your advices -- Best regards, Konstantin Kondratyuk.
Re: mshtml: Add new interfaces into mshtml.idl
On Monday 24 November 2008 00:38:18 Alistair Leslie-Hughes wrote: > You have > missed > POINTER_GRAVITY_Max > MARKUP_CONTEXT_TYPE_Max > SELECTION_TYPE_Max Thanks, fixed. > The following interfacess dont contain dual interfaces > IHTMLEditDesigner > IMarkupContainer > IMarkupPointer > ISegment > ISelectionServicesListener > ISelectionServices > IHTMLEditServices IElementSegment interface too? I have changed it in try2 Also, one question about retval attributes. There can be only one attribute in one method? For example, in IMarkupPointer interface: HRESULT Right( [in] BOOL fMove, [out] MARKUP_CONTEXT_TYPE *pContext, [out] IHTMLElement **ppElement, [out] long *pcch, [retval, out] OLECHAR *pchText); It is correct now? Try 1 contained four attributes "retval" in this method... Thanks for advices. -- Best regards, Konstantin Kondratyuk.
Re: [2/2] winspool.drv: GetDefaultPrinterW reads the value from data in registry
On Wednesday 09 April 2008 22:13:44 Detlef Riekenberg wrote: > win3.x and win9.x use only "win.ini". > We need to fix bug #4096, before we can switch to the Registry. Thanks for advice! I will try to fix it. -- Best regards, Konstantin Kondratyuk.
Re: programs/net: Add russian resources (resend)
Hello! > My note is a nitpicking, but... > > >+ * NET.EXE - Wine-compatible net program > >+ * English language support > > This file supports Russian language, not English Thanks, Kirill. I correct my patch... -- Best regards, Konstantin Kondratyuk.
Re: mpr: Changes comparison of dwScope in WNetOpenEnum function
Hello!
> Your patch should probably fix both of those, then (and please ignore
> my earlier comment.)
I have resent my patch, having added in it the passed corrections.
I have one more question. To add realization of new function, I can add it in
struct WNetProvider? For example:
typedef struct _WNetProvider
{
HMODULE hLib;
PWSTR name;
PF_NPGetCaps getCaps;
DWORD dwSpecVersion;
DWORD dwNetType;
DWORD dwEnumScopes;
PF_NPOpenEnum openEnum;
PF_NPEnumResource enumResource;
PF_NPCloseEnumcloseEnum;
PF_NPGetResourceInformation getResourceInformation; //my added function
} WNetProvider, *PWNetProvider;
It is correct?
--
Best regards,
Konstantin Kondratyuk.
Re: mpr: Changes comparison of dwScope in WNetOpenEnum function
Hello, Juan! > Hi Konstantin, > > - providerTable->table[index].dwEnumScopes > & dwScope) > + providerTable->table[index].dwEnumScopes > & WNNC_ENUM_GLOBAL) > > This change looks correct, but it should be changed in the next block as > well: > > ret = providerTable->table[index].openEnum( > dwScope, dwType, dwUsage, lpNet, &handle); > > It also looks incorrect in _enumerateGlobalPassthroughW: > ret = providerTable->table[enumerator->providerIndex]. > openEnum(enumerator->dwScope, enumerator->dwType, > enumerator->dwUsage, enumerator->lpNet, > &enumerator->handle); > > In fact, all of these usages of dwScope look to confuse the two > meanings. (D'oh.) > --Juan Well, I have looked all code in mpr/wnet.c The following condition in _globalEnumeratorAdvance() looks incorrect: for (; enumerator->providerIndex < providerTable->numProviders && !(enumerator->dwScope & providerTable->table [enumerator->providerIndex].dwEnumScopes); enumerator->providerIndex++) Other conditions and parameters look correctly. For example, function NPOpenEnum() expects a dwScope, containing RESOURCE_CONNECTED, RESOURCE_GLOBALNET or RESOURCE_CONTEXT. Correct for me if I am not right. -- Best regards, Konstantin Kondratyuk.
An enumeration of network resources
Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The information about loaded dll is absent in the wine registry. Whether it means, what there are no preparations of DLL's for work with a network (similar ntlanman.dll in Windows)? -- Best regards, Konstantin Kondratyuk.
Re: programs/net: Add russian resources
Hello! > Did you test this translation? You are using KOI8-R which won't work > properly in russian resources. I'm sorry for a carelessness. My current locale was koi8, it became the reason of my mistake. I resend the patch. -- Best regards, Konstantin Kondratyuk.
