Re: [1/5] gameux: Add initial implementation of gameux.dll
Dan McDonald wrote: On 07/21/2010 11:10 AM, André Hentschel wrote: Am 21.07.2010 19:01, schrieb Mariusz Pluciński: W dniu 19.07.2010 15:02, Henri Verbeet pisze: 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: + * DllRegisterServer (OLEAUT32.@) The code of "my" regsvr.c is almost non-modified copy of the same file in oleaut32.dll implementation. If it's bad formatted, why it exists in official Wine code? For the same reason why intentation patches are not accepted, because it makes the use of "git blame" hard. git blame has a -w option. Does that not work very well? Dan Although that is a good option, we don't want to know everyone who touched a piece of code in many cases, just the last person. Also, the output from that command is HUGE. James McKenzie
Re: [1/5] gameux: Add initial implementation of gameux.dll
On 07/21/2010 11:10 AM, André Hentschel wrote: > Am 21.07.2010 19:01, schrieb Mariusz Pluciński: >> W dniu 19.07.2010 15:02, Henri Verbeet pisze: >>> 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; >>> This is unused. >>> >>> You're mixing tabs and spaces, and have a couple of trailing spaces. >>> >>> Also: + * DllRegisterServer (OLEAUT32.@) >> The code of "my" regsvr.c is almost non-modified copy of the same >> file in oleaut32.dll implementation. If it's bad formatted, why it >> exists in official Wine code? > > For the same reason why intentation patches are not accepted, because it > makes the use of "git blame" hard. git blame has a -w option. Does that not work very well? Dan > >> However, I modified my copy to fulfill Wine's formatting assumptions >> and resent it. Hope it's acceptable now. >> >> > > That's the right way. > -- Dan McDonald Wellkeeper Inc. 1208 San Pedro NE #168 Albuquerque, NM 87110 (505) 938-6266
Re: [1/5] gameux: Add initial implementation of gameux.dll
Am 21.07.2010 19:01, schrieb Mariusz Pluciński: > W dniu 19.07.2010 15:02, Henri Verbeet pisze: >> 2010/7/18 Mariusz Pluciński: >>> +static HINSTANCE hInstance; >> This is unused. >> >> You're mixing tabs and spaces, and have a couple of trailing spaces. >> >> Also: >>> + * DllRegisterServer (OLEAUT32.@) > The code of "my" regsvr.c is almost non-modified copy of the same > file in oleaut32.dll implementation. If it's bad formatted, why it > exists in official Wine code? For the same reason why intentation patches are not accepted, because it makes the use of "git blame" hard. > However, I modified my copy to fulfill Wine's formatting assumptions > and resent it. Hope it's acceptable now. > > That's the right way. -- Best Regards, André Hentschel
Re: [1/5] gameux: Add initial implementation of gameux.dll
W dniu 19.07.2010 15:02, Henri Verbeet pisze: 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: + * DllRegisterServer (OLEAUT32.@) The code of "my" regsvr.c is almost non-modified copy of the same file in oleaut32.dll implementation. If it's bad formatted, why it exists in official Wine code? However, I modified my copy to fulfill Wine's formatting assumptions and resent it. Hope it's acceptable now.
Re: [1/5] gameux: Add initial implementation of gameux.dll
2010/7/18 Mariusz Pluciński : > +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: > + * DllRegisterServer (OLEAUT32.@)
